[PATCH] D24954: [ToolChains] Disable OpenSUSE rules for SLES10

ismail added a comment. That looks good to me but I am not a reviewer. Someone else must approve. https://reviews.llvm.org/D24954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24954: [ToolChains] Do not assume OpenSUSE for other SUSE variants

ismail added a comment. This will break SLES11 and later so it's not OK. Also note that SLES10 is not supported anymore. https://reviews.llvm.org/D24954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20672: Don't pass -fms-compatibility-version flag during build

This revision was automatically updated to reflect the committed changes. Closed by commit rL270860: Since some time clang itself figures out the default for ms-compatibility… (authored by ismail). Changed prior to commit: http://reviews.llvm.org/D20672?vs=58586=58623#toc Repository: rL

[PATCH] D20672: Don't pass -fms-compatibility-version flag during build

ismail created this revision. ismail added reviewers: hans, rnk. ismail added a subscriber: cfe-commits. ismail set the repository for this revision to rL LLVM. Since some time clang itself figures out the default for ms-compatibility-version and uses it. Trying to figure it out during build is

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

ismail added a subscriber: ismail. ismail added a comment. Richard, Does this mean this feature will never be accepted? It would help to make a clear statement on this issue. I am not happy how this feature is introduced but it's too late now that every big Linux distro out there switched to

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

ismail added a comment. Reverted in r257468. http://reviews.llvm.org/D15006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

ismail added a comment. Martell, any update on this? http://reviews.llvm.org/D15006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

ismail added a comment. Tested on openSUSE and it works. Thanks! http://reviews.llvm.org/D15006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

This doesn't seem to work here, VS 2015 on Win 10 x64: C:\Users\ismail\Desktop>clang-cl.exe -fms-compatibility-version=19 foo.cpp LINK : fatal error LNK1104: cannot open file 'kernel32.lib' clang-cl.exe: error: linker command failed with exit code 1104 (use -v to see invocation) Works fine after

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

Hi, C:\Users\ismail\Desktop>set include INCLUDE=C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE;C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\INCLUDE;C:\Program Files (x86)\Windows Kits\10\include\10.0.10240.0\ucrt;C:\Program Files (x86)\Windows

Re: r246497 - [modules] Rework serialized DeclContext lookup table management. Instead of

Hi, On Tue, Sep 1, 2015 at 1:17 AM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Mon Aug 31 17:17:11 2015 > New Revision: 246497 > > URL: http://llvm.org/viewvc/llvm-project?rev=246497=rev > Log: > [modules] Rework serialized DeclContext lookup table

Re: [PATCH] D11932: [OPENMP] Link libomp.lib on Windows

ismail accepted this revision. ismail added a reviewer: ismail. ismail added a comment. This revision is now accepted and ready to land. Great work. Tested fine on Windows. Next step would be mapping /openmp flag to -fopenmp but I guess thats for another bug. http://reviews.llvm.org/D11932

Re: [PATCH] D11932: [OPENMP] Link libomp.lib on Windows

ismail added a comment. In http://reviews.llvm.org/D11932#225158, @hfinkel wrote: What library path should be passed (where did you build the OpenMP runtime library)? This is a default installation so the lib path is $PATH_TO_CLANG_EXE/../lib which in my case is C:\Program Files\LLVM\lib

Re: [clang-tools-extra] r245052 - [clang-tidy] Move IncludeSorter.* and IncludeInserter.* to clang-tidy/utils/

Looks fixed now, thanks! On Sat, Aug 15, 2015 at 8:41 AM, Alexander Kornienko ale...@google.com wrote: ... or this may have been fixed by r245144. In any case, please check again and report if anything is still broken. On Sat, Aug 15, 2015 at 7:39 AM, Alexander Kornienko ale...@google.com

Re: [PATCH] D11932: [OPENMP] Link libomp.lib on Windows

ismail added a comment. Tests pass but, now when I tried to compile a file with -fopenmp I get: LINK: fatal error LNK1104: cannot open file 'libomp.lib' libomp.lib does exist in C:\Program Files\LLVM\lib but I guess we need to pass the library path down to linker.