https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/96453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman commented:
Some wording changes; more may come as I better understand the concept.
https://github.com/llvm/llvm-project/pull/96453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/AaronBallman approved this pull request.
Thank you for the additional docs, they LGTM!
https://github.com/llvm/llvm-project/pull/96573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: Aaron Ballman
Date: 2024-06-25T14:02:05-04:00
New Revision: a0869331ec0c9ae42f696e87d72416ea5ecb926f
URL:
https://github.com/llvm/llvm-project/commit/a0869331ec0c9ae42f696e87d72416ea5ecb926f
DIFF:
https://github.com/llvm/llvm-project/commit/a0869331ec0c9ae42f696e87d72416ea5ecb926f.diff
AaronBallman wrote:
> > and that implies (at least to me) that an expression cannot form an
> > infinity to begin with, so the act of trying to expand INFINITY is
> > nonsensical in that case, right?
>
> It's undefined behavior at runtime.
>
> I don't think we need to worry too much about
AaronBallman wrote:
> I'm not sure about tying this to `__FINITE_MATH_ONLY__`; -ffinite-math-only
> doesn't mean infinity doesn't exist, it just means you're promising that you
> won't use floating-point arithmetic/comparison ops on infinity. Which is
> weird, but that's fast-math. Also,
Author: Aaron Ballman
Date: 2024-06-25T12:46:41-04:00
New Revision: 5e2beed9a1643cd6358fb8b43feb893543d90bf3
URL:
https://github.com/llvm/llvm-project/commit/5e2beed9a1643cd6358fb8b43feb893543d90bf3
DIFF:
https://github.com/llvm/llvm-project/commit/5e2beed9a1643cd6358fb8b43feb893543d90bf3.diff
Author: Aaron Ballman
Date: 2024-06-25T12:34:34-04:00
New Revision: 05ca20744159a33349271a96b90959a0a3807133
URL:
https://github.com/llvm/llvm-project/commit/05ca20744159a33349271a96b90959a0a3807133
DIFF:
https://github.com/llvm/llvm-project/commit/05ca20744159a33349271a96b90959a0a3807133.diff
AaronBallman wrote:
Link to WG14 N2848: https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2848.pdf
https://github.com/llvm/llvm-project/pull/96659
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
AaronBallman wrote:
Do you need me to land the changes on your behalf?
https://github.com/llvm/llvm-project/pull/96487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
> The `preserve_none` calling convention is new in clang 19 and hasn't been
> released yet; do fixes need a release note if they happen within the release
> cycle a feature is added?
Nope, no need for a release note in this case; I forgot that this was new for
clang 19
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/96374
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/96374
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman created
https://github.com/llvm/llvm-project/pull/96659
This is in support of WG14 N2848 which only define the macros if
infinity and nan are supported, so use of -ffinite-math will cause the
macros to not be defined.
>From
https://github.com/AaronBallman unassigned
https://github.com/llvm/llvm-project/pull/96643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman unassigned
https://github.com/llvm/llvm-project/pull/96643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman unassigned
https://github.com/llvm/llvm-project/pull/96643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman unassigned
https://github.com/llvm/llvm-project/pull/96643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman unassigned
https://github.com/llvm/llvm-project/pull/96643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman updated
https://github.com/llvm/llvm-project/pull/96643
>From 408c34b84966a256bb6e7fdf45758f5c77380bbe Mon Sep 17 00:00:00 2001
From: Aaron Ballman
Date: Tue, 25 Jun 2024 10:27:10 -0400
Subject: [PATCH 1/2] [C23] Add *_NORM_MAX macros to
This adds the
Author: Aaron Ballman
Date: 2024-06-25T10:34:39-04:00
New Revision: fb463e154e7fe1200b9d91f82fafa532331ce764
URL:
https://github.com/llvm/llvm-project/commit/fb463e154e7fe1200b9d91f82fafa532331ce764
DIFF:
https://github.com/llvm/llvm-project/commit/fb463e154e7fe1200b9d91f82fafa532331ce764.diff
https://github.com/AaronBallman created
https://github.com/llvm/llvm-project/pull/96643
This adds the *_NORM_MAX macros to for freestanding mode in Clang;
the values were chosen based on the behavior seen coming from GCC and the
values already produced for the *_MAX macros by Clang.
>From
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/96579
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Aaron Ballman
Date: 2024-06-24T15:09:20-04:00
New Revision: 2ae09052477e1a966afbc5482d88585f95694c53
URL:
https://github.com/llvm/llvm-project/commit/2ae09052477e1a966afbc5482d88585f95694c53
DIFF:
https://github.com/llvm/llvm-project/commit/2ae09052477e1a966afbc5482d88585f95694c53.diff
https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/96532
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman created
https://github.com/llvm/llvm-project/pull/96532
This updates Clang's extension criteria to explicitly mention impacts on other
projects within the monorepo.
These changes were discussed in the following RFC:
AaronBallman wrote:
> I don't have any context beyond what's written on
> https://reviews.llvm.org/D25204 . And at this point, I'm not sure what
> compiler we're trying to be compatible with. (I added @erichkeane in case he
> remembers.)
The original feature was written for compatibility
https://github.com/AaronBallman approved this pull request.
Generally LGTM, though the changes should come with a release note in
`clang/docs/ReleaseNotes.rst` so users know about the fix.
https://github.com/llvm/llvm-project/pull/96487
___
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/96487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Aaron Ballman
Date: 2024-06-24T11:12:18-04:00
New Revision: 3e36dfafa0d11b2a5d7776d88f170c449116aa0e
URL:
https://github.com/llvm/llvm-project/commit/3e36dfafa0d11b2a5d7776d88f170c449116aa0e
DIFF:
https://github.com/llvm/llvm-project/commit/3e36dfafa0d11b2a5d7776d88f170c449116aa0e.diff
Author: Aaron Ballman
Date: 2024-06-24T10:52:17-04:00
New Revision: b012ab01cb39e440a38dad5d7dd71b419480264b
URL:
https://github.com/llvm/llvm-project/commit/b012ab01cb39e440a38dad5d7dd71b419480264b
DIFF:
https://github.com/llvm/llvm-project/commit/b012ab01cb39e440a38dad5d7dd71b419480264b.diff
https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/96494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM, thanks for the quick fix!
https://github.com/llvm/llvm-project/pull/96494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: Aaron Ballman
Date: 2024-06-24T10:34:11-04:00
New Revision: 6ecb9fd83d6015b19be8db554328645ae15e63e9
URL:
https://github.com/llvm/llvm-project/commit/6ecb9fd83d6015b19be8db554328645ae15e63e9
DIFF:
https://github.com/llvm/llvm-project/commit/6ecb9fd83d6015b19be8db554328645ae15e63e9.diff
Author: Aaron Ballman
Date: 2024-06-24T10:29:15-04:00
New Revision: 29e0f046735010540fbdba4371dcd26f9e437650
URL:
https://github.com/llvm/llvm-project/commit/29e0f046735010540fbdba4371dcd26f9e437650
DIFF:
https://github.com/llvm/llvm-project/commit/29e0f046735010540fbdba4371dcd26f9e437650.diff
Author: Aaron Ballman
Date: 2024-06-24T09:50:37-04:00
New Revision: 3ff680a1a57d74a5c94d3da35594a8046a879888
URL:
https://github.com/llvm/llvm-project/commit/3ff680a1a57d74a5c94d3da35594a8046a879888
DIFF:
https://github.com/llvm/llvm-project/commit/3ff680a1a57d74a5c94d3da35594a8046a879888.diff
https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/95290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM still
https://github.com/llvm/llvm-project/pull/95290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4570,7 +4570,8 @@ ExprResult Sema::BuildAtomicExpr(SourceRange CallRange,
SourceRange ExprRange,
}
// Pointer to object of size zero is not allowed.
- if (Context.getTypeInfoInChars(AtomTy).Width.isZero()) {
+ if (!AtomTy->isIncompleteType() &&
https://github.com/AaronBallman commented:
Thank you for the fix! The changes should also come with a release note in
`clang/docs/ReleaseNotes.rst` so users know about the improvement.
https://github.com/llvm/llvm-project/pull/96374
___
cfe-commits
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/96374
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
> Given that this is for a clang extension and not a conformance issue, I'm
> inclined to revert.
>
> It might make sense to do that, yeah. Either way, we should investigate
> what’s going on here. @AaronBallman wdyt?
Definitely worth investigating, unsure whether this is
@@ -2068,7 +2068,8 @@ bool Lexer::LexNumericConstant(Token , const char
*CurPtr) {
}
// If we have a digit separator, continue.
- if (C == '\'' && (LangOpts.CPlusPlus14 || LangOpts.C23)) {
+ if (C == '\'' &&
+ (LangOpts.CPlusPlus14 || LangOpts.C23 ||
AaronBallman wrote:
> > > > I guess the general question is - is it acceptable to have the Scanner
> > > > operating in a language standard different than the passed in language
> > > > mode and different than the compiler language standard?
> > >
> > >
> > > I think that is acceptable. It
Author: Aaron Ballman
Date: 2024-06-21T13:47:57-04:00
New Revision: 918ef312d1fda56ff783f3974b5a193542e5497c
URL:
https://github.com/llvm/llvm-project/commit/918ef312d1fda56ff783f3974b5a193542e5497c
DIFF:
https://github.com/llvm/llvm-project/commit/918ef312d1fda56ff783f3974b5a193542e5497c.diff
Author: Aaron Ballman
Date: 2024-06-21T13:28:02-04:00
New Revision: 131bc0390dba1bc21fb8af8e5e8afa78a17d39b9
URL:
https://github.com/llvm/llvm-project/commit/131bc0390dba1bc21fb8af8e5e8afa78a17d39b9
DIFF:
https://github.com/llvm/llvm-project/commit/131bc0390dba1bc21fb8af8e5e8afa78a17d39b9.diff
Author: Aaron Ballman
Date: 2024-06-21T12:48:01-04:00
New Revision: 19470e72e4aadfe16d1b6b0e4df325d75dc7fd7c
URL:
https://github.com/llvm/llvm-project/commit/19470e72e4aadfe16d1b6b0e4df325d75dc7fd7c
DIFF:
https://github.com/llvm/llvm-project/commit/19470e72e4aadfe16d1b6b0e4df325d75dc7fd7c.diff
AaronBallman wrote:
> > LGTM -- that new documentation is fantastic, thank you for that!
>
> Thank you! I hope it saves future readers some time.
>
> I don't have write access, so feel free to merge unless we're waiting for
> @aaronpuchert to review :)
I'll give Aaron a chance to weigh in
https://github.com/AaronBallman approved this pull request.
LGTM -- that new documentation is fantastic, thank you for that!
https://github.com/llvm/llvm-project/pull/95290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/95290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
The only thing I think is missing is a release note in
`clang/docs/ReleaseNotes.rst` so users know about the new functionality,
otherwise this LGTM!
https://github.com/llvm/llvm-project/pull/84983
https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/94542
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
Thank you both for collaborating to get that solved!
https://github.com/llvm/llvm-project/pull/95802
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
> @AaronBallman Thank you for your feedback. Do you think this needs to be
> reviewed by someone else? I can't add reviewers myself :)
Nope, it's ready to land; sorry for not asking earlier, do you need me to
commit this on your behalf?
@@ -8,6 +8,9 @@
Overview
+**NOTE:** This is a design document and the feature is not available for users
yet.
+Please find :doc:`BoundsSafetyImplPlans` for more details.
AaronBallman wrote:
```suggestion
Please see :doc:`BoundsSafetyImplPlans` for
https://github.com/AaronBallman approved this pull request.
Thank you for updating the documentation, the changes LGTM (had one minor
suggestion you can take or leave as you'd like). I think it's better for us to
have the documentation than not, so I'm fine with this approach of letting
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/95964
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Aaron Ballman
Date: 2024-06-20T13:29:36-04:00
New Revision: 6bc71cdd32de0add80d620b1342b5549efff363a
URL:
https://github.com/llvm/llvm-project/commit/6bc71cdd32de0add80d620b1342b5549efff363a
DIFF:
https://github.com/llvm/llvm-project/commit/6bc71cdd32de0add80d620b1342b5549efff363a.diff
AaronBallman wrote:
Do you need someone to land these changes on your behalf?
https://github.com/llvm/llvm-project/pull/93913
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM; when we add `-fbounds-safety` in the future, we may want the language
option to become an enumeration so we can distinguish between the experimental,
non-experimental, and disabled bounds safety options, but we can cross that
AaronBallman wrote:
> @AaronBallman We haven't exposed the `-fbounds-safety` flag yet. The idea was
> to guard it under the experimental flag called `-fexperimental-bounds-safety`
> as a CC1 flag for testing until we have the full feature available (the
> feature is work-in-progress and is
https://github.com/AaronBallman approved this pull request.
Clang changes LGTM modulo the dependency scanner bits.
https://github.com/llvm/llvm-project/pull/88265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
AaronBallman wrote:
> > Why gnu99 mode and not gnu89 mode? I see GCC has that behavior, but I'm not
> > certain why.
>
> We went over this a while back: [#88265
> (comment)](https://github.com/llvm/llvm-project/pull/88265#discussion_r1571088366)
THAT is why this was so familiar to me! :-D
AaronBallman wrote:
Thank you for the fix! FWIW, I don't think this is NFC as it is changing test
behavior (fixing a memory leak); please be sure to get a proper code review for
functional changes. The changes are reasonable enough, but one question I have
is: why not stack allocate the
https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/91100
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -964,7 +964,7 @@ def err_main_global_variable :
def warn_main_redefined : Warning<"variable named 'main' with external linkage
"
"has undefined behavior">, InGroup;
def ext_main_used : Extension<
- "ISO C++ does not allow 'main' to be used by a program">, InGroup;
+
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/96168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Aaron Ballman
Date: 2024-06-20T10:26:13-04:00
New Revision: 40a0ad2af3b6305fbabec003e51dad62564aa019
URL:
https://github.com/llvm/llvm-project/commit/40a0ad2af3b6305fbabec003e51dad62564aa019
DIFF:
https://github.com/llvm/llvm-project/commit/40a0ad2af3b6305fbabec003e51dad62564aa019.diff
Author: Aaron Ballman
Date: 2024-06-20T10:02:22-04:00
New Revision: b84323cca9e2c7049c0aec92a45911742822b40e
URL:
https://github.com/llvm/llvm-project/commit/b84323cca9e2c7049c0aec92a45911742822b40e
DIFF:
https://github.com/llvm/llvm-project/commit/b84323cca9e2c7049c0aec92a45911742822b40e.diff
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/88367
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/88367
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
> raw string literals are enabled in C++11 and later, as well as in C in gnu99
> mode and later;
Why gnu99 mode and not gnu89 mode? I see GCC has that behavior, but I'm not
certain why.
> I’m not entirely sure how to fix this candidly. It doesn’t look like
>
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/93612
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/93612
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/84983
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -964,7 +964,7 @@ def err_main_global_variable :
def warn_main_redefined : Warning<"variable named 'main' with external linkage
"
"has undefined behavior">, InGroup;
def ext_main_used : Extension<
- "ISO C++ does not allow 'main' to be used by a program">, InGroup;
+
@@ -141,3 +141,15 @@ namespace r360308_regression {
return a == b;
}
}
+
+namespace GH95598 {
+template
+struct __is_pointer {};
+// expected-warning@-1 {{keyword '__is_pointer' will be made available as an
identifier for the remainder of the translation unit}}
https://github.com/AaronBallman approved this pull request.
LGTM, thank you, I love it!
https://github.com/llvm/llvm-project/pull/96051
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
Leak fix LGTM, I think it's ready to re-land and try again.
https://github.com/llvm/llvm-project/pull/95802
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -0,0 +1,98 @@
+// RUN: %clang_cc1 %s -fsyntax-only --embed-dir=%S/Inputs -verify=expected,cxx
-Wno-c23-extensions
+// RUN: %clang_cc1 -x c -std=c23 %s -fsyntax-only --embed-dir=%S/Inputs
-verify=expected,c
+#embed
+;
+
+void f (unsigned char x) { (void)x;}
+void g () {}
@@ -141,3 +141,15 @@ namespace r360308_regression {
return a == b;
}
}
+
+namespace GH95598 {
+template
+struct __is_pointer {};
+// expected-warning@-1 {{keyword '__is_pointer' will be made available as an
identifier for the remainder of the translation unit}}
@@ -0,0 +1,98 @@
+// RUN: %clang_cc1 %s -fsyntax-only --embed-dir=%S/Inputs -verify=expected,cxx
-Wno-c23-extensions
+// RUN: %clang_cc1 -x c -std=c23 %s -fsyntax-only --embed-dir=%S/Inputs
-verify=expected,c
+#embed
+;
+
+void f (unsigned char x) { (void)x;}
+void g () {}
Timm =?utf-8?q?B=C3=A4der?= ,
Timm =?utf-8?q?B=C3=A4der?=
Message-ID:
In-Reply-To:
https://github.com/AaronBallman approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/83683
___
cfe-commits mailing list
https://github.com/AaronBallman commented:
Thank you for working on this! I was trying to devise a test case that would
exercise the issue... and I think I've convinced myself this entire function is
dead code. It only seems to be possible to reach in C++ mode, but
`ident` is annotated as a
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/95917
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
Continues to LGTM, @delcypher are you happy with the changes?
https://github.com/llvm/llvm-project/pull/93231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
AaronBallman wrote:
> To your point about proliferation of flags. `-fexperimental-bounds-safety`
> **is the CC1 flag** that guard the `-fbounds-safety` feature in our internal
> Clang (modulo the name, we don't have the `experimental-` prefix internally).
> It will **need to exist** as we
@@ -2544,6 +2544,85 @@ bool
ByteCodeExprGen::VisitCXXInheritedCtorInitExpr(
return this->emitCall(F, 0, E);
}
+template
+bool ByteCodeExprGen::VisitCXXNewExpr(const CXXNewExpr *E) {
+ assert(classifyPrim(E->getType()) == PT_Ptr);
+ const Expr *Init =
@@ -2544,6 +2544,85 @@ bool
ByteCodeExprGen::VisitCXXInheritedCtorInitExpr(
return this->emitCall(F, 0, E);
}
+template
+bool ByteCodeExprGen::VisitCXXNewExpr(const CXXNewExpr *E) {
+ assert(classifyPrim(E->getType()) == PT_Ptr);
AaronBallman wrote:
I
@@ -2544,6 +2544,85 @@ bool
ByteCodeExprGen::VisitCXXInheritedCtorInitExpr(
return this->emitCall(F, 0, E);
}
+template
+bool ByteCodeExprGen::VisitCXXNewExpr(const CXXNewExpr *E) {
+ assert(classifyPrim(E->getType()) == PT_Ptr);
+ const Expr *Init =
@@ -2544,6 +2544,85 @@ bool
ByteCodeExprGen::VisitCXXInheritedCtorInitExpr(
return this->emitCall(F, 0, E);
}
+template
+bool ByteCodeExprGen::VisitCXXNewExpr(const CXXNewExpr *E) {
+ assert(classifyPrim(E->getType()) == PT_Ptr);
+ const Expr *Init =
@@ -0,0 +1,119 @@
+//== DynamicAllocator.cpp - Dynamic allocations --*- C++
-*-==//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -277,7 +277,9 @@ void dr258(void) {
void dr261(void) {
/* This is still an integer constant expression despite the overflow. */
enum e1 {
-ex1 = __INT_MAX__ + 1 /* expected-warning {{overflow in expression;
result is -2'147'483'648 with type 'int'}} */
+ex1 =
@@ -430,7 +430,8 @@ void dr081(void) {
/* Demonstrate that we don't crash when left shifting a signed value; that's
* implementation defined behavior.
*/
- _Static_assert(-1 << 1 == -2, "fail"); /* Didn't shift a zero into the "sign
bit". */
+ _Static_assert(-1 << 1
@@ -614,9 +619,23 @@ static bool checkTryLockFunAttrCommon(Sema , Decl *D,
const ParsedAttr ,
return false;
}
- // check that all arguments are lockable objects
+ // Check that all remaining arguments are lockable objects.
checkAttrArgsAreCapabilityObjs(S, D, AL,
@@ -614,9 +619,23 @@ static bool checkTryLockFunAttrCommon(Sema , Decl *D,
const ParsedAttr ,
return false;
}
- // check that all arguments are lockable objects
+ // Check that all remaining arguments are lockable objects.
checkAttrArgsAreCapabilityObjs(S, D, AL,
AaronBallman wrote:
> * A handful of functions in the parsing tests return `void` and yet are
> annotated as trylock functions. I don't believe this is a valid use case.
> What does `EXCLUSIVE_TRYLOCK_FUNCTION` mean when it's impossible to return a
> value? I think the solution is to just
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/95233
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/95233
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/95909
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
401 - 500 of 5460 matches
Mail list logo
