aadanen wrote:
Nice!
https://github.com/llvm/llvm-project/pull/150348
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aadanen updated
https://github.com/llvm/llvm-project/pull/150348
>From 4e24cb20efa22e364d41026ae40aec470ff786aa Mon Sep 17 00:00:00 2001
From: Aaron Danen
Date: Wed, 23 Jul 2025 18:01:14 -0700
Subject: [PATCH 01/17] added undo to docs in same format as %quit
---
clang/docs/
aadanen wrote:
It is a little awkward for %help to use logAllUnhandledErrors because the
message goes to stderr and then my test needs to do input redirection. There is
likely a better way to do this but I haven't found it yet, unless it's the raw
ostream thing from earlier
https://github.com
https://github.com/aadanen updated
https://github.com/llvm/llvm-project/pull/150348
>From 4e24cb20efa22e364d41026ae40aec470ff786aa Mon Sep 17 00:00:00 2001
From: Aaron Danen
Date: Wed, 23 Jul 2025 18:01:14 -0700
Subject: [PATCH 01/16] added undo to docs in same format as %quit
---
clang/docs/
https://github.com/aadanen updated
https://github.com/llvm/llvm-project/pull/150348
>From 4e24cb20efa22e364d41026ae40aec470ff786aa Mon Sep 17 00:00:00 2001
From: Aaron Danen
Date: Wed, 23 Jul 2025 18:01:14 -0700
Subject: [PATCH 01/14] added undo to docs in same format as %quit
---
clang/docs/
@@ -370,9 +378,24 @@ int main(int argc, const char **argv) {
if (Input == R"(%undo)") {
if (auto Err = Interp->Undo())
llvm::logAllUnhandledErrors(std::move(Err), llvm::errs(), "error: ");
+ } else if (Input == R"(%help)") {
+auto Err =
+
aadanen wrote:
1. printing stuff on clang-repl start causes several tests to fail
2. need to not parse %lib as a bad % command. Maybe should add %lib as list of
% commands?
https://github.com/llvm/llvm-project/pull/150348
___
cfe-commits mailing list
https://github.com/aadanen updated
https://github.com/llvm/llvm-project/pull/150348
>From 4e24cb20efa22e364d41026ae40aec470ff786aa Mon Sep 17 00:00:00 2001
From: Aaron Danen
Date: Wed, 23 Jul 2025 18:01:14 -0700
Subject: [PATCH 1/6] added undo to docs in same format as %quit
---
clang/docs/Cl
aadanen wrote:
@DavidSpickett I've added %undo to the documentation and implemented %help.
Would it be good to also add %help to the documentation?
To print stuff, I am just using printf(). Is this fine? It would be easy to
switch to std::cout or it looks like there are some llvm print functio
https://github.com/aadanen updated
https://github.com/llvm/llvm-project/pull/150348
>From 4e24cb20efa22e364d41026ae40aec470ff786aa Mon Sep 17 00:00:00 2001
From: Aaron Danen
Date: Wed, 23 Jul 2025 18:01:14 -0700
Subject: [PATCH 1/4] added undo to docs in same format as %quit
---
clang/docs/Cl
https://github.com/aadanen updated
https://github.com/llvm/llvm-project/pull/150348
>From 4e24cb20efa22e364d41026ae40aec470ff786aa Mon Sep 17 00:00:00 2001
From: Aaron Danen
Date: Wed, 23 Jul 2025 18:01:14 -0700
Subject: [PATCH 1/3] added undo to docs in same format as %quit
---
clang/docs/Cl
aadanen wrote:
I thought about "Undoing Input" as the section header but I feel like %undo is
pretty self explanatory. As far as "%help" and clang-repl --help go, I think
those sound like nice ideas. Both would be useful for new people using
clang-repl.
As far as "%foobar" throwing an error
https://github.com/aadanen created
https://github.com/llvm/llvm-project/pull/150348
so far just added undo to the documentation. We can see about implementing
%help or something similar. This will attempt to solve issue #143666
>From 4e24cb20efa22e364d41026ae40aec470ff786aa Mon Sep 17 00:00:0
https://github.com/aadanen updated
https://github.com/llvm/llvm-project/pull/149396
>From f3fbebdd6d940d36561ccf5177510095ba05077e Mon Sep 17 00:00:00 2001
From: Aaron Danen
Date: Wed, 16 Jul 2025 19:44:58 -0700
Subject: [PATCH 1/5] clarified %undo error msg in clang-repl
used grep -r "Too man
aadanen wrote:
@DavidSpickett I applied clang-format and I think everything is looking good.
Do I need to do anything else? Or is squashing the commits and merging up to
someone with write permissions?
Also, thanks a lot for the help. I plan to find a new issue to work on soon.
Thanks for off
https://github.com/aadanen updated
https://github.com/llvm/llvm-project/pull/149396
>From f3fbebdd6d940d36561ccf5177510095ba05077e Mon Sep 17 00:00:00 2001
From: Aaron Danen
Date: Wed, 16 Jul 2025 19:44:58 -0700
Subject: [PATCH 1/5] clarified %undo error msg in clang-repl
used grep -r "Too man
https://github.com/aadanen edited
https://github.com/llvm/llvm-project/pull/149396
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aadanen edited
https://github.com/llvm/llvm-project/pull/149396
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aadanen wrote:
Okay I think that does it :)
https://github.com/llvm/llvm-project/pull/149396
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aadanen updated
https://github.com/llvm/llvm-project/pull/149396
>From f3fbebdd6d940d36561ccf5177510095ba05077e Mon Sep 17 00:00:00 2001
From: Aaron Danen
Date: Wed, 16 Jul 2025 19:44:58 -0700
Subject: [PATCH 1/4] clarified %undo error msg in clang-repl
used grep -r "Too man
https://github.com/aadanen updated
https://github.com/llvm/llvm-project/pull/149396
>From f3fbebdd6d940d36561ccf5177510095ba05077e Mon Sep 17 00:00:00 2001
From: Aaron Danen
Date: Wed, 16 Jul 2025 19:44:58 -0700
Subject: [PATCH 1/4] clarified %undo error msg in clang-repl
used grep -r "Too man
https://github.com/aadanen updated
https://github.com/llvm/llvm-project/pull/149396
>From f3fbebdd6d940d36561ccf5177510095ba05077e Mon Sep 17 00:00:00 2001
From: Aaron Danen
Date: Wed, 16 Jul 2025 19:44:58 -0700
Subject: [PATCH 1/3] clarified %undo error msg in clang-repl
used grep -r "Too man
https://github.com/aadanen updated
https://github.com/llvm/llvm-project/pull/149396
>From f3fbebdd6d940d36561ccf5177510095ba05077e Mon Sep 17 00:00:00 2001
From: Aaron Danen
Date: Wed, 16 Jul 2025 19:44:58 -0700
Subject: [PATCH 1/2] clarified %undo error msg in clang-repl
used grep -r "Too man
aadanen wrote:
1. I am able to build clang, compile the project, and I am currently running
the "ninja check-clang-unit" tests. Although it does take an incredibly long
time ( 45 minutes to an hour) but that's off topic
2. I attached my email
3. I think I understand what you're describing as
https://github.com/aadanen created
https://github.com/llvm/llvm-project/pull/149396
Hi all. This is my first pull request to an open source project. I am a student
so have mercy on me!
I have done my best to read all of the relevant documentation about how to
contribute most effectively but i
25 matches
Mail list logo
