[PATCH] D157566: [SEH] fix assertion when -fasy-exceptions is used.

asmith accepted this revision. asmith added inline comments. Comment at: clang/test/CodeGen/windows-seh-async-exceptions.cpp:21 +{ +devif_Warning(""); +return 0; nit; spacing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

asmith accepted this revision. asmith added a comment. Thanks everyone for the great feedback! We'll move forward with landing this first patch and start the review of the next one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

asmith added a comment. @rjmccall @rsmith Thanks for your help. Do you have any additional feedback before we commit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

asmith added a comment. In D80344#2671157 , @lebedev.ri wrote: > It would be good for @rjmccall / @rsmith / etc to actually finish reviewing > this and accept it. > I would personally want to see the next patches - what changes are needed for > llvm

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

asmith added a comment. Hi John, how does this look now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

asmith added a comment. This patch looks ready to land. Are there any other concerns or feedback? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 ___ cfe-commits

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

asmith added a comment. > @rjmccall wrote: > I think you're missing what I'm asking. If LLVM accepts this feature, it > will become our collective responsibility as a project to keep it working. > You have a large external correctness test suite for this feature. It does > not sound like

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

asmith added a comment. Yes there was an RFC and discussion and several requests for comments. http://lists.llvm.org/pipermail/llvm-dev/2020-March/140541.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344

[PATCH] D77982: [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally

asmith added a comment. Thanks for all the helpful feedback. Before we commit this just want to double check there are no final comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77982/new/ https://reviews.llvm.org/D77982

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC option -EHa)

asmith added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:2003 +// : Under -EHa, Invoke llvm.eha.scope.begin() right after +// Ctor is emitted and EHStack.pushCleanup Nit - remove name Comment at:

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

asmith added a comment. really happy for native bfloat support! Comment at: clang/include/clang/AST/ASTContext.h:965 CanQualType HalfTy; // [OpenCL 6.1.1.1], ARM NEON + CanQualType BFloat16Ty; // ARM NEON CanQualType Float16Ty; // C11 extension ISO/IEC TS 18661-3

[PATCH] D77936: [Windows SEH] Fix abnormal-exits in _try

This revision was automatically updated to reflect the committed changes. Closed by commit rG4eabd0061254: [Windows SEH] Fix abnormal-exits in _try (authored by asmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77936/new/

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

This revision was automatically updated to reflect the committed changes. Closed by commit rG292058a5d6d7: [clang-format] Fix Microsoft style for enums (authored by asmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith added a comment. In D78982#2012992 , @MyDeveloperDay wrote: > LGTM Thanks for the help! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 ___

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith updated this revision to Diff 261247. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith updated this revision to Diff 261246. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith updated this revision to Diff 261239. asmith marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith marked 2 inline comments as done. asmith added inline comments. Comment at: clang/lib/Format/Format.cpp:1143 Style.PenaltyReturnTypeOnItsOwnLine = 1000; + Style.AllowShortEnumsOnASingleLine = (Language != FormatStyle::LK_Cpp); Style.AllowShortFunctionsOnASingleLine

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith updated this revision to Diff 260932. asmith retitled this revision from "[clang-format] Fix Microsoft style for C++ enums" to "[clang-format] Fix Microsoft style for enums". asmith edited the summary of this revision. asmith added a comment. Enable for C# CHANGES SINCE LAST ACTION

[PATCH] D78982: [clang-format] Fix Microsoft style for C++ enums

asmith added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:721 - -**InsertTrailingCommas** (``TrailingCommaStyle``) can be set to ``TCS_Wrapped`` - to insert trailing commas in container literals (arrays and objects) that wrap

[PATCH] D78982: [clang-format] Fix Microsoft style for C++ enums

asmith marked 6 inline comments as done. asmith added a comment. The is done unless there are other comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:721 - -**InsertTrailingCommas** (``TrailingCommaStyle``) can be set to ``TCS_Wrapped`` - to insert trailing commas

[PATCH] D78982: [clang-format] Fix Microsoft style for C++ enums

asmith updated this revision to Diff 260814. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp

[PATCH] D78982: [clang-format] Fix Microsoft style for C++ enums

asmith updated this revision to Diff 260812. asmith retitled this revision from "[clang-format] Fix Microsoft style for enums" to "[clang-format] Fix Microsoft style for C++ enums". asmith edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith added a comment. In D78982#2007172 , @MyDeveloperDay wrote: > - This needs unit tests in clang/unittests/Format to demonstrate the problem > and test this fixing it Is there an easy way to check the test is working? 'ninja check-clang-format'

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith marked 5 inline comments as done. asmith added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1767 if (FormatTok->Tok.getKind() == ClosingBraceKind) { + if (!Style.AllowEnumsOnASingleLine) +addUnwrappedLine(); This

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith updated this revision to Diff 260732. asmith added a comment. Rename option Add test case Only apply to Microsoft CPP style CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 Files: clang/include/clang/Format/Format.h

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith updated this revision to Diff 260551. asmith added a comment. Fix line breaks like this: enum { a=1, b=2, c=3 } myEnum; which becomes: enum { a=1, b=2, c=3 } myEnum; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 Files:

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith updated this revision to Diff 260542. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 Files: clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp clang/lib/Format/UnwrappedLineParser.cpp Index:

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith added a comment. This change tries to fix this bug. https://bugs.llvm.org/show_bug.cgi?id=32810 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 ___

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith created this revision. asmith added reviewers: jbcoe, MyDeveloperDay. Herald added a project: clang. Herald added a subscriber: cfe-commits. asmith added a reviewer: thakis. Before this change enums were formatted incorrectly for the Microsoft style. [Original Source] enum {

[PATCH] D59347: [DebugInfo] Combine Trivial and NonTrivial flags

This revision was automatically updated to reflect the committed changes. Closed by commit rL358219: [DebugInfo] Combine Trivial and NonTrivial flags (authored by asmith, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D59347: [DebugInfo] Combine Trivial and NonTrivial flags

asmith marked 2 inline comments as done. asmith added a comment. This should be ready to commit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59347/new/ https://reviews.llvm.org/D59347 ___ cfe-commits mailing list

[PATCH] D59347: [DebugInfo] Combine Trivial and NonTrivial flags

asmith updated this revision to Diff 194249. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59347/new/ https://reviews.llvm.org/D59347 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGenCXX/debug-info-composite-triviality.cpp Index: test/CodeGenCXX/debug-info-composite-triviality.cpp

[PATCH] D59347: [DebugInfo] Combine Trivial and NonTrivial flags

asmith added a comment. Okay if we change the flag then I believe the tests under llvm/tests/lib/DebugInfo/CodeView must be updated. If we use NonTrivial all the existing tests work as expected. LLVM change is here (you are all reviewers). https://reviews.llvm.org/D59348 Repository: rC

[PATCH] D59347: [DebugInfo] Combine Trivial and NonTrivial flags

asmith added a comment. Either way. It was fewer changes to use FlagNonTrivial. Which flag do people want to keep? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59347/new/ https://reviews.llvm.org/D59347 ___

[PATCH] D59347: [DebugInfo] Combine Trivial and NonTrivial flags

asmith created this revision. asmith added reviewers: rnk, zturner, dblaikie, probinson. Herald added subscribers: cfe-commits, jdoerfert, aprantl. Herald added a project: clang. These flags are used when emitting debug info and needed to initialize subprogram and member function attributes

[PATCH] D59010: [DebugInfo] Add test cases for FlagNonTrivial

This revision was automatically updated to reflect the committed changes. Closed by commit rC355890: [DebugInfo] Add test cases for FlagNonTrivial (authored by asmith, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang CHANGES SINCE

[PATCH] D45124: [CodeGen] Record if a C++ record is a trivial type

This revision was automatically updated to reflect the committed changes. Closed by commit rC337736: [CodeGen] Record if a C++ record is a trivial type (authored by asmith, committed by ). Repository: rC Clang https://reviews.llvm.org/D45124 Files: lib/CodeGen/CGDebugInfo.cpp Index:

[PATCH] D45124: [CodeGen] Record if a C++ record is a trivial type when emitting Codeview

asmith updated this revision to Diff 156664. https://reviews.llvm.org/D45124 Files: lib/CodeGen/CGDebugInfo.cpp Index: lib/CodeGen/CGDebugInfo.cpp === --- lib/CodeGen/CGDebugInfo.cpp +++ lib/CodeGen/CGDebugInfo.cpp @@ -2847,6

[PATCH] D45124: [CodeGen] Record if a C++ record is a trivial type when emitting Codeview

asmith added a reviewer: aleksandr.urakov. asmith added a comment. Adding Aleksandr Repository: rC Clang https://reviews.llvm.org/D45124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45124: [CodeGen] Record if a C++ record is trivial type when emitting Codeview

asmith created this revision. asmith added reviewers: rnk, zturner, llvm-commits. Herald added a subscriber: cfe-commits. This has a dependence on https://reviews.llvm.org/D45122 Repository: rC Clang https://reviews.llvm.org/D45124 Files: CodeGen/CGDebugInfo.cpp Index:

[PATCH] D44581: [Driver] Fix the descriptions for -Tdata and -Ttext options

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC327775: [Driver] Fix the descriptions for -Tdata and -Ttext options (authored by asmith, committed by ). Repository:

[PATCH] D44581: [Driver] Fix the descriptions for -Tdata and -Ttext options

asmith created this revision. asmith added a reviewer: llvm-commits. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D44581 Files: include/clang/Driver/Options.td Index: include/clang/Driver/Options.td

[PATCH] D43164: Fix test clang-diff-json.cpp

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC324824: Fix test clang-diff-json.cpp (authored by asmith, committed by ). Repository: rC Clang

[PATCH] D43164: Fix test from failing when the python path has spaces

asmith created this revision. asmith added reviewers: zturner, llvm-commits. Herald added subscribers: cfe-commits, klimek. This test would fail if the python path had spaces. Add a quote around the path to fix this problem and update some test values changed by the addition of quotes around