@@ -7245,6 +7245,11 @@ let Visibility = [CC1Option, CC1AsOption, FC1Option] in {
def tune_cpu : Separate<["-"], "tune-cpu">,
HelpText<"Tune for a specific cpu type">,
MarshallingInfoString>;
+def fexec_charset : Separate<["-"], "fexec-charset">, MetaVarName<"">,
+ HelpText
@@ -25,6 +26,16 @@
#define CCSID_UTF_8 1208
#define CCSID_ISO8859_1 819
+#ifndef STDIN_FILENO
+#define STDIN_FILENO 0
+#endif
+#ifndef STDOUT_FILENO
+#define STDOUT_FILENO 1
+#endif
+#ifndef STDERR_FILENO
+#define STDERR_FILENO 2
+#endif
abhina-sree wrote:
Th
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/143174
>From adae2d22365b1c4f75a5050cce840e3241cc Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Fri, 6 Jun 2025 12:16:52 -0400
Subject: [PATCH] refactor AutoConvert.h to remove MVS guard
---
cl
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/143174
>From cedf7e22c9d1ee7af74aa9c8e3e77c4d86fe7767 Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Fri, 6 Jun 2025 12:16:52 -0400
Subject: [PATCH] refactor AutoConvert.h to remove MVS guard
---
cl
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/143174
>From a796217c30f70f2ded3505c1624649b7226ef5ff Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Fri, 6 Jun 2025 12:16:52 -0400
Subject: [PATCH] refactor AutoConvert.h to remove MVS guard
---
cl
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/143174
>From dd9f82c5f6f48f175e973b43cd6303e757e1907e Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Fri, 6 Jun 2025 12:16:52 -0400
Subject: [PATCH] refactor AutoConvert.h to remove MVS guard
---
cl
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/143174
>From 4f8acb6898ca282321d688b960ca02f8e80bad26 Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Fri, 6 Jun 2025 12:16:52 -0400
Subject: [PATCH] refactor AutoConvert.h to remove MVS guard
---
cl
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/143174
>From 086e1c1b4f9e03d9868bcbf20a49a3ca7eba7b4c Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Fri, 6 Jun 2025 12:16:52 -0400
Subject: [PATCH] refactor AutoConvert.h to remove MVS guard
---
cl
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/143174
>From 4150caef611edbf277604823a6d625cfd8424bc4 Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Fri, 6 Jun 2025 12:16:52 -0400
Subject: [PATCH] refactor AutoConvert.h to remove MVS guard
---
cl
https://github.com/abhina-sree edited
https://github.com/llvm/llvm-project/pull/143174
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/143174
>From 101542e2ea0b58482937819a94dc5d0db81e91a5 Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Fri, 6 Jun 2025 12:16:52 -0400
Subject: [PATCH] refactor AutoConvert.h to remove MVS guard
---
cl
https://github.com/abhina-sree created
https://github.com/llvm/llvm-project/pull/143174
This AutoConvert.h header frequently gets mislabeled as an unused include
because it is guarded by MVS internally and every usage is also guarded. This
refactors the change to remove this guard and instead
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/138895
>From 425aa66b8a57eb49ad0c678587a20e81c0ae5433 Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Wed, 7 May 2025 11:26:59 -0400
Subject: [PATCH] This patch enables the fexec-charset option to cont
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/138895
>From 7c6653b4a05097333ae2b73c6664f18b7acb9edb Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Wed, 7 May 2025 11:26:59 -0400
Subject: [PATCH] This patch enables the fexec-charset option to cont
https://github.com/abhina-sree edited
https://github.com/llvm/llvm-project/pull/138895
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,36 @@
+//===--- clang/Lex/LiteralConverter.h - Translator for Literals -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -246,18 +249,19 @@ class StringLiteralParser {
StringLiteralEvalMethod EvalMethod;
public:
- StringLiteralParser(ArrayRef StringToks, Preprocessor &PP,
- StringLiteralEvalMethod StringMethod =
- StringLiteralEvalMethod::Evalu
https://github.com/abhina-sree closed
https://github.com/llvm/llvm-project/pull/142966
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
abhina-sree wrote:
> LGTM, but I would also consider dropping the "using namespace llvm" instead.
> This seems a bit unusual for a file in clang/lib/Analysis.
Thanks! I've implemented your suggested solution instead
https://github.com/llvm/llvm-project/pull/142966
_
https://github.com/abhina-sree edited
https://github.com/llvm/llvm-project/pull/142966
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/142966
>From f536c944cf6526676e5034471ff238b1ce3b0d13 Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Thu, 5 Jun 2025 09:41:54 -0400
Subject: [PATCH 1/2] fix error that reference to PointerType is ambi
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/142966
>From f536c944cf6526676e5034471ff238b1ce3b0d13 Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Thu, 5 Jun 2025 09:41:54 -0400
Subject: [PATCH] fix error that reference to PointerType is ambiguou
https://github.com/abhina-sree edited
https://github.com/llvm/llvm-project/pull/142966
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/138895
>From bd3dd4db933d9fa62e2cbb1f2dacf215e10c9e5e Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Wed, 7 May 2025 11:26:59 -0400
Subject: [PATCH] This patch enables the fexec-charset option to cont
abhina-sree wrote:
I'm currently working on addressing all the comments, I have just rebased this
PR to use the TextEncodingConverter, thanks for your patience!
https://github.com/llvm/llvm-project/pull/138895
___
cfe-commits mailing list
cfe-commits@
https://github.com/abhina-sree edited
https://github.com/llvm/llvm-project/pull/138895
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/138895
>From c7822ec6f907f88c960cdf4b3eaeb5eb2ed55024 Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Wed, 7 May 2025 11:26:59 -0400
Subject: [PATCH] This patch enables the fexec-charset option to cont
https://github.com/abhina-sree approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/141110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/abhina-sree edited
https://github.com/llvm/llvm-project/pull/138895
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/abhina-sree approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/138244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/abhina-sree approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/135842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/abhina-sree approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/135430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/abhina-sree closed
https://github.com/llvm/llvm-project/pull/127514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/127514
>From a015e8389fa263cbbb28e56e93fae733f5e94dde Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Mon, 17 Feb 2025 10:56:10 -0500
Subject: [PATCH 1/2] mark text files as text in ClangScanDeps
---
https://github.com/abhina-sree created
https://github.com/llvm/llvm-project/pull/127514
This patch continues the work that was started here
https://reviews.llvm.org/D99426 to correctly open text files in text mode.
>From a015e8389fa263cbbb28e56e93fae733f5e94dde Mon Sep 17 00:00:00 2001
From: A
https://github.com/abhina-sree closed
https://github.com/llvm/llvm-project/pull/125570
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/abhina-sree created
https://github.com/llvm/llvm-project/pull/125570
This patch continues the work that was started here
https://reviews.llvm.org/D99426 to correctly open text files in text mode.
>From 7ac3589c34f4cb48bbf9b0fea74adfc9fccaecdf Mon Sep 17 00:00:00 2001
From: A
@@ -277,6 +277,11 @@ def err_cpu_unsupported_isa
def err_arch_unsupported_isa
: Error<"architecture '%0' does not support '%1' execution mode">;
+def err_zos_target_release_discontinued
+ : Error<"z/OS target level \"%0\" is discontinued. Unexpected behavior
might occur i
https://github.com/abhina-sree approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/123399
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/abhina-sree approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/121849
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/abhina-sree approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/120276
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/abhina-sree closed
https://github.com/llvm/llvm-project/pull/98652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/98652
>From 4583cacec6daa1e980d5149be063120b34731f4c Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Fri, 12 Jul 2024 11:17:24 -0400
Subject: [PATCH 1/3] update autoconversion functionality to fix erro
@@ -70,6 +70,13 @@ class FileEntryRef {
const FileEntry &getFileEntry() const {
return *getBaseMapEntry().second->V.get();
}
+
+ // This is a non const version of getFileEntry() which is used if the buffer
+ // size needs to be increased due to potential z/OS EBCDIC -
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/98652
>From 4583cacec6daa1e980d5149be063120b34731f4c Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Fri, 12 Jul 2024 11:17:24 -0400
Subject: [PATCH 1/4] update autoconversion functionality to fix erro
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/98652
>From 4583cacec6daa1e980d5149be063120b34731f4c Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Fri, 12 Jul 2024 11:17:24 -0400
Subject: [PATCH 1/3] update autoconversion functionality to fix erro
@@ -70,6 +70,13 @@ class FileEntryRef {
const FileEntry &getFileEntry() const {
return *getBaseMapEntry().second->V.get();
}
+
+ // This is a non const version of getFileEntry() which is used if the buffer
+ // size needs to be increased due to potential z/OS EBCDIC -
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/98652
>From 4583cacec6daa1e980d5149be063120b34731f4c Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Fri, 12 Jul 2024 11:17:24 -0400
Subject: [PATCH 1/2] update autoconversion functionality to fix erro
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/98652
>From 4583cacec6daa1e980d5149be063120b34731f4c Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Fri, 12 Jul 2024 11:17:24 -0400
Subject: [PATCH 1/2] update autoconversion functionality to fix erro
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/98652
>From 4583cacec6daa1e980d5149be063120b34731f4c Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Fri, 12 Jul 2024 11:17:24 -0400
Subject: [PATCH 1/2] update autoconversion functionality to fix erro
https://github.com/abhina-sree edited
https://github.com/llvm/llvm-project/pull/98652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -617,6 +625,23 @@ FileID SourceManager::createFileIDImpl(ContentCache &File,
StringRef Filename,
return FileID::get(LoadedID);
}
unsigned FileSize = File.getSize();
+#ifdef __MVS__
abhina-sree wrote:
Thanks, I made a small helper function to move o
@@ -617,6 +625,23 @@ FileID SourceManager::createFileIDImpl(ContentCache &File,
StringRef Filename,
return FileID::get(LoadedID);
}
unsigned FileSize = File.getSize();
+#ifdef __MVS__
+ llvm::ErrorOr NeedConversion =
+ llvm::needzOSConversion(Filename.str().c_str
https://github.com/abhina-sree edited
https://github.com/llvm/llvm-project/pull/98652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -166,8 +167,15 @@ ContentCache::getBufferOrNone(DiagnosticsEngine &Diag,
FileManager &FM,
// Unless this is a named pipe (in which case we can handle a mismatch),
// check that the file's size is the same as in the file entry (which may
// have come from a stat cache)
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/98652
>From 4583cacec6daa1e980d5149be063120b34731f4c Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Fri, 12 Jul 2024 11:17:24 -0400
Subject: [PATCH 1/2] update autoconversion functionality to fix erro
https://github.com/abhina-sree edited
https://github.com/llvm/llvm-project/pull/98652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -70,6 +70,11 @@ class FileEntryRef {
const FileEntry &getFileEntry() const {
return *getBaseMapEntry().second->V.get();
}
+#ifdef __MVS__
abhina-sree wrote:
There are a lot of uses of the const function so we would hit a lot of errors
if we got rid
https://github.com/abhina-sree approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/115368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
abhina-sree wrote:
> > Hi, this PR is causing a regression on the AIX bot here
> > https://lab.llvm.org/buildbot/#/builders/64/builds/1321/steps/6/logs/FAIL__Clang__pgo-cold-function-coverage_c.
> > Would you be able to take a look? I think it can be resolved by using
> > clang_cc1 in the test
abhina-sree wrote:
Hi, this PR is causing a regression on the AIX bot here
https://lab.llvm.org/buildbot/#/builders/64/builds/1321/steps/6/logs/FAIL__Clang__pgo-cold-function-coverage_c.
Would you be able to take a look? I think it can be resolved by using
clang_cc1 in the testcase of marking
https://github.com/abhina-sree approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/100142
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/abhina-sree approved this pull request.
LGTM, just needs to include the suggested formatting fix
https://github.com/llvm/llvm-project/pull/11
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
abhina-sree wrote:
Closing this because an alternative solution was implemented here
https://github.com/llvm/llvm-project/pull/111723
https://github.com/llvm/llvm-project/pull/110661
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://list
https://github.com/abhina-sree closed
https://github.com/llvm/llvm-project/pull/110661
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/abhina-sree closed
https://github.com/llvm/llvm-project/pull/111723
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/abhina-sree approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/112814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -8,7 +8,6 @@
#include "clang-c/Documentation.h"
#include "clang-c/Index.h"
#include "clang/Config/config.h"
-#include "llvm/Support/AutoConvert.h"
abhina-sree wrote:
Yes, I think that would be a better solution, I will try to get to that when I
have time,
@@ -8,7 +8,6 @@
#include "clang-c/Documentation.h"
#include "clang-c/Index.h"
#include "clang/Config/config.h"
-#include "llvm/Support/AutoConvert.h"
abhina-sree wrote:
Inside that header we guard the C++ code inside an `#ifdef __cplusplus` so it
should work
@@ -8,7 +8,6 @@
#include "clang-c/Documentation.h"
#include "clang-c/Index.h"
#include "clang/Config/config.h"
-#include "llvm/Support/AutoConvert.h"
abhina-sree wrote:
We need this header because we are using the function enablezOSAutoConversion
below in thi
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/111723
>From c1676e48a587e10ba54c28e99192fd5e6a36f72e Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Wed, 9 Oct 2024 13:23:41 -0400
Subject: [PATCH 1/3] [SystemZ][z/OS] Add new openFileForReadBinary f
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/111723
>From c1676e48a587e10ba54c28e99192fd5e6a36f72e Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Wed, 9 Oct 2024 13:23:41 -0400
Subject: [PATCH 1/3] [SystemZ][z/OS] Add new openFileForReadBinary f
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/111723
>From c1676e48a587e10ba54c28e99192fd5e6a36f72e Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Wed, 9 Oct 2024 13:23:41 -0400
Subject: [PATCH 1/3] [SystemZ][z/OS] Add new openFileForReadBinary f
abhina-sree wrote:
@cor3ntin, I've added support for #embed handling now, I've added a z/OS only
testcase clang/test/Preprocessor/embed_zos.c which is a copy of
clang/test/Preprocessor/embed_art.c except it changes the file tag to be
non-ascii which is now working with the latest commit.
http
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/111723
>From c1676e48a587e10ba54c28e99192fd5e6a36f72e Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Wed, 9 Oct 2024 13:23:41 -0400
Subject: [PATCH 1/3] [SystemZ][z/OS] Add new openFileForReadBinary f
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/111723
>From c1676e48a587e10ba54c28e99192fd5e6a36f72e Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Wed, 9 Oct 2024 13:23:41 -0400
Subject: [PATCH 1/2] [SystemZ][z/OS] Add new openFileForReadBinary f
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/111723
>From c1676e48a587e10ba54c28e99192fd5e6a36f72e Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Wed, 9 Oct 2024 13:23:41 -0400
Subject: [PATCH 1/2] [SystemZ][z/OS] Add new openFileForReadBinary f
abhina-sree wrote:
> @abhina-sree do you plan to modify embed in this PR?
Actually Sean has pointed out that if we pass in non-ascii inputs, the tests do
in fact fail. So I will look into passing the IsText parameter in the necessary
functions. Thanks for pointing this out!
https://github.com
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/111723
>From c1676e48a587e10ba54c28e99192fd5e6a36f72e Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Wed, 9 Oct 2024 13:23:41 -0400
Subject: [PATCH 1/2] [SystemZ][z/OS] Add new openFileForReadBinary f
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/111723
>From c1676e48a587e10ba54c28e99192fd5e6a36f72e Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Wed, 9 Oct 2024 13:23:41 -0400
Subject: [PATCH 1/2] [SystemZ][z/OS] Add new openFileForReadBinary f
@@ -54,7 +54,9 @@ std::unique_ptr HeaderMap::Create(FileEntryRef FE,
FileManager &FM) {
unsigned FileSize = FE.getSize();
if (FileSize <= sizeof(HMapHeader)) return nullptr;
- auto FileBuffer = FM.getBufferForFile(FE);
+ auto FileBuffer =
+ FM.getBufferForFile(FE,
@@ -302,6 +305,17 @@ class RealFileSystem : public FileSystem {
return Storage;
}
+ ErrorOr> openFileForRead(const Twine &Name,
abhina-sree wrote:
I don't think I'm able to mark it static because it calls adjustPath which is
non-static
https://github
@@ -324,6 +330,17 @@ ErrorOr RealFileSystem::status(const Twine &Path) {
ErrorOr>
RealFileSystem::openFileForRead(const Twine &Name) {
+ SmallString<256> RealName, Storage;
abhina-sree wrote:
I've created a private function for both functions to call, thanks
@@ -117,8 +117,12 @@ FileSystem::~FileSystem() = default;
ErrorOr>
FileSystem::getBufferForFile(const llvm::Twine &Name, int64_t FileSize,
- bool RequiresNullTerminator, bool IsVolatile) {
- auto F = openFileForRead(Name);
+
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/111723
>From c1676e48a587e10ba54c28e99192fd5e6a36f72e Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Wed, 9 Oct 2024 13:23:41 -0400
Subject: [PATCH] [SystemZ][z/OS] Add new openFileForReadBinary funct
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/111723
>From 8443744a40bd1397155ea9d91fbe720a8826139d Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Wed, 9 Oct 2024 13:23:41 -0400
Subject: [PATCH 1/2] [SystemZ][z/OS] Add new openFileForReadBinary f
abhina-sree wrote:
> The default is set to OF_Text instead of OF_None, this change in value does
> not affect any other platforms other than z/OS. Setting this parameter
> correctly is required to open files on z/OS in the correct encoding. The
> IsText parameter is based on the context of whe
https://github.com/abhina-sree created
https://github.com/llvm/llvm-project/pull/111723
This patch adds an IsText parameter to the following getBufferForFile,
getBufferForFileImpl. We introduce a new virtual function openFileForReadBinary
which defaults to openFileForRead except in RealFileSys
https://github.com/abhina-sree approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/82
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
abhina-sree wrote:
> https://github.com/llvm/llvm-project/blob/main/clang/lib/Lex/PPDirectives.cpp#L3964-L3990
Yes I think we still require specifying the Text/Binary parameter based on the
context of where it is called. I will look into adding the new virtual
functions as an alternative solu
https://github.com/abhina-sree approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/111035
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/abhina-sree approved this pull request.
LGTM, can we add [SystemZ][z/OS] in the title to make it consistent with other
PRs
https://github.com/llvm/llvm-project/pull/111053
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
abhina-sree wrote:
> > sorry this is same as #107906 (with a bigger impact radius, as you're also
> > changing getBufferForFile) and doesn't address any of the issues mention
> > about explaining the semantics of `IsText` or justification for changing
> > the core VFS interfaces, for an operat
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/110661
>From b4bf7c601d2b790ea5e65f68cb1fa9375457b558 Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Mon, 9 Sep 2024 15:32:09 -0400
Subject: [PATCH] Propagate IsText parameter to openFileForRead funct
https://github.com/abhina-sree edited
https://github.com/llvm/llvm-project/pull/110661
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
abhina-sree wrote:
> > @perry-ca raised some concerns in #109664 about this functionality
> > requiring some context awareness, I don't think any of those is addressed
> > by this patch either. Pretty much all of the callers apart from ASTReader
> > is just using `IsText = true`.
>
> It just
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/110661
>From 1a5096483d5d6d84087e913b20f6f260452988b3 Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Mon, 9 Sep 2024 15:32:09 -0400
Subject: [PATCH] Propagate IsText parameter to openFileForRead funct
https://github.com/abhina-sree closed
https://github.com/llvm/llvm-project/pull/109972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/109972
>From 0dd3d22bfa419a70fe91c6b1b0c277d7cb21a51e Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Wed, 25 Sep 2024 08:42:10 -0400
Subject: [PATCH] [SystemZ][z/OS] Open text files in text mode
---
https://github.com/abhina-sree approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/107916
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 193 matches
Mail list logo
