[PATCH] D150258: [clang][parser] Fix namespace dropping after malformed declarations

2023-05-15 Thread Alejandro Álvarez Ayllón via Phabricator via cfe-commits
alejandro-alvarez-sonarsource added a comment. In D150258#4337880 , @aaron.ballman wrote: > LGTM! Do you need me to commit on your behalf? If so, what name and email > address would you like used for patch attribution? Thanks a lot! And yes, I would ne

[PATCH] D150258: [clang][parser] Fix namespace dropping after malformed declarations

2023-05-12 Thread Alejandro Álvarez Ayllón via Phabricator via cfe-commits
alejandro-alvarez-sonarsource added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:2306-2310 // Otherwise things are very confused and we skip to recover. if (!isDeclarationSpecifier(ImplicitTypenameContext::No)) { - SkipUntil(tok::r_brace, StopAtSemi |

[PATCH] D150258: [clang][parser] Fix namespace dropping after malformed declarations

2023-05-12 Thread Alejandro Álvarez Ayllón via Phabricator via cfe-commits
alejandro-alvarez-sonarsource updated this revision to Diff 521625. alejandro-alvarez-sonarsource added a comment. Applied suggested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150258/new/ https://reviews.llvm.org/D150258 Files: clang/docs/ReleaseNotes.rst clang/lib/Pars

[PATCH] D150258: [clang][parser] Fix namespace dropping after malformed declarations

2023-05-10 Thread Alejandro Álvarez Ayllón via Phabricator via cfe-commits
alejandro-alvarez-sonarsource created this revision. alejandro-alvarez-sonarsource added a reviewer: aaron.ballman. alejandro-alvarez-sonarsource added a project: clang. Herald added a subscriber: kadircet. Herald added a project: All. alejandro-alvarez-sonarsource requested review of this revision