[PATCH] D152443: Add operator style options to clang-format

KitsuneAlex updated this revision to Diff 530348. KitsuneAlex marked 2 inline comments as done. KitsuneAlex added a comment. Fix broken style in TokenAnnotator.cpp. I don't know how i keep missing these, trying to get better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152443: Add operator style options to clang-format

KitsuneAlex updated this revision to Diff 530346. KitsuneAlex marked 4 inline comments as done. KitsuneAlex added a comment. Added missing test case for default operator declarations as requested, as well as blank lines between the blocks inside the test functions as visual separators.

[PATCH] D152443: Add operator style options to clang-format

KitsuneAlex updated this revision to Diff 530343. KitsuneAlex added a comment. Revamped the formatting logic again and added the requested unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152443/new/ https://reviews.llvm.org/D152443

[PATCH] D152443: Add SpaceAfterOperatorKeyword & SpaceAfterOperatorKeywordInCall style options for clang-format

KitsuneAlex updated this revision to Diff 530303. KitsuneAlex marked 2 inline comments as done. KitsuneAlex removed reviewers: lattner, craig.topper, RKSimon, respindola, rymiel, owenpan. KitsuneAlex added a comment. Herald added reviewers: rymiel, owenpan. This revision of the diff changes the

[PATCH] D152443: Add SpaceAfterOperatorKeyword & SpaceAfterOperatorKeywordInCall style options for clang-format

KitsuneAlex added a comment. In D152443#4408991 , @MyDeveloperDay wrote: > In D152443#4407438 , @KitsuneAlex > wrote: > >> I had some issues with Git there because i messed up a merge, so the diff >> was bad.

[PATCH] D152443: Add SpaceAfterOperatorKeyword & SpaceAfterOperatorKeywordInCall style options for clang-format

KitsuneAlex updated this revision to Diff 529804. KitsuneAlex added a comment. Clean up the formatting with clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152443/new/ https://reviews.llvm.org/D152443 Files:

[PATCH] D152443: Add SpaceAfterOperatorKeyword & SpaceAfterOperatorKeywordInCall style options for clang-format

KitsuneAlex updated this revision to Diff 529799. KitsuneAlex added a comment. I had some issues with Git there because i messed up a merge, so the diff was bad. Here's the proper diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152443/new/

[PATCH] D152443: Add SpaceAfterOperatorKeyword & SpaceAfterOperatorKeywordInCall style options for clang-format

KitsuneAlex updated this revision to Diff 529798. KitsuneAlex added a comment. Some additional changes because i exceeded the maximum line width on multiple occasions. Herald added a comment. NOTE: Clang-Format Team Automated Review Comment Your review contains a change to

[PATCH] D152443: Add SpaceAfterOperatorKeyword style option for clang-format

KitsuneAlex updated this revision to Diff 529788. KitsuneAlex added a comment. Applied all suggested changes and added a suiting option for aformentioned edge-case for call expressions. Also added the missing release notes to the apropriate section. Repository: rG LLVM Github Monorepo

[PATCH] D152443: Add SpaceAfterOperatorKeyword style option for clang-format

KitsuneAlex added a comment. In D152443#4406923 , @HazardyKnusperkeks wrote: > Can you add a note to the release notes also please? Of course! Doing that right now :) Another thing i was wondering was if it would make sense to add a separate option

[PATCH] D152443: Add SpaceAfterOperatorKeyword style option for clang-format

KitsuneAlex updated this revision to Diff 529635. KitsuneAlex added a comment. I took the liberty and extended the unit tests for SpaceAfterTemplateKeyword and SpaceAfterOperator keyword to cover both possible cases, which lead to me discovering that my code was not quite right because of an

[PATCH] D152443: Add SpaceAfterOperatorKeyword style option for clang-format

KitsuneAlex updated this revision to Diff 529587. KitsuneAlex added a comment. I removed the redundant anonymous parameter in the unit test source string. Locally all formatting tests passed fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152443: Add SpaceAfterOperatorKeyword style option for clang-format

KitsuneAlex added a comment. I made a stupid mistake and messed up the formatting of the anonymous parameter in the unit test code. Fixing this right now, don't know why it slipped through. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152443/new/

[PATCH] D152443: Add SpaceAfterOperatorKeyword style option for clang-format

KitsuneAlex created this revision. KitsuneAlex added reviewers: lattner, craig.topper, RKSimon, respindola. KitsuneAlex added a project: clang-format. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan,