alexfh wrote:
Sorry, we've been in a bit of a firefighting. I'll try to arrange some time for
this till the EOW.
https://github.com/llvm/llvm-project/pull/111992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
alexfh wrote:
@kadircet is working on a repro for the crash we're seeing. @usx95 is looking
at the compilation errors.
https://github.com/llvm/llvm-project/pull/111852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
alexfh wrote:
We've also found a clang crash and a few new compilation errors after
https://github.com/llvm/llvm-project/pull/114569. We definitely need to revert
it as well as this commit.
https://github.com/llvm/llvm-project/pull/111852
___
cfe-com
https://github.com/alexfh approved this pull request.
LG
https://github.com/llvm/llvm-project/pull/115159
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/alexfh closed
https://github.com/llvm/llvm-project/pull/111581
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/alexfh created
https://github.com/llvm/llvm-project/pull/111581
This manifested as an assertion failure in Clang built against libc++ with
hardening enabled (e.g. -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_DEBUG):
`libcxx/include/__memory/unique_ptr.h:596: assertion
__c
alexfh wrote:
I see. A clear diagnostic wouldn't hurt indeed. Thanks a lot for the analysis!
No more concerns from our side at this point.
https://github.com/llvm/llvm-project/pull/100692
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:/
alexfh wrote:
Wow, I would never have thought it was a problem. Making these the same type
removes the compilation error. Can you explain why this is a problem from the
C++ standard PoV?
https://github.com/llvm/llvm-project/pull/100692
___
cfe-commit
alexfh wrote:
It was faster than I thought. The original code for case 2 is indeed invalid.
Having looked carefully at the two definitions of PrintTo, I clearly see they
are violating ODR. And both are originating in the internal code, so nothing
specific to Eigen. Thanks again for the good ex
alexfh wrote:
> However, I suspect that the parentheses reduction and the one with a ternary
> are actually the same issue - The code is IFNDR per
> https://eel.is/c++draft/temp.over.link#5
>
> In you last example, M*2 and the conditional with M+N after the substitution
> of the default argum
alexfh wrote:
Thanks for the clarification! The fact that there's code around that isn't
quite following the standard, is not news, but the regular way to approach
tightening the compiler is to provide an opt-out mechanism for some time (one
release cycle?) in the shape of a flag or otherwise
alexfh wrote:
Our internal releases have been blocked on this issue, since even a local
revert is not an option at the moment due to the number of dependent commits
and problems in other parts of LLVM. We would appreciate if we could get a
resolution in the next day or two. If there's no clear
alexfh wrote:
An example, which is a bit closer to the original:
https://gcc.godbolt.org/z/5WMb78434.
https://github.com/llvm/llvm-project/pull/100692
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
alexfh wrote:
I looked at the original code and found a much more involved expression there
(https://gitlab.com/libeigen/eigen/-/blob/master/Eigen/src/Core/util/ForwardDeclarations.h?ref_type=heads#L66),
so the parenthesized expression is merely an artifact of reduction and there
doesn't seem
https://github.com/alexfh approved this pull request.
Looks good as a temporary fix. Thanks!
https://github.com/llvm/llvm-project/pull/109065
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
alexfh wrote:
> @alexfh #109065 Fixes test case 1.
I can confirm that it also fixes the compilation error in the original code.
https://github.com/llvm/llvm-project/pull/100692
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm
alexfh wrote:
Test case #2: https://gcc.godbolt.org/z/YbTKzao7d
https://github.com/llvm/llvm-project/pull/100692
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh wrote:
@mizvekov any news here? I think, I'll come up with two more reduced tests
later today.
https://github.com/llvm/llvm-project/pull/100692
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
alexfh wrote:
@mizvekov another distinct compilation error after this commit (and not fixed
by https://github.com/llvm/llvm-project/pull/107972 and other follow-up
commits): https://gcc.godbolt.org/z/zMG5nsda3 (reduced from
https://github.com/hlslibs/ac_math/blob/20bbf040834c5815b01a9ed8e523e4
https://github.com/alexfh approved this pull request.
Thanks! This fixes the issues we've found so far, and it seems to be a quite
clear correctness fix. LGTM
https://github.com/llvm/llvm-project/pull/108491
___
cfe-commits mailing list
cfe-commits@li
alexfh wrote:
Thanks! The fix resolves the crash, but the original code still doesn't
compile. See
https://github.com/llvm/llvm-project/pull/108491#issuecomment-2350634130
https://github.com/llvm/llvm-project/pull/94981
___
cfe-commits mailing list
c
alexfh wrote:
I could reduce the code to something that compiles with Clang before
fa6580470547411667b866362941db0b02e25578, but not after it, this PR doesn't fix
the issue. The example is: https://gcc.godbolt.org/z/odWYhxGxK
Note that the code doesn't compile with Clang 18.1, but should compi
alexfh wrote:
Filed #108618
https://github.com/llvm/llvm-project/pull/73662
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh wrote:
Apologies for resurrecting this old thread, but I found a problem with this
patch. It seems like it makes a comparator violate strict weak ordering
requirements. This manifests as an assertion failure when Clang is compiled
with the corresponding libc++ check:
```
clang -O1 -c -o
alexfh wrote:
Unfortunately, the original code, from which I reduced the test case for this,
still breaks (without crashing Clang though). I'm trying to come up with
another test case now.
https://github.com/llvm/llvm-project/pull/108491
___
cfe-comm
alexfh wrote:
Here's a reduced test case: https://gcc.godbolt.org/z/jxer3W39W
As usual, it's hard to say if the code got invalid during automatic reduction,
but it at least compiles well with clang before this commit.
https://github.com/llvm/llvm-project/pull/94981
alexfh wrote:
Hi @mizvekov, we started seeing crashes after this commit.
I'm working on a shareable test case, but here's the assertion failure and the
stack trace:
```
assert.h assertion failed at llvm-project/clang/lib/AST/TemplateName.cpp:184 in
TemplateDecl *clang::TemplateName::getAsTempl
alexfh wrote:
What about this case: https://godbolt.org/z/1TsK96ao8 ? It's a reduction of one
of a large number of broken builds we see after this patch.
https://github.com/llvm/llvm-project/pull/100692
___
cfe-commits mailing list
cfe-commits@lists.l
@@ -12210,7 +12220,18 @@ bool Sema::CheckFunctionDeclaration(Scope *S,
FunctionDecl *NewFD,
return Redeclaration;
}
-void Sema::CheckMain(FunctionDecl* FD, const DeclSpec& DS) {
+void Sema::CheckMain(FunctionDecl *FD, const DeclSpec &DS) {
+ // [basic.start.main]p3
+ //
alexfh wrote:
Thanks for the fix, @a-tarasyuk! Can you merge the PR or should I do this for
you?
https://github.com/llvm/llvm-project/pull/104594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/c
@@ -264,6 +264,7 @@ Bug Fixes to C++ Support
- Properly reject defaulted copy/move assignment operators that have a
non-reference explicit object parameter.
- Clang now properly handles the order of attributes in `extern` blocks.
(#GH101990).
- Fixed an assertion failure by p
@@ -122,6 +119,26 @@ namespace ns2 {
extern "C++" void main() {} // ok
}
+#elif TEST14
+extern "C" {
+ int main(); // expected-warning {{'main' should not be 'extern "C"'}}
+}
+
+extern "C" int main(); // expected-warning {{'main' should not be 'extern
"C"'}}
+
+#elif TEST
https://github.com/alexfh edited
https://github.com/llvm/llvm-project/pull/104594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -12233,7 +12233,6 @@ void Sema::CheckMain(FunctionDecl *FD, const DeclSpec
&DS) {
FD->getDeclContext()->getRedeclContext()->isTranslationUnit())) {
Diag(FD->getLocation(), diag::ext_main_invalid_linkage_specification)
<< FD->getLanguageLinkage();
-FD-
https://github.com/alexfh edited
https://github.com/llvm/llvm-project/pull/104594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/alexfh commented:
One more comment, actually.
https://github.com/llvm/llvm-project/pull/104594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/alexfh edited
https://github.com/llvm/llvm-project/pull/104594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/alexfh approved this pull request.
Looks good with one nit.
https://github.com/llvm/llvm-project/pull/104594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -264,6 +264,7 @@ Bug Fixes to C++ Support
- Properly reject defaulted copy/move assignment operators that have a
non-reference explicit object parameter.
- Clang now properly handles the order of attributes in `extern` blocks.
(#GH101990).
- Fixed an assertion failure by p
@@ -12210,7 +12220,18 @@ bool Sema::CheckFunctionDeclaration(Scope *S,
FunctionDecl *NewFD,
return Redeclaration;
}
-void Sema::CheckMain(FunctionDecl* FD, const DeclSpec& DS) {
+void Sema::CheckMain(FunctionDecl *FD, const DeclSpec &DS) {
+ // [basic.start.main]p3
+ //
alexfh wrote:
Hi @a-tarasyuk, it looks like this patch introduces a couple of problems. I
guess, this boils down to marking the declaration of main() invalid in case
it's declared with `extern "C"`, but I may be wrong here.
The first problem is a clang crash: https://gcc.godbolt.org/z/dWETErhz
https://github.com/alexfh closed
https://github.com/llvm/llvm-project/pull/100556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/alexfh closed
https://github.com/llvm/llvm-project/pull/100408
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh wrote:
> Could we merge the test into this change? I think we could then land this as
> a temporary workaround indeed. I'll keep looking into fixing this proper and
> will remove the XFAIL line when appropriate.
I've added the test to the change and verified it:
* fails without the Sem
alexfh wrote:
> ... I'd like to see at least a test added to this PR.
See #100556. The test would fail with assertions enabled (thus, marked XFAIL:
asserts), and when compiled against hardened libc++ (e.g. libc++ built with
`-D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_FAST`).
https://gith
https://github.com/alexfh created
https://github.com/llvm/llvm-project/pull/100556
The test is set to XFAIL with assertions enabled.
>From 09cf032759b43e8a30720be9ef2f9caf13bcb0cb Mon Sep 17 00:00:00 2001
From: Alexander Kornienko
Date: Thu, 25 Jul 2024 13:02:38 +0200
Subject: [PATCH] Add a t
alexfh wrote:
> Can you please add a reference to #100095 in the summary so folks just
> reading the git log have more context w/o going to the commit itself.
>
> I would like to see a more flushed out long-term plan for fixing this
> properly but I think it makes sense.
I've added more detai
https://github.com/alexfh edited
https://github.com/llvm/llvm-project/pull/100408
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/alexfh ready_for_review
https://github.com/llvm/llvm-project/pull/100408
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/alexfh updated
https://github.com/llvm/llvm-project/pull/100408
>From af5b5c114252cf1f6815b51871e2ad6436ffa723 Mon Sep 17 00:00:00 2001
From: Alexander Kornienko
Date: Wed, 24 Jul 2024 17:44:26 +0200
Subject: [PATCH] Avoid accessing unset optional, workaround for #100095
Thi
https://github.com/alexfh created
https://github.com/llvm/llvm-project/pull/100408
This is not a proper fix, but enables Clang to continue working with more
libc++ runtime checks enabled.
>From af5b5c114252cf1f6815b51871e2ad6436ffa723 Mon Sep 17 00:00:00 2001
From: Alexander Kornienko
Date: W
alexfh wrote:
Now there's a different and more subtle side-effect of this patch:
https://gcc.godbolt.org/z/YP3EfGern
The invalid expression `1 << 59` leads to the compiler silently ignoring the
in-class initializer of the static data member.
https://github.com/llvm/llvm-project/pull/70307
___
alexfh wrote:
I see. Thanks for the explanation and for the suggestion on how to fix that.
Actually, the only instance I've seen, had already been fixed upstream
(https://hg.openjdk.org/jdk/jdk/rev/71495d579a65), so the impact of this
compiler behavior change is quite low in my part of the uni
alexfh wrote:
Just to confirm: is this the intentional outcome of this patch?
https://gcc.godbolt.org/z/Kf9YK1qM3
```
enum {
a = 1<<12,
b = (-1)<<13
};
```
```
:3:9: error: expression is not an integral constant expression
3 | b = (-1)<<13
| ^~~~
:3:13: note: le
https://github.com/alexfh approved this pull request.
https://github.com/llvm/llvm-project/pull/97425
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh wrote:
Thanks for proposing a fix! I've been hinted though that Clang may be incorrect
in accepting explicit specializations of a templated static class data member
in the class scope. It looks like with all the restrictions in the standard it
may only be allowed to place explicit speci
Author: Alexander Kornienko
Date: 2024-01-24T21:42:38+01:00
New Revision: 6e4930c67508a90bdfd756f6e45417b5253cd741
URL:
https://github.com/llvm/llvm-project/commit/6e4930c67508a90bdfd756f6e45417b5253cd741
DIFF:
https://github.com/llvm/llvm-project/commit/6e4930c67508a90bdfd756f6e45417b5253cd741
Author: Alexander Kornienko
Date: 2023-09-01T12:53:24+02:00
New Revision: b7f4915644844fb9f32e8763922a070f5fe4fd29
URL:
https://github.com/llvm/llvm-project/commit/b7f4915644844fb9f32e8763922a070f5fe4fd29
DIFF:
https://github.com/llvm/llvm-project/commit/b7f4915644844fb9f32e8763922a070f5fe4fd29
Author: Alexander Kornienko
Date: 2023-02-23T17:31:04+01:00
New Revision: 1812e13a3d6be9a838672ff74b3d9d383f5a83b5
URL:
https://github.com/llvm/llvm-project/commit/1812e13a3d6be9a838672ff74b3d9d383f5a83b5
DIFF:
https://github.com/llvm/llvm-project/commit/1812e13a3d6be9a838672ff74b3d9d383f5a83b5
Author: Alexander Kornienko
Date: 2022-11-25T17:04:31+01:00
New Revision: 38f5ab4d44e3fa826006022aad377bb23ed357ca
URL:
https://github.com/llvm/llvm-project/commit/38f5ab4d44e3fa826006022aad377bb23ed357ca
DIFF:
https://github.com/llvm/llvm-project/commit/38f5ab4d44e3fa826006022aad377bb23ed357ca
Author: Alexander Kornienko
Date: 2022-11-08T17:19:54+01:00
New Revision: a5c18fcf6e7ffeea72aaf079477caf2ac1d641bc
URL:
https://github.com/llvm/llvm-project/commit/a5c18fcf6e7ffeea72aaf079477caf2ac1d641bc
DIFF:
https://github.com/llvm/llvm-project/commit/a5c18fcf6e7ffeea72aaf079477caf2ac1d641bc
Given the broad impact of this in our code I'm inclined to revert the patch
to unblock us. The test case I have so far is still too large, but I hope
to get something shareable tomorrow.
On Tue, 8 Nov 2022, 04:03 Matheus Izvekov via Phabricator, <
revi...@reviews.llvm.org> wrote:
> mizvekov added
Author: Alexander Kornienko
Date: 2022-10-23T23:14:40+02:00
New Revision: e7656daea8724ba1bed6eb7a4dc96498ce7d06c5
URL:
https://github.com/llvm/llvm-project/commit/e7656daea8724ba1bed6eb7a4dc96498ce7d06c5
DIFF:
https://github.com/llvm/llvm-project/commit/e7656daea8724ba1bed6eb7a4dc96498ce7d06c5
Author: Alexander Kornienko
Date: 2022-10-23T23:14:40+02:00
New Revision: e86161076e4a0633d7ab845037fe9443363a5a29
URL:
https://github.com/llvm/llvm-project/commit/e86161076e4a0633d7ab845037fe9443363a5a29
DIFF:
https://github.com/llvm/llvm-project/commit/e86161076e4a0633d7ab845037fe9443363a5a29
Author: Alexander Kornienko
Date: 2022-09-13T12:18:07+02:00
New Revision: 637da9de4c6619c0e179c2c2f0dbfebd08ac2a0f
URL:
https://github.com/llvm/llvm-project/commit/637da9de4c6619c0e179c2c2f0dbfebd08ac2a0f
DIFF:
https://github.com/llvm/llvm-project/commit/637da9de4c6619c0e179c2c2f0dbfebd08ac2a0f
On Thu, Oct 21, 2021 at 8:49 AM stan li wrote:
> Hi Alex,
>
> I tried compile your repro on Windows with
>
> clang -S
>
> But it didn’t crash.
>
>
>
> Could you share the command line and environment to repro the crash?
>
I'm seeing the crash on linux on x86 with just `clang q.cc`. However, on
o
Author: Bogdan Graur
Date: 2021-07-13T15:54:31+02:00
New Revision: e9533b84920798cf9b35d26586a61bad0a1f9825
URL:
https://github.com/llvm/llvm-project/commit/e9533b84920798cf9b35d26586a61bad0a1f9825
DIFF:
https://github.com/llvm/llvm-project/commit/e9533b84920798cf9b35d26586a61bad0a1f9825.diff
Author: Alexander Kornienko
Date: 2021-04-12T18:46:13+02:00
New Revision: 8883cb3e4004aebddf9bd0f92ea47ba897397794
URL:
https://github.com/llvm/llvm-project/commit/8883cb3e4004aebddf9bd0f92ea47ba897397794
DIFF:
https://github.com/llvm/llvm-project/commit/8883cb3e4004aebddf9bd0f92ea47ba897397794
Author: Jens Massberg
Date: 2021-04-12T18:46:12+02:00
New Revision: 8a944d82cd14001a92ef088229041ee0fb1fd1e6
URL:
https://github.com/llvm/llvm-project/commit/8a944d82cd14001a92ef088229041ee0fb1fd1e6
DIFF:
https://github.com/llvm/llvm-project/commit/8a944d82cd14001a92ef088229041ee0fb1fd1e6.diff
Author: Jinzheng Tu
Date: 2021-03-10T14:00:51+01:00
New Revision: 481079e2841f1d7aafbbd627e7028bcc632a4ef7
URL:
https://github.com/llvm/llvm-project/commit/481079e2841f1d7aafbbd627e7028bcc632a4ef7
DIFF:
https://github.com/llvm/llvm-project/commit/481079e2841f1d7aafbbd627e7028bcc632a4ef7.diff
L
Author: Alexander Kornienko
Date: 2021-01-28T15:00:07+01:00
New Revision: dfd2374ab6c393d675e7b4583bc279b2d7e9b51f
URL:
https://github.com/llvm/llvm-project/commit/dfd2374ab6c393d675e7b4583bc279b2d7e9b51f
DIFF:
https://github.com/llvm/llvm-project/commit/dfd2374ab6c393d675e7b4583bc279b2d7e9b51f
Author: Alexander Kornienko
Date: 2021-01-28T15:00:07+01:00
New Revision: dfd2374ab6c393d675e7b4583bc279b2d7e9b51f
URL:
https://github.com/llvm/llvm-project/commit/dfd2374ab6c393d675e7b4583bc279b2d7e9b51f
DIFF:
https://github.com/llvm/llvm-project/commit/dfd2374ab6c393d675e7b4583bc279b2d7e9b51f
Author: Alexander Kornienko
Date: 2020-12-15T02:16:12+01:00
New Revision: 9c49b0bba0fcbe8b10c0f44ce60a8d26e6f30479
URL:
https://github.com/llvm/llvm-project/commit/9c49b0bba0fcbe8b10c0f44ce60a8d26e6f30479
DIFF:
https://github.com/llvm/llvm-project/commit/9c49b0bba0fcbe8b10c0f44ce60a8d26e6f30479
Author: Alexander Kornienko
Date: 2020-12-11T12:39:33+01:00
New Revision: 4c5e0c7fd801ccc52d3b137fa685d4215a6c57ed
URL:
https://github.com/llvm/llvm-project/commit/4c5e0c7fd801ccc52d3b137fa685d4215a6c57ed
DIFF:
https://github.com/llvm/llvm-project/commit/4c5e0c7fd801ccc52d3b137fa685d4215a6c57ed
Author: Alexander Kornienko
Date: 2020-10-22T13:31:21+02:00
New Revision: 37558fd29ee0af2302c051b8e70543cfc3e7ca91
URL:
https://github.com/llvm/llvm-project/commit/37558fd29ee0af2302c051b8e70543cfc3e7ca91
DIFF:
https://github.com/llvm/llvm-project/commit/37558fd29ee0af2302c051b8e70543cfc3e7ca91
Author: Alexander Kornienko
Date: 2020-10-16T04:12:32+02:00
New Revision: cc175c2cc8e638462bab74e0781e06f9b6eb5017
URL:
https://github.com/llvm/llvm-project/commit/cc175c2cc8e638462bab74e0781e06f9b6eb5017
DIFF:
https://github.com/llvm/llvm-project/commit/cc175c2cc8e638462bab74e0781e06f9b6eb5017
Author: Alexander Kornienko
Date: 2020-10-12T15:05:42+02:00
New Revision: 1968a6155fd5ef178598b204cc6a176719b99f2e
URL:
https://github.com/llvm/llvm-project/commit/1968a6155fd5ef178598b204cc6a176719b99f2e
DIFF:
https://github.com/llvm/llvm-project/commit/1968a6155fd5ef178598b204cc6a176719b99f2e
Author: Alexander Kornienko
Date: 2020-10-09T15:24:57+02:00
New Revision: fe4715c47f9c02a83b339c12067f1d27a3115fe4
URL:
https://github.com/llvm/llvm-project/commit/fe4715c47f9c02a83b339c12067f1d27a3115fe4
DIFF:
https://github.com/llvm/llvm-project/commit/fe4715c47f9c02a83b339c12067f1d27a3115fe4
Author: Alexander Kornienko
Date: 2020-09-28T15:14:04+02:00
New Revision: fdfe324da195ebd9b9c691f006b0d6ccc64365e1
URL:
https://github.com/llvm/llvm-project/commit/fdfe324da195ebd9b9c691f006b0d6ccc64365e1
DIFF:
https://github.com/llvm/llvm-project/commit/fdfe324da195ebd9b9c691f006b0d6ccc64365e1
Author: Alexander Kornienko
Date: 2020-04-13T06:19:09+02:00
New Revision: 8dda0f91995955bb8f484f8d41374aff59118355
URL:
https://github.com/llvm/llvm-project/commit/8dda0f91995955bb8f484f8d41374aff59118355
DIFF:
https://github.com/llvm/llvm-project/commit/8dda0f91995955bb8f484f8d41374aff59118355
Author: Joe Turner
Date: 2020-03-02T12:39:16+01:00
New Revision: 071002ffdb3f13fa3006618e7ee8277a75792df5
URL:
https://github.com/llvm/llvm-project/commit/071002ffdb3f13fa3006618e7ee8277a75792df5
DIFF:
https://github.com/llvm/llvm-project/commit/071002ffdb3f13fa3006618e7ee8277a75792df5.diff
LO
Author: Joe Turner
Date: 2020-02-27T19:39:42+01:00
New Revision: b26c88e3c6e08f8f78ab4291bc85b5685241f493
URL:
https://github.com/llvm/llvm-project/commit/b26c88e3c6e08f8f78ab4291bc85b5685241f493
DIFF:
https://github.com/llvm/llvm-project/commit/b26c88e3c6e08f8f78ab4291bc85b5685241f493.diff
LO
On Wed, Jan 8, 2020 at 2:45 PM Sylvestre Ledru wrote:
> Le 08/01/2020 à 14:14, Alexander Kornienko a écrit :
> > [adding the list back]
> >
> > This list is one of the places that would be quite boring and
> error-prone to update manually. I'd strongly prefer to have an automatic
> way of updatin
[adding the list back]
This list is one of the places that would be quite boring and error-prone
to update manually. I'd strongly prefer to have an automatic way of
updating it. Detecting whether a check has a fix might be not an easy task
though. Maybe the script could use some simple heuristic t
Any news here? The problem is still there.
On Fri, Dec 13, 2019 at 12:33 AM Andrews, Elizabeth <
elizabeth.andr...@intel.com> wrote:
> Hi Alexander,
>
>
>
> I am debugging this now but I assume the checks for the if condition were
> skipped before this commit (therefore no crash) because ‘c’ was
Author: Alexander Kornienko
Date: 2019-12-12T17:00:57+01:00
New Revision: 65996c302a4472e597780c99bd834f9bf8978712
URL:
https://github.com/llvm/llvm-project/commit/65996c302a4472e597780c99bd834f9bf8978712
DIFF:
https://github.com/llvm/llvm-project/commit/65996c302a4472e597780c99bd834f9bf8978712
Author: Alexander Kornienko
Date: 2019-12-12T17:00:57+01:00
New Revision: 2b09390c136247b42c1b54f42ce925e31d51062a
URL:
https://github.com/llvm/llvm-project/commit/2b09390c136247b42c1b54f42ce925e31d51062a
DIFF:
https://github.com/llvm/llvm-project/commit/2b09390c136247b42c1b54f42ce925e31d51062a
After this commit clang started generating assertion failures on valid
code. There are tons of instances in our codebase. Here's a reduced test
case:
template
class a {
int c : b;
void f() {
if (c)
;
}
};
Please take a look.
On Wed, Dec 4, 2019 at 12:39 AM Elizabeth Andrews via cf
Author: Alexander Kornienko
Date: 2019-12-06T10:10:15+01:00
New Revision: fac4e3c5f8a018599cbd9363a735b1c13e8f8a05
URL:
https://github.com/llvm/llvm-project/commit/fac4e3c5f8a018599cbd9363a735b1c13e8f8a05
DIFF:
https://github.com/llvm/llvm-project/commit/fac4e3c5f8a018599cbd9363a735b1c13e8f8a05
Author: Alexander Kornienko
Date: 2019-12-03T20:30:41+01:00
New Revision: c375dc230d16f451cf1c7e2868237da6ef7bc4cf
URL:
https://github.com/llvm/llvm-project/commit/c375dc230d16f451cf1c7e2868237da6ef7bc4cf
DIFF:
https://github.com/llvm/llvm-project/commit/c375dc230d16f451cf1c7e2868237da6ef7bc4cf
Author: Alexander Kornienko
Date: 2019-11-26T16:34:23+01:00
New Revision: aa0e92e1f7069834852c08fdd32a92258e30555c
URL:
https://github.com/llvm/llvm-project/commit/aa0e92e1f7069834852c08fdd32a92258e30555c
DIFF:
https://github.com/llvm/llvm-project/commit/aa0e92e1f7069834852c08fdd32a92258e30555c
Author: alexfh
Date: Thu Sep 5 07:48:23 2019
New Revision: 371075
URL: http://llvm.org/viewvc/llvm-project?rev=371075&view=rev
Log:
Add a bugprone-argument-comment option: IgnoreSingleArgument.
Summary:
Add bugprone-argument-comment option: IgnoreSingleArgument.
When true, the check will ignore
Author: alexfh
Date: Thu Sep 5 07:48:31 2019
New Revision: 371076
URL: http://llvm.org/viewvc/llvm-project?rev=371076&view=rev
Log:
[clang-tidy] Make most ArgumentCommentCheck options local, as they should be
Modified:
clang-tools-extra/trunk/clang-tidy/bugprone/ArgumentCommentCheck.cpp
Author: alexfh
Date: Thu Sep 5 07:13:57 2019
New Revision: 371072
URL: http://llvm.org/viewvc/llvm-project?rev=371072&view=rev
Log:
[clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not
checked.
Summary:
For example:
```
void foo(int a);
foo(-2);
```
should be fixed as:
Author: alexfh
Date: Wed Sep 4 09:19:32 2019
New Revision: 370919
URL: http://llvm.org/viewvc/llvm-project?rev=370919&view=rev
Log:
[clang-tidy] Fix bugprone-argument-comment bug if there are marcos.
Summary:
Fix bugprone-argument-comment bug if there are marcos.
For example:
```
void j(int a,
I suspect that this patch makes analysis much slower in certain cases. For
example, the clang/test/Analysis/pr37802.cpp test has become ~5 times
slower in some configurations in our environment. This happened somewhere
between r369520 and r369679, and your series of patches seems most
suspicious :)
Author: alexfh
Date: Mon Jul 1 11:55:10 2019
New Revision: 364837
URL: http://llvm.org/viewvc/llvm-project?rev=364837&view=rev
Log:
Fixed two issues in clang-tidy -help.
HeaderFilter -> HeaderFilterRegex
Modified:
cfe/trunk/lib/Tooling/CommonOptionsParser.cpp
Modified: cfe/trunk/lib/Toolin
Author: alexfh
Date: Mon Jul 1 11:55:10 2019
New Revision: 364837
URL: http://llvm.org/viewvc/llvm-project?rev=364837&view=rev
Log:
Fixed two issues in clang-tidy -help.
HeaderFilter -> HeaderFilterRegex
Modified:
clang-tools-extra/trunk/clang-tidy/tool/ClangTidyMain.cpp
clang-tools-ext
Author: alexfh
Date: Wed Apr 17 17:36:51 2019
New Revision: 358630
URL: http://llvm.org/viewvc/llvm-project?rev=358630&view=rev
Log:
[clang-format] Remove unused Environment constructor.
Modified:
cfe/trunk/lib/Format/TokenAnalyzer.h
Modified: cfe/trunk/lib/Format/TokenAnalyzer.h
URL:
http:
Author: alexfh
Date: Wed Apr 17 15:35:36 2019
New Revision: 358621
URL: http://llvm.org/viewvc/llvm-project?rev=358621&view=rev
Log:
[clang-tidy] Don't issue cppcoreguidelines-macro-usage on builtin macros
Before the patch calling clang-tidy with -header-filter=.* -system-headers would
result in
1 - 100 of 1810 matches
Mail list logo
