[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

ayermolo added a comment. OK was able to create small(ish) repro main.h #include enum class Enums { ACCESS = 0, MAP = 1, }; template class DMap { public: template requires std::is_convertible_v void getOrCreate(TIDR v); }; template

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

ayermolo added a comment. That would be great. :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147722/new/ https://reviews.llvm.org/D147722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147722: [Concepts] Fix Function Template Concepts comparisons

ayermolo added a comment. With this patch here is still a build failure in our code base. I am trying to create a small repro. But from high level there is a templated class that has partial specializations, and it errors out on definition of a function that doesn't have any. CHANGES SINCE

[PATCH] D138376: Use None consistently (NFC)

ayermolo added a comment. Is there an a RFC for this or something? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138376/new/ https://reviews.llvm.org/D138376 ___ cfe-commits mailing list

[PATCH] D131528: [Clang] Restrict non fixed enum to a value outside the range of the enumeration values warning to context requiring a constant expression

ayermolo added a comment. In D131528#3722395 , @shafik wrote: > In D131528#3719430 , @ayermolo > wrote: > >> Was this and previous change intended to capture this case? >> const enum NumberType neg_one = (enum

[PATCH] D131528: [Clang] Restrict non fixed enum to a value outside the range of the enumeration values warning to context requiring a constant expression

ayermolo added a comment. Was this and previous change intended to capture this case? const enum NumberType neg_one = (enum NumberType) ((enum NumberType) 0 - (enum NumberType) 1); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131528/new/

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

ayermolo added a comment. In D131307#3714629 , @shafik wrote: > In D131307#3713011 , @sberg wrote: > >> With this commit, >> >> $ cat test.cc >> #include "boost/numeric/conversion/cast.hpp" >> int main() {

[PATCH] D131202: [Clang] Fix capture of values initialized by bitfields

ayermolo added a comment. Thanks for reverting this. Previous commit broke build of projects using fmt library. https://github.com/fmtlib/fmt/blame/master/include/fmt/format.h fmt/fmt/include/fmt/format.h:1904:9: error: cannot capture a bit-field by reference if (sign) *it++ =

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

ayermolo added a comment. +2 turning it in to warning. It's breaking our builds, due to boost. :( CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130058/new/ https://reviews.llvm.org/D130058 ___ cfe-commits mailing list

[PATCH] D120610: [DebugInfo] Include DW_TAG_skeleton_unit when looking for parent UnitDie

ayermolo added a comment. @wenlei Thanks for digging in to this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120610/new/ https://reviews.llvm.org/D120610 ___ cfe-commits mailing list

[PATCH] D58920: [Modules][PR39287] Consolidate multiple std's

ayermolo added a comment. @modocache Just checking is this diff abandoned? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58920/new/ https://reviews.llvm.org/D58920 ___ cfe-commits mailing list

[PATCH] D96783: [Driver] Support -gdwarf64 for assembly files

ayermolo added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96783/new/ https://reviews.llvm.org/D96783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo updated this revision to Diff 315495. ayermolo added a comment. rebased on latest. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo added a comment. @dblaikie @MaskRay Anything else do I need to change, all good? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 ___ cfe-commits mailing

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo updated this revision to Diff 314413. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo updated this revision to Diff 313621. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo added inline comments. Comment at: clang/test/Driver/debug-options.c:379 +// VALIDT: x86_64 +// RUN: %clang -### -c -gdwarf-5 -gdwarf64 -target VALIDT %s 2>&1 | FileCheck -check-prefix=GDWARF64_ON %s +// RUN: %clang -### -c -gdwarf-4 -gdwarf64 -target VALIDT %s 2>&1 |

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo updated this revision to Diff 313421. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo updated this revision to Diff 313412. ayermolo marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo updated this revision to Diff 313410. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo updated this revision to Diff 312882. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D73418: [WPD] Emit vcall_visibility metadata for MicrosoftCXXABI

ayermolo added a comment. @tejohnson I was wondering where does this @anon.{{.*}} gets set, or in general where can I find more information about it. When I step through the code in emitVTableTypeMetadata, it's still. @0 = private unnamed_addr constant { [2 x i8*] } { [2 x i8*] [i8* bitcast

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo updated this revision to Diff 312327. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo updated this revision to Diff 311764. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo updated this revision to Diff 311751. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo updated this revision to Diff 311747. ayermolo marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:35 CODEGENOPT(AsmVerbose, 1, 0) ///< -dA, -fverbose-asm. +CODEGENOPT(Dwarf64 , 1, 0) ///< -gdwarf64. CODEGENOPT(PreserveAsmComments, 1, 1) ///< -dA,

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:35 CODEGENOPT(AsmVerbose, 1, 0) ///< -dA, -fverbose-asm. +CODEGENOPT(Dwarf64 , 1, 0) ///< -gdwarf64. CODEGENOPT(PreserveAsmComments, 1, 1) ///< -dA,

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:35 CODEGENOPT(AsmVerbose, 1, 0) ///< -dA, -fverbose-asm. +CODEGENOPT(Dwarf64 , 1, 0) ///< -gdwarf64. CODEGENOPT(PreserveAsmComments, 1, 1) ///< -dA,

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ayermolo updated this revision to Diff 306482. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ayermolo updated this revision to Diff 306477. ayermolo marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ayermolo updated this revision to Diff 306263. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ayermolo added inline comments. Comment at: clang/include/clang/Driver/Options.td:2145-2146 HelpText<"Generate source-level debug information with dwarf version 5">; +def gdwarf64 : Flag<["-"], "gdwarf64">, Group, Flags<[CC1Option]>, + HelpText<"Generate DWARF64 debug

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ayermolo added inline comments. Comment at: clang/include/clang/Driver/Options.td:2145-2146 HelpText<"Generate source-level debug information with dwarf version 5">; +def gdwarf64 : Flag<["-"], "gdwarf64">, Group, Flags<[CC1Option]>, + HelpText<"Generate DWARF64 debug

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ayermolo added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4020 +const Arg *A = Args.getLastArg(options::OPT_gdwarf64); +const llvm::Triple = TC.getTriple(); +if (DWARFVersion < 3) MaskRay wrote: > The variable is only used

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ayermolo updated this revision to Diff 306223. ayermolo retitled this revision from "Adding DWARF64 clang flag" to "Adding DWARF64 clang flag: -gdwarf64". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo marked 2 inline comments as done. ayermolo added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:35 CODEGENOPT(AsmVerbose, 1, 0) ///< -dA, -fverbose-asm. +CODEGENOPT(Dwarf64 , 1, 0) ///< -gdwarf64.

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo updated this revision to Diff 306187. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo updated this revision to Diff 306186. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo added a comment. In D90507#2398654 , @ikudrin wrote: > It looks like `lld/test/COFF/lto-new-pass-manager.ll.obj` was added to the > patch by accident and should be removed. It's weird. The file gets automatically added whenever I commit the

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo added a comment. In D90507#2394109 , @wenlei wrote: > This change covers non-LTO cases. For LTO, I think we would need to pass it > from driver to LTO. Something like this: tools::addLTOOptions -> lld -> > lto::Config

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo added a comment. In D90507#2393434 , @jansvoboda11 wrote: > Hi @ayermolo, do you think this might be triggered by D82756 > ? (my only upstream patch ATM) Oh, no. Sorry I wasn't clear. I was just looking for

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo added a subscriber: jansvoboda11. ayermolo added a comment. @jansvoboda11 Can you take a look? The failing test is unrelated it seems. Fails locally even without my change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo added a comment. The failure seems unrelated to my changes. Trying locally it fails with latest upstream even without my changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo updated this revision to Diff 304000. Herald added subscribers: steven_wu, hiraditya. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo added a comment. In D90507#2378015 , @ikudrin wrote: > 1. The patch needs tests to check the added functionality. > 2. DWARF64 can be generated only for a limited number of targets. There > should be diagnostics for invalid switch combinations

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo updated this revision to Diff 303303. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo updated this revision to Diff 303209. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo updated this revision to Diff 302326. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo created this revision. ayermolo added a reviewer: llvm-commits. Herald added subscribers: cfe-commits, dexonsmith, wenlei, dang. Herald added a project: clang. ayermolo requested review of this revision. @ikudrin enabled support for dwarf64 in D87011 .