[PATCH] D103929: [clang] P2085R0: Consistent defaulted comparisons

2021-08-27 Thread Alexandru Octavian Buțiu via Phabricator via cfe-commits
predator5047 added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103929/new/ https://reviews.llvm.org/D103929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D103929: [clang] P2085R0: Consistent defaulted comparisons

2021-07-10 Thread Alexandru Octavian Buțiu via Phabricator via cfe-commits
predator5047 updated this revision to Diff 357756. predator5047 added a comment. Fix clang-tidy formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103929/new/ https://reviews.llvm.org/D103929 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaDeclCXX.c

[PATCH] D103929: [clang] P2085R0: Consistent defaulted comparisons

2021-07-10 Thread Alexandru Octavian Buțiu via Phabricator via cfe-commits
predator5047 updated this revision to Diff 357755. predator5047 added a comment. Fix clang-tidy warning CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103929/new/ https://reviews.llvm.org/D103929 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D103929: [clang] P2085R0: Consistent defaulted comparisons

2021-07-10 Thread Alexandru Octavian Buțiu via Phabricator via cfe-commits
predator5047 added a comment. Regarding struct A; bool operator==(A, A); struct A { friend bool operator==(A, A) = default; // error, not first declaration }; GCC and msvc have marked P2085R0 as complete and do not implement this rule should I implement it anyway? I don't know if

[PATCH] D103929: [clang] P2085R0: Consistent defaulted comparisons

2021-07-10 Thread Alexandru Octavian Buțiu via Phabricator via cfe-commits
predator5047 updated this revision to Diff 357747. predator5047 added a comment. Addressed Richard's comments. Fix handling of friend functions. Added an error dialog for when enum type are used as params. Removed define outside of class dialog since it is no longer needed. Moved tests to p1.cpp

[PATCH] D103929: [clang] P2085R0: Consistent defaulted comparisons

2021-06-30 Thread Alexandru Octavian Buțiu via Phabricator via cfe-commits
predator5047 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103929/new/ https://reviews.llvm.org/D103929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D102186: [clang][c++20] Fix false warning for unused private fields when a class has only defaulted comparison operators.

2021-06-22 Thread Alexandru Octavian Buțiu via Phabricator via cfe-commits
predator5047 marked an inline comment as done. predator5047 added a comment. @hans Can you commit on my behalf? Email: Alexandru Octavian Butiu alexandru.octavian.butiu at gmail.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102186/new/ https:/

[PATCH] D103929: [clang] P2085R0: Consistent defaulted comparisons

2021-06-17 Thread Alexandru Octavian Buțiu via Phabricator via cfe-commits
predator5047 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103929/new/ https://reviews.llvm.org/D103929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D102186: [clang][c++20] Fix false warning for unused private fields when a class has only defaulted comparison operators.

2021-06-16 Thread Alexandru Octavian Buțiu via Phabricator via cfe-commits
predator5047 marked an inline comment as done. predator5047 added inline comments. Comment at: clang/test/SemaCXX/warn-unused-private-field.cpp:7 + +class EqDefaultCompare { + int unused_; hans wrote: > The test case feels a little strange to me, I mean the memb

[PATCH] D102186: [clang][c++20] Fix false warning for unused private fields when a class has only defaulted comparison operators.

2021-06-16 Thread Alexandru Octavian Buțiu via Phabricator via cfe-commits
predator5047 updated this revision to Diff 352400. predator5047 added a comment. Updated the test case so it is clearer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102186/new/ https://reviews.llvm.org/D102186 Files: clang/lib/Sema/SemaDeclCXX

[PATCH] D102186: [clang][c++20] Fix false warning for unused private fields when a class has only defaulted comparison operators.

2021-06-10 Thread Alexandru Octavian Buțiu via Phabricator via cfe-commits
predator5047 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102186/new/ https://reviews.llvm.org/D102186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D43745: Fix cppcoreguidelines-pro-bounds-pointer-arithmetic not working for functions with auto return specifier.

2018-02-25 Thread Alexandru Octavian Buțiu via Phabricator via cfe-commits
predator5047 created this revision. predator5047 added reviewers: alexfh, alexfh_. predator5047 added a project: clang-tools-extra. Herald added subscribers: cfe-commits, kbarton, nemanjai. Fix bug #36489 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43745 Files: clang-tidy/

[PATCH] D38284: [clang-tidy] Fix google-readability-namespace-comments handling of C++17 nested namespaces

2017-11-01 Thread Alexandru Octavian Buțiu via Phabricator via cfe-commits
predator5047 updated this revision to Diff 121152. predator5047 added a comment. Fixed assert error caused by macros. https://reviews.llvm.org/D38284 Files: clang-tidy/readability/NamespaceCommentCheck.cpp clang-tidy/readability/NamespaceCommentCheck.h test/clang-tidy/google-readability-n

[PATCH] D38284: [clang-tidy] Fix google-readability-namespace-comments handling of C++17 nested namespaces

2017-10-06 Thread Alexandru Octavian Buțiu via Phabricator via cfe-commits
predator5047 added a comment. In https://reviews.llvm.org/D38284#888124, @aaron.ballman wrote: > Aside from a small nit, this LGTM, thanks! Can you commit it? I don't have commit rights. https://reviews.llvm.org/D38284 ___ cfe-commits mailing li

[PATCH] D38284: [clang-tidy] Fix google-readability-namespace-comments handling of C++17 nested namespaces

2017-10-02 Thread Alexandru Octavian Buțiu via Phabricator via cfe-commits
predator5047 updated this revision to Diff 117398. predator5047 marked 5 inline comments as done. predator5047 added a comment. Address review comments: - Use llvm::SmallVector instead of std::vector - Some formatting changes. https://reviews.llvm.org/D38284 Files: clang-tidy/readabilit

[PATCH] D38284: [clang-tidy] Fix google-readability-namespace-comments handling of C++17 nested namespaces

2017-09-29 Thread Alexandru Octavian Buțiu via Phabricator via cfe-commits
predator5047 updated this revision to Diff 117193. predator5047 marked 12 inline comments as done. predator5047 added a comment. Address review comments: - Don't use auto if the type is not spelled out in initialization. - Better names for variables. - Elide braces. - Format changes. https://

[PATCH] D38284: [clang-tidy] Fix google-readability-namespace-comments handling of C++17 nested namespaces

2017-09-27 Thread Alexandru Octavian Buțiu via Phabricator via cfe-commits
predator5047 updated this revision to Diff 116850. predator5047 added a comment. Fixed spelling mistake and added a test case. https://reviews.llvm.org/D38284 Files: clang-tidy/readability/NamespaceCommentCheck.cpp clang-tidy/readability/NamespaceCommentCheck.h test/clang-tidy/google-read