@@ -14,9 +14,11 @@
#define LLVM_CLANG_SEMA_SEMASYCL_H
#include "clang/AST/Decl.h"
+#include "clang/AST/DeclBase.h"
bader wrote:
I'm okay with that.
It just looks strange to add forward declaration for `Decl` class when full
declaration is included with
@@ -14,9 +14,11 @@
#define LLVM_CLANG_SEMA_SEMASYCL_H
#include "clang/AST/Decl.h"
+#include "clang/AST/DeclBase.h"
bader wrote:
> This one should be fixed as well now.
Can we drop `#include "clang/AST/Decl.h"` as well?
https://github.com/bader commented:
I'm okay with the patch in general, but I'd like either @michalpaszkowski or
@VyacheslavLevytskyy to take a look.
Just one question about doubling the test scope for LLVM tests with spir64
target triple.
https://github.com/llvm/llvm-project/pull/89796
@@ -1,4 +1,5 @@
; RUN: llc -O0 -mtriple=spirv64-unknown-unknown %s -o - | FileCheck %s
+; RUN: llc -O0 -mtriple=spirv64-amd-amdhsa %s -o - | FileCheck %s
bader wrote:
I'm not sure if there is a value in testing `spirv64-amd-amdhsa` triple in
addition to
https://github.com/bader edited https://github.com/llvm/llvm-project/pull/89796
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bader wrote:
@AlexVlx, do you think it's worth promoting
[SPV_INTEL_inline_assembly](https://github.com/intel/llvm/blob/sycl/sycl/doc/design/spirv-extensions/SPV_INTEL_inline_assembly.asciidoc)
and
https://github.com/bader commented:
> I'll emphasise that this is only a problem for things such as implicitly
> generated globals (e.g. VTables or typeinfo for classes etc.)
I suppose usage of VTables and typeinfo is kind of restricted in GPU
programming models. Right?
Anyway, I think it's
bader wrote:
The change seems reasonable.
> CodeGen/LLVM will default to AS0 in this case, which produces Globals that
> end up in the private address space for e.g. OCL, HIPSPV or SYCL.
Can we add a test checking LLVM address space for globals emitted from
OCL/HIPSPV/SYCL, please? It's
bader wrote:
> How does this attribute relate to `reqd_work_group_size` and related existing
> attributes?
They seems to be different/"unrelated". Based on the description of the
`amdgpu-num-work-groups` attribute it provides "number of work-groups", whereas
`reqd_work_group_size` provides
Author: Alexey Bader
Date: 2023-09-11T16:24:37-07:00
New Revision: a2e2f471c51f0aea836a4929dfdf50523dcff1eb
URL:
https://github.com/llvm/llvm-project/commit/a2e2f471c51f0aea836a4929dfdf50523dcff1eb
DIFF:
https://github.com/llvm/llvm-project/commit/a2e2f471c51f0aea836a4929dfdf50523dcff1eb.diff
Author: Alexey Bader
Date: 2022-10-19T03:50:47-07:00
New Revision: 66bd6074c133402e45075b591c062c22f308ef26
URL:
https://github.com/llvm/llvm-project/commit/66bd6074c133402e45075b591c062c22f308ef26
DIFF:
https://github.com/llvm/llvm-project/commit/66bd6074c133402e45075b591c062c22f308ef26.diff
Author: Alexey Bader
Date: 2022-07-06T06:20:09-07:00
New Revision: 923b56e7ca96e03cedcb0e3a5df5c05e8e975a38
URL:
https://github.com/llvm/llvm-project/commit/923b56e7ca96e03cedcb0e3a5df5c05e8e975a38
DIFF:
https://github.com/llvm/llvm-project/commit/923b56e7ca96e03cedcb0e3a5df5c05e8e975a38.diff
Author: Pavel Samolysov
Date: 2022-04-04T12:16:39+03:00
New Revision: 87b28f5092f2f92fc380f18e8578746bdd2a54b2
URL:
https://github.com/llvm/llvm-project/commit/87b28f5092f2f92fc380f18e8578746bdd2a54b2
DIFF:
Author: Henry Linjamäki
Date: 2021-12-08T12:18:15+03:00
New Revision: 9ae5810b53c2e096d7442ba8af3f00ebc3d301b0
URL:
https://github.com/llvm/llvm-project/commit/9ae5810b53c2e096d7442ba8af3f00ebc3d301b0
DIFF:
Author: Henry Linjamäki
Date: 2021-11-18T03:41:24+03:00
New Revision: 49682f14bf3fb8db5e2721d9896b27bb4c2bd635
URL:
https://github.com/llvm/llvm-project/commit/49682f14bf3fb8db5e2721d9896b27bb4c2bd635
DIFF:
Author: Alexey Bader
Date: 2021-09-20T09:32:25+03:00
New Revision: 15feaaa359c7245bb59ff0a2aa3b806682f44286
URL:
https://github.com/llvm/llvm-project/commit/15feaaa359c7245bb59ff0a2aa3b806682f44286
DIFF:
https://github.com/llvm/llvm-project/commit/15feaaa359c7245bb59ff0a2aa3b806682f44286.diff
Author: Alexey Bader
Date: 2021-08-13T13:20:11+03:00
New Revision: d754b970eddb83b1c68346a36b067391d93166b0
URL:
https://github.com/llvm/llvm-project/commit/d754b970eddb83b1c68346a36b067391d93166b0
DIFF:
https://github.com/llvm/llvm-project/commit/d754b970eddb83b1c68346a36b067391d93166b0.diff
Author: Alexey Bader
Date: 2021-08-13T08:59:47+03:00
New Revision: c064ba34c7d867c1180279fe3dca8817d835cb28
URL:
https://github.com/llvm/llvm-project/commit/c064ba34c7d867c1180279fe3dca8817d835cb28
DIFF:
https://github.com/llvm/llvm-project/commit/c064ba34c7d867c1180279fe3dca8817d835cb28.diff
Author: Alexey Bader
Date: 2021-05-18T10:27:35+03:00
New Revision: 2ab513cd3e0648806db7ed1f8170ad4a3d4e7749
URL:
https://github.com/llvm/llvm-project/commit/2ab513cd3e0648806db7ed1f8170ad4a3d4e7749
DIFF:
https://github.com/llvm/llvm-project/commit/2ab513cd3e0648806db7ed1f8170ad4a3d4e7749.diff
Author: Alexey Bader
Date: 2021-04-30T11:40:10+03:00
New Revision: 76f84e772978a3daef33df5bea7da676a0163f28
URL:
https://github.com/llvm/llvm-project/commit/76f84e772978a3daef33df5bea7da676a0163f28
DIFF:
https://github.com/llvm/llvm-project/commit/76f84e772978a3daef33df5bea7da676a0163f28.diff
Author: Alexey Bader
Date: 2021-04-26T16:16:10+03:00
New Revision: b2bb13a761644f675ec9f2d0b4371c51a05ab51c
URL:
https://github.com/llvm/llvm-project/commit/b2bb13a761644f675ec9f2d0b4371c51a05ab51c
DIFF:
https://github.com/llvm/llvm-project/commit/b2bb13a761644f675ec9f2d0b4371c51a05ab51c.diff
Author: Alexey Bader
Date: 2021-04-26T15:39:43+03:00
New Revision: b52e69c4268181d8143fe49aee0ea85395c8737d
URL:
https://github.com/llvm/llvm-project/commit/b52e69c4268181d8143fe49aee0ea85395c8737d
DIFF:
https://github.com/llvm/llvm-project/commit/b52e69c4268181d8143fe49aee0ea85395c8737d.diff
Author: Alexey Bader
Date: 2021-04-26T13:44:10+03:00
New Revision: 7818906ca134775edffb77857f436359d3a50b90
URL:
https://github.com/llvm/llvm-project/commit/7818906ca134775edffb77857f436359d3a50b90
DIFF:
https://github.com/llvm/llvm-project/commit/7818906ca134775edffb77857f436359d3a50b90.diff
Author: Alexey Bader
Date: 2021-04-13T08:00:21+03:00
New Revision: 95c614afcd4de71d00a240d6a4a02c036c972ed0
URL:
https://github.com/llvm/llvm-project/commit/95c614afcd4de71d00a240d6a4a02c036c972ed0
DIFF:
https://github.com/llvm/llvm-project/commit/95c614afcd4de71d00a240d6a4a02c036c972ed0.diff
Author: Alexey Bader
Date: 2020-12-12T23:26:54+03:00
New Revision: a500a4358789d1794bc672421c55900ea2bbc938
URL:
https://github.com/llvm/llvm-project/commit/a500a4358789d1794bc672421c55900ea2bbc938
DIFF:
https://github.com/llvm/llvm-project/commit/a500a4358789d1794bc672421c55900ea2bbc938.diff
Author: Alexey Bader
Date: 2020-09-29T15:23:50+03:00
New Revision: 9263931fcccdc99000c1de668bea330711333729
URL:
https://github.com/llvm/llvm-project/commit/9263931fcccdc99000c1de668bea330711333729
DIFF:
https://github.com/llvm/llvm-project/commit/9263931fcccdc99000c1de668bea330711333729.diff
Author: Alexey Bader
Date: 2020-07-29T17:24:53+03:00
New Revision: 8d27be8dbaffce0519ac41173d51923fc2524b1b
URL:
https://github.com/llvm/llvm-project/commit/8d27be8dbaffce0519ac41173d51923fc2524b1b
DIFF:
https://github.com/llvm/llvm-project/commit/8d27be8dbaffce0519ac41173d51923fc2524b1b.diff
Author: Mariya Podchishchaeva
Date: 2020-06-17T14:36:00+03:00
New Revision: 0bdcd95bf20f159a2512aff1ef032bec52039bf6
URL:
https://github.com/llvm/llvm-project/commit/0bdcd95bf20f159a2512aff1ef032bec52039bf6
DIFF:
Author: Alexey Bader
Date: 2020-06-17T13:04:01+03:00
New Revision: 93cd4115799cefa698833ca7a2f1899243d94c77
URL:
https://github.com/llvm/llvm-project/commit/93cd4115799cefa698833ca7a2f1899243d94c77
DIFF:
https://github.com/llvm/llvm-project/commit/93cd4115799cefa698833ca7a2f1899243d94c77.diff
Author: Mariya Podchishchaeva
Date: 2020-05-30T12:27:58+03:00
New Revision: bd85b7d6688725e854a694f9f3e8baa6a3077a4a
URL:
https://github.com/llvm/llvm-project/commit/bd85b7d6688725e854a694f9f3e8baa6a3077a4a
DIFF:
Author: Mariya Podchishchaeva
Date: 2020-05-29T18:00:48+03:00
New Revision: cf6cc6622b1416430f517850be9032788e39
URL:
https://github.com/llvm/llvm-project/commit/cf6cc6622b1416430f517850be9032788e39
DIFF:
Author: Alexey Bader
Date: 2020-05-22T13:43:24+03:00
New Revision: e95ee300c0530158d86430fd82ffabd36262e862
URL:
https://github.com/llvm/llvm-project/commit/e95ee300c0530158d86430fd82ffabd36262e862
DIFF:
https://github.com/llvm/llvm-project/commit/e95ee300c0530158d86430fd82ffabd36262e862.diff
Author: Ruyman
Date: 2020-03-07T18:28:54+03:00
New Revision: 118b057f1268d1789e40ffceb214e73772df04f4
URL:
https://github.com/llvm/llvm-project/commit/118b057f1268d1789e40ffceb214e73772df04f4
DIFF:
https://github.com/llvm/llvm-project/commit/118b057f1268d1789e40ffceb214e73772df04f4.diff
LOG:
Author: Alexey Bader
Date: 2020-02-27T16:23:54+03:00
New Revision: 740ed617f7d4d16e7883636c5eff994f8be7eba4
URL:
https://github.com/llvm/llvm-project/commit/740ed617f7d4d16e7883636c5eff994f8be7eba4
DIFF:
https://github.com/llvm/llvm-project/commit/740ed617f7d4d16e7883636c5eff994f8be7eba4.diff
Author: Ruyman
Date: 2020-02-27T15:08:42+03:00
New Revision: bd97704eb5a95ecb048ce343c1a4be5d94e5
URL:
https://github.com/llvm/llvm-project/commit/bd97704eb5a95ecb048ce343c1a4be5d94e5
DIFF:
https://github.com/llvm/llvm-project/commit/bd97704eb5a95ecb048ce343c1a4be5d94e5.diff
LOG:
Author: Alexey Bader
Date: 2020-02-06T08:42:31+03:00
New Revision: 863d9752105f390b31b3d08d1980d2888c15b034
URL:
https://github.com/llvm/llvm-project/commit/863d9752105f390b31b3d08d1980d2888c15b034
DIFF:
https://github.com/llvm/llvm-project/commit/863d9752105f390b31b3d08d1980d2888c15b034.diff
Author: Alexey Bader
Date: 2020-01-21T18:30:56+03:00
New Revision: dd18729b2a7a23b76b8d74fbf4f4bb4efbe8aa97
URL:
https://github.com/llvm/llvm-project/commit/dd18729b2a7a23b76b8d74fbf4f4bb4efbe8aa97
DIFF:
https://github.com/llvm/llvm-project/commit/dd18729b2a7a23b76b8d74fbf4f4bb4efbe8aa97.diff
Author: Alexey Bader
Date: 2019-12-28T16:35:51+03:00
New Revision: 128f39da932be50cb49646084820119e6e0d1e22
URL:
https://github.com/llvm/llvm-project/commit/128f39da932be50cb49646084820119e6e0d1e22
DIFF:
https://github.com/llvm/llvm-project/commit/128f39da932be50cb49646084820119e6e0d1e22.diff
Author: Alexey Bader
Date: 2019-12-12T14:36:11+03:00
New Revision: 2d6a5e4fe45d0a1f1c94df6b3422ffb0d676fb6d
URL:
https://github.com/llvm/llvm-project/commit/2d6a5e4fe45d0a1f1c94df6b3422ffb0d676fb6d
DIFF:
https://github.com/llvm/llvm-project/commit/2d6a5e4fe45d0a1f1c94df6b3422ffb0d676fb6d.diff
Author: Alexey Bader
Date: 2019-12-11T12:40:43+03:00
New Revision: cb30ad728f0b791c72a6a1399f36ebc60ad5
URL:
https://github.com/llvm/llvm-project/commit/cb30ad728f0b791c72a6a1399f36ebc60ad5
DIFF:
https://github.com/llvm/llvm-project/commit/cb30ad728f0b791c72a6a1399f36ebc60ad5.diff
Author: Victor Lomuller
Date: 2019-12-05T12:24:06+03:00
New Revision: 11a9bae8f66986751078501988b4414f24dbe37e
URL:
https://github.com/llvm/llvm-project/commit/11a9bae8f66986751078501988b4414f24dbe37e
DIFF:
Author: Mariya Podchishchaeva
Date: 2019-12-03T16:13:22+03:00
New Revision: c094e7dc4b3f9d1c1e590b008bb1cc46e3496abd
URL:
https://github.com/llvm/llvm-project/commit/c094e7dc4b3f9d1c1e590b008bb1cc46e3496abd
DIFF:
Author: bader
Date: Mon Feb 25 03:48:48 2019
New Revision: 354773
URL: http://llvm.org/viewvc/llvm-project?rev=354773=rev
Log:
[SYCL] Add clang front-end option to enable SYCL device compilation flow.
Patch by Mariya Podchishchaeva
Added:
cfe/trunk/test/Preprocessor/sycl-macro.cpp (with
Author: bader
Date: Tue Feb 19 07:19:06 2019
New Revision: 354337
URL: http://llvm.org/viewvc/llvm-project?rev=354337=rev
Log:
[OpenCL] Change type of block pointer for OpenCL
Summary:
For some reason OpenCL blocks in LLVM IR are represented as function pointers.
These pointers do not point to
Author: bader
Date: Wed Jun 20 01:31:24 2018
New Revision: 335103
URL: http://llvm.org/viewvc/llvm-project?rev=335103=rev
Log:
[Sema] Allow creating types with multiple of the same addrspace.
Summary:
The comment with the OpenCL clause about this clearly
says: "No type shall be qualified by
Author: bader
Date: Fri Jan 26 03:48:46 2018
New Revision: 323522
URL: http://llvm.org/viewvc/llvm-project?rev=323522=rev
Log:
[OpenCL] Add "cles_khr_int64" extension.
Summary:
For OpenCL 1.1 embedded profile 64 bit integers i.e. long,
ulong including the appropriate vector data types and
Author: bader
Date: Wed Nov 15 03:38:17 2017
New Revision: 318290
URL: http://llvm.org/viewvc/llvm-project?rev=318290=rev
Log:
[OpenCL] Fix code generation of function-scope constant samplers.
Summary:
Constant samplers are handled as static variables and clang's code generation
library, which
Author: bader
Date: Wed Oct 11 04:16:31 2017
New Revision: 315453
URL: http://llvm.org/viewvc/llvm-project?rev=315453=rev
Log:
[OpenCL] Allow function declaration with empty argument list.
Treat 'f()' as 'f(void)' rather than a function w/o a prototype.
Reviewers: Anastasia, yaxunl
Reviewed
Author: bader
Date: Thu Jun 29 01:44:10 2017
New Revision: 306653
URL: http://llvm.org/viewvc/llvm-project?rev=306653=rev
Log:
[OpenCL] Allow function declaration with empty argument list.
Summary:
does it make sense to enable K function declaration style for OpenCL?
clang throws following error
Author: bader
Date: Tue Jun 20 09:30:18 2017
New Revision: 305796
URL: http://llvm.org/viewvc/llvm-project?rev=305796=rev
Log:
[OpenCL] Fix OpenCL and SPIR version metadata generation.
Summary: OpenCL and SPIR version metadata must be generated once per module
instead of once per mangled global
Author: bader
Date: Fri Jun 2 13:08:58 2017
New Revision: 304575
URL: http://llvm.org/viewvc/llvm-project?rev=304575=rev
Log:
[OpenCL] Harden function pointer diagnostics.
Summary: Improve OpenCL type checking by rejecting function pointer types.
Reviewers: Anastasia, yaxunl
Reviewed By:
Author: bader
Date: Wed Dec 7 02:43:49 2016
New Revision: 288891
URL: http://llvm.org/viewvc/llvm-project?rev=288891=rev
Log:
[OpenCL] Added a LIT test for ensuring address space mangling is done the same
both in OpenCL1.2 and OpenCL2.0.
Patch by Egor Churaev (echuraev).
Reviewers: Anastasia
Author: bader
Date: Wed Dec 7 02:38:24 2016
New Revision: 288890
URL: http://llvm.org/viewvc/llvm-project?rev=288890=rev
Log:
[OpenCL] Fix SPIR version generation.
Patch by Egor Churaev (echuraev).
Reviewers: Anastasia
Subscribers: bader, yaxunl, cfe-commits
Differential Revision:
Author: bader
Date: Tue Nov 29 04:21:40 2016
New Revision: 288126
URL: http://llvm.org/viewvc/llvm-project?rev=288126=rev
Log:
[OpenCL] Prohibit using reserve_id_t in program scope.
Patch by Egor Churaev (echuraev).
Reviewers: Anastasia
Subscribers: cfe-commits, yaxunl, bader
Differential
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
A few minor comments regarding outdated comments and style.
Comment at: include/clang/AST/ASTContext.h:1124
/// \brief Return pipe type for the specified
bader added a comment.
@pekka.jaaskelainen, I have related question: what is the problem with
retaining OpenCL address space information in LLVM IR?
My understanding is that target CodeGen can ignore this information for the
machines with 'flat' address space model.
On the other hand I would
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285700: [OpenCL] Override supported OpenCL extensions with
-cl-ext option (authored by bader).
Changed prior to commit:
https://reviews.llvm.org/D23712?vs=75568=76571#toc
Repository:
rL LLVM
Author: bader
Date: Tue Nov 1 10:50:52 2016
New Revision: 285700
URL: http://llvm.org/viewvc/llvm-project?rev=285700=rev
Log:
[OpenCL] Override supported OpenCL extensions with -cl-ext option
Summary:
This patch adds a command line option '-cl-ext' to control a set of
supported OpenCL
bader added a comment.
Committed at 285557 with updated tests.
https://reviews.llvm.org/D25305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bader
Date: Mon Oct 31 05:26:31 2016
New Revision: 285557
URL: http://llvm.org/viewvc/llvm-project?rev=285557=rev
Log:
[OpenCL] Setting constant address space for array initializers
Summary: Setting constant address space for global constants used for
memcpy-initialization of arrays.
bader added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1272
+if (getLangOpts().OpenCL) {
+ UA = llvm::GlobalValue::UnnamedAddr::None;
+ AS = CGM.getContext().getTargetAddressSpace(LangAS::opencl_constant);
Anastasia wrote:
> bader wrote:
>
bader added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1272
+if (getLangOpts().OpenCL) {
+ UA = llvm::GlobalValue::UnnamedAddr::None;
+ AS = CGM.getContext().getTargetAddressSpace(LangAS::opencl_constant);
AlexeySotkin wrote:
> Anastasia
bader accepted this revision.
bader added a comment.
LGTM
https://reviews.llvm.org/D25305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282252: [OpenCL] Augment pipe built-ins with pipe packet
size and alignment. (authored by bader).
Changed prior to commit:
https://reviews.llvm.org/D23992?vs=70366=72276#toc
Repository:
rL LLVM
Author: bader
Date: Fri Sep 23 09:20:00 2016
New Revision: 282252
URL: http://llvm.org/viewvc/llvm-project?rev=282252=rev
Log:
[OpenCL] Augment pipe built-ins with pipe packet size and alignment.
Reviewers: Anastasia, vpykhtin
Subscribers: dmitry, cfe-commits
Differential Revision:
bader added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:7599-7602
@@ -7595,3 +7598,6 @@
// of event_t type.
-S.Diag(Param->getLocation(), diag::err_bad_kernel_param_type) << PT;
+// Do not diagnose half type since it is diagnosed as invalid argument
+//
bader added inline comments.
Comment at: test/SemaOpenCL/half.cl:29
@@ +28,3 @@
+kernel void half_disabled_kernel(global half *p,
+ half h); // expected-error{{'half' cannot be
used as the type of a kernel parameter}} // expected-error{{declaring
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
https://reviews.llvm.org/D24626
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
bader added a comment.
Valery, do you have any additional comments/questions regarding this patch?
https://reviews.llvm.org/D23992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280800: [OpenCL] Fix pipe built-in functions return type.
(authored by bader).
Changed prior to commit:
https://reviews.llvm.org/D24136?vs=70368=70516#toc
Repository:
rL LLVM
Author: bader
Date: Wed Sep 7 05:32:03 2016
New Revision: 280800
URL: http://llvm.org/viewvc/llvm-project?rev=280800=rev
Log:
[OpenCL] Fix pipe built-in functions return type.
By default return type of call expressions calling built-in
functions is set to bool.
Fixes
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280699: [OpenCL] Remove access qualifiers on images in arg
info metadata. (authored by bader).
Changed prior to commit:
https://reviews.llvm.org/D23915?vs=69649=70372#toc
Repository:
rL LLVM
Author: bader
Date: Tue Sep 6 05:10:28 2016
New Revision: 280699
URL: http://llvm.org/viewvc/llvm-project?rev=280699=rev
Log:
[OpenCL] Remove access qualifiers on images in arg info metadata.
Summary:
Remove access qualifiers on images in arg info metadata:
* kernel_arg_type
*
bader updated this revision to Diff 70368.
bader added a comment.
Added get_pipe_num_packets and get_pipe_max_packets test cases.
https://reviews.llvm.org/D24136
Files:
lib/Sema/SemaChecking.cpp
test/CodeGenOpenCL/pipe_builtin.cl
Index: test/CodeGenOpenCL/pipe_builtin.cl
bader updated this revision to Diff 70366.
bader added a comment.
Applied code review comment from Anastasia.
Use getTypeSizeInChars instead of getTypeSize to get type size in bytes. Assume
that char size is always one byte.
https://reviews.llvm.org/D23992
Files:
lib/CodeGen/CGBuiltin.cpp
bader added a comment.
Could you a regression test, please?
https://reviews.llvm.org/D24054
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bader created this revision.
bader added a reviewer: Anastasia.
bader added subscribers: yaxunl, cfe-commits.
By default return type of call expressions calling built-in
functions is set to bool.
Fixes https://llvm.org/bugs/show_bug.cgi?id=30219.
https://reviews.llvm.org/D24136
Files:
Author: bader
Date: Tue Aug 30 09:42:54 2016
New Revision: 280097
URL: http://llvm.org/viewvc/llvm-project?rev=280097=rev
Log:
[OpenCL] Make is_valid_event, create_user_event overloadable.
Summary: Make is_valid_event and create_user_event overloadable like other
built-ins.
Patch by Evgeniy
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280097: [OpenCL] Make is_valid_event, create_user_event
overloadable. (authored by bader).
Changed prior to commit:
https://reviews.llvm.org/D23914?vs=69650=69682#toc
Repository:
rL LLVM
bader created this revision.
bader added reviewers: Anastasia, vpykhtin.
bader added a subscriber: cfe-commits.
Keep pipe packet size and alignment in LLVM IR layer to enable
translation from LLVM IR to SPIR-V format.
https://reviews.llvm.org/D23992
Files:
lib/CodeGen/CGBuiltin.cpp
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D23915
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D23914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277743: [OpenCL] Added underscores to the names of 'to_addr'
OpenCL built-ins. (authored by bader).
Changed prior to commit:
https://reviews.llvm.org/D23120?vs=66653=66832#toc
Repository:
rL LLVM
Author: bader
Date: Thu Aug 4 13:06:27 2016
New Revision: 277743
URL: http://llvm.org/viewvc/llvm-project?rev=277743=rev
Log:
[OpenCL] Added underscores to the names of 'to_addr' OpenCL built-ins.
Summary:
In order to re-define OpenCL built-in functions
'to_{private,local,global}' in OpenCL
bader created this revision.
bader added reviewers: Anastasia, yaxunl.
bader added a subscriber: cfe-commits.
In order to re-define OpenCL built-in functions
'to_{private,local,global}' in OpenCL run-time library LLVM names must
be different from the clang built-in function names.
bader added inline comments.
Comment at: test/CodeGenOpenCL/cl20-device-side-enqueue.cl:12
@@ -11,3 +11,3 @@
unsigned flags = 0;
- // CHECK: %ndrange = alloca %opencl.ndrange_t*
+ // CHECK: %ndrange = alloca %ndrange_t
ndrange_t ndrange;
Could you also
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274858: [OpenCL] Fix access qualifiers handling for typedefs
(authored by bader).
Changed prior to commit:
http://reviews.llvm.org/D20948?vs=63222=63235#toc
Repository:
rL LLVM
Author: bader
Date: Fri Jul 8 10:34:59 2016
New Revision: 274858
URL: http://llvm.org/viewvc/llvm-project?rev=274858=rev
Log:
[OpenCL] Fix access qualifiers handling for typedefs
OpenCL s6.6: "Access qualifier must be used with image object arguments
of kernels and of user-defined functions
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM.
A few minor style comments.
Comment at: lib/Sema/SemaExpr.cpp:10806-10807
@@ -10816,4 +10805,4 @@
// the ATOMIC_VAR_INIT macro.
if
bader added a comment.
Ping.
Xiuli, do you have any comments?
http://reviews.llvm.org/D21744
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bader added a comment.
LGTM!
Thanks a lot for working on this.
http://reviews.llvm.org/D20249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bader added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:6773-6774
@@ -6772,4 +7016,2 @@
-namespace {
-
/// Structure recording the 'active' range of an integer-valued
The con of this change - it will export all the symbols from this unnamed
Author: bader
Date: Wed Jun 29 07:25:58 2016
New Revision: 274120
URL: http://llvm.org/viewvc/llvm-project?rev=274120=rev
Log:
[OpenCL] Fix typo in as_type test.
Reset astype variable in f6 function to avoid matching with wrong value from f5
function.
Modified:
bader updated this revision to Diff 62100.
bader added a comment.
Re-format the patch.
No functional changes.
http://reviews.llvm.org/D21744
Files:
lib/CodeGen/CodeGenFunction.cpp
test/CodeGenOpenCL/pipe_types.cl
Index: test/CodeGenOpenCL/pipe_types.cl
bader created this revision.
bader added reviewers: Anastasia, yaxunl.
bader added subscribers: cfe-commits, pxli168, pekka.jaaskelainen.
http://reviews.llvm.org/D21795
Files:
lib/Headers/opencl-c.h
Index: lib/Headers/opencl-c.h
bader accepted this revision.
bader added a comment.
LGTM.
A few style nitpicks.
Comment at: lib/CodeGen/CGBuiltin.cpp:2180-2181
@@ +2179,4 @@
+}
+// Could have events and/or vaargs.
+if (NumArgs >= 5) {
+ if (E->getArg(3)->getType()->isBlockPointerType()) {
bader added a comment.
Hi Anastasia,
Sorry for the delay.
I have just a few comments.
Thanks,
Alexey
Comment at: lib/Sema/SemaChecking.cpp:95
@@ +94,3 @@
+ IllegalParams = true;
+ break;
+}
It looks like this function will report only first
bader accepted this revision.
bader added a comment.
LGTM.
Comment at: test/CodeGenOpenCL/kernel-attributes.cl:9
@@ -8,3 +10,1 @@
-// CHECK: opencl.kernels = !{[[MDNODE0:![0-9]+]], [[MDNODE3:![0-9]+]]}
-
AFAIK, this named metadata node were also useful for
bader accepted this revision.
Comment at: test/Headers/opencl-c-header.cl:30-31
@@ +29,4 @@
+
+// ===
+// Compile for OpenCL 2.0 for the first time. The module should change.
+// RUN: %clang_cc1 -cc1 -emit-llvm -o - -cl-std=CL2.0
-finclude-default-header -fmodules
bader added a comment.
Sorry for the delay.
Is this code valid:
clk_event_t e1, e2, e3;
clk_event_t events[] = {e1, e2};
enqueue_kernel(get_default_queue(), 0, get_ndrange(), 2, events, , ...);
With this patch clang rejects it with an error:
'illegal call to enqueue_kernel, expected
1 - 100 of 138 matches
Mail list logo
