[PATCH] D144510: [clang-tidy] improve readability-identifier-naming hungarian options test

amurzeau added a comment. In D144510#4254959 , @dougpuob wrote: > Hi @amurzeau > > I missed the review before landing. I have a suggestion regarding the > customized prefix "cust" because it confused me when I found the Hungarian > notation patterns in

[PATCH] D147779: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

amurzeau accepted this revision. amurzeau added a comment. Thanks ! LGTM, nothing to add. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147779/new/ https://reviews.llvm.org/D147779 ___ cfe-commits mailin

[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

amurzeau added a comment. In D144912#4204088 , @carlosgalvezp wrote: > Looks great, approved! Thanks for fixing :) Thanks for the review :) I don't have push access, so please can you (or anyone else) land it for me ? (as `Alexis Murzeau ` (phabricator

[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

amurzeau added a comment. In D144912#4203920 , @carlosgalvezp wrote: > Looks good but I fail to understand what exactly the patch fixes, can you > point me to an example in the tests? The patch fixes these enum tests in C language mode: enum REV_TYP

[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

amurzeau added a comment. Hi, thanks PiotrZSL, the build is now passed and is green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144912/new/ https://reviews.llvm.org/D144912 ___ cfe-commits mailing lis

[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

amurzeau marked an inline comment as done. amurzeau added a comment. I see the build is still marked as failed in phabricator, but succeed in buildkite, do I need to do something, like a rebuild ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14491

[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

amurzeau updated this revision to Diff 501247. amurzeau added a comment. Fix clang-format error, release notes and factorize typedefs in tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144912/new/ https://reviews.llvm.org/D144912 Files: cla

[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

amurzeau updated this revision to Diff 500905. amurzeau added a comment. Update the release notes too, to notify of this changes with C files. Suggest the user to use `EnumConstantPrefix` instead of `EnumConstantHungarianPrefix` to keep the previous behavior of using `i` for all enum tags. Repo

[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

amurzeau created this revision. amurzeau added reviewers: njames93, alexfh, kazu, dougpuob, aaron.ballman, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. amurzeau requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscri

[PATCH] D144790: [clang-tidy] readability-identifier-naming.HungarianNotation: rename CharPrinter to CharPointer

amurzeau created this revision. amurzeau added reviewers: njames93, alexfh, kazu, dougpuob, aaron.ballman, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. amurzeau requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a pr

[PATCH] D144510: [clang-tidy] improve readability-identifier-naming hungarian options test

amurzeau updated this revision to Diff 500256. amurzeau added a comment. Rebase on main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144510/new/ https://reviews.llvm.org/D144510 Files: clang-tools-extra/test/clang-tidy/checkers/readability/Inp

[PATCH] D144431: [clang-tidy] Fix readability-identifer-naming Hungarian CString options

amurzeau added a comment. In D144431#4146524 , @carlosgalvezp wrote: > Alright, sounds good, thanks for the clarification! Then I misunderstood the > change in the tests and indeed it belonged together in this patch, sorry for > the confusion. I have a

[PATCH] D144431: [clang-tidy] Fix readability-identifer-naming Hungarian CString options

amurzeau marked an inline comment as done. amurzeau added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/Inputs/identifier-naming/hungarian-notation2/.clang-tidy:115 value: On - - key: readability-identifier-naming.HungarianNotatio

[PATCH] D144510: [clang-tidy] improve readability-identifier-naming hungarian options test

amurzeau created this revision. Herald added a subscriber: xazax.hun. Herald added a project: All. amurzeau requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang-tools-extra. Adjust identifier-naming-hungarian-notation-cfgfile test with ch

[PATCH] D144431: [clang-tidy] Fix readability-identifer-naming Hungarian CString options

amurzeau updated this revision to Diff 499239. amurzeau added a comment. Add a release note for this fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144431/new/ https://reviews.llvm.org/D144431 Files: clang-tools-extra/clang-tidy/readability/

[PATCH] D144431: [clang-tidy] Fix readability-identifer-naming Hungarian CString options

amurzeau updated this revision to Diff 499235. amurzeau edited the summary of this revision. amurzeau added a comment. Remove test changes, I will make a different patch for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144431/new/ https://re

[PATCH] D144431: [clang-tidy] Fix readability-identifer-naming Hungarian CString options

amurzeau created this revision. amurzeau added reviewers: njames93, alexfh, kazu, dougpuob, aaron.ballman, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. amurzeau requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a pr

[PATCH] D144422: [clang-tidy] update docs for new hungarian identifier-naming types (unsigned char and void)

amurzeau added a comment. I don't have commit access to the repo, so please commit this for me when accepted. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144422/new/ https://reviews.llvm.org/D144422 _

[PATCH] D144422: [clang-tidy] update docs for new hungarian identifier-naming types (unsigned char and void)

amurzeau created this revision. amurzeau added reviewers: njames93, alexfh, kazu, dougpuob, aaron.ballman, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. amurzeau requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscri

[PATCH] D144041: [clang-tidy] add primitive types for hungarian identifier-naming (unsigned char and void)

amurzeau added a comment. I do not have commit access to the repo, can someone commit this patch for me ? (after D144037 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144041/new/ https://reviews.llvm.org/D144041

[PATCH] D144037: [clang-tidy] allow tests to use --config-file instead of --config

amurzeau added a comment. I do not have commit access to the repo, can someone commit this patch for me ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144037/new/ https://reviews.llvm.org/D144037 ___ cf

[PATCH] D144037: [clang-tidy] allow tests to use --config-file instead of --config

amurzeau updated this revision to Diff 497773. amurzeau retitled this revision from "[clang-tidy] allow tests to use -config-file instead of -config" to "[clang-tidy] allow tests to use --config-file instead of --config". amurzeau added a comment. Allow use of --config and --config-file (with do

[PATCH] D144041: [clang-tidy] add primitive types for hungarian identifier-naming (unsigned char and void)

amurzeau created this revision. amurzeau added reviewers: njames93, alexfh, kazu, dougpuob. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. amurzeau requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang-tool

[PATCH] D144037: [clang-tidy] allow tests to use -config-file instead of -config

amurzeau created this revision. amurzeau added reviewers: njames93, alexfh, kazu, dougpuob. Herald added a subscriber: xazax.hun. Herald added a project: All. amurzeau requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The previous