[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir abandoned this revision. Amir added a comment. Migrated to https://github.com/llvm/llvm-project/pull/69133 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617

[PATCH] D155419: [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED

Amir updated this revision to Diff 550996. Amir added a comment. Bugfixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155419/new/ https://reviews.llvm.org/D155419 Files: clang/CMakeLists.txt clang/cmake/caches/CSSPGO.cmake clang/utils/perf

[PATCH] D155419: [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED

Amir updated this revision to Diff 550607. Amir added a comment. perf2prof Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155419/new/ https://reviews.llvm.org/D155419 Files: clang/CMakeLists.txt clang/cmake/caches/CSSPGO.cmake clang/utils/per

[PATCH] D155419: [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED

Amir updated this revision to Diff 550532. Amir added a comment. Append to PGO_OPT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155419/new/ https://reviews.llvm.org/D155419 Files: clang/CMakeLists.txt clang/cmake/caches/CSSPGO.cmake clang/u

[PATCH] D156607: [Clang][CMake] Allow using passthrough BOLT in BOLT-PGO.cmake

Amir updated this revision to Diff 545406. Amir added a comment. Add clang-bolt-profile-deps dependency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156607/new/ https://reviews.llvm.org/D156607 Files: clang/CMakeLists.txt clang/cmake/caches/B

[PATCH] D156607: [Clang][CMake] Allow using passthrough BOLT in BOLT-PGO.cmake

Amir created this revision. Amir added reviewers: bolt, phosek, beanz. Herald added subscribers: wlei, ekilmer, wenlei. Herald added a project: All. Amir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Factor out bolt project dependency fro

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 542280. Amir added a comment. Make the name of BOLT-instrumented Clang binary (CLANG_BOLT_INSTRUMENTED) a user-settable cache variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 542272. Amir added a comment. Set CLANG_BOLT_INSTRUMENTED in parent scope too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: clang/CMakeLists.txt clang/cmak

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 542264. Amir marked an inline comment as done. Amir added a comment. Fix instrumentation mode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: clang/CMakeLists.t

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir marked 7 inline comments as done. Amir added inline comments. Comment at: clang/utils/perf-training/perf-helper.py:75 +parser.add_argument( +"--lbr", required=False, action="store_true", help="Use perf with branch stacks" +) phosek wrote: >

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 542060. Amir added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake clang/util

[PATCH] D155419: [Clang][CMake][WIP] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED

Amir updated this revision to Diff 541222. Amir added a comment. More plumbing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155419/new/ https://reviews.llvm.org/D155419 Files: clang/CMakeLists.txt clang/utils/perf-training/CMakeLists.txt cl

[PATCH] D155419: [Clang][CMake][WIP] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED

Amir created this revision. Herald added subscribers: wlei, ekilmer, wenlei. Herald added a project: All. Amir requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 538271. Amir added a comment. Rebase + reformatted with `black` (D150761 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: cla

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir added a comment. Ping @beanz, @phosek Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D151595: [BOLT][CMake] Redo the build and install targets

Amir added a comment. Merged the PR. Please reland Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151595/new/ https://reviews.llvm.org/D151595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D151595: [BOLT][CMake] Redo the build and install targets

Amir accepted this revision. Amir added a comment. Thanks. Will update the dependencies, removing always-installed symlinks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151595/new/ https://reviews.llvm.org/D151595 ___

[PATCH] D151595: [BOLT][CMake] Redo the build and install targets

Amir added inline comments. Comment at: bolt/test/CMakeLists.txt:40 llvm-bolt - llvm-boltdiff llvm-bolt-heatmap We have a number of dependencies on llvm-boltdiff and perf2bolt, e.g. in internal and upstream binary tests: https://github.com/rafaelauler/bo

[PATCH] D151595: [BOLT][CMake] Redo the build and install targets

Amir added a comment. In D151595#4385506 , @phosek wrote: > @Amir does this change look good to you? Looks good overall. Thanks for adding AddBolt cmake module. Testing the build internally, will reply shortly. Repository: rG LLVM Github Monorepo C

[PATCH] D150752: [bolt] Use correct output paths and passthrough necessary options

Amir added a comment. Please retitle as "[BOLT][CMake] ..." Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150752/new/ https://reviews.llvm.org/D150752 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D133633: [CMake] Add ClangBootstrap configuration

Amir abandoned this revision. Amir added a comment. Herald added a subscriber: ekilmer. No longer needed for Clang-BOLT. @thevinster – feel free to commandeer if it fits your needs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133633/new/ https:/

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 521919. Amir added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake clang/utils/perf-tra

[PATCH] D143553: [Clang][CMake] Use perf-training for Clang-BOLT

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG76b2915fdbbb: [Clang][CMake] Use perf-training for Clang-BOLT (authored by Amir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143553: [Clang][CMake] Use perf-training for Clang-BOLT

Amir added a comment. In D143553#4339755 , @beanz wrote: > LGTM. > > Sorry for the delays reviewing! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143553/new/ https://reviews.llvm.org/D143553 ___

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 504392. Amir added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake clang/utils/perf-tra

[PATCH] D143553: [Clang][CMake] Use perf-training for Clang-BOLT

Amir added a comment. Ping @phosek Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143553/new/ https://reviews.llvm.org/D143553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D143553: [Clang][CMake] Use perf-training for Clang-BOLT

Amir updated this revision to Diff 500956. Amir added a comment. Rebase, reduce changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143553/new/ https://reviews.llvm.org/D143553 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake clan

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 496276. Amir added a comment. Reduce changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake clang/utils/

[PATCH] D143553: [Clang][CMake] Use perf-training for Clang-BOLT

Amir updated this revision to Diff 496274. Amir edited the summary of this revision. Amir added a comment. Remove sysroot_flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143553/new/ https://reviews.llvm.org/D143553 Files: clang/CMakeLists.tx

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 496273. Amir added a comment. Reduce changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake clang/utils/

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 496272. Amir added a comment. Reduce changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake clang/utils/

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 496271. Amir added a comment. Reduce changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake clang/utils/

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 496253. Amir added a comment. Reduce changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake clang/utils/

[PATCH] D143617: [Clang][CMake] Break out Instrument from CLANG_BOLT option

Amir updated this revision to Diff 496249. Amir added a comment. Add perf and perf+LBR support Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake

[PATCH] D143617: [Clang][CMake] Break out Instrument from CLANG_BOLT option

Amir created this revision. Amir added a reviewer: bolt. Herald added a project: All. Amir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Split up and refactor CLANG_BOLT_INSTRUMENT into pieces that would work with other profiling modes, n

[PATCH] D143553: [Clang][CMake] Add BOLT perf-training

Amir updated this revision to Diff 495941. Amir added a comment. Fixed BOLT-PGO build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143553/new/ https://reviews.llvm.org/D143553 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake clang/

[PATCH] D139496: [CMake] Add perf profiling for clang-bolt

Amir abandoned this revision. Amir added a comment. Abandon in favor of D143553 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139496/new/ https://reviews.llvm.org/D139496 _

[PATCH] D143553: [Clang][CMake] Add BOLT perf-training (WIP)

Amir updated this revision to Diff 495915. Amir added a comment. Fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143553/new/ https://reviews.llvm.org/D143553 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake clang/utils/perf-trai

[PATCH] D143553: [Clang][CMake] Add BOLT perf-training (WIP)

Amir created this revision. Amir added a reviewer: phosek. Herald added a subscriber: wenlei. Herald added a project: All. Amir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove the bootstrapped build for BOLT profile collection. Adopt

[PATCH] D140565: [Clang][CMake] Set up distribution target for Clang-BOLT

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42129deaa67b: [Clang][CMake] Set up distribution target for Clang-BOLT (authored by Amir). Changed prior to commit: https://reviews.llvm.org/D1405

[PATCH] D139454: [CMake] Replace clang binary if using clang-bolt target

This revision was automatically updated to reflect the committed changes. Closed by commit rGe67f849001bb: [CMake] Replace clang binary if using clang-bolt target (authored by Amir). Changed prior to commit: https://reviews.llvm.org/D139454?vs=492638&id=493025#toc Repository: rG LLVM Github

[PATCH] D139454: [CMake] Replace clang binary if using clang-bolt target

Amir updated this revision to Diff 492638. Amir added a comment. Use generator expression, put clang-bolt temp binary to CMAKE_CURRENT_BINARY_DIR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139454/new/ https://reviews.llvm.org/D139454 Files: c

[PATCH] D139454: [CMake] Replace clang binary if using clang-bolt target

Amir added a comment. Ping @phosek @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139454/new/ https://reviews.llvm.org/D139454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D141342: [perf-training] Check extension in findFilesWithExtension

This revision was automatically updated to reflect the committed changes. Closed by commit rG1fbbf92e4fda: [perf-training] Check extension in findFilesWithExtension (authored by Amir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141342/new/ https:

[PATCH] D141342: [perf-training] Check extension in findFilesWithExtension

Amir created this revision. Amir added reviewers: phosek, beanz. Herald added a subscriber: pengfei. Herald added a project: All. Amir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `findFilesWithExtension` helper checks for `endswith(exte

[PATCH] D108265: .clang-tidy: Push variable related readability-identifier-naming options down to projects

Amir accepted this revision. Amir added a comment. This revision is now accepted and ready to land. LGTM for BOLT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108265/new/ https://reviews.llvm.org/D108265 __

[PATCH] D140565: [Clang][CMake] Set up distribution target for Clang-BOLT

Amir created this revision. Amir added a reviewer: phosek. Herald added a subscriber: wenlei. Herald added a project: All. Amir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Provide a way to install usable BOLT-optimized Clang (clang + re

[PATCH] D139496: [CMake] Add perf profiling for clang-bolt

Amir updated this revision to Diff 484727. Amir added a comment. Convert perf profile using perf2bolt (aggregate-only mode) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139496/new/ https://reviews.llvm.org/D139496 Files: clang/CMakeLists.txt

[PATCH] D139496: [CMake] Add perf profiling for clang-bolt

Amir updated this revision to Diff 484102. Amir added a comment. Typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139496/new/ https://reviews.llvm.org/D139496 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake llvm/docs/AdvancedBuil

[PATCH] D139496: [CMake] Add perf profiling for clang-bolt

Amir added a comment. @phosek – this diff adds support for AArch64 via Linux perf. I believe it makes sense to add this functionality first in an incremental fashion and refactor it later, moving parts into perf-training script. What do you think? (And thank you for reviewing this stuff!) Rep

[PATCH] D139496: [CMake] Add perf profiling for clang-bolt

Amir updated this revision to Diff 483400. Amir added a comment. Generalize to -DCLANG_BOLT={Instrument,perf,LBR}, update documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139496/new/ https://reviews.llvm.org/D139496 Files: clang/CMake

[PATCH] D139496: [CMake] Add perf profiling for clang-bolt

Amir added a comment. In D139496#3986435 , @phosek wrote: > Could we add the `perf` related logic to > https://github.com/llvm/llvm-project/blob/ba3d808feedaa7f31750d8bc02754e15b372c868/clang/utils/perf-training/perf-helper.py? > I think that's a better

[PATCH] D139496: [CMake] Use perf with LBR for clang-bolt (WIP)

Amir updated this revision to Diff 481138. Amir added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139496/new/ https://reviews.llvm.org/D139496 Files:

[PATCH] D139496: [CMake] Use perf with LBR for clang-bolt (WIP)

Amir updated this revision to Diff 481078. Amir added a comment. Fix instrumentation and no-LBR modes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139496/new/ https://reviews.llvm.org/D139496 Files: clang/CMakeLists.txt clang/cmake/caches/BOL

[PATCH] D139496: [CMake] Use perf with LBR for clang-bolt (WIP)

Amir updated this revision to Diff 480982. Amir added a comment. Avoid using perf2bolt, provide perf.data directly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139496/new/ https://reviews.llvm.org/D139496 Files: clang/CMakeLists.txt clang/cma

[PATCH] D139496: [CMake] Use perf with LBR for clang-bolt (WIP)

Amir updated this revision to Diff 480760. Amir added a comment. Fixed COMPILER_LAUNCHER, perf2bolt invocation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139496/new/ https://reviews.llvm.org/D139496 Files: clang/CMakeLists.txt clang/cmake/c

[PATCH] D139496: [CMake] Use perf with LBR for clang-bolt (WIP)

Amir updated this revision to Diff 480739. Amir added a comment. Fix dependence between bolt-profile and clang (either instrumented or not) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139496/new/ https://reviews.llvm.org/D139496 Files: clang/C

[PATCH] D139496: [CMake] Use perf with LBR for clang-bolt (WIP)

Amir created this revision. Amir added reviewers: bolt, phosek. Herald added a project: All. Amir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `perf` provides a faster and easier way to collect BOLT profile. Generalize CMake handling of

[PATCH] D139454: [CMake] Replace clang binary if using clang-bolt target

Amir created this revision. Amir added reviewers: bolt, phosek, MaskRay. Herald added subscribers: StephenFan, wenlei. Herald added a project: All. Amir requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Instead of creating a

[PATCH] D133633: [CMake] Add ClangBootstrap configuration

Amir added inline comments. Comment at: clang/cmake/modules/ClangBootstrap.cmake:11 +macro(clang_bootstrap_add name) + cmake_parse_arguments(ARG "" "LINKER;AR;RANLIB;OBJCOPY;STRIP" +"DEPENDS;TABLEGEN;CMAKE_ARGS;BUILD_TOOL_ARGS" thevinster wrote: > Were you p

[PATCH] D133633: [CMake] Add ClangBootstrap configuration

Amir marked an inline comment as done. Amir added inline comments. Comment at: clang/cmake/modules/ClangBootstrap.cmake:10 +# Optional arguments to pass to the build tool +macro(clang_Bootstrap_Add name) + cmake_parse_arguments(ARG "" "LINKER;AR;RANLIB;OBJCOPY;STRIP" ---

[PATCH] D133633: [CMake] Add ClangBootstrap configuration

Amir updated this revision to Diff 475505. Amir added a comment. s/clang_Bootstrap_Add/clang_bootstrap_add Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133633/new/ https://reviews.llvm.org/D133633 Files: clang/CMakeLists.txt clang/cmake/modul

[PATCH] D133633: [CMake] Add ClangBootstrap configuration

Amir updated this revision to Diff 475309. Amir added a comment. Move out toolchain tools back into CMAKE_ARGS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133633/new/ https://reviews.llvm.org/D133633 Files: clang/CMakeLists.txt clang/cmake/m

[PATCH] D137338: Fix dupe word typos

Amir accepted this revision. Amir added a comment. BOLT changes LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137338/new/ https://reviews.llvm.org/D137338 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D136023: [CMake] Disable BOLT instrumentation of Clang on instrumented build

This revision was automatically updated to reflect the committed changes. Closed by commit rG076240fa0624: [CMake] Disable BOLT instrumentation of Clang on instrumented build (authored by Amir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136023/ne

[PATCH] D132975: [CMake] Add clang-bolt target

Amir added a comment. In D132975#3861334 , @phosek wrote: > In D132975#3860896 , @Amir wrote: > >> In D132975#3763264 , @phosek wrote: >> >>> This was already on my list o

[PATCH] D132975: [CMake] Add clang-bolt target

Amir added a comment. In D132975#3763264 , @phosek wrote: > This was already on my list of build system features I'd like to implement > and I'm glad someone else is already looking into it, thank you! I have two > high level comments about your approac

[PATCH] D71507: [perf-training] Make training data location configurable

Amir added a comment. Herald added a subscriber: wenlei. Herald added a project: All. Hi @smeenai, Sorry for asking on this diff, but... Do you have any pointers for training sets? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71507/new/

[PATCH] D136023: [CMake] Disable BOLT instrumentation of Clang on instrumented build

Amir updated this revision to Diff 468030. Amir added a comment. Add BOLT-PGO cmake cache file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136023/new/ https://reviews.llvm.org/D136023 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT-PGO.c

[PATCH] D136023: [CMake] Disable BOLT instrumentation of Clang on instrumented build

Amir created this revision. Amir added reviewers: phosek, nikic, beanz. Herald added a subscriber: wenlei. Herald added a project: All. Amir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This enables multi-stage PGO build optimized by BOL

[PATCH] D132975: [CMake] Add clang-bolt target

This revision was automatically updated to reflect the committed changes. Closed by commit rG3dab7fede201: [CMake] Add clang-bolt target (authored by Amir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132975/new/ https://reviews.llvm.org/D132975

[PATCH] D127800: [llvm-driver] Generate symlinks instead of executables for tools

Amir added inline comments. Comment at: llvm/cmake/modules/AddLLVM.cmake:1283 macro(add_llvm_tool name) + cmake_parse_arguments(ARG "DEPENDS;GENERATE_DRIVER" "" "" ${ARGN}) if( NOT LLVM_BUILD_TOOLS ) Sorry for a late question but I don't see any use of ARG_D

[PATCH] D132975: [CMake] Add clang-bolt target

Amir marked an inline comment as done. Amir added inline comments. Comment at: clang/CMakeLists.txt:930-937 +-DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX} +-DCMAKE_C_COMPILER=${CLANG_INSTRUMENTED} +-DCMAKE_CXX_COMPILER=${CLANGXX_IN

[PATCH] D133633: [CMake] Add ClangBootstrap configuration

Amir updated this revision to Diff 459589. Amir added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133633/new/ https://reviews.llvm.org/D133633 Files: clang/CMakeLists.txt clang/cmake/modules/ClangBootstrap.cmake Index: cla

[PATCH] D132975: [CMake] Add clang-bolt target

Amir updated this revision to Diff 459588. Amir added a comment. Add an ability to pass extra cmake flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132975/new/ https://reviews.llvm.org/D132975 Files: clang/CMakeLists.txt clang/cmake/caches

[PATCH] D132975: [CMake] Add clang-bolt target

Amir marked an inline comment as not done. Amir added inline comments. Comment at: clang/CMakeLists.txt:930-937 +-DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX} +-DCMAKE_C_COMPILER=${CLANG_INSTRUMENTED} +-DCMAKE_CXX_COMPILER=${CLANGX

[PATCH] D132975: [CMake] Add clang-bolt target

Amir updated this revision to Diff 459539. Amir added a comment. Address @phosek's comment about dependency on shell Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132975/new/ https://reviews.llvm.org/D132975 Files: clang/CMakeLists.txt clang/c

[PATCH] D133633: [CMake] Add ClangBootstrap configuration

Amir created this revision. Amir added reviewers: phosek, MaskRay. Herald added subscribers: StephenFan, mgorny. Herald added a reviewer: alexander-shaposhnikov. Herald added a project: All. Amir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commit

[PATCH] D132975: [clang][BOLT] Add clang-bolt target

Amir added a comment. In D132975#3768391 , @tschuett wrote: > Will there be eventually a way to build a fully optimised clang/lld with > ThinLTO, PGO, and Bolt? Short answer is likely yes. For clang, I think this diff should be compatible with PGO, with

[PATCH] D132975: [clang][BOLT] Add clang-bolt target

Amir updated this revision to Diff 457467. Amir added a comment. Fix up paths Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132975/new/ https://reviews.llvm.org/D132975 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake Index: clang/cm

[PATCH] D132975: [clang][BOLT] Add clang-bolt target

Amir added a comment. Hi Petr, thank you for your comments! In D132975#3763264 , @phosek wrote: > This was already on my list of build system features I'd like to implement > and I'm glad someone else is already looking into it, thank you! I have two >

[PATCH] D132975: [clang][BOLT] Add clang-bolt target (WIP)

Amir updated this revision to Diff 457400. Amir added a comment. Succeeded in producing optimized Clang. Switch the default profiling target from `lld` to `count`, which produces a sufficient Clang coverage of 5.3B exec insns (along with configure-stage Clang invocations). Repository: rG LLVM

[PATCH] D132975: [clang][BOLT] Add clang-bolt target (WIP)

Amir updated this revision to Diff 457172. Amir added a comment. Successfully invoke the bootstrap/profiling build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132975/new/ https://reviews.llvm.org/D132975 Files: clang/CMakeLists.txt clang/cma

[PATCH] D132975: [clang][BOLT] Add clang-bolt target (WIP)

Amir updated this revision to Diff 457102. Amir added a comment. Succeeded instrumenting Clang with BOLT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132975/new/ https://reviews.llvm.org/D132975 Files: clang/CMakeLists.txt clang/cmake/caches/

[PATCH] D132975: [clang][BOLT] Add clang-bolt target (WIP)

Amir updated this revision to Diff 456799. Amir added a comment. CMAKE_CURRENT_BINARY_DIR already contains bin/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132975/new/ https://reviews.llvm.org/D132975 Files: clang/CMakeLists.txt clang/cmake/

[PATCH] D132975: [clang][BOLT] Add clangbolt target (WIP)

Amir created this revision. Amir added a reviewer: bolt. Herald added subscribers: treapster, wenlei, mgorny. Herald added a project: All. Amir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds `CLANG_BOLT_INSTRUMENT` option t

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

Amir added a comment. Hi @void, The msvc build is still broken. https://lab.llvm.org/buildbot/#/builders/222/builds/532 In D124836#3528529 , @void wrote: > In D124836#3528521 , @vvereschaka > wrote: > >> got i

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

Amir added a comment. Looks like this commit breaks msvc build: https://lab.llvm.org/buildbot/#/builders/222/builds/532 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124836/new/ https://reviews.llvm.org/D124836 ___

[PATCH] D123100: [Support/Hash functions] Change the `final()` and `result()` of the hashing functions to return an array of bytes

Amir accepted this revision. Amir added a comment. BOLT changes LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123100/new/ https://reviews.llvm.org/D123100 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D123100: [Support/Hash functions] Change the `final()` and `result()` of the hashing functions to return an array of bytes

Amir added inline comments. Comment at: bolt/lib/Core/DebugData.cpp:823 Hasher.update(AbbrevData); -StringRef Key = Hasher.final(); +auto Hash = Hasher.final(); +StringRef Key((const char *)Hash.data(), Hash.size()); I think it would be more in l

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

Amir accepted this revision. Amir added a comment. LGTM from BOLT side Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119918/new/ https://reviews.llvm.org/D119918 ___ cfe-commits mailing list cfe-commits@