[PATCH] D155544: [AIX][TLS][clang] Add -maix-small-local-exec-tls clang option.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1922e55ab3b: [AIX][TLS][clang] Add -maix-small-local-exec-tls clang option. (authored by amyk). Changed prior to commit: https://reviews.llvm.org

[PATCH] D155544: [AIX][TLS][clang] Add -maix-small-local-exec-tls clang option.

amyk updated this revision to Diff 543818. amyk marked 5 inline comments as done. amyk added a comment. Address review comments from Hubert and update this patch to be only the clang portion of the option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D155544: [AIX][TLS] Add -maix-small-local-exec-tls option.

amyk added a comment. In D155544#4523536 , @hubert.reinterpretcast wrote: > Patch should not land before back-end patch. I also suggest having the patch > incorporate the new option into the Clang release notes before it lands. I'm currently addressing

[PATCH] D155544: [AIX][TLS] Add -maix-small-local-exec-tls option.

amyk created this revision. amyk added reviewers: PowerPC, stefanp, kamaub, nemanjai, hubert.reinterpretcast. amyk added a project: LLVM. Herald added subscribers: kbarton, hiraditya. Herald added a project: All. amyk requested review of this revision. Herald added a project: clang. Herald added s

[PATCH] D149596: [AIX][TLS] Relax front end diagnostics to accept the local-exec TLS model

This revision was automatically updated to reflect the committed changes. Closed by commit rG706b5472d897: [AIX][TLS] Relax front end diagnostics to accept the local-exec TLS model (authored by amyk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149

[PATCH] D150520: [clang] Convert a few tests to opaque pointers

amyk added a comment. In D150520#4342943 , @barannikov88 wrote: > In D150520#4342429 , @amyk wrote: > >> Hi, I just wanted to give a heads up that it appears that this patch is >> causing failures on some of the

[PATCH] D150520: [clang] Convert a few tests to opaque pointers

amyk added a comment. Hi, I just wanted to give a heads up that it appears that this patch is causing failures on some of the PPC buildbots. In particular, the `const-str-array-decay.cl` appears to be failing. The failing build can be seen in: https://lab.llvm.org/buildbot/#/builders/36/builds/

[PATCH] D149596: [AIX][TLS] Relax front end diagnostics to accept the local-exec TLS model

amyk created this revision. amyk added reviewers: PowerPC, stefanp, kamaub, nemanjai. amyk added projects: LLVM, PowerPC, clang. Herald added a reviewer: aaron.ballman. Herald added a project: All. amyk requested review of this revision. Herald added a subscriber: cfe-commits. This patch relaxes t

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

amyk added a comment. Overall looks OK to me, as well. I just had two questions that I wanted to ask. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:444 +TARGET_BUILTIN(__builtin_altivec_vcmpnew_p, "iiV4iV4i", "", "power9-vector") +TARGET_BUILTIN(__builtin_altivec_vcmpne

[PATCH] D144967: [PowerPC] Recognize long CPU name for -mtune in Clang

amyk added a comment. In D144967#4164858 , @nathanchance wrote: > Could this be merged into `main` and backported to `release/16.x`? If this > makes 16.0.0 final, I think the kernel can avoid working around this issue > altogether, as `-mtune` was only

[PATCH] D144293: [PowerPC] Fix the implicit casting for the emulated intrinsics

amyk added inline comments. Comment at: clang/lib/Headers/ppc_wrappers/emmintrin.h:57 typedef __vector unsigned char __v16qu; +typedef __vector float __v2f; nemanjai wrote: > The name `__v2f` seems strange since `__vector float` is a vector of 4 > `float` val

[PATCH] D143210: PowerPC] Include vector bool and pixel when emitting lax warning

amyk added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:9845 if (anyAltivecTypes(RHSType, LHSType) && -!areSameVectorElemTypes(RHSType, LHSType)) +!Context.areCompatibleVectorTypes(RHSType, LHSType)) Diag(RHS.get()->getExprL

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

amyk added a comment. In D138675#3995282 , @probinson wrote: > See D139967 for why `UNSUPPORTED: powerpc` > didn't work. That patch will put it back, and also update the lit config so > the check will work now. Thank

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

amyk added a comment. In D138675#3989997 , @tblah wrote: > In D138675#3989826 , @amyk wrote: > >> Thanks for the follow up patch! I tested the patch locally and also saw the >> buildbot results, and it doesn't ap

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

amyk added a comment. In D138675#3989634 , @tblah wrote: > In D138675#3989403 , @amyk wrote: > >> Hi, >> >> The ppc64le-flang-rhel-clang >> bot is also experiencing s

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

amyk added a comment. Hi, The ppc64le-flang-rhel-clang bot is also experiencing some failures with the `Driver/fast_math.f90` test case. In particular, `crtfastmath.o` is not found at all for `CHECK-CRT` as we can see in the failure details

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

amyk added a comment. It might be good to add a test case to illustrate the 'unknown target CPU' error that is issued as a result of this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139720/new/ https://reviews.llvm.org/D139720 __

[PATCH] D135834: [PowerPC] Fix parameters for __builtin_crypto_vsbox

amyk accepted this revision as: amyk. amyk added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135834/new/ https://reviews.llvm.org/D135834 _

[PATCH] D135300: [PowerPC] Fix types for vcipher builtins.

amyk accepted this revision as: amyk. amyk added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135300/new/ https://reviews.llvm.org/D135300 _

[PATCH] D131622: [NFC][PowerPC] Add missing NOCOMPAT checks for builtins-ppc-xlcompat.c

amyk accepted this revision. amyk added a comment. This revision is now accepted and ready to land. I think this LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131622/new/ https://reviews.llvm.org/D131622 _

[PATCH] D126291: [flang][Driver] Update link job on windows

amyk added a comment. Hi, I have come across a failure involving `flang/test/Driver/linker-flags.f90` that occurs when the default linker is lld. I have opened an external issue for it here: https://github.com/llvm/llvm-project/issues/56955 Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

amyk added a comment. In D130224#3688034 , @skc7 wrote: > In D130224#3687907 , @aaron.ballman > wrote: > >> In D130224#3687860 , @amyk wrote: >> >>> In D130224#3687487

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

amyk added a comment. In D130224#3687907 , @aaron.ballman wrote: > In D130224#3687860 , @amyk wrote: > >> In D130224#3687487 , @mubarizafzal >> wrote: >> >>> Hi, the tes

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

amyk added a comment. In D130224#3687487 , @mubarizafzal wrote: > Hi, the test cases that this patch introduces are failing on some ppc64le > (Linux on Power) buildbots: > https://lab.llvm.org/buildbot/#/builders/57 > https://lab.llvm.org/buildbot/#/bui

[PATCH] D130066: [pseudo] Key guards by RuleID, add guards to literals (and 0).

amyk added a comment. In D130066#3670875 , @sammccall wrote: > In D130066#3670745 , @amyk wrote: > >> Hi! >> >> It appears that this patch is causing a build failure on a couple PPC bots >> that build with shared

[PATCH] D130066: [pseudo] Key guards by RuleID, add guards to literals (and 0).

amyk added a comment. Hi! It appears that this patch is causing a build failure on a couple PPC bots that build with shared libraries: https://lab.llvm.org/buildbot/#/builders/57/builds/20179 https://lab.llvm.org/buildbot/#/builders/121/builds/21678 The specific error that occurs looks like thi

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

amyk added inline comments. Comment at: clang/test/Driver/ppc-unsupported.c:12 +// RUN: -c %s 2>&1 | FileCheck %s +// RUN: not %clang -target powerpc64le-unknown-linux -maix64-quadword-atomics \ +// RUN: -c %s 2>&1 | FileCheck %s amyk wrote: > Should we have

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

amyk added a comment. This patch makes sense. I had some questions regarding it. Comment at: clang/include/clang/Driver/Options.td:3611 HelpText<"Enable the default Altivec ABI on AIX (AIX only). Uses only volatile vector registers.">; +def maix_quadword_atomics : Flag<["-"

[PATCH] D128288: [PowerPC] Fix signatures for vec_replace_unaligned builtin

amyk accepted this revision. amyk added a comment. LGTM too. Thank you Lei. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128288/new/ https://reviews.llvm.org/D128288 ___ cfe-commits mailing list cfe-com

[PATCH] D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions

amyk accepted this revision. amyk added a comment. This patch also LGTM. Thank you Lei. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124093/new/ https://reviews.llvm.org/D124093 ___ cfe-commits mailing

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

amyk accepted this revision. amyk added a comment. This revision is now accepted and ready to land. Thanks for the updates. Unless @lei has any other additional comments, I think LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126540/new/ http

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

amyk added a comment. Some additional minor comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7572 + "Current bitcast for incompatible vector types (%0 and %1) are deprecated. " + "The default behaviour will change to what implied by the " + "-fno-lax-ve

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

amyk added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7572 + "Current bitcast for incompatible vector types (%0 and %1) are deprecated. " + "The default behaviour will change to what implied by the " + "-fno-lax-vector-conversions option">, -

[PATCH] D126302: [PowerPC] Diagnose invalid combination with Altivec, VSX and soft-float

amyk added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:452 + if (llvm::is_contained(FeaturesVec, "-hard-float") && + llvm::is_contained(FeaturesVec, "+altivec")) +Diags.Report(diag::err_opt_not_valid_with_opt) << "-msoft-float" Do we al

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

amyk added a comment. In D125506#3528380 , @nathanchance wrote: > I bisected a crash when compiling the Linux kernel to this change. > > A reduced C reproducer: > > enum { > OP_CB_GETATTR = 3, > OP_CB_RECALL, > OP_CB_RECALL_ANY = 8, > O

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

amyk added a comment. In D125506#3528380 , @nathanchance wrote: > I bisected a crash when compiling the Linux kernel to this change. > > A reduced C reproducer: > > enum { > OP_CB_GETATTR = 3, > OP_CB_RECALL, > OP_CB_RECALL_ANY = 8, > O

[PATCH] D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions

amyk added a comment. I was wondering where are the test cases in this patch. Did they get missed when updating the revision? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124093/new/ https://reviews.llvm.org/D124093 _

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc35ca3a1c78f: [PowerPC] Implement XL compat __fnabs and __fnabss builtins. (authored by amyk). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

amyk updated this revision to Diff 430671. amyk added a comment. - Add a P6 +VSX run line and remove extra P7 /P8 lines for backend test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

amyk added inline comments. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-fnabs.ll:46 +; RUN: -mattr=-vsx < %s | FileCheck %s --check-prefix=CHECK-NOVSX + +declare double @llvm.ppc.fnabs(double) lei wrote: > nit: same as before no need to test all

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

amyk updated this revision to Diff 430249. amyk added a comment. Address review comments: - Remove `-no-opaque-pointers` and updates CHECKs - Simplify runs and checks of C and IR test files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125506/new/

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

amyk created this revision. amyk added reviewers: PowerPC, power-llvm-team, nemanjai, lei. amyk added a project: LLVM. Herald added subscribers: shchenz, hiraditya. Herald added a project: All. amyk requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-com

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

amyk added inline comments. Comment at: llvm/test/CodeGen/PowerPC/fast-isel-fcmp-nan.ll:5 ; CHECK-LABEL: TestULT: -; CHECK: xscmpudp +; CHECK: fcmpu ; CHECK: blr nemanjai wrote: > Why do we not emit the VSX instructions here any longer? How are crbits > relate

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. amyk marked an inline comment as done. Closed by commit rG2534dc120a4c: [PowerPC] Enable CR bits support for Power8 and above. (authored by amyk). Changed prior to com

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

amyk marked an inline comment as done. amyk added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:519 .Default(false); + Features["crbits"] = llvm::StringSwitch(CPU) +.Case("ppc64le", true) ---

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

amyk updated this revision to Diff 425417. amyk added a comment. Address review comments of adding documentation to `clang/docs/ClangCommandLineReference.rst` and adding AIX checks to `clang/test/Driver/ppc-crbits.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

amyk added a comment. In D119136#3459738 , @alanphipps wrote: > We've also been seeing failures in our downstream Arm compiler when running > the Perennial C++14 compliance tests related to this change. Specifically, > the tests expect a diagnostic to

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

amyk created this revision. amyk added reviewers: PowerPC, nemanjai, power-llvm-team. amyk added projects: LLVM, clang, PowerPC. Herald added subscribers: shchenz, hiraditya. Herald added a project: All. amyk requested review of this revision. Herald added a subscriber: cfe-commits. This patch tur

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

amyk accepted this revision as: amyk. amyk added a comment. This revision is now accepted and ready to land. Thanks Quinn. i think this overall LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/ https://reviews.llvm.org/D121637 __

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

amyk added a comment. Overall this change looks good to me, although I do have one question. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15208 - for (unsigned i = 0, e = E->getNumArgs(); i != e; i++) { -if (E->getArg(i)->getType()->isArrayType()) - Ops.push_back(EmitA

[PATCH] D118753: [PowerPC] Fix __builtin_pdepd and __builtin_pextd to be 64-bit and P10 only.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5dc0a1657be1: [PowerPC] Fix __builtin_pdepd and __builtin_pextd to be 64-bit and P10 only. (authored by amyk). Repository: rG LLVM Github Monorepo

[PATCH] D118753: [PowerPC] Fix __builtin_pdepd and __builtin_pextd to be 64-bit and P10 only.

amyk added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118753/new/ https://reviews.llvm.org/D118753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D117355: [PowerPC] Fix the undef virtual register reading failure for PPC backend trap optimization

amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:432 if (EnableTrapOptimization && TrapOpt) { +bool IsVReg = +(MI.getNumOperands() && MI.getOperand(0).isReg()) amyk wrote: > Might be good to pull out `MI

[PATCH] D118753: [PowerPC] Fix __builtin_pdepd and __builtin_pextd to be 64-bit and P10 only.

amyk created this revision. amyk added reviewers: PowerPC, nemanjai, lei, kamaub, quinnp. amyk added projects: LLVM, PowerPC. Herald added subscribers: shchenz, kbarton. amyk requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `__builtin_pd

[PATCH] D117355: [PowerPC] Fix the undef virtual register reading failure for PPC backend trap optimization

amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:432 if (EnableTrapOptimization && TrapOpt) { +bool IsVReg = +(MI.getNumOperands() && MI.getOperand(0).isReg()) Might be good to pull out `MI.getOperand(0)

[PATCH] D111434: [PowerPC] PPC backend optimization on conditional trap intrustions

amyk accepted this revision. amyk added a comment. Thanks for addressing the review comments and answering my question. This LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111434/new/ https://reviews.llvm.org/D111434 _

[PATCH] D111434: [PowerPC] PPC backend optimization on conditional trap intrustions

amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:1018 +unsigned Opcode2 = LiMI2->getOpcode(); +bool isOperand2Immeidate = MI.getOperand(2).isImm(); +// We can only do the optimization for the "reg + reg" form. -

[PATCH] D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions

amyk accepted this revision. amyk added a comment. Aside from Nemanja's comments, this patch LGTM. Thanks for addressing the comments! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112285/new/ https://reviews.llvm.org/D112285

[PATCH] D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions

amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:5001 + case ISD::INTRINSIC_VOID: { +if (N->getConstantOperandVal(1) == Intrinsic::ppc_tdw || +N->getConstantOperandVal(1) == Intrinsic::ppc_tw) { Might be a good idea

[PATCH] D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions

amyk added inline comments. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-trap-64bit-only.ll:131 +; CHECK: # %bb.0: +; CHECK-NEXT:tdi 3, 3, 32767 +; CHECK-NEXT:blr nemanjai wrote: > Can we add `-ppc-asm-full-reg-names` to the RUN line

[PATCH] D111434: [PowerPC] PPC backend optimization on conditional trap intrustions

amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:1011 + case PPC::TDI: + case PPC::TWI: { +MachineInstr *LiMIA = getVRegDefOrNull(&MI.getOperand(1), MRI); nemanjai wrote: > Seems that we should be able to handle

[PATCH] D109652: [PowerPC] Restrict various P10 options to P10 only.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5eaf5b916146: [PowerPC] Restrict various P10 options to P10 only. (authored by amyk). Changed prior to commit: https://reviews.llvm.org/D109652?vs

[PATCH] D111229: [PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter

amyk accepted this revision as: amyk. amyk added a comment. Aside from the comment made by Victor, also LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111229/new/ https://reviews.llvm.org/D111229 __

[PATCH] D110935: [NFC] Update vec_extract builtin signatures to take signed int.

This revision was automatically updated to reflect the committed changes. Closed by commit rG03bfddae5080: [NFC] Update vec_extract builtin signatures to take signed int. (authored by amyk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110935/new/

[PATCH] D109652: [PowerPC] Restrict various P10 options to P10 only.

amyk added a comment. Ping @lei. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109652/new/ https://reviews.llvm.org/D109652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D110934: [NFC] Update return type of vec_popcnt to vector unsigned.

This revision was automatically updated to reflect the committed changes. Closed by commit rG74b1ac7155a0: [NFC] Update return type of vec_popcnt to vector unsigned. (authored by amyk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110934/new/ https

[PATCH] D110428: [AIX] Define WCHAR_T_TYPE as unsigned short on AIX for wchar.c test case.

This revision was automatically updated to reflect the committed changes. Closed by commit rG49dbde9c9e51: [AIX] Define WCHAR_T_TYPE as unsigned short on AIX for wchar.c test case. (authored by amyk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110

[PATCH] D110428: [AIX] Define WCHAR_T_TYPE as unsigned short on AIX for wchar.c test case.

amyk updated this revision to Diff 376723. amyk added a comment. Addressed comment made by @daltenty. Update the patch to account set the wchar type to `unsigned short` only on 32-bit AIX. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110428/new/

[PATCH] D109652: [PowerPC] Restrict various P10 options to P10 only.

amyk added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109652/new/ https://reviews.llvm.org/D109652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D110428: [AIX] Define WCHAR_T_TYPE as unsigned short on AIX for wchar.c test case.

amyk added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110428/new/ https://reviews.llvm.org/D110428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D110935: [NFC] Update vec_extract builtin signatures to take signed int.

amyk created this revision. amyk added reviewers: PowerPC, nemanjai, stefanp. amyk added projects: LLVM, PowerPC, clang. amyk requested review of this revision. This patch updates the vec_extract builtins to take a signed int as the second parameter, as defined by the Power Vector Intrinsics Prog

[PATCH] D110934: [NFC] Update return type of vec_popcnt to vector unsigned.

amyk created this revision. amyk added reviewers: PowerPC, nemanjai, stefanp. amyk added projects: LLVM, PowerPC, clang. amyk requested review of this revision. This patch updates the vec_popcnt builtins to take a signed int as the second parameter, as defined by the Power Vector Intrinsics Progr

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

amyk added a comment. Additional nits regarding comments. Comment at: llvm/test/CodeGen/PowerPC/test-vector-insert.ll:20 ; RUN: -mcpu=pwr9 < %s | FileCheck %s --check-prefix=CHECK-BE-P9 ; xscvdpsxws and uxws is only available on Power7 and above ; Codgen is different for LE

[PATCH] D109178: [PowerPC] Disable vector types when not supported by subtarget features

amyk accepted this revision. amyk added a comment. Overall LGTM. Comment at: clang/test/CodeGen/builtins-ppc-int128.c:7 +// RUN: -triple powerpc64le-unknown-unknown -target-cpu pwr8 \ +// RUN: -emit-llvm %s -o - -U__XL_COMPAT_ALTIVEC__ | FileCheck %s -check-prefix=CHECK-LE

[PATCH] D110273: [PowerPC] Fix lharx and lbarx builtin signatures

amyk added a comment. Additional nit regarding the description and comment: The signatures for the PowerPC builtins lharx and lbarx are incorrect, and causes issues when in a function that requiers the return of the builtin to be promoted. This patch fixes these signatures. Updated to: The sign

[PATCH] D110431: Explicitly specify -fintegrated-as to clang/test/Driver/compilation_database.c test case.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f5b60ad47f1: Explicitly specify -fintegrated-as to clang/test/Driver/compilation_database.c… (authored by amyk). Repository: rG LLVM Github Monor

[PATCH] D109652: [PowerPC] Restrict various P10 options to P10 only.

amyk updated this revision to Diff 374990. amyk edited the summary of this revision. amyk added a comment. Addressed Lei's review comments to output: error: option '-mpcrel' cannot be specified without '-mcpu=pwr10 -mprefixed' when PC-Rel is specified pre-P10. Also updated the comment for MMA

[PATCH] D110431: Explicitly specify -fintegrated-as to clang/test/Driver/compilation_database.c test case.

amyk created this revision. amyk added reviewers: hubert.reinterpretcast, daltenty, sammccall. amyk added a project: clang. amyk requested review of this revision. It appears that this test assumes that the toolchain utilizes the integrated assembler by default, since the expected output in the

[PATCH] D110428: [AIX] Define WCHAR_T_TYPE as unsigned short on AIX for wchar.c test case.

amyk created this revision. amyk added reviewers: hubert.reinterpretcast, daltenty, thakis. amyk added projects: clang, PowerPC. amyk requested review of this revision. The default wchar type is different on AIX vs. Linux. When this test is run on AIX, WCHAR_T_TYPE ends up being set to `int`. Thi

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

amyk accepted this revision as: amyk. amyk added a comment. This revision is now accepted and ready to land. LGTM. Thanks for addressing comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109902/new/ https://reviews.llvm.org/D109902 ___

[PATCH] D110282: [PowerPC] SemaChecking for darn family of builtins

amyk accepted this revision as: amyk. amyk added a comment. Thanks for updating the tests and description, Albion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110282/new/ https://reviews.llvm.org/D110282 ___ cfe-commits mailing list cfe-com

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

amyk accepted this revision as: amyk. amyk added a comment. LGTM as long as Lei's comment is addressed. Thanks Quinn! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109710/new/ https://reviews.llvm.org/D109710 __

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrVSX.td:2815 +def : Pat<(v4i32 (PPCSToV DblToUInt.A)), + (v4i32 (SUBREG_TO_REG (i64 1), (XSCVDPSXWS f64:$A), sub_64))>; defm : ScalToVecWPermute< This should be `XSCVDPUXWS`? =

[PATCH] D110282: [PowerPC] SemaChecking for darn family of builtins

amyk added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-darn-32.c:13 +int testdarn_32(void) { + return __darn_32(); +} Conanap wrote: > amyk wrote: > > lei wrote: > > > Isn't this valid for both 32 and 64bit? > > > Maybe change one of th

[PATCH] D110282: [PowerPC] SemaChecking for darn family of builtins

amyk added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-darn-32.c:13 +int testdarn_32(void) { + return __darn_32(); +} lei wrote: > Isn't this valid for both 32 and 64bit? > Maybe change one of the run lines above to a 64bit test. I agre

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

amyk added a comment. `builtins-ppc-p10vector.c` looks like it needs to be updated from the failing test case. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:1373 vector signed int test_vec_vec_splati_ins_si(void) { + // CHECK-BE: [[T0:%.+]]] = and %{{.+}}, i32 1

[PATCH] D108823: [PowerPC] Mark splat immediate instructions as rematerializable

amyk added a comment. A question I have is, I noticed there are some test case changes involving `xxspltidp` and `xxsplti32dx`, but are additional tests needed for `xxspltiw`? Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:1887 // XXSPLI32DX needs extra flags to make

[PATCH] D109652: [PowerPC] Restrict various P10 options to P10 only.

amyk created this revision. amyk added reviewers: PowerPC, nemanjai, stefanp. amyk added projects: LLVM, PowerPC. Herald added subscribers: shchenz, kbarton. amyk requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch attempts to restri

[PATCH] D108302: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields.

amyk added a comment. Please update the patch with full context. Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp:1546 + // into a select. + if (Register::isPhysicalRegister(Cond[1].getReg())) { +return false; nit: `uses a physical register` ===

[PATCH] D108702: [PowerPC][NFC] Rename P10 builtins vec_clrl, vec_clrr to vec_clr_first and vec_clr_last

amyk accepted this revision as: amyk. amyk added a comment. We wanted `vec_clr_first` to translate to vclrrb for LE, and to vclrlb for BE, and the opposite mapping for `vec_clr_last`, so I think this LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D107646: [PowerPC] Fix the frame addresss computing return address for `__builtin_return_address`

amyk added inline comments. Comment at: llvm/test/CodeGen/PowerPC/retaddr_multi_levels.ll:2 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -verify-machineinstrs < %s -mtriple=powerpc64le-unknown-linux -mcpu=pwr8 | FileCheck %s -check-p

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

amyk added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1436 + +def int_ppc_ftdivdp : Intrinsic<[llvm_i32_ty], [llvm_double_ty, llvm_double_ty], [IntrNoMem]>; } Line too long? Comment at: llvm/include/llvm/IR/Intrins

[PATCH] D107138: [PowerPC] Implement cmplxl builtins

amyk added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-complex.c:35 + // CHECK-NEXT: %1 = load ppc_fp128, ppc_fp128* @ldb + // CHECK-NEXT: %.fca.0.insert = insertvalue { ppc_fp128, ppc_fp128 } undef, ppc_fp128 %0, 0 + // CHECK-NEXT: %.fca.1.insert =

[PATCH] D106410: [PowerPC] Emit error for Altivec vector initializations when -faltivec-src-compat=gcc is specified

amyk marked an inline comment as done. amyk added a comment. Addressed Nemanja's comment on the commit. https://reviews.llvm.org/rG5ea6117a9e9eae49ad1295fa422266ef3832e419 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106410/new/ https://reviews.l

[PATCH] D106410: [PowerPC] Emit error for Altivec vector initializations when -faltivec-src-compat=gcc is specified

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ea6117a9e9e: [PowerPC] Emit error for Altivec vector initializations when -faltivec-src… (authored by amyk). Changed prior to commit: https://rev

[PATCH] D106410: [PowerPC] Emit error for Altivec vector initializations when -faltivec-src-compat=gcc is specified

amyk added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106410/new/ https://reviews.llvm.org/D106410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D106817: [PowerPC] Changed sema checking range for tdw td builtin

amyk accepted this revision as: amyk. amyk added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106817/new/ https://reviews.llvm.org/D106817 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D106757: [PowerPC] Implement partial vector ld/st builtins for XL compatibility

amyk accepted this revision. amyk added a comment. Thanks for addressing the comment and adding back the tests! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106757/new/ https://reviews.llvm.org/D106757 _

[PATCH] D106757: [PowerPC] Implement partial vector ld/st builtins for XL compatibility

amyk added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15111 +if (IsLE) { + Constant *Zero = llvm::Constant::getNullValue(ResTy); + SmallVector Consts; Maybe we can pull out this line and do the following: ``` Constant *Zero = llvm:

[PATCH] D106410: [PowerPC] Emit error for Altivec vector initializations when -faltivec-src-compat=gcc is specified

amyk created this revision. amyk added reviewers: PowerPC, nemanjai, stefanp. amyk added projects: PowerPC, LLVM, clang. Herald added a subscriber: shchenz. amyk requested review of this revision. Under the `-faltivec-src-compat=gcc` option, AltiVec vector initialization should be treated as if t

  1   2   3   >