[PATCH] D138377: add clang_Type_getFullyQualifiedName

anderslanglands updated this revision to Diff 477399. anderslanglands added a comment. couple of little spaces I missed... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138377/new/ https://reviews.llvm.org/D138377 Files: clang/docs/ReleaseNotes.

[PATCH] D138377: add clang_Type_getFullyQualifiedName

anderslanglands updated this revision to Diff 477398. anderslanglands added a comment. Remove whitespace changes on unaffected lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138377/new/ https://reviews.llvm.org/D138377 Files: clang/docs/Rel

[PATCH] D138377: add clang_Type_getFullyQualifiedName

anderslanglands added inline comments. Comment at: clang/tools/c-index-test/c-index-test.c:1787 PrintCursor(cursor, NULL); + VisitorData *Data = (VisitorData *)d; PrintSingleTypeSize(T, " [type=%s] [typekind=%s]", " [sizeof=%lld]", anderslanglands wrote: >

[PATCH] D138377: add clang_Type_getFullyQualifiedName

anderslanglands added a comment. Re the whitespace - yeah that's me running clang-format on the whole function rather than just the lines I changed. I'll see if I can split those out. Comment at: clang/tools/c-index-test/c-index-test.c:1787 PrintCursor(cursor, NULL); + Vis

[PATCH] D138377: add clang_Type_getFullyQualifiedName

anderslanglands updated this revision to Diff 477085. anderslanglands added a comment. Now tested by adding a -print-qualified-type-names flag to c-index-test and creating a (small) dedicated test in print-qualified-type.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D137818: Add support for querying SubstTemplateTypeParm types

anderslanglands updated this revision to Diff 476935. anderslanglands added a comment. Move getReplacementType to LLVM_16 block Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137818/new/ https://reviews.llvm.org/D137818 Files: clang/docs/ReleaseN

[PATCH] D138377: add clang_Type_getFullyQualifiedName

anderslanglands created this revision. anderslanglands added a reviewer: aaron.ballman. Herald added a subscriber: arphaman. Herald added a project: All. anderslanglands requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Not sure how to test t

[PATCH] D137818: Add support for querying SubstTemplateTypeParm types

anderslanglands added a comment. Arg just noticed an issue: clang_Type_getReplacementType should be in the LLVM_16 block in libclang.map not in the LLVM_13 block. I've blown away my local branch so don't know how to fix the patch. Shall I just make a new patch once this is merged? Repository:

[PATCH] D137818: Add support for querying SubstTemplateTypeParm types

anderslanglands added a comment. Great, thanks! I've got a couple more things to land once this is merged and I've cleaned them up. Do you wanna show me how to do the merge myself? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137818/new/ https://

[PATCH] D137818: Add support for querying SubstTemplateTypeParm types

anderslanglands updated this revision to Diff 476261. anderslanglands added a comment. Added release note, incorporated other review notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137818/new/ https://reviews.llvm.org/D137818 Files: clang/do

[PATCH] D137818: Add support for querying SubstTemplateTypeParm types

anderslanglands created this revision. anderslanglands added reviewers: tbaeder, aaron.ballman. Herald added subscribers: arphaman, kristof.beyls. Herald added a project: All. anderslanglands requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

anderslanglands added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration dblaikie wrote: > aaron.ballman wro

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

anderslanglands added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration dblaikie wrote: > royjacobson wrote

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

anderslanglands added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration dblaikie wrote: > aaron.ballman wro

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

anderslanglands added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration dblaikie wrote: > aaron.ballman wro

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

anderslanglands added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration royjacobson wrote: > anderslangland

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

anderslanglands added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration royjacobson wrote: > aaron.ballman

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

anderslanglands updated this revision to Diff 48. anderslanglands added a comment. Fixed clang-format error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135557/new/ https://reviews.llvm.org/D135557 Files: clang/bindings/python/clang/cindex.

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

anderslanglands created this revision. Herald added a subscriber: arphaman. Herald added a project: All. anderslanglands requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Wraps CXXRecord::needsImplicitDefaultConstructor, needsImplicitCopyCons

[PATCH] D134416: Allow getting template args for ClassTemplateSpecializations

anderslanglands added a comment. I ended up modifying c-index-test to print out the template arguments in the same way it does for FunctionDecl, which ends up working all cases in the existing test suite. The only other thing I added was a specific case in index-templates.cpp to check whether i

[PATCH] D134416: Allow getting template args for ClassTemplateSpecializations

anderslanglands updated this revision to Diff 462392. anderslanglands marked 7 inline comments as done. anderslanglands added a comment. Add testing, address style notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134416/new/ https://reviews.llvm

[PATCH] D134416: Allow getting template args for ClassTemplateSpecializations

anderslanglands updated this revision to Diff 462103. anderslanglands added a comment. Herald added a subscriber: arphaman. Updating doc comments to reflect new functionality Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134416/new/ https://reviews

[PATCH] D134416: Allow getting template args for ClassTemplateSpecializations

anderslanglands added reviewers: tbaeder, aaron.ballman. anderslanglands added a comment. Hello again, this generalizes the template argument functionality to operate on cursor kinds other than functions. I could use some help creating a test for this. On my previous path I was able to just cop

[PATCH] D134416: Allow getting template args for ClassTemplateSpecializations

anderslanglands created this revision. Herald added a project: All. anderslanglands requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Modifies clang_Cursor_getNumTemplateArguments() and friends to work on Struct, Class and ClassTemplateParti

[PATCH] D133924: add clang_CXXMethod_isDeleted function

anderslanglands added a comment. Yes it's probably safest if someone commits on my behalf, unless someone's got time to walk me through it. Just use Anders Langlands anderslanga...@gmail.com for attribution please. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D133924: add clang_CXXMethod_isDeleted function

anderslanglands updated this revision to Diff 460865. anderslanglands added a comment. Adding missing backtick Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133924/new/ https://reviews.llvm.org/D133924 Files: clang/bindings/python/clang/cindex.p

[PATCH] D133924: add clang_CXXMethod_isDeleted function

anderslanglands added a comment. OK that should all be good now. Thanks for your patience, it's my first time doing all this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133924/new/ https://reviews.llvm.org/D133924 _

[PATCH] D133924: add clang_CXXMethod_isDeleted function

anderslanglands updated this revision to Diff 460672. anderslanglands added a comment. Adding in the dyn_cast_is_present change I missed on the previous one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133924/new/ https://reviews.llvm.org/D133924

[PATCH] D133924: add clang_CXXMethod_isDeleted function

anderslanglands updated this revision to Diff 460663. anderslanglands added a comment. squashing all commits into one to hopefully fix the revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133924/new/ https://reviews.llvm.org/D133924 Files:

[PATCH] D133991: add new function to release notes

anderslanglands added a comment. Sorry, this was supposed to update https://reviews.llvm.org/D13392. How do I delete this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133991/new/ https://reviews.llvm.org/D133991

[PATCH] D133924: add clang_CXXMethod_isDeleted function

anderslanglands updated this revision to Diff 460549. anderslanglands added a comment. Updating based on review - Add new function to release notes - Fix failing test and add a new test specifically for this function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D133991: add new function to release notes

anderslanglands created this revision. Herald added a subscriber: arphaman. Herald added a project: All. anderslanglands requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. fix copy/paste error in doc comment fix failing test now deleted is su

[PATCH] D133924: add clang_CXXMethod_isDeleted function

anderslanglands created this revision. Herald added a subscriber: arphaman. Herald added a project: All. anderslanglands requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D133924