[PATCH] D153220: [clang-tidy] Improve `performance-move-const-arg` message when no move constructor is available

AMS21 added a comment. As always if there are no more problems, I would kindly ask for someone to push this on my behalf :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153220/new/ https://reviews.llvm.org/D153220

[PATCH] D153220: [clang-tidy] Improve `performance-move-const-arg` message when no move constructor is available

AMS21 updated this revision to Diff 532467. AMS21 added a comment. Improve doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153220/new/ https://reviews.llvm.org/D153220 Files: clang-tools-extra/clang-tidy/performance/MoveConstArgCheck.cpp

[PATCH] D153220: [clang-tidy] Improve `performance-move-const-arg` message when no move constructor is available

AMS21 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance/move-const-arg.cpp:345 +namespace issue_62550 { + +struct NonMoveConstructable { PiotrZSL wrote: > AMS21 wrote: > > I've tried to add > > > > ``` > > //

[PATCH] D153220: [clang-tidy] Improve `performance-move-const-arg` message when no move constructor is available

AMS21 updated this revision to Diff 532466. AMS21 marked 2 inline comments as done. AMS21 added a comment. Implemented suggested changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153220/new/ https://reviews.llvm.org/D153220 Files:

[PATCH] D153218: [clang-tidy] Fix `llvmlibc-inline-function-decl` false positives for templated function definitions

AMS21 added a comment. If there are no more problems, I would kindly as for someone to push this on my behalf :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153218/new/ https://reviews.llvm.org/D153218

[PATCH] D153220: [clang-tidy] Improve `performance-move-const-arg` message when no move constructor is available

AMS21 updated this revision to Diff 532458. AMS21 marked 5 inline comments as done. AMS21 added a comment. Implement suggested changes Add tests with typedefs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153220/new/

[PATCH] D153218: [clang-tidy] Fix `llvmlibc-inline-function-decl` false positives for templated function definitions

AMS21 added a comment. Regarding the problems with attributes like nodiscard. I'm honestly not quite sure, but from the way the check is implemented and the warning is worded, it sounds to me like the attributes should come after LIBC_INLINE. Although looking at the Styleguide for libc, I

[PATCH] D153218: [clang-tidy] Fix `llvmlibc-inline-function-decl` false positives for templated function definitions

AMS21 updated this revision to Diff 532455. AMS21 added a comment. Implemented suggested fix and added a test case Added entry to ReleaseNotes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153218/new/ https://reviews.llvm.org/D153218 Files:

[PATCH] D153220: [clang-tidy] Improve `performance-move-const-arg` message when no move constructor is available

AMS21 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance/move-const-arg.cpp:345 +namespace issue_62550 { + +struct NonMoveConstructable { I've tried to add ``` // CHECK-MESSAGES: [[@LINE+1]]:1: note:

[PATCH] D153220: [clang-tidy] Improve `performance-move-const-arg` message when no move constructor is available

AMS21 created this revision. AMS21 added reviewers: PiotrZSL, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. AMS21 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D153218: [clang-tidy] Fix `llvmlibc-inline-function-decl` false positives for templated function definitions

AMS21 created this revision. AMS21 added reviewers: PiotrZSL, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. AMS21 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D153198: [clang-tidy] Refactor common code from the Noexcept*Checks into `NoexceptFunctionCheck`

AMS21 added a comment. If there are no more problems, I would kindly ask for someone to push this no my behalf :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153198/new/ https://reviews.llvm.org/D153198

[PATCH] D153198: [clang-tidy] Refactor common code from the Noexcept*Checks into `NoexceptFunctionCheck`

AMS21 updated this revision to Diff 532414. AMS21 marked an inline comment as done. AMS21 added a comment. So somehow I didn't add the actual `BaseNoexceptFunctionCheck` files, thats why the build failed. Also implemented the two new suggestions. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D153198: [clang-tidy] Refactor common code from the Noexcept*Checks into `NoexceptFunctionCheck`

AMS21 updated this revision to Diff 532394. AMS21 marked 3 inline comments as done. AMS21 added a comment. Implement suggested changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153198/new/ https://reviews.llvm.org/D153198 Files:

[PATCH] D153198: [clang-tidy] Refactor common code from the Noexcept*Checks into `NoexceptFunctionCheck`

AMS21 created this revision. AMS21 added a reviewer: PiotrZSL. Herald added subscribers: ChuanqiXu, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. AMS21 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D152852: [clang-tidy] Fix wrong code generation for `modernize-loop-convert` with structured bindings.

AMS21 marked an inline comment as done. AMS21 added a comment. If there are no more problems, I would kindly ask for someone to push this on my behalf :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152852/new/ https://reviews.llvm.org/D152852

[PATCH] D152852: [clang-tidy] Fix wrong code generation for `modernize-loop-convert` with structured bindings.

AMS21 updated this revision to Diff 531274. AMS21 added a comment. Use dyn_cast Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152852/new/ https://reviews.llvm.org/D152852 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp

[PATCH] D152852: [clang-tidy] Fix wrong code generation for `modernize-loop-convert` with structured bindings.

AMS21 updated this revision to Diff 531042. AMS21 added a comment. Remove debug code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152852/new/ https://reviews.llvm.org/D152852 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp

[PATCH] D152852: [clang-tidy] Fix wrong code generation for `modernize-loop-convert` with structured bindings.

AMS21 created this revision. AMS21 added reviewers: PiotrZSL, njames93, carlosgalvezp. Herald added subscribers: ChuanqiXu, xazax.hun. Herald added a project: All. AMS21 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fixes

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

AMS21 added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/NoexceptSwapCheck.cpp:21 + Finder->addMatcher( + functionDecl(unless(isImplicit()), unless(isDeleted()), hasName("swap")) + .bind("decl"), PiotrZSL wrote: > i dont

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

AMS21 updated this revision to Diff 531005. AMS21 marked 3 inline comments as done. AMS21 added a comment. Implement the suggested changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148697/new/ https://reviews.llvm.org/D148697 Files:

[PATCH] D152802: [clang-tidy] Fix crash in `modernize-use-default-member-init`

AMS21 added a comment. Great, would someone be so kind and push this on by behalf :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152802/new/ https://reviews.llvm.org/D152802 ___ cfe-commits mailing

[PATCH] D152825: [clang-tidy] Fix false positive in `readability-named-parameter` for defaulted out-of-line special member functions

AMS21 added a comment. Great, would someone be so kind and push this on my behalf :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152825/new/ https://reviews.llvm.org/D152825 ___ cfe-commits mailing

[PATCH] D152825: [clang-tidy] Fix false positive in `readability-named-parameter` for defaulted out-of-line special member functions This fixes llvm#63056

AMS21 created this revision. AMS21 added reviewers: PiotrZSL, njames93, carlosgalvezp, eugene. Herald added a subscriber: xazax.hun. Herald added a project: All. AMS21 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D152802: [clang-tidy] Fix crash in `modernize-use-default-member-init`

AMS21 updated this revision to Diff 530921. AMS21 marked an inline comment as done. AMS21 added a comment. Should now properly handle arrays Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152802/new/ https://reviews.llvm.org/D152802 Files:

[PATCH] D152802: [clang-tidy] Fix crash in `modernize-use-default-member-init`

AMS21 updated this revision to Diff 530892. AMS21 marked an inline comment as done. AMS21 added a comment. Still issue a warning just no fixit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152802/new/ https://reviews.llvm.org/D152802 Files:

[PATCH] D152802: [clang-tidy] Fix crash in `modernize-use-default-member-init`

AMS21 created this revision. AMS21 added reviewers: PiotrZSL, njames93, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. AMS21 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This was causes by

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

AMS21 added a comment. Patch is now open for 2+ weeks. If there are no more reviews, I would kindly ask for someone to push this on my behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148697/new/ https://reviews.llvm.org/D148697

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

AMS21 updated this revision to Diff 526327. AMS21 added a comment. Removed unrelated change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148697/new/ https://reviews.llvm.org/D148697 Files:

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

AMS21 updated this revision to Diff 526326. AMS21 marked 2 inline comments as done. AMS21 added a comment. Rename `cppcoreguidelines-noexcept-move-constructor` to `cppcoreguidelines-noexcept-move-operations` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

AMS21 added a comment. Bumping to ask for reviews Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148697/new/ https://reviews.llvm.org/D148697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148697: [clang-tidy] Handle more cases of functions which should always be noexcept

AMS21 updated this revision to Diff 518278. AMS21 marked an inline comment as done. AMS21 added a comment. Split the changes into 2 new checks and added cppcoreguidelines aliases for all of them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

AMS21 added a comment. If someone could be so kind as to push this on my behalf, it would be greatly appreciated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148318/new/ https://reviews.llvm.org/D148318

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

AMS21 added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/AvoidEndlCheck.cpp:48-51 +const CharSourceRange TokenRange = +CharSourceRange::getTokenRange(Expression->getSourceRange()); +const StringRef SourceText = Lexer::getSourceText( +

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

AMS21 updated this revision to Diff 515283. AMS21 marked 12 inline comments as done. AMS21 added a comment. Implement suggested changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148318/new/ https://reviews.llvm.org/D148318 Files:

[PATCH] D148697: [clang-tidy] Handle more cases of functions which should always be noexcept

AMS21 added a comment. Well first of all thanks for the feedback. I agree not renaming a check which is already used and splitting each special case into it's own check seems like the easier and better way to go. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

AMS21 updated this revision to Diff 514908. AMS21 added a comment. Minor code cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148318/new/ https://reviews.llvm.org/D148318 Files: clang-tools-extra/clang-tidy/performance/AvoidEndlCheck.cpp

[PATCH] D148697: [clang-tidy] Handle more cases of functions which should always be noexcept

AMS21 created this revision. AMS21 added reviewers: PiotrZSL, njames93. Herald added subscribers: carlosgalvezp, kbarton, xazax.hun, nemanjai. Herald added a project: All. AMS21 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits.

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

AMS21 updated this revision to Diff 514367. AMS21 added a comment. Fix docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148318/new/ https://reviews.llvm.org/D148318 Files: clang-tools-extra/clang-tidy/performance/AvoidEndlCheck.cpp

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

AMS21 updated this revision to Diff 514366. AMS21 added a comment. Handle the function calling case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148318/new/ https://reviews.llvm.org/D148318 Files:

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

AMS21 added a comment. I've also notices that we don't handle this case std::endl(std::cout); Although a rather unusual thing to use, its still valid and has the same problems. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148318/new/

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

AMS21 updated this revision to Diff 514118. AMS21 added a comment. Remove std::ends from the check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148318/new/ https://reviews.llvm.org/D148318 Files:

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

AMS21 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance/avoid-endl.cpp:46 +void bad() { + std::cout << "World" << std::endl; + // CHECK-MESSAGES: :[[@LINE-1]]:27: warning: do not use std::endl with iostreams; use '\n' instead

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

AMS21 updated this revision to Diff 513878. AMS21 marked 12 inline comments as done. AMS21 added a comment. Implement suggested fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148318/new/ https://reviews.llvm.org/D148318 Files:

[PATCH] D148318: [clang-tidy] Add `performance-dont-use-endl` check

AMS21 updated this revision to Diff 513582. AMS21 added a comment. Rename to `performance-avoid-endl` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148318/new/ https://reviews.llvm.org/D148318 Files:

[PATCH] D148318: [clang-tidy] Add `performance-dont-use-endl` check

AMS21 added a comment. This check is mostly working. Added notes about problems I know about. Comment at: clang-tools-extra/clang-tidy/performance/DontUseEndlCheck.cpp:44 + Diag << FixItHint::CreateReplacement( + CharSourceRange::getCharRange(EndlCall->getSourceRange()),

[PATCH] D148318: [clang-tidy] Add `performance-dont-use-endl` check

AMS21 created this revision. AMS21 added a reviewer: PiotrZSL. Herald added subscribers: ChuanqiXu, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. AMS21 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 added a comment. I'm fine with pushing this change, but since I don't have commit access someone would need to commit this for me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146922/new/ https://reviews.llvm.org/D146922

[PATCH] D147383: [clang-tidy] Allow bugprone-unchecked-optional-access to handle calls to `std::forward`

AMS21 added a comment. Now I would kindly as for someone to commit this on my behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147383/new/ https://reviews.llvm.org/D147383 ___ cfe-commits mailing

[PATCH] D147383: [clang-tidy] Allow bugprone-unchecked-optional-access to handle calls to `std::forward`

AMS21 updated this revision to Diff 510698. AMS21 marked an inline comment as done. AMS21 added a comment. Remove unneccesary braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147383/new/ https://reviews.llvm.org/D147383 Files:

[PATCH] D147376: [clang-tidy] Small refactor for ExceptionAnalyzer

AMS21 added a comment. In D147376#4239421 , @PiotrZSL wrote: > LGTM. I would kindly ask for someone to commit this on my behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147376/new/

[PATCH] D147411: [clang-tidy] Fix readability-static-accessed-through-instance check for anonymous structs

AMS21 added a comment. In D147411#4241016 , @PiotrZSL wrote: > LGTM, will you commit this or want someone else to commit this ? As I don't have access to the repository. I need someone else to commit it. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D147411: [clang-tidy] Fix readability-static-accessed-through-instance check for anonymous structs

AMS21 updated this revision to Diff 510537. AMS21 marked 2 inline comments as done. AMS21 added a comment. Implement suggested way of checking for anonymous structs Add a new more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147411/new/

[PATCH] D147411: [clang-tidy] Fix readability-static-accessed-through-instance check for anonymous structs

AMS21 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/StaticAccessedThroughInstanceCheck.cpp:78 + // Ignore anonymous structs/classes + if (StringRef(BaseTypeName).contains("(unnamed ")) +return; I wonder if there's a cleaner

[PATCH] D147411: [clang-tidy] Fix readability-static-accessed-through-instance check for anonymous structs

AMS21 created this revision. AMS21 added reviewers: PiotrZSL, njames93, Eugene.Zelenko. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. AMS21 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits.

[PATCH] D147383: [clang-tidy] Allow bugprone-unchecked-optional-access to handle calls to `std::forward`

AMS21 created this revision. AMS21 added reviewers: PiotrZSL, njames93, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. AMS21 requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a

[PATCH] D147376: [clang-tidy] Small refactor for ExceptionAnalyzer

AMS21 created this revision. AMS21 added a reviewer: njames93. Herald added subscribers: PiotrZSL, carlosgalvezp, manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware, xazax.hun. Herald added a project: All. AMS21 requested review of this revision. Herald added a

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/NoexceptMoveConstructorCheck.cpp:45-49 +const auto *ProtoType = Decl->getType()->castAs(); +const Expr *NoexceptExpr = ProtoType->getNoexceptExpr(); +if (NoexceptExpr) { +

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 updated this revision to Diff 509911. AMS21 marked 3 inline comments as done. AMS21 added a comment. Fixed docs and cleanup tests a bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146922/new/ https://reviews.llvm.org/D146922 Files:

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:260 +- Fixed an issue in :doc:`performance-noexcept-move-constructor + ` which resulted in false Eugene.Zelenko wrote: > Please keep alphabetical order (by check name) in this

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/NoexceptMoveConstructorCheck.cpp:45-49 +const auto *ProtoType = Decl->getType()->castAs(); +const Expr *NoexceptExpr = ProtoType->getNoexceptExpr(); +if (NoexceptExpr) { +

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 updated this revision to Diff 509695. AMS21 marked 15 inline comments as done. AMS21 added a comment. Implement review suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146922/new/ https://reviews.llvm.org/D146922 Files:

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 updated this revision to Diff 509417. AMS21 added a comment. Use llvm::DenseMap instead of std::map Add some more test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146922/new/ https://reviews.llvm.org/D146922 Files:

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 marked 2 inline comments as done. AMS21 added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/NoexceptMoveConstructorCheck.cpp:21 + +enum CanMoveConstrcutorThrowResult { + CMCT_CanThrow,///< We are sure the move constructor can throw

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 updated this revision to Diff 509409. AMS21 marked 8 inline comments as done. AMS21 added a comment. Sprinkle some more `const` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146922/new/ https://reviews.llvm.org/D146922 Files:

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 added a comment. Looking around I've found the `ExceptionAnalyzer` class inside utils. In D146922#4227832 , @PiotrZSL wrote: > Try refactoring code a lite bit, check suggestions, add tests for typedefs, > and inheritance from template type. I'm

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 updated this revision to Diff 509405. AMS21 marked an inline comment as done. AMS21 added a comment. Herald added a subscriber: ChuanqiXu. Move functionality to a seperate file Also the noexcept move constrcutor check now only runs with exceptions enabled like other checks. Repository:

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 updated this revision to Diff 509013. AMS21 added a comment. Implemented suggested fixes from reviews Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146922/new/ https://reviews.llvm.org/D146922 Files:

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 added a comment. @PiotrZSL thanks for the quick response. I've tried to work on the `Field` test case but seem to have hit a roadblock. From what I can see the `FunctionProtoType` exception specificaion is `EST_Unevaluated` which causes it to give up because of the check on Line 41. I'm

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 created this revision. AMS21 added a reviewer: njames93. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a project: All. AMS21 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Previously a struct