[PATCH] D108424: [NFC][clang] Move multiversion resolver code generation to llvm/ subdirectory

2021-09-03 Thread Andrei Elovikov via Phabricator via cfe-commits
a.elovikov added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108424/new/ https://reviews.llvm.org/D108424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D108424: [NFC][clang] Move multiversion resolver code generation to llvm/ subdirectory

2021-08-30 Thread Andrei Elovikov via Phabricator via cfe-commits
a.elovikov updated this revision to Diff 369485. a.elovikov added a comment. Rebase + ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108424/new/ https://reviews.llvm.org/D108424 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/Code

[PATCH] D108423: [NFC][clang] Move IR-independent parts of target MV support to X86TargetParser.cpp

2021-08-30 Thread Andrei Elovikov via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1724a164378f: [NFC][clang] Move IR-independent parts of target MV support to X86TargetParser. (authored by a.elovikov). Changed prior to commit: h

[PATCH] D108423: [NFC][clang] Move IR-independent parts of target MV support to X86TargetParser.cpp

2021-08-26 Thread Andrei Elovikov via Phabricator via cfe-commits
a.elovikov added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108423/new/ https://reviews.llvm.org/D108423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D108423: [NFC][clang] Move IR-independent parts of target MV support to X86TargetParser.cpp

2021-08-24 Thread Andrei Elovikov via Phabricator via cfe-commits
a.elovikov updated this revision to Diff 368390. a.elovikov added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108423/new/ https://reviews.llvm.org/D108423 Files: clang/lib/Basic/Targets/X86.cpp clang/lib/CodeGen/CGBuiltin.c

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

2021-08-24 Thread Andrei Elovikov via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf387a3617860: [NFC][clang] Move remaining part of X86Target.def to… (authored by a.elovikov). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

2021-08-23 Thread Andrei Elovikov via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf5c288948844: [NFC][clang] Use X86 Features declaration from X86TargetParser (authored by a.elovikov). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

2021-08-23 Thread Andrei Elovikov via Phabricator via cfe-commits
a.elovikov updated this revision to Diff 368164. a.elovikov added a comment. Address Erich's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108151/new/ https://reviews.llvm.org/D108151 Files: clang/include/clang/Basic/X86Target.def cla

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

2021-08-23 Thread Andrei Elovikov via Phabricator via cfe-commits
a.elovikov marked an inline comment as done. a.elovikov added a comment. Hi guys, do you want me to fix anything else? I think I've addressed what I could. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108151/new/ https://reviews.llvm.org/D108151

[PATCH] D108424: [NFC][clang] Move multiversion resolver code generation to llvm/ subdirectory

2021-08-20 Thread Andrei Elovikov via Phabricator via cfe-commits
a.elovikov updated this revision to Diff 367890. a.elovikov added a comment. Fix a bug with not saving builder's insertion point. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108424/new/ https://reviews.llvm.org/D108424 Files: clang/lib/CodeGen

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

2021-08-20 Thread Andrei Elovikov via Phabricator via cfe-commits
a.elovikov updated this revision to Diff 367821. a.elovikov added a comment. Remove stale FIXME comment in the code being moved Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108422/new/ https://reviews.llvm.org/D108422 Files: clang/include/clang

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

2021-08-20 Thread Andrei Elovikov via Phabricator via cfe-commits
a.elovikov added inline comments. Comment at: llvm/include/llvm/Support/X86TargetParser.def:220 + +// FIXME: When commented out features are supported in LLVM, enable them here. +CPU_SPECIFIC("generic", 'A', "") craig.topper wrote: > erichkeane wrote: > > RKSimon

[PATCH] D108424: [NFC][clang] Move multiversion resolver code generation to llvm/ subdirectory

2021-08-19 Thread Andrei Elovikov via Phabricator via cfe-commits
a.elovikov created this revision. a.elovikov added reviewers: erichkeane, craig.topper. Herald added subscribers: pengfei, hiraditya, tpr, mgorny. a.elovikov requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Some part of the

[PATCH] D108423: [NFC][clang] Move IR-independent parts of target MV support to X86TargetParser.cpp

2021-08-19 Thread Andrei Elovikov via Phabricator via cfe-commits
a.elovikov created this revision. a.elovikov added reviewers: erichkeane, craig.topper. Herald added a subscriber: hiraditya. a.elovikov requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. ...that is located under llvm/lib/Sup

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

2021-08-19 Thread Andrei Elovikov via Phabricator via cfe-commits
a.elovikov created this revision. a.elovikov added reviewers: erichkeane, craig.topper. a.elovikov requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108422 Fi

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

2021-08-19 Thread Andrei Elovikov via Phabricator via cfe-commits
a.elovikov marked 3 inline comments as done. a.elovikov added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:1071 +assert(llvm::is_contained(Priorities, Priority) && + "Priorites don't form consequtive range!"); + } erichkeane wrote:

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

2021-08-19 Thread Andrei Elovikov via Phabricator via cfe-commits
a.elovikov updated this revision to Diff 367640. a.elovikov added a comment. Apply reviewers' suggestions. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108151/new/ https://reviews.llvm.org/D108151 Files: clang/include/clang/Basic/X86Tar

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

2021-08-16 Thread Andrei Elovikov via Phabricator via cfe-commits
a.elovikov updated this revision to Diff 366760. a.elovikov added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Another version. My main goal here is to gradually move more stuff from clang/ to llvm/ so I'm open to other suggestions in doing so. Repository:

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

2021-08-16 Thread Andrei Elovikov via Phabricator via cfe-commits
a.elovikov created this revision. a.elovikov added reviewers: erichkeane, craig.topper. Herald added a subscriber: pengfei. a.elovikov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ...instead of redeclaring them in clang's own X86Target.d

[PATCH] D50963: [NFC] Don't define static function in header (UninitializedObject.h)

2018-08-20 Thread Andrei Elovikov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL340174: [NFC] Don't define static function in header (UninitializedObject.h) (authored by a.elovikov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D50963: [NFC] Don't define static function in header (UninitializedObject.h)

2018-08-20 Thread Andrei Elovikov via Phabricator via cfe-commits
a.elovikov created this revision. a.elovikov added reviewers: Szelethus, erichkeane. See also http://lists.llvm.org/pipermail/cfe-users/2016-January/000854.html for the reasons why it's bad. https://reviews.llvm.org/D50963 Files: clang/lib/StaticAnalyzer/Checkers/UninitializedObject/Uninitial

[PATCH] D50056: [NFC] Silence warning about ptr-to-func to ptr-to-obj cast in clang-fuzzer/handle-llvm/handle_llvm.cpp.

2018-08-01 Thread Andrei Elovikov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC338551: [NFC] Silence warning about ptr-to-func to ptr-to-obj cast in clang… (authored by a.elovikov, committed by ). Changed prior to commit: https://reviews.llvm.org/D50056?vs=158483&id=158527#toc Re

[PATCH] D50056: [NFC] Silence warning about ptr-to-func to ptr-to-obj cast in clang-fuzzer/handle-llvm/handle_llvm.cpp.

2018-08-01 Thread Andrei Elovikov via Phabricator via cfe-commits
a.elovikov updated this revision to Diff 158483. a.elovikov added a comment. - Address Erich's comment + clang-format. https://reviews.llvm.org/D50056 Files: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp Index: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp

[PATCH] D50056: [NFC] Silence warning about ptr-to-func to ptr-to-obj cast in clang-fuzzer/handle-llvm/handle_llvm.cpp.

2018-07-31 Thread Andrei Elovikov via Phabricator via cfe-commits
a.elovikov created this revision. a.elovikov added reviewers: emmettneyman, erichkeane. I don't have the whole list of GCC binaries available so I determined the exact version where the warning disappeared via: https://github.com/gcc-mirror/gcc/blob/gcc-4_9_0-release/gcc/cp/typeck.c#L6863 https:/