[PATCH] D46664: Fix null MSInheritanceAttr deref in CXXRecordDecl::getMSInheritanceModel()

2018-05-31 Thread Andrew Rogers via Phabricator via cfe-commits
adr26 added a comment. That's a nice change to avoid duplication in `ClassTemplateSpecializationDecl::getMostRecentDecl()`. Thanks for your help getting this out the door! Repository: rC Clang https://reviews.llvm.org/D46664 ___ cfe-commits mai

[PATCH] D46664: Fix null MSInheritanceAttr deref in CXXRecordDecl::getMSInheritanceModel()

2018-05-31 Thread Andrew Rogers via Phabricator via cfe-commits
adr26 updated this revision to Diff 149300. adr26 added a comment. Hi Reid, I've added testcases matching the issues I hit in `microsoft-abi-member-pointers.cpp` (no change to the rest of the fix). If you are happy with this, please feel free to push. I checked with MSVC, and as per the added

[PATCH] D46664: Fix null MSInheritanceAttr deref in CXXRecordDecl::getMSInheritanceModel()

2018-05-22 Thread Andrew Rogers via Phabricator via cfe-commits
adr26 updated this revision to Diff 148044. adr26 added a comment. Update to change MSInheritanceAttr to always be attached to the latest non-injected class name decl, as suggested by Reid. https://reviews.llvm.org/D46664 Files: include/clang/AST/DeclCXX.h lib/AST/MicrosoftMangle.cpp lib

[PATCH] D46664: Fix null MSInheritanceAttr deref in CXXRecordDecl::getMSInheritanceModel()

2018-05-09 Thread Andrew Rogers via Phabricator via cfe-commits
adr26 created this revision. adr26 added a reviewer: rnk. adr26 added a project: clang. Herald added a subscriber: cfe-commits. Ensure latest MPT decl has a MSInheritanceAttr when instantiating templates, to avoid null MSInheritanceAttr deref in CXXRecordDecl::getMSInheritanceModel(). See PR#373