asl wrote:
Tagging @slydiman @vvereschaka
https://github.com/llvm/llvm-project/pull/94208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
asl wrote:
@kbeyls Will you please summarize briefly what we discussed on the sync call
from the license standpoint?
https://github.com/llvm/llvm-project/pull/93902
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -15,6 +15,29 @@ typedef enum {
ptrauth_key_asib = 1,
ptrauth_key_asda = 2,
ptrauth_key_asdb = 3,
+
+#ifdef __APPLE__
asl wrote:
I believe these are defaults for ELF as well. So, I'd remove ifdef and decide
on necessary gating when there will be a
https://github.com/asl approved this pull request.
Ok from the generic point of view. I cannot judge if wasm-related part is ok
though :)
https://github.com/llvm/llvm-project/pull/92192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -20,7 +20,7 @@
.text
#endif
-#if !defined(__USING_SJLJ_EXCEPTIONS__)
+#if !defined(__USING_SJLJ_EXCEPTIONS__) && !defined(__wasm__)
asl wrote:
Ok. Then does the clang change really belong here?
`LIBUNWIND_USES_WASM_EXCEPTIONS` also seems to be unused.
@@ -20,7 +20,7 @@
.text
#endif
-#if !defined(__USING_SJLJ_EXCEPTIONS__)
+#if !defined(__USING_SJLJ_EXCEPTIONS__) && !defined(__wasm__)
asl wrote:
You are defining `__USING_WASM_EXCEPTIONS__`. Why you are not using it here and
everywhere else?
https://github.com/asl closed https://github.com/llvm/llvm-project/pull/91258
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/asl approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/91258
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/asl edited https://github.com/llvm/llvm-project/pull/91258
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
asl wrote:
> The python script should likely be up streamed as well. But where?
You could just put into `Target/MSP430`.
https://github.com/llvm/llvm-project/pull/91258
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/asl approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/86721
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
asl wrote:
Tagging @kovdan01
Can the triple checks be generalized to checking about pauth-enabled subtarget
feature? This way everything would work for ELF platforms eventually.
https://github.com/llvm/llvm-project/pull/84704
___
cfe-commits
asl wrote:
> Maybe `emitRawPointerFromAddress` is better. I see a lot of functions
> starting with `emit` in CodeGen.
Works for me!
https://github.com/llvm/llvm-project/pull/67454
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
asl wrote:
> I'm not sure `extractRawPointerFromAddress` conveys the fact that the
> function might do code-gen instead of just returning some pointer. I wonder
> if there's a better name.
>
> `computeRawPointerFromAddress` `genRawPointerFromAddress`
> `generateRawPointerFromAddress`
asl wrote:
We discussed the naming thing (`extractRawPointerFromAddress` vs
`getRawPointerFromAddress`) at pauth call and decided that it would be better
to do this renaming now. @ahmedbougacha will coordinate that renaming.
https://github.com/llvm/llvm-project/pull/67454
https://github.com/asl milestoned
https://github.com/llvm/llvm-project/pull/67454
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/asl milestoned
https://github.com/llvm/llvm-project/pull/65996
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
asl wrote:
I am ok with the changes. Though with pauth we'd probably need to rename
`getRawPointerFromAddress` to indicate clearer that it has side effects (like
`extractRawPointerFromAddress` or something like this)
https://github.com/llvm/llvm-project/pull/67454
@@ -159,14 +159,26 @@ declare i32 @bar(i32)
; SYM: Symbols [
; SYM-NEXT: Symbol {
; SYM-NEXT: Index: 0
-; SYM-NEXT: Name:
+; SYM-NEXT: Name: .file
; SYM-NEXT: Value (SymbolTableIndex): 0x0
; SYM-NEXT: Section: N_DEBUG
; SYM-NEXT: Source
asl wrote:
@nico How about revert?
https://github.com/llvm/llvm-project/pull/80162
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
asl wrote:
@stephenpeckham Apparently this was merged without waiting for buildkite
results or ignoring its results. Linux build failed due to obvious spelling
mistakes. Will you please next time wait until CI to finish?
Thanks!
https://github.com/llvm/llvm-project/pull/80162
asl wrote:
I do not thing this is a proper fix and that it actually improves anything.
"Treat as signed 5-bit literal" means that:
- Only allow literal parameters
- Only allow integers that would fit into 5-bit signed immediate
https://github.com/llvm/llvm-project/pull/78905
@@ -9,7 +9,7 @@
/// \file
/// Defines the Diagnostic-related interfaces.
//
-//===--===//
+//===--===//]
asl wrote:
still
@@ -635,16 +635,16 @@ def execute_command(self) -> bool:
"""
This function reads lines from STDIN and executes the first command
that it finds. The 2 supported commands are:
-/cherry-pick commit0 <...>
asl wrote:
You
@@ -1098,7 +1098,10 @@ void VerifyDiagnosticConsumer::CheckDiagnostics() {
// Produce an error if no expected-* directives could be found in the
// source file(s) processed.
if (Status == HasNoDirectives) {
-
@@ -1404,7 +1404,7 @@ void ASTContext::InitBuiltinTypes(const TargetInfo
,
getTranslationUnitDecl()->addDecl(MSGuidTagDecl);
}
}
-
+// maybe change here also.
asl wrote:
Ditto
https://github.com/llvm/llvm-project/pull/78338
@@ -635,16 +635,16 @@ def execute_command(self) -> bool:
"""
This function reads lines from STDIN and executes the first command
that it finds. The 2 supported commands are:
-/cherry-pick commit0 <...>
asl wrote:
Do not
https://github.com/asl requested changes to this pull request.
Ensure that PR does not contain unrelated things. See
https://llvm.org/docs/Contributing.html#how-to-submit-a-patch for more
information
https://github.com/llvm/llvm-project/pull/78338
https://github.com/asl edited https://github.com/llvm/llvm-project/pull/78338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -9,7 +9,9 @@
/// \file
/// Defines the Diagnostic-related interfaces.
//
-//===--===//
+//===--===//]
+
+// look into this file as well
@@ -108,13 +108,9 @@ else()
linux/HostInfoLinux.cpp
linux/LibcGlue.cpp
linux/Support.cpp
+ android/HostInfoAndroid.cpp
+ android/LibcGlue.cpp
)
-if (CMAKE_SYSTEM_NAME MATCHES "Android")
asl wrote:
Not quite. It's distant
@@ -108,13 +108,9 @@ else()
linux/HostInfoLinux.cpp
linux/LibcGlue.cpp
linux/Support.cpp
+ android/HostInfoAndroid.cpp
+ android/LibcGlue.cpp
)
-if (CMAKE_SYSTEM_NAME MATCHES "Android")
asl wrote:
Well, so this is not a
https://github.com/asl edited https://github.com/llvm/llvm-project/pull/77216
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -46,64 +46,64 @@ class Triple {
enum ArchType {
UnknownArch,
-arm,// ARM (little endian): arm, armv.*, xscale
asl wrote:
You can ignore these.
https://github.com/llvm/llvm-project/pull/77216
@@ -108,13 +108,9 @@ else()
linux/HostInfoLinux.cpp
linux/LibcGlue.cpp
linux/Support.cpp
+ android/HostInfoAndroid.cpp
+ android/LibcGlue.cpp
)
-if (CMAKE_SYSTEM_NAME MATCHES "Android")
asl wrote:
What is wrong with
@@ -46,64 +46,64 @@ class Triple {
enum ArchType {
UnknownArch,
-arm,// ARM (little endian): arm, armv.*, xscale
asl wrote:
Please do not do such large code reformatting. It makes impossible to review
them
=?utf-8?b?5b6Q5oyB5oGS?= Xu Chiheng,=?utf-8?b?5b6Q5oyB5oGS?= Xu Chiheng
Message-ID:
In-Reply-To:
https://github.com/asl requested changes to this pull request.
This lacks tests and some references how TLS is implemented on Cygwin
https://github.com/llvm/llvm-project/pull/76943
=?utf-8?b?5b6Q5oyB5oGS?= Xu Chiheng,=?utf-8?b?5b6Q5oyB5oGS?= Xu Chiheng
Message-ID:
In-Reply-To:
https://github.com/asl closed https://github.com/llvm/llvm-project/pull/74868
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
=?utf-8?b?5b6Q5oyB5oGS?= Xu Chiheng,=?utf-8?b?5b6Q5oyB5oGS?= Xu Chiheng
Message-ID:
In-Reply-To:
asl wrote:
Will you please provide meaningful description in the PRs from now on? Since
this is not the first time you've been asked to do this and you are ignoring
these requests I'm closing
asl wrote:
Will you please provide meaningful description in the PRs from now on? Since
this is not the first time you've been asked to do this and you are ignoring
these requests I'm closing this PR. Please do not use PRs to debug your own
issues, this is wasting both time of reviewers as
https://github.com/asl closed https://github.com/llvm/llvm-project/pull/74982
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/asl closed https://github.com/llvm/llvm-project/pull/74981
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
asl wrote:
@xu-chiheng Will you please provide meaningful description in the PRs from now
on? Since this is not the first time you've been asked to do this and you are
ignoring these requests I'm closing this PR. Please do not use PRs to debug
your own issues, this is wasting both time of
asl wrote:
Will you please provide meaningful description in the PRs from now on? Since
this is not the first time you've been asked to do this and you are ignoring
these requests I'm closing this PR. Please do not use PRs to debug your own
issues, this is wasting both time of reviewers as
https://github.com/asl closed https://github.com/llvm/llvm-project/pull/74984
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/asl closed https://github.com/llvm/llvm-project/pull/74983
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
asl wrote:
Will you please provide meaningful description in the PRs from now on? Since
this is not the first time you've been asked to do this and you are ignoring
these requests I'm closing this PR. Please do not use PRs to debug your own
issues, this is wasting both time of reviewers as
asl wrote:
Looks like the review stalled. Where we are here? @ahmedbougacha @ChuanqiXu9 ?
https://github.com/llvm/llvm-project/pull/65996
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -232,110 +279,133 @@ class CGBuilderTy : public CGBuilderBaseTy {
/// where i64 is actually the target word size.
Address CreateConstGEP(Address Addr, uint64_t Index,
const llvm::Twine = "") {
+llvm::Type *ElTy = Addr.getElementType();
https://github.com/asl requested changes to this pull request.
See the comment about function argument evaluation order that causes
instability of the codegen with pauth.
https://github.com/llvm/llvm-project/pull/67454
___
cfe-commits mailing list
https://github.com/asl edited https://github.com/llvm/llvm-project/pull/67454
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -519,6 +519,7 @@ StringRef ARM::computeDefaultTargetABI(const Triple ,
StringRef CPU) {
case Triple::GNUEABIHF:
case Triple::MuslEABI:
case Triple::MuslEABIHF:
+ case llvm::Triple::OpenHOS:
asl wrote:
```suggestion
case Triple::OpenHOS:
```
asl wrote:
@sam-mccall As far as I can see, the bot was green before this change:
https://lab.llvm.org/buildbot/#/builders/119/builds/15229
Have you not received email from the buildbot?
https://github.com/llvm/llvm-project/pull/66947
___
https://github.com/asl resolved https://github.com/llvm/llvm-project/pull/66333
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/asl closed https://github.com/llvm/llvm-project/pull/66333
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
asl wrote:
> Got it. Thanks. Then I am wondering how about the `retcon` ABI? I am confused
> since the doc said the last continuation of `retcon` ABI will return a
> nullptr to indicate it has finished. Don't we have the same problem? Or we
> can't solve the problem in `retcon` ABI? Or we
asl wrote:
> What make me curious is the motivation case of the PR. I mean what can be
> presented in retcon.once ABI after the PR which is impossible/hard before.
> And how do we handle that in retcon ABI.
Well, the PR allows `recon.once` coroutines to have normal results in addition
to
asl wrote:
> > > Out of curiousity, why don't we have the problem in the normal return
> > > continuation ABI?
> >
> >
> > The problem happens when the value is directly used in `coro.end`
> > intrinsic. For example, when we're forwarding coroutine argument as a
> > result. Or, when the
@@ -3046,7 +3046,8 @@ void coro::buildCoroutineFrame(
// Collect the spills for arguments and other not-materializable values.
for (Argument : F.args())
for (User *U : A.users())
- if (Checker.isDefinitionAcrossSuspend(A, U))
+ if
asl wrote:
> Out of curiousity, why don't we have the problem in the normal return
> continuation ABI?
The problem happens when the value is directly used in `coro.end` intrinsic.
For example, when we're forwarding coroutine argument as a result. Or, when the
value itself is computed before
https://github.com/asl edited https://github.com/llvm/llvm-project/pull/66333
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/asl review_requested
https://github.com/llvm/llvm-project/pull/66333
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Jozef Lawrynowicz
Date: 2021-09-28T20:47:26+03:00
New Revision: be610932fa068ed2228b0f694ae80c9294f0293f
URL:
https://github.com/llvm/llvm-project/commit/be610932fa068ed2228b0f694ae80c9294f0293f
DIFF:
Author: Anatoly Trosinenko
Date: 2020-06-26T15:32:07+03:00
New Revision: cb56fa2196c5d80ce72e8e8f6ee2a7ac80acca77
URL:
https://github.com/llvm/llvm-project/commit/cb56fa2196c5d80ce72e8e8f6ee2a7ac80acca77
DIFF:
Author: Anton Korobeynikov
Date: 2020-06-22T13:37:22+03:00
New Revision: 6cb80fbe405264471e9bc5b6ea19694e51ae1b11
URL:
https://github.com/llvm/llvm-project/commit/6cb80fbe405264471e9bc5b6ea19694e51ae1b11
DIFF:
Author: Anatoly Trosinenko
Date: 2020-06-22T13:24:03+03:00
New Revision: 8f6620f663031da2bb35b788239f4b607271af84
URL:
https://github.com/llvm/llvm-project/commit/8f6620f663031da2bb35b788239f4b607271af84
DIFF:
Author: asl
Date: Tue Feb 12 12:46:00 2019
New Revision: 353877
URL: http://llvm.org/viewvc/llvm-project?rev=353877=rev
Log:
Disable PIC/PIE for MSP430 target
Relocatable code generation is meaningless on MSP430, as the platform is too
small to use shared libraries.
Patch by Dmitry Mikushev!
Author: asl
Date: Tue Feb 5 12:15:03 2019
New Revision: 353212
URL: http://llvm.org/viewvc/llvm-project?rev=353212=rev
Log:
Do not use frame pointer by default for MSP430
This is suggested by 3.3.9 of MSP430 EABI document.
We do allow user to manually enable frame pointer. GCC toolchain uses
Author: asl
Date: Fri Jan 25 02:35:35 2019
New Revision: 352186
URL: http://llvm.org/viewvc/llvm-project?rev=352186=rev
Log:
Revert r352181 as it's breaking the bots
Removed:
cfe/trunk/test/CodeGen/msp430-reloc.c
Modified:
cfe/trunk/lib/Driver/ToolChains/MSP430.h
Modified:
Author: asl
Date: Fri Jan 25 01:41:20 2019
New Revision: 352181
URL: http://llvm.org/viewvc/llvm-project?rev=352181=rev
Log:
Disable PIC/PIE for MSP430 target by default.
Relocatable code generation is meaningless on MSP430, as the platform is too
small to use shared libraries.
Patch by Dmitry
Author: asl
Date: Fri Jan 25 00:51:53 2019
New Revision: 352177
URL: http://llvm.org/viewvc/llvm-project?rev=352177=rev
Log:
[MSP430] Ajust f32/f64 alignment according to MSP430 EABI
Patch by Kristina Bessonova!
Differential Revision: https://reviews.llvm.org/D57015
Added:
Author: asl
Date: Thu Jan 17 07:21:55 2019
New Revision: 351449
URL: http://llvm.org/viewvc/llvm-project?rev=351449=rev
Log:
CodeGen: Cast llvm.flt.rounds result to match __builtin_flt_rounds
llvm.flt.rounds returns an i32, but the builtin expects an integer.
On targets where integers are not
Author: asl
Date: Wed Jan 16 05:44:01 2019
New Revision: 351344
URL: http://llvm.org/viewvc/llvm-project?rev=351344=rev
Log:
[MSP430] Improve support of 'interrupt' attribute
* Accept as an argument constants in range 0..63 (aligned with TI headers and
linker scripts provided with TI GCC
Author: asl
Date: Wed Jan 16 05:28:30 2019
New Revision: 351340
URL: http://llvm.org/viewvc/llvm-project?rev=351340=rev
Log:
[MSP430] Fix msp430-toolchain.c on Windows (added in r351228)
Patch by Kristina Bessonova!
Differential Revision: https://reviews.llvm.org/D56776
Modified:
Thanks!
On Wed, Jan 16, 2019 at 12:03 AM Peter Collingbourne via cfe-commits
wrote:
>
> Author: pcc
> Date: Tue Jan 15 12:59:59 2019
> New Revision: 351241
>
> URL: http://llvm.org/viewvc/llvm-project?rev=351241=rev
> Log:
> CodeGen: Remove debug printf unintentionally added in r351228.
>
>
Author: asl
Date: Tue Jan 15 11:44:05 2019
New Revision: 351228
URL: http://llvm.org/viewvc/llvm-project?rev=351228=rev
Log:
[MSP430] Provide a toolchain description
This is an initial implementation for msp430 toolchain including
-mmcu option support
-mhwmult options support
-integrated-as by
Author: asl
Date: Mon Mar 6 03:32:56 2017
New Revision: 297005
URL: http://llvm.org/viewvc/llvm-project?rev=297005=rev
Log:
Do not include GCC "resource" directory into the set of built-in include paths
on MingW.
Patch by Mateusz MikuĊa.
Differential Revision: https://reviews.llvm.org/D29464
asl added a comment.
I totally agree with Renato. What part of libc++abi requires exactly
libunwind's unwind.h, what is the dependency?
https://reviews.llvm.org/D24084
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
asl added a comment.
Hrm? Why I'm set to review this?
Repository:
rL LLVM
http://reviews.llvm.org/D21737
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
asl requested changes to this revision.
asl added a comment.
This revision now requires changes to proceed.
Please don't create empty review requests. This is ridiculous.
Repository:
rL LLVM
http://reviews.llvm.org/D16754
___
cfe-commits mailing
80 matches
Mail list logo
