[clang] 8f6620f - [MSP430] Update register names

2020-06-22 Thread Anton Korobeynikov via cfe-commits
Author: Anatoly Trosinenko Date: 2020-06-22T13:24:03+03:00 New Revision: 8f6620f663031da2bb35b788239f4b607271af84 URL: https://github.com/llvm/llvm-project/commit/8f6620f663031da2bb35b788239f4b607271af84 DIFF: https://github.com/llvm/llvm-project/commit/8f6620f663031da2bb35b788239f4b607271af84.

[clang] 6cb80fb - Revert "[MSP430] Update register names"

2020-06-22 Thread Anton Korobeynikov via cfe-commits
Author: Anton Korobeynikov Date: 2020-06-22T13:37:22+03:00 New Revision: 6cb80fbe405264471e9bc5b6ea19694e51ae1b11 URL: https://github.com/llvm/llvm-project/commit/6cb80fbe405264471e9bc5b6ea19694e51ae1b11 DIFF: https://github.com/llvm/llvm-project/commit/6cb80fbe405264471e9bc5b6ea19694e51ae1b11.

[clang] cb56fa2 - [MSP430] Update register names

2020-06-26 Thread Anton Korobeynikov via cfe-commits
Author: Anatoly Trosinenko Date: 2020-06-26T15:32:07+03:00 New Revision: cb56fa2196c5d80ce72e8e8f6ee2a7ac80acca77 URL: https://github.com/llvm/llvm-project/commit/cb56fa2196c5d80ce72e8e8f6ee2a7ac80acca77 DIFF: https://github.com/llvm/llvm-project/commit/cb56fa2196c5d80ce72e8e8f6ee2a7ac80acca77.

r297005 - Do not include GCC "resource" directory into the set of built-in include paths on MingW.

2017-03-06 Thread Anton Korobeynikov via cfe-commits
Author: asl Date: Mon Mar 6 03:32:56 2017 New Revision: 297005 URL: http://llvm.org/viewvc/llvm-project?rev=297005&view=rev Log: Do not include GCC "resource" directory into the set of built-in include paths on MingW. Patch by Mateusz MikuĊ‚a. Differential Revision: https://reviews.llvm.org/D29

Re: [PATCH] D21737: [PATCH] [CodeGen] Insert TargetLibraryInfoWrapperPass before anything else.

2016-06-26 Thread Anton Korobeynikov via cfe-commits
asl added a comment. Hrm? Why I'm set to review this? Repository: rL LLVM http://reviews.llvm.org/D21737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24084: [CMake] Cleanup libunwind lookup code.

2016-09-02 Thread Anton Korobeynikov via cfe-commits
asl added a comment. I totally agree with Renato. What part of libc++abi requires exactly libunwind's unwind.h, what is the dependency? https://reviews.llvm.org/D24084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

Re: [PATCH] D16754: Bug 15785 - OpenCL errors using vector/scalar conditionals and short integer types

2016-01-31 Thread Anton Korobeynikov via cfe-commits
asl requested changes to this revision. asl added a comment. This revision now requires changes to proceed. Please don't create empty review requests. This is ridiculous. Repository: rL LLVM http://reviews.llvm.org/D16754 ___ cfe-commits mailing

[llvm] [clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-12-04 Thread Anton Korobeynikov via cfe-commits
asl wrote: Looks like the review stalled. Where we are here? @ahmedbougacha @ChuanqiXu9 ? https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [llvm] [CodeGen][arm64e] Add methods and data members to Address, which are needed to authenticate signed pointers (PR #67454)

2023-11-20 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl edited https://github.com/llvm/llvm-project/pull/67454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [CodeGen][arm64e] Add methods and data members to Address, which are needed to authenticate signed pointers (PR #67454)

2023-11-20 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl requested changes to this pull request. See the comment about function argument evaluation order that causes instability of the codegen with pauth. https://github.com/llvm/llvm-project/pull/67454 ___ cfe-commits mailing list cfe

[clang] [llvm] [CodeGen][arm64e] Add methods and data members to Address, which are needed to authenticate signed pointers (PR #67454)

2023-11-20 Thread Anton Korobeynikov via cfe-commits
@@ -232,110 +279,133 @@ class CGBuilderTy : public CGBuilderBaseTy { /// where i64 is actually the target word size. Address CreateConstGEP(Address Addr, uint64_t Index, const llvm::Twine &Name = "") { +llvm::Type *ElTy = Addr.getElementType();

[llvm] [clang] [mlir] [compiler-rt] [clang-tools-extra] [lldb] Fix Multiple Build Errors on different platforms (PR #77216)

2024-01-06 Thread Anton Korobeynikov via cfe-commits
@@ -46,64 +46,64 @@ class Triple { enum ArchType { UnknownArch, -arm,// ARM (little endian): arm, armv.*, xscale asl wrote: Please do not do such large code reformatting. It makes impossible to review them https://github.com/llvm/llvm-

[llvm] [clang] [mlir] [compiler-rt] [clang-tools-extra] [lldb] Fix Multiple Build Errors on different platforms (PR #77216)

2024-01-06 Thread Anton Korobeynikov via cfe-commits
@@ -108,13 +108,9 @@ else() linux/HostInfoLinux.cpp linux/LibcGlue.cpp linux/Support.cpp + android/HostInfoAndroid.cpp + android/LibcGlue.cpp ) -if (CMAKE_SYSTEM_NAME MATCHES "Android") asl wrote: What is wrong with andro

[llvm] [clang] [mlir] [compiler-rt] [clang-tools-extra] [lldb] Fix Multiple Build Errors on different platforms (PR #77216)

2024-01-06 Thread Anton Korobeynikov via cfe-commits
@@ -46,64 +46,64 @@ class Triple { enum ArchType { UnknownArch, -arm,// ARM (little endian): arm, armv.*, xscale asl wrote: You can ignore these. https://github.com/llvm/llvm-project/pull/77216 __

[llvm] [clang] [mlir] [compiler-rt] [clang-tools-extra] [lldb] Fix Multiple Build Errors on different platforms (PR #77216)

2024-01-06 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl edited https://github.com/llvm/llvm-project/pull/77216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [mlir] [compiler-rt] [clang-tools-extra] [lldb] Fix Multiple Build Errors on different platforms (PR #77216)

2024-01-06 Thread Anton Korobeynikov via cfe-commits
@@ -108,13 +108,9 @@ else() linux/HostInfoLinux.cpp linux/LibcGlue.cpp linux/Support.cpp + android/HostInfoAndroid.cpp + android/LibcGlue.cpp ) -if (CMAKE_SYSTEM_NAME MATCHES "Android") asl wrote: Well, so this is not a c

[llvm] [clang] [mlir] [compiler-rt] [clang-tools-extra] [lldb] Fix Multiple Build Errors on different platforms (PR #77216)

2024-01-06 Thread Anton Korobeynikov via cfe-commits
@@ -108,13 +108,9 @@ else() linux/HostInfoLinux.cpp linux/LibcGlue.cpp linux/Support.cpp + android/HostInfoAndroid.cpp + android/LibcGlue.cpp ) -if (CMAKE_SYSTEM_NAME MATCHES "Android") asl wrote: Not quite. It's distant

[clang] [Clang][OHOS] Keep ARM ABI selection logic in sync between Clang and LLVM (PR #68656)

2023-10-14 Thread Anton Korobeynikov via cfe-commits
@@ -519,6 +519,7 @@ StringRef ARM::computeDefaultTargetABI(const Triple &TT, StringRef CPU) { case Triple::GNUEABIHF: case Triple::MuslEABI: case Triple::MuslEABIHF: + case llvm::Triple::OpenHOS: asl wrote: ```suggestion case Triple::OpenHOS: ``` ht

[clang-tools-extra] [pseudo] gen Main.cpp (PR #74983)

2023-12-31 Thread Anton Korobeynikov via cfe-commits
asl wrote: Will you please provide meaningful description in the PRs from now on? Since this is not the first time you've been asked to do this and you are ignoring these requests I'm closing this PR. Please do not use PRs to debug your own issues, this is wasting both time of reviewers as wel

[clang-tools-extra] [pseudo] gen Main.cpp (PR #74983)

2023-12-31 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl closed https://github.com/llvm/llvm-project/pull/74983 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [pseudo] lib Grammar.cpp (PR #74984)

2023-12-31 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl closed https://github.com/llvm/llvm-project/pull/74984 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [pseudo] lib Grammar.cpp (PR #74984)

2023-12-31 Thread Anton Korobeynikov via cfe-commits
asl wrote: Will you please provide meaningful description in the PRs from now on? Since this is not the first time you've been asked to do this and you are ignoring these requests I'm closing this PR. Please do not use PRs to debug your own issues, this is wasting both time of reviewers as wel

[clang] [MinGW] MinGW pthread (PR #74981)

2023-12-31 Thread Anton Korobeynikov via cfe-commits
asl wrote: @xu-chiheng Will you please provide meaningful description in the PRs from now on? Since this is not the first time you've been asked to do this and you are ignoring these requests I'm closing this PR. Please do not use PRs to debug your own issues, this is wasting both time of rev

[clang] [MinGW] MinGW pthread (PR #74981)

2023-12-31 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl closed https://github.com/llvm/llvm-project/pull/74981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MinGW] MinGW Value.h (PR #74982)

2023-12-31 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl closed https://github.com/llvm/llvm-project/pull/74982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MinGW] MinGW Value.h (PR #74982)

2023-12-31 Thread Anton Korobeynikov via cfe-commits
asl wrote: Will you please provide meaningful description in the PRs from now on? Since this is not the first time you've been asked to do this and you are ignoring these requests I'm closing this PR. Please do not use PRs to debug your own issues, this is wasting both time of reviewers as wel

[clang] [Cygwin] Cygwin basic support (PR #74868)

2023-12-31 Thread Anton Korobeynikov via cfe-commits
=?utf-8?b?5b6Q5oyB5oGS?= Xu Chiheng,=?utf-8?b?5b6Q5oyB5oGS?= Xu Chiheng Message-ID: In-Reply-To: asl wrote: Will you please provide meaningful description in the PRs from now on? Since this is not the first time you've been asked to do this and you are ignoring these requests I'm closing this

[clang] [Cygwin] Cygwin basic support (PR #74868)

2023-12-31 Thread Anton Korobeynikov via cfe-commits
=?utf-8?b?5b6Q5oyB5oGS?= Xu Chiheng,=?utf-8?b?5b6Q5oyB5oGS?= Xu Chiheng Message-ID: In-Reply-To: https://github.com/asl closed https://github.com/llvm/llvm-project/pull/74868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] [Cygwin] Cygwin basic support (PR #76943)

2024-01-04 Thread Anton Korobeynikov via cfe-commits
=?utf-8?b?5b6Q5oyB5oGS?= Xu Chiheng,=?utf-8?b?5b6Q5oyB5oGS?= Xu Chiheng Message-ID: In-Reply-To: https://github.com/asl requested changes to this pull request. This lacks tests and some references how TLS is implemented on Cygwin https://github.com/llvm/llvm-project/pull/76943

r351228 - [MSP430] Provide a toolchain description

2019-01-15 Thread Anton Korobeynikov via cfe-commits
Author: asl Date: Tue Jan 15 11:44:05 2019 New Revision: 351228 URL: http://llvm.org/viewvc/llvm-project?rev=351228&view=rev Log: [MSP430] Provide a toolchain description This is an initial implementation for msp430 toolchain including -mmcu option support -mhwmult options support -integrated-as

Re: r351241 - CodeGen: Remove debug printf unintentionally added in r351228.

2019-01-15 Thread Anton Korobeynikov via cfe-commits
Thanks! On Wed, Jan 16, 2019 at 12:03 AM Peter Collingbourne via cfe-commits wrote: > > Author: pcc > Date: Tue Jan 15 12:59:59 2019 > New Revision: 351241 > > URL: http://llvm.org/viewvc/llvm-project?rev=351241&view=rev > Log: > CodeGen: Remove debug printf unintentionally added in r351228. > >

r351340 - [MSP430] Fix msp430-toolchain.c on Windows (added in r351228)

2019-01-16 Thread Anton Korobeynikov via cfe-commits
Author: asl Date: Wed Jan 16 05:28:30 2019 New Revision: 351340 URL: http://llvm.org/viewvc/llvm-project?rev=351340&view=rev Log: [MSP430] Fix msp430-toolchain.c on Windows (added in r351228) Patch by Kristina Bessonova! Differential Revision: https://reviews.llvm.org/D56776 Modified: cfe/

r351344 - [MSP430] Improve support of 'interrupt' attribute

2019-01-16 Thread Anton Korobeynikov via cfe-commits
Author: asl Date: Wed Jan 16 05:44:01 2019 New Revision: 351344 URL: http://llvm.org/viewvc/llvm-project?rev=351344&view=rev Log: [MSP430] Improve support of 'interrupt' attribute * Accept as an argument constants in range 0..63 (aligned with TI headers and linker scripts provided with TI GCC to

r351449 - CodeGen: Cast llvm.flt.rounds result to match __builtin_flt_rounds

2019-01-17 Thread Anton Korobeynikov via cfe-commits
Author: asl Date: Thu Jan 17 07:21:55 2019 New Revision: 351449 URL: http://llvm.org/viewvc/llvm-project?rev=351449&view=rev Log: CodeGen: Cast llvm.flt.rounds result to match __builtin_flt_rounds llvm.flt.rounds returns an i32, but the builtin expects an integer. On targets where integers are n

r352177 - [MSP430] Ajust f32/f64 alignment according to MSP430 EABI

2019-01-25 Thread Anton Korobeynikov via cfe-commits
Author: asl Date: Fri Jan 25 00:51:53 2019 New Revision: 352177 URL: http://llvm.org/viewvc/llvm-project?rev=352177&view=rev Log: [MSP430] Ajust f32/f64 alignment according to MSP430 EABI Patch by Kristina Bessonova! Differential Revision: https://reviews.llvm.org/D57015 Added: cfe/trunk/te

r352181 - Disable PIC/PIE for MSP430 target by default.

2019-01-25 Thread Anton Korobeynikov via cfe-commits
Author: asl Date: Fri Jan 25 01:41:20 2019 New Revision: 352181 URL: http://llvm.org/viewvc/llvm-project?rev=352181&view=rev Log: Disable PIC/PIE for MSP430 target by default. Relocatable code generation is meaningless on MSP430, as the platform is too small to use shared libraries. Patch by Dm

r352186 - Revert r352181 as it's breaking the bots

2019-01-25 Thread Anton Korobeynikov via cfe-commits
Author: asl Date: Fri Jan 25 02:35:35 2019 New Revision: 352186 URL: http://llvm.org/viewvc/llvm-project?rev=352186&view=rev Log: Revert r352181 as it's breaking the bots Removed: cfe/trunk/test/CodeGen/msp430-reloc.c Modified: cfe/trunk/lib/Driver/ToolChains/MSP430.h Modified: cfe/trunk

r353212 - Do not use frame pointer by default for MSP430

2019-02-05 Thread Anton Korobeynikov via cfe-commits
Author: asl Date: Tue Feb 5 12:15:03 2019 New Revision: 353212 URL: http://llvm.org/viewvc/llvm-project?rev=353212&view=rev Log: Do not use frame pointer by default for MSP430 This is suggested by 3.3.9 of MSP430 EABI document. We do allow user to manually enable frame pointer. GCC toolchain use

r353877 - Disable PIC/PIE for MSP430 target

2019-02-12 Thread Anton Korobeynikov via cfe-commits
Author: asl Date: Tue Feb 12 12:46:00 2019 New Revision: 353877 URL: http://llvm.org/viewvc/llvm-project?rev=353877&view=rev Log: Disable PIC/PIE for MSP430 target Relocatable code generation is meaningless on MSP430, as the platform is too small to use shared libraries. Patch by Dmitry Mikushe

[clang] [llvm] [CodeGen][arm64e] Add methods and data members to Address, which are needed to authenticate signed pointers (PR #67454)

2024-03-12 Thread Anton Korobeynikov via cfe-commits
asl wrote: > Maybe `emitRawPointerFromAddress` is better. I see a lot of functions > starting with `emit` in CodeGen. Works for me! https://github.com/llvm/llvm-project/pull/67454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang] [llvm] [CodeGen][AArch64][FMV] PAC the stub_helper's frame on arm64e (PR #84704)

2024-03-14 Thread Anton Korobeynikov via cfe-commits
asl wrote: Tagging @kovdan01 Can the triple checks be generalized to checking about pauth-enabled subtarget feature? This way everything would work for ELF platforms eventually. https://github.com/llvm/llvm-project/pull/84704 ___ cfe-commits mailing

[clang] [llvm] [CodeGen][arm64e] Add methods and data members to Address, which are needed to authenticate signed pointers (PR #67454)

2024-03-01 Thread Anton Korobeynikov via cfe-commits
asl wrote: I am ok with the changes. Though with pauth we'd probably need to rename `getRawPointerFromAddress` to indicate clearer that it has side effects (like `extractRawPointerFromAddress` or something like this) https://github.com/llvm/llvm-project/pull/67454 _

[clang] [llvm] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2024-03-02 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl milestoned https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CodeGen][arm64e] Add methods and data members to Address, which are needed to authenticate signed pointers (PR #67454)

2024-03-02 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl milestoned https://github.com/llvm/llvm-project/pull/67454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CodeGen][arm64e] Add methods and data members to Address, which are needed to authenticate signed pointers (PR #86721)

2024-03-27 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/86721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CodeGen][arm64e] Add methods and data members to Address, which are needed to authenticate signed pointers (PR #67454)

2024-03-11 Thread Anton Korobeynikov via cfe-commits
asl wrote: We discussed the naming thing (`extractRawPointerFromAddress` vs `getRawPointerFromAddress`) at pauth call and decided that it would be better to do this renaming now. @ahmedbougacha will coordinate that renaming. https://github.com/llvm/llvm-project/pull/67454 _

[clang] [llvm] [CodeGen][arm64e] Add methods and data members to Address, which are needed to authenticate signed pointers (PR #67454)

2024-03-11 Thread Anton Korobeynikov via cfe-commits
asl wrote: > I'm not sure `extractRawPointerFromAddress` conveys the fact that the > function might do code-gen instead of just returning some pointer. I wonder > if there's a better name. > > `computeRawPointerFromAddress` `genRawPointerFromAddress` > `generateRawPointerFromAddress` `codeGen

[clang] [clang] Resolve FIXME in altivec.h (PR #78905)

2024-01-27 Thread Anton Korobeynikov via cfe-commits
asl wrote: I do not thing this is a proper fix and that it actually improves anything. "Treat as signed 5-bit literal" means that: - Only allow literal parameters - Only allow integers that would fit into 5-bit signed immediate https://github.com/llvm/llvm-project/pull/78905 _

[clang-tools-extra] [clang] [llvm] [XCOFF] Add compiler version to an auxiliary symbol table entry (PR #80162)

2024-02-06 Thread Anton Korobeynikov via cfe-commits
asl wrote: @stephenpeckham Apparently this was merged without waiting for buildkite results or ignoring its results. Linux build failed due to obvious spelling mistakes. Will you please next time wait until CI to finish? Thanks! https://github.com/llvm/llvm-project/pull/80162

[clang-tools-extra] [clang] [llvm] [XCOFF] Add compiler version to an auxiliary symbol table entry (PR #80162)

2024-02-06 Thread Anton Korobeynikov via cfe-commits
asl wrote: @nico How about revert? https://github.com/llvm/llvm-project/pull/80162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [llvm] [XCOFF] Add compiler version to an auxiliary symbol table entry (PR #80162)

2024-02-06 Thread Anton Korobeynikov via cfe-commits
@@ -159,14 +159,26 @@ declare i32 @bar(i32) ; SYM: Symbols [ ; SYM-NEXT: Symbol { ; SYM-NEXT: Index: 0 -; SYM-NEXT: Name: +; SYM-NEXT: Name: .file ; SYM-NEXT: Value (SymbolTableIndex): 0x0 ; SYM-NEXT: Section: N_DEBUG ; SYM-NEXT: Source Langua

[clang-tools-extra] [llvm] [clang] [CLANG] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-16 Thread Anton Korobeynikov via cfe-commits
@@ -9,7 +9,9 @@ /// \file /// Defines the Diagnostic-related interfaces. // -//===--===// +//===--===//] + +// look into this file as well ---

[clang-tools-extra] [llvm] [clang] [CLANG] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-16 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl edited https://github.com/llvm/llvm-project/pull/78338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [CLANG] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-16 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl requested changes to this pull request. Ensure that PR does not contain unrelated things. See https://llvm.org/docs/Contributing.html#how-to-submit-a-patch for more information https://github.com/llvm/llvm-project/pull/78338 __

[llvm] [clang] [clang-tools-extra] [CLANG] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-16 Thread Anton Korobeynikov via cfe-commits
@@ -635,16 +635,16 @@ def execute_command(self) -> bool: """ This function reads lines from STDIN and executes the first command that it finds. The 2 supported commands are: -/cherry-pick commit0 <...> asl wrote: Do not inclu

[llvm] [clang] [clang-tools-extra] [CLANG] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-16 Thread Anton Korobeynikov via cfe-commits
@@ -1404,7 +1404,7 @@ void ASTContext::InitBuiltinTypes(const TargetInfo &Target, getTranslationUnitDecl()->addDecl(MSGuidTagDecl); } } - +// maybe change here also. asl wrote: Ditto https://github.com/llvm/llvm-project/pull/78338 _

[llvm] [clang-tools-extra] [clang] [CLANG] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-16 Thread Anton Korobeynikov via cfe-commits
@@ -1098,7 +1098,10 @@ void VerifyDiagnosticConsumer::CheckDiagnostics() { // Produce an error if no expected-* directives could be found in the // source file(s) processed. if (Status == HasNoDirectives) { - Diags.Report(diag::err_verify_no_directives).setForc

[clang-tools-extra] [clang] [llvm] [CLANG] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-16 Thread Anton Korobeynikov via cfe-commits
@@ -635,16 +635,16 @@ def execute_command(self) -> bool: """ This function reads lines from STDIN and executes the first command that it finds. The 2 supported commands are: -/cherry-pick commit0 <...> asl wrote: You certainl

[clang-tools-extra] [clang] [llvm] [CLANG] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-16 Thread Anton Korobeynikov via cfe-commits
@@ -9,7 +9,7 @@ /// \file /// Defines the Diagnostic-related interfaces. // -//===--===// +//===--===//] asl wrote: still un

[clang] [llvm] [PAC][Driver] Implement `-mbranch-protection=pauthabi` option (PR #97237)

2024-07-02 Thread Anton Korobeynikov via cfe-commits
asl wrote: > Is there any thought on how we want to manage signing schemas going forward? > For example I can imagine looking an environment from the triple to select a > signing schema for a particular platform. I could also see a potential for a > separate command line option to choose from

[clang] [llvm] [clang] Define ptrauth_string_discriminator builtin. (PR #93903)

2024-06-14 Thread Anton Korobeynikov via cfe-commits
asl wrote: @ahmedbougacha Will you please rebase https://github.com/llvm/llvm-project/pull/93903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Serialization] Use specialized decl hash function for GlobalDeclID (PR #95730)

2024-06-16 Thread Anton Korobeynikov via cfe-commits
@@ -230,7 +230,11 @@ template <> struct DenseMapInfo { } static unsigned getHashValue(const GlobalDeclID &Key) { -return DenseMapInfo::getHashValue(Key.get()); +// Our default hash algorithm for 64 bits integer may not be very good. +// In GlobalDeclID's case,

[clang] [llvm] [AArch64][PAC] Sign block addresses used in indirectbr. (PR #97647)

2024-07-08 Thread Anton Korobeynikov via cfe-commits
asl wrote: > Please make sure you have a testcase for computing the difference between two > blockaddresses (`void g(int*); int f() { static int x = &&A-&&B; > A:g(&x);B:return x; }`). Not sure how you should handle that case. Will you please clarify what is the problem here? `&&A-&&B` will be

[clang] [llvm] [AArch64][PAC] Sign block addresses used in indirectbr. (PR #97647)

2024-07-08 Thread Anton Korobeynikov via cfe-commits
asl wrote: > Under the proposed ABI, `&&A-&&B` is actually "sign(A)-sign(B)". Which is a > constant, but not one which can be represented as a relocation (as far as I > know). Right. The difference should be not be signed IMO as stated above. https://github.com/llvm/llvm-project/pull/97647 __

[clang] [clang] Ensure pointers passed to runtime support functions are correctly signed (PR #98276)

2024-07-10 Thread Anton Korobeynikov via cfe-commits
@@ -333,7 +338,8 @@ void CodeGenFunction::registerGlobalDtorWithLLVM(const VarDecl &VD, llvm::FunctionCallee Dtor, llvm::Constant *Addr) { // Create a function which calls the d

[clang] [libunwind] [libunwind][WebAssembly] Make libunwind compilable (PR #92192)

2024-05-17 Thread Anton Korobeynikov via cfe-commits
@@ -20,7 +20,7 @@ .text #endif -#if !defined(__USING_SJLJ_EXCEPTIONS__) +#if !defined(__USING_SJLJ_EXCEPTIONS__) && !defined(__wasm__) asl wrote: You are defining `__USING_WASM_EXCEPTIONS__`. Why you are not using it here and everywhere else? https://gith

[clang] [libunwind] [libunwind][WebAssembly] Make libunwind compilable (PR #92192)

2024-05-17 Thread Anton Korobeynikov via cfe-commits
@@ -20,7 +20,7 @@ .text #endif -#if !defined(__USING_SJLJ_EXCEPTIONS__) +#if !defined(__USING_SJLJ_EXCEPTIONS__) && !defined(__wasm__) asl wrote: Ok. Then does the clang change really belong here? `LIBUNWIND_USES_WASM_EXCEPTIONS` also seems to be unused.

[clang] [libunwind] [libunwind][WebAssembly] Make libunwind compilable (PR #92192)

2024-05-21 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl approved this pull request. Ok from the generic point of view. I cannot judge if wasm-related part is ok though :) https://github.com/llvm/llvm-project/pull/92192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] [MSP430][Clang] Update list of MCUs (PR #91258)

2024-05-06 Thread Anton Korobeynikov via cfe-commits
asl wrote: > The python script should likely be up streamed as well. But where? You could just put into `Target/MSP430`. https://github.com/llvm/llvm-project/pull/91258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] [MSP430][Clang] Update list of MCUs (PR #91258)

2024-05-07 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl edited https://github.com/llvm/llvm-project/pull/91258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MSP430][Clang] Update list of MCUs (PR #91258)

2024-05-07 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/91258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MSP430][Clang] Update list of MCUs (PR #91258)

2024-05-07 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl closed https://github.com/llvm/llvm-project/pull/91258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add arm64e ABI-defined key assignments to ptrauth.h. (PR #93901)

2024-05-30 Thread Anton Korobeynikov via cfe-commits
@@ -15,6 +15,29 @@ typedef enum { ptrauth_key_asib = 1, ptrauth_key_asda = 2, ptrauth_key_asdb = 3, + +#ifdef __APPLE__ asl wrote: I believe these are defaults for ELF as well. So, I'd remove ifdef and decide on necessary gating when there will be a pre

[clang] [llvm] [Support] Add SipHash-based 16/64-bit ptrauth stable hash. (PR #93902)

2024-06-03 Thread Anton Korobeynikov via cfe-commits
asl wrote: @kbeyls Will you please summarize briefly what we discussed on the sync call from the license standpoint? https://github.com/llvm/llvm-project/pull/93902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread Anton Korobeynikov via cfe-commits
asl wrote: Tagging @slydiman @vvereschaka https://github.com/llvm/llvm-project/pull/94208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Define ptrauth_string_discriminator builtin. (PR #93903)

2024-06-19 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/93903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PAC][clang][Driver] Add signed GOT flag (PR #96160)

2024-06-21 Thread Anton Korobeynikov via cfe-commits
asl wrote: > Do we want a lot of `-fptrauth-xxx` instead of > `-fptrauth-something=xxx,yyy,zzz`? I would lean towards a single flag. However, I do not know how this would affect Apple downstream and what are preferences there. Tagging @ahmedbougacha @ahatanak @ojhunt https://github.com/llv

[clang] [compiler-rt] [llvm] [PAC][AArch64] Support init/fini array signing (PR #96478)

2024-06-24 Thread Anton Korobeynikov via cfe-commits
asl wrote: Can we have LLVM IR test as well? https://github.com/llvm/llvm-project/pull/96478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

2023-09-22 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl resolved https://github.com/llvm/llvm-project/pull/66333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Fix detection of libc++ with empty sysroot. (PR #66947)

2023-09-27 Thread Anton Korobeynikov via cfe-commits
asl wrote: @sam-mccall As far as I can see, the bot was green before this change: https://lab.llvm.org/buildbot/#/builders/119/builds/15229 Have you not received email from the buildbot? https://github.com/llvm/llvm-project/pull/66947 ___ cfe-commits

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

2023-09-13 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl review_requested https://github.com/llvm/llvm-project/pull/66333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

2023-09-14 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl edited https://github.com/llvm/llvm-project/pull/66333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

2023-09-14 Thread Anton Korobeynikov via cfe-commits
asl wrote: > Out of curiousity, why don't we have the problem in the normal return > continuation ABI? The problem happens when the value is directly used in `coro.end` intrinsic. For example, when we're forwarding coroutine argument as a result. Or, when the value itself is computed before t

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

2023-09-14 Thread Anton Korobeynikov via cfe-commits
@@ -3046,7 +3046,8 @@ void coro::buildCoroutineFrame( // Collect the spills for arguments and other not-materializable values. for (Argument &A : F.args()) for (User *U : A.users()) - if (Checker.isDefinitionAcrossSuspend(A, U)) + if (Checker.isDefinitionAcros

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

2023-09-14 Thread Anton Korobeynikov via cfe-commits
asl wrote: > > > Out of curiousity, why don't we have the problem in the normal return > > > continuation ABI? > > > > > > The problem happens when the value is directly used in `coro.end` > > intrinsic. For example, when we're forwarding coroutine argument as a > > result. Or, when the valu

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

2023-09-14 Thread Anton Korobeynikov via cfe-commits
asl wrote: > What make me curious is the motivation case of the PR. I mean what can be > presented in retcon.once ABI after the PR which is impossible/hard before. > And how do we handle that in retcon ABI. Well, the PR allows `recon.once` coroutines to have normal results in addition to yiel

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

2023-09-14 Thread Anton Korobeynikov via cfe-commits
asl wrote: > Got it. Thanks. Then I am wondering how about the `retcon` ABI? I am confused > since the doc said the last continuation of `retcon` ABI will return a > nullptr to indicate it has finished. Don't we have the same problem? Or we > can't solve the problem in `retcon` ABI? Or we just

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

2023-09-15 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl closed https://github.com/llvm/llvm-project/pull/66333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] be61093 - [MSP430][Clang] Remove support for -mmcu=msp430

2021-09-28 Thread Anton Korobeynikov via cfe-commits
Author: Jozef Lawrynowicz Date: 2021-09-28T20:47:26+03:00 New Revision: be610932fa068ed2228b0f694ae80c9294f0293f URL: https://github.com/llvm/llvm-project/commit/be610932fa068ed2228b0f694ae80c9294f0293f DIFF: https://github.com/llvm/llvm-project/commit/be610932fa068ed2228b0f694ae80c9294f0293f.d

[clang] [PAC] Add support for __ptrauth type qualifier (PR #100830)

2024-08-09 Thread Anton Korobeynikov via cfe-commits
asl wrote: > Was there an RFC for this? I ask because it's introducing another qualifier > and that has broad impacts on things beyond Clang like libc++, etc so we > really need buy-in from a wider range of the community than will likely see > this PR. Just my 2 cents from downstream experien

[clang] [clang] Wire -fptrauth-returns to "ptrauth-returns" fn attribute. (PR #102416)

2024-08-09 Thread Anton Korobeynikov via cfe-commits
asl wrote: /cherry-pick 2eb6e30fe83ccce3cf01e596e73fa6385facd44b https://github.com/llvm/llvm-project/pull/102416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Wire -fptrauth-returns to "ptrauth-returns" fn attribute. (PR #102416)

2024-08-09 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl milestoned https://github.com/llvm/llvm-project/pull/102416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement -fptrauth-auth-traps. (PR #102417)

2024-08-09 Thread Anton Korobeynikov via cfe-commits
asl wrote: /cherry-pick d179acd0484bac30c5ebbbed4d29a4734d92ac93 https://github.com/llvm/llvm-project/pull/102417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement -fptrauth-auth-traps. (PR #102417)

2024-08-09 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl milestoned https://github.com/llvm/llvm-project/pull/102417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement -fptrauth-auth-traps. (PR #102417)

2024-08-09 Thread Anton Korobeynikov via cfe-commits
asl wrote: > Failed to cherry-pick: > [d179acd](https://github.com/llvm/llvm-project/commit/d179acd0484bac30c5ebbbed4d29a4734d92ac93) > > https://github.com/llvm/llvm-project/actions/runs/10324823761 > > Please manually backport the fix and push it to your github fork. Once this > is done, pl

[clang] [clang] Implement -fptrauth-auth-traps. (PR #102417)

2024-08-12 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl demilestoned https://github.com/llvm/llvm-project/pull/102417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement -fptrauth-auth-traps. (PR #102417)

2024-08-12 Thread Anton Korobeynikov via cfe-commits
asl wrote: /cherry-pick https://github.com/llvm/llvm-project/commit/d179acd0484bac30c5ebbbed4d29a4734d92ac93 https://github.com/llvm/llvm-project/pull/102417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] [clang] Implement -fptrauth-auth-traps. (PR #102417)

2024-08-12 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl milestoned https://github.com/llvm/llvm-project/pull/102417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PAC][clang] Enhance preprocessor ptrauth tests (PR #98862)

2024-07-15 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl approved this pull request. Thanks https://github.com/llvm/llvm-project/pull/98862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PAC][Driver] Support `pauthtest` ABI for AArch64 Linux triples (PR #97237)

2024-07-16 Thread Anton Korobeynikov via cfe-commits
@@ -324,6 +324,9 @@ ARMTargetInfo::ARMTargetInfo(const llvm::Triple &Triple, case llvm::Triple::GNU: setABI("apcs-gnu"); break; +case llvm::Triple::PAuthTest: asl wrote: Do we really need to touch 32-bit ARM? https://github.com/llvm/llvm-p

  1   2   >