[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl added a comment. Thanks for fixing my tests! This is the second time I messed up the requirements. I am very sorry about that! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153924/new/ https://reviews.llvm.org/D153924

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl added a comment. Thanks a lot for pointing this out and for fixing my mistakes, Arthur and Hans. I am sorry for the inconvenience! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153924/new/ https://reviews.llvm.org/D153924

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c9988f85d25: [OpenMP] Allow exceptions in target regions when offloading to GPUs (authored by AntonRydahl). Repository: rG LLVM Github Monorepo

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl updated this revision to Diff 554520. AntonRydahl added a comment. Updating the line numbers in the unit tests to match the addition of `// REQUIRES: ` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153924/new/ https://reviews.llvm.org/

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c62e943b717: [OpenMP] Allow exceptions in target regions when offloading to GPUs (authored by AntonRydahl). Repository: rG LLVM Github Monorepo

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl updated this revision to Diff 554401. AntonRydahl added a comment. After landing this patch, two of the unit tests broke aarch64 and Windows build bots. To avoid that, `// REQUIRES:` was added to the unit tests to ensure that they only run when the target triple is supported. Repos

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

This revision was automatically updated to reflect the committed changes. Closed by commit rG0cfc2dba93b1: [OpenMP] Allow exceptions in target regions when offloading to GPUs (authored by AntonRydahl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl added a comment. In D153924#4623357 , @jhuber6 wrote: > The libcxx tests are always broken randomly in my experience. I wouldn't > worry about it. Thanks a bunch! I did not know that. Shall I just land the patch? Repository: rG LLVM Gith

[PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for -fopenmp-version

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGc1b5674fbb76: [OpenMP] Change OpenMP default version in documentation and help text for… (authored by AntonRydahl). Repos

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl updated this revision to Diff 554132. AntonRydahl added a comment. Rebased on main to see if libc++ CI is still failing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153924/new/ https://reviews.llvm.org/D153924 Files: clang/include/

[PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for -fopenmp-version

AntonRydahl updated this revision to Diff 554049. AntonRydahl added a comment. Rebased on main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156901/new/ https://reviews.llvm.org/D156901 Files: clang/docs/OpenMPSupport.rst clang/include/clang/

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl marked 2 inline comments as done. AntonRydahl added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:869 bool IsThrownVarInScope) { - // Don't report an error if 'throw' is used in system headers. - if (!getLangOpts().CXXEx

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl updated this revision to Diff 554034. AntonRydahl marked 2 inline comments as done. AntonRydahl added a comment. Replaced instances of `const llvm::Triple T` with `const llvm::Triple &T`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl marked 2 inline comments as done. AntonRydahl added inline comments. Comment at: clang/test/OpenMP/amdgpu_exceptions.cpp:11 +// RUN: %clang_cc1 -fopenmp -triple amdgcn-amd-amdhsa -fopenmp-is-target-device -fexceptions %s -emit-llvm -S -verify=with -Wopenmp-target-ex

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl updated this revision to Diff 554021. AntonRydahl added a comment. Moved emission of warnings from CodeGen to Sema to allow using `-verify -analyze`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153924/new/ https://reviews.llvm.org/D1

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl updated this revision to Diff 551600. AntonRydahl added a comment. CI tests failed on the built-bot, but that was not related to this patch. I patched the file that made the built-bot fail and rebased this differential after the patch. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl updated this revision to Diff 551560. AntonRydahl added a comment. Rebased on upstream LLVM to check if flang CI is still affected by this commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153924/new/ https://reviews.llvm.org/D1539

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl updated this revision to Diff 551323. AntonRydahl added a comment. Avoided changing clang/lib/Frontend/CompilerInvocation.cpp by performing checks for OpenMP offloading to GPU devices in Sema instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for -fopenmp-version

AntonRydahl updated this revision to Diff 547065. AntonRydahl added a comment. Removed whitespace that caused CI tests to fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156901/new/ https://reviews.llvm.org/D156901 Files: clang/docs/OpenMPSu

[PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for -fopenmp-version

AntonRydahl added a comment. The unit test that fails, `flang/test/Driver/omp-driver-offload.f90`, also fails on main. I don't see that it should be related to this patch. Comment at: flang/test/Driver/driver-help.f90:55 ! HELP-NEXT: -fopenmp-version= -! HELP-NEXT:

[PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for -fopenmp-version

AntonRydahl updated this revision to Diff 546964. AntonRydahl added a comment. Removing information about Flang default version of OpenMP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156901/new/ https://reviews.llvm.org/D156901 Files: clang/do

[PATCH] D153924: Allowing exception handling in OpenMP target regions when offloading to AMDGCN or NVPTX targets

AntonRydahl added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:432 + "Target '%0' does not support exception handling." + " To allow code generation for '%0', 'catch' statement will be replaced by a no operation instruction.">; } ---

[PATCH] D153924: Allowing exception handling in OpenMP target regions when offloading to AMDGCN or NVPTX targets

AntonRydahl marked 2 inline comments as done. AntonRydahl added inline comments. Comment at: clang/lib/CodeGen/CGException.cpp:624 + const bool is_omp_gpu_target = + (CGM.getLangOpts().OpenMPIsDevice && (T.isNVPTX() || T.isAMDGCN())); + if (is_omp_gpu_target) { ---

[PATCH] D153924: Allowing exception handling in OpenMP target regions when offloading to AMDGCN or NVPTX targets

AntonRydahl updated this revision to Diff 546636. AntonRydahl added a comment. Herald added subscribers: wangpc, kerbowa, jvesely. Updated the tests to use `%clang_cc1 -verify`. There are still things that need to be improved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for --fopenmp-version

AntonRydahl added inline comments. Comment at: flang/test/Driver/driver-help.f90:55 ! HELP-NEXT: -fopenmp-version= -! HELP-NEXT:Set OpenMP version (e.g. 45 for OpenMP 4.5, 50 for OpenMP 5.0). Default value is 50 for Clang and 11 for Flang +! HELP-NEXT:

[PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for --fopenmp-version

AntonRydahl updated this revision to Diff 546477. AntonRydahl added a comment. I was a bit too fast. I changed OpenMPSupport.rst to point to both the OpenMP 5.0 and OpenMP 5.1 implementation status. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156

[PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for --fopenmp-version

AntonRydahl created this revision. AntonRydahl added a reviewer: jdoerfert. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added projects: Flang, All. AntonRydahl requested review of this revision. Herald added

[PATCH] D156641: [Clang][Frontend] Change help text for --offload-host-device

This revision was automatically updated to reflect the committed changes. Closed by commit rG2301e13269d5: [Clang][Frontend] Change help text for --offload-host-device (authored by AntonRydahl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156641/ne

[PATCH] D156641: [Clang][Frontend] Change help text for --offload-host-device

AntonRydahl updated this revision to Diff 546083. AntonRydahl added a comment. Rebased on latest commit from main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156641/new/ https://reviews.llvm.org/D156641 Files: clang/include/clang/Driver/Optio

[PATCH] D156641: [Clang][Frontend] Change help text for --offload-host-device

AntonRydahl updated this revision to Diff 545867. AntonRydahl added a comment. Running tests again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156641/new/ https://reviews.llvm.org/D156641 Files: clang/include/clang/Driver/Options.td flang/t

[PATCH] D156641: [Clang][Frontend] Change help text for --offload-host-device

AntonRydahl added a comment. The tests that failed pass locally on my machine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156641/new/ https://reviews.llvm.org/D156641 ___ cfe-commits mailing list cfe-

[PATCH] D156641: [Clang][Frontend] Change help text for --offload-host-device

AntonRydahl created this revision. AntonRydahl added a reviewer: jdoerfert. Herald added a reviewer: awarzynski. Herald added projects: Flang, All. AntonRydahl requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. I believe the help text f

[PATCH] D153924: Allowing exception handling in OpenMP target regions when offloading to AMDGCN or NVPTX targets

AntonRydahl created this revision. AntonRydahl added reviewers: jdoerfert, jhuber6. Herald added subscribers: sunshaoce, mattd, gchakrabarti, asavonic, guansong, tpr, yaxunl, rampitec. Herald added a project: All. AntonRydahl requested review of this revision. Herald added subscribers: cfe-commits