Arfrever added a comment.
In `clang-tools-extra/clangd/unittests/CMakeLists.txt`, usage of
`CompletionModel.cmake` probably also should be dependent on
`CLANGD_DECISION_FOREST`.
In `clang-tools-extra/clangd/CMakeLists.txt` and
`clang-tools-extra/clangd/unittests/CMakeLists.txt`, calls to
`tar
Arfrever added inline comments.
Comment at: clang-tools-extra/clangd/quality/CompletionModel.cmake:25
+
+ file(GLOB cpp_files "${output_dir}/${filename}*.cpp")
+
thakis wrote:
> Can we list them? We try not to use globs in cmakelists.txt files.
This `gen_decisio
Arfrever added a comment.
After reading this discussion, I need some clarification.
If there were the followining symlinks pointing to `clang`:
`i386-pc-linux-gnu-clang`, `i486-pc-linux-gnu-clang`,
`i586-pc-linux-gnu-clang`, `i686-pc-linux-gnu-clang`,
`x86_64-pc-linux-gnu-clang`.
Then do I ass
Arfrever added inline comments.
Comment at: clang/lib/Basic/CMakeLists.txt:114-117
+target_link_libraries(clangBasic
+ PRIVATE
+ ${LLVM_ATOMIC_LIB}
+)
mgorny wrote:
> Is this the right place? Grepping for `std::atomic`, I see lib/Frontend and a
> bunch of tool
Arfrever added inline comments.
Comment at: llvm/docs/GettingStarted.rst:1225
+* -DLLVM_ENABLE_RUNTIMES
+ Set this equal to the runtimes you wish to compile (e.g. libcxx, libcxxabi,
etc.)
One space is missing before `*`, so currently this part of this page i
Arfrever added inline comments.
Comment at: clang/docs/UsersManual.rst:877
For example, if the Clang executable is named `armv7l-clang` (it may be a
symbolic link to `clang`), then Clang will search for file `armv7l.cfg` in the
+directories mentioned above. If the executable is
Arfrever added a comment.
This commit is missing in `release/12.x` branch, so `scan-view` in recently
released Clang 12.0.0 is broken.
Please backport this commit to `release/12.x` branch so that it is included at
least in upcoming Clang 12.0.1.
Repository:
rG LLVM Github Monorepo
CHANGES S
