https://github.com/aeubanks closed
https://github.com/llvm/llvm-project/pull/139614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aeubanks wrote:
I've also seen ConstantEvaluationC99 intermittently fail on our mac bots
recently
https://github.com/llvm/llvm-project/pull/134196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
https://github.com/aeubanks edited
https://github.com/llvm/llvm-project/pull/138343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aeubanks edited
https://github.com/llvm/llvm-project/pull/138343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -106,7 +106,7 @@ if (LLVM_EXPORTED_SYMBOL_FILE)
DEPENDS ${LIBCLANG_VERSION_SCRIPT_FILE})
endif()
-if((NOT (WIN32 OR CYGWIN) AND LLVM_ENABLE_PIC) OR
+if((NOT CYGWIN AND LLVM_ENABLE_PIC) OR
((WIN32 OR CYGWIN) AND NOT LIBCLANG_BUILD_STATIC))
---
https://github.com/aeubanks edited
https://github.com/llvm/llvm-project/pull/138343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aeubanks updated
https://github.com/llvm/llvm-project/pull/138343
>From f3e9e6f256bef046b513701a43b369c5c127aac7 Mon Sep 17 00:00:00 2001
From: Arthur Eubanks
Date: Fri, 2 May 2025 20:39:17 +
Subject: [PATCH 1/2] [cmake] Reenable libclang.dll on Windows when
LLVM_ENABLE_
@@ -106,7 +106,8 @@ if (LLVM_EXPORTED_SYMBOL_FILE)
DEPENDS ${LIBCLANG_VERSION_SCRIPT_FILE})
endif()
-if(LLVM_ENABLE_PIC OR (WIN32 AND NOT LIBCLANG_BUILD_STATIC))
+if((NOT (WIN32 OR CYGWIN) AND LLVM_ENABLE_PIC) OR
+ ((WIN32 OR CYGWIN) AND NOT LIBCLANG_BUIL
https://github.com/aeubanks created
https://github.com/llvm/llvm-project/pull/138343
This was accidentally disabled in #138119 for non-mingw Windows.
>From f3e9e6f256bef046b513701a43b369c5c127aac7 Mon Sep 17 00:00:00 2001
From: Arthur Eubanks
Date: Fri, 2 May 2025 20:39:17 +
Subject: [PATC
@@ -106,7 +106,8 @@ if (LLVM_EXPORTED_SYMBOL_FILE)
DEPENDS ${LIBCLANG_VERSION_SCRIPT_FILE})
endif()
-if(LLVM_ENABLE_PIC OR (WIN32 AND NOT LIBCLANG_BUILD_STATIC))
+if((NOT (WIN32 OR CYGWIN) AND LLVM_ENABLE_PIC) OR
+ ((WIN32 OR CYGWIN) AND NOT LIBCLANG_BUIL
aeubanks wrote:
this causes a `-Wmicrosoft-goto` warning on
```
$ cat /tmp/a.c
void f() {
goto l;
int i = 0;
l:
}
$ bin/clang-cl /c /tmp/a.c
...
/tmp/a.c(2,2): warning: jump from this goto statement to its label is a
Microsoft extension [-Wmicrosoft-goto]
2 | goto l;
https://github.com/aeubanks approved this pull request.
https://github.com/llvm/llvm-project/pull/138172
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -130,6 +133,20 @@ static bool saveMLIRTempFile(const CompilerInvocation &ci,
// Custom BeginSourceFileAction
//===--===//
+
+static llvm::cl::opt ClPGOColdFuncAttr(
aeubanks wrote:
sorry,
https://github.com/aeubanks approved this pull request.
https://github.com/llvm/llvm-project/pull/138035
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -296,7 +296,14 @@ int cc1_main(ArrayRef Argv, const char
*Argv0, void *MainAddr) {
// If any timers were active but haven't been destroyed yet, print their
// results now. This happens in -disable-free mode.
- llvm::TimerGroup::printAll(llvm::errs());
+ // llvm::Tim
@@ -442,10 +442,6 @@ void TimerGroup::clearAll() {
void TimerGroup::printJSONValue(raw_ostream &OS, const PrintRecord &R,
const char *suffix, double Value) {
- assert(yaml::needsQuotes(Name) == yaml::QuotingType::None &&
aeuban
https://github.com/aeubanks edited
https://github.com/llvm/llvm-project/pull/137737
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aeubanks approved this pull request.
lgtm, although I'd like @AaronBallman to take a quick look to make sure this
seems ok (e.g. naming)
https://github.com/llvm/llvm-project/pull/137737
___
cfe-commits mailing list
cfe-commits@lists
https://github.com/aeubanks closed
https://github.com/llvm/llvm-project/pull/136154
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aeubanks wrote:
ah yes, the build directory can be outside of the source directory, lgtm. still
good to keep the other PR though so outside .clang-format-ignore files don't
leak into clang-format used inside llvm-project
https://github.com/llvm/llvm-project/pull/136154
aeubanks wrote:
I'm guessing that a stage2 build of clang would probably repro the issue,
perhaps this was tested against older clangs that didn't warn on this.
https://github.com/llvm/llvm-project/pull/133173
___
cfe-commits mailing list
cfe-commits@
aeubanks wrote:
we're seeing the following after this patch:
```
/Volumes/Work/s/w/ir/cache/builder/src/third_party/llvm/llvm/lib/Support/ProgramStack.cpp:67:34:
error: this directive must appear between .cfi_startproc and .cfi_endproc
directives
67 | "add x29, x0, #0x10\n\t"
aeubanks wrote:
@mizvekov we're seeing pcm non-determinism after this reland, does anything
jump out at you?
https://github.com/llvm/llvm-project/pull/132401
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
aeubanks wrote:
hi, this breaks
`clang -cc1 -triple x86_64-pc-windows-msvc19.26.0 -fsyntax-only
-fms-extensions -fms-compatibility -fms-compatibility-version=19.26 -std=c++17
/tmp/a.ii`
[a.ii.txt](https://github.com/user-attachments/files/19375232/a.ii.txt)
which breaks stage 2 builds of cla
aeubanks wrote:
thanks!
https://github.com/llvm/llvm-project/pull/131965
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aeubanks wrote:
seems like there are conflicts reverting this at head, could you take a look
@mizvekov?
https://github.com/llvm/llvm-project/pull/131965
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
https://github.com/aeubanks closed
https://github.com/llvm/llvm-project/pull/131036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aeubanks approved this pull request.
not locking causing the test failures makes sense
https://github.com/llvm/llvm-project/pull/131217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
https://github.com/aeubanks created
https://github.com/llvm/llvm-project/pull/131173
Reverts llvm/llvm-project#130375
Causes breakages, e.g. https://lab.llvm.org/buildbot/#/builders/160/builds/14607
>From 747535b6fd8b3bbee0c8a34a7d92fd47a89d65f5 Mon Sep 17 00:00:00 2001
From: Arthur Eubanks
D
https://github.com/aeubanks updated
https://github.com/llvm/llvm-project/pull/131036
>From 6ab707eec90cbe1d8a8f5ddf19765f514b275095 Mon Sep 17 00:00:00 2001
From: Arthur Eubanks
Date: Wed, 12 Mar 2025 21:42:47 +
Subject: [PATCH 1/2] [clang][lit] mkdir before mkstemp in
is_filesystem_case_i
https://github.com/aeubanks approved this pull request.
lgtm
https://github.com/llvm/llvm-project/pull/130375
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aeubanks created
https://github.com/llvm/llvm-project/pull/131036
In the CMake build test_exec_root already exists here, but not in the gn build,
which causes this to fail.
>From 6ab707eec90cbe1d8a8f5ddf19765f514b275095 Mon Sep 17 00:00:00 2001
From: Arthur Eubanks
Date: We
@@ -39,19 +39,20 @@ Timer *getPassTimer(Pass *);
/// This class implements -time-passes functionality for new pass manager.
/// It provides the pass-instrumentation callbacks that measure the pass
/// execution time. They collect timing info into individual timers as
-/// passe
@@ -62,16 +62,13 @@ class PassTimingInfo {
private:
StringMap PassIDCountMap; ///< Map that counts instances of passes
- DenseMap> TimingData; ///< timers for
pass instances
- TimerGroup TG;
+ DenseMap TimingData; ///< timers for pass instances
aeubanks
@@ -19,6 +19,5 @@
// NPM: InstCombinePass{{$}}
// NPM-NOT: InstCombinePass #
// TIME: Total{{$}}
-// NPM: Pass execution timing report
aeubanks wrote:
why does this line disappear?
https://github.com/llvm/llvm-project/pull/130375
_
@@ -115,7 +103,9 @@ void PassTimingInfo::init() {
/// Prints out timing information and then resets the timers.
void PassTimingInfo::print(raw_ostream *OutStream) {
- TG.print(OutStream ? *OutStream : *CreateInfoOutputFile(), true);
+ NamedRegionTimer::getNamedTimerGroup(Tim
@@ -169,6 +169,17 @@ struct NamedRegionTimer : public TimeRegion {
explicit NamedRegionTimer(StringRef Name, StringRef Description,
StringRef GroupName,
StringRef GroupDescription, bool Enabled = true);
+
+ // Create or
https://github.com/aeubanks closed
https://github.com/llvm/llvm-project/pull/124834
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aeubanks wrote:
I believe all concerns have been addressed, will merge now with the approvals.
Happy to follow up on any other concerns.
https://github.com/llvm/llvm-project/pull/124834
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://l
https://github.com/aeubanks updated
https://github.com/llvm/llvm-project/pull/124834
>From 7c40169ec7430ec64aaeb053e423eca1ceff7f0d Mon Sep 17 00:00:00 2001
From: Arthur Eubanks
Date: Tue, 28 Jan 2025 20:36:58 +
Subject: [PATCH 01/11] [clang][X86] Support
__attribute__((model("small"/"larg
https://github.com/aeubanks deleted
https://github.com/llvm/llvm-project/pull/124834
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2950,12 +2950,11 @@ static void handleSectionAttr(Sema &S, Decl *D, const
ParsedAttr &AL) {
}
}
-static bool isValidCodeModelAttr(Sema &S, StringRef Str) {
- if (S.Context.getTargetInfo().getTriple().isLoongArch()) {
+static bool isValidCodeModelAttr(llvm::Triple Tripl
https://github.com/aeubanks updated
https://github.com/llvm/llvm-project/pull/124834
>From 7c40169ec7430ec64aaeb053e423eca1ceff7f0d Mon Sep 17 00:00:00 2001
From: Arthur Eubanks
Date: Tue, 28 Jan 2025 20:36:58 +
Subject: [PATCH 01/11] [clang][X86] Support
__attribute__((model("small"/"larg
https://github.com/aeubanks updated
https://github.com/llvm/llvm-project/pull/124834
>From 7c40169ec7430ec64aaeb053e423eca1ceff7f0d Mon Sep 17 00:00:00 2001
From: Arthur Eubanks
Date: Tue, 28 Jan 2025 20:36:58 +
Subject: [PATCH 01/10] [clang][X86] Support
__attribute__((model("small"/"larg
@@ -2964,20 +2963,36 @@ static bool isValidCodeModelAttr(Sema &S, StringRef
Str) {
static void handleCodeModelAttr(Sema &S, Decl *D, const ParsedAttr &AL) {
StringRef Str;
SourceLocation LiteralLoc;
+ auto IsTripleSupported = [](const llvm::Triple Triple) {
+return Tr
@@ -2949,15 +2950,34 @@ static void handleSectionAttr(Sema &S, Decl *D, const
ParsedAttr &AL) {
}
}
+static bool isValidCodeModelAttr(Sema &S, StringRef Str) {
+ if (S.Context.getTargetInfo().getTriple().isLoongArch()) {
+return Str == "normal" || Str == "medium" || St
https://github.com/aeubanks edited
https://github.com/llvm/llvm-project/pull/124834
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aeubanks updated
https://github.com/llvm/llvm-project/pull/124834
>From 7c40169ec7430ec64aaeb053e423eca1ceff7f0d Mon Sep 17 00:00:00 2001
From: Arthur Eubanks
Date: Tue, 28 Jan 2025 20:36:58 +
Subject: [PATCH 1/9] [clang][X86] Support
__attribute__((model("small"/"large"
https://github.com/aeubanks approved this pull request.
https://github.com/llvm/llvm-project/pull/125944
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -62,6 +62,10 @@ def CodeModelDocs : Documentation {
let Content = [{
The ``model`` attribute allows overriding the translation unit's
code model (specified by ``-mcmodel``) for a specific global variable.
+
+On LoongArch, allowed values are "normal", "medium", "extreme".
-
https://github.com/aeubanks updated
https://github.com/llvm/llvm-project/pull/124834
>From 7c40169ec7430ec64aaeb053e423eca1ceff7f0d Mon Sep 17 00:00:00 2001
From: Arthur Eubanks
Date: Tue, 28 Jan 2025 20:36:58 +
Subject: [PATCH 1/8] [clang][X86] Support
__attribute__((model("small"/"large"
https://github.com/aeubanks updated
https://github.com/llvm/llvm-project/pull/124834
>From 7c40169ec7430ec64aaeb053e423eca1ceff7f0d Mon Sep 17 00:00:00 2001
From: Arthur Eubanks
Date: Tue, 28 Jan 2025 20:36:58 +
Subject: [PATCH 1/7] [clang][X86] Support
__attribute__((model("small"/"large"
@@ -3117,11 +3120,20 @@ def PragmaClangTextSection : InheritableAttr {
let Documentation = [InternalOnly];
}
-def CodeModel : InheritableAttr, TargetSpecificAttr {
+// The code model attribute only applies to LoongArch and x86-64, but for NVPTX
aeubanks wrot
@@ -2949,15 +2950,34 @@ static void handleSectionAttr(Sema &S, Decl *D, const
ParsedAttr &AL) {
}
}
+static bool isValidCodeModelAttr(Sema &S, StringRef Str) {
+ if (S.Context.getTargetInfo().getTriple().isLoongArch()) {
+return Str == "normal" || Str == "medium" || St
https://github.com/aeubanks edited
https://github.com/llvm/llvm-project/pull/124834
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2949,15 +2950,32 @@ static void handleSectionAttr(Sema &S, Decl *D, const
ParsedAttr &AL) {
}
}
+static bool isValidCodeModelAttr(Sema &S, StringRef Str) {
+ if (S.Context.getTargetInfo().getTriple().isLoongArch()) {
+return Str == "normal" || Str == "medium" || St
https://github.com/aeubanks updated
https://github.com/llvm/llvm-project/pull/124834
>From 7c40169ec7430ec64aaeb053e423eca1ceff7f0d Mon Sep 17 00:00:00 2001
From: Arthur Eubanks
Date: Tue, 28 Jan 2025 20:36:58 +
Subject: [PATCH 1/6] [clang][X86] Support
__attribute__((model("small"/"large"
Author: Arthur Eubanks
Date: 2025-02-03T22:12:04Z
New Revision: 5dccfd9283cd784758aa3d16fcb6e31f135c080f
URL:
https://github.com/llvm/llvm-project/commit/5dccfd9283cd784758aa3d16fcb6e31f135c080f
DIFF:
https://github.com/llvm/llvm-project/commit/5dccfd9283cd784758aa3d16fcb6e31f135c080f.diff
LOG
https://github.com/aeubanks updated
https://github.com/llvm/llvm-project/pull/124834
>From 7c40169ec7430ec64aaeb053e423eca1ceff7f0d Mon Sep 17 00:00:00 2001
From: Arthur Eubanks
Date: Tue, 28 Jan 2025 20:36:58 +
Subject: [PATCH 1/5] [clang][X86] Support
__attribute__((model("small"/"large"
aeubanks wrote:
I've allowed the attribute for NVPTX targets and ignored it in SemaDeclAttr
rather than figure out how to conditionally emit a warning during codegen, does
that work?
https://github.com/llvm/llvm-project/pull/124834
___
cfe-commits ma
@@ -1,64 +1,40 @@
-// RUN: %clang_cc1 -triple aarch64 -verify=expected,aarch64 -fsyntax-only %s
+// RUN: %clang_cc1 -triple aarch64 -verify=expected,unsupported -fsyntax-only
%s
// RUN: %clang_cc1 -triple loongarch64 -verify=expected,loongarch64
-fsyntax-only %s
-// RUN: %clang
@@ -1,64 +1,40 @@
-// RUN: %clang_cc1 -triple aarch64 -verify=expected,aarch64 -fsyntax-only %s
+// RUN: %clang_cc1 -triple aarch64 -verify=expected,unsupported -fsyntax-only
%s
// RUN: %clang_cc1 -triple loongarch64 -verify=expected,loongarch64
-fsyntax-only %s
-// RUN: %clang
https://github.com/aeubanks edited
https://github.com/llvm/llvm-project/pull/124834
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1,64 +1,40 @@
-// RUN: %clang_cc1 -triple aarch64 -verify=expected,aarch64 -fsyntax-only %s
+// RUN: %clang_cc1 -triple aarch64 -verify=expected,unsupported -fsyntax-only
%s
// RUN: %clang_cc1 -triple loongarch64 -verify=expected,loongarch64
-fsyntax-only %s
-// RUN: %clang
@@ -5,7 +5,7 @@
// RUN: %clang_cc1 -triple riscv64 -verify=expected,riscv64 -fsyntax-only %s
// RUN: %clang_cc1 -triple x86_64 -verify=expected,x86_64 -fsyntax-only %s
aeubanks wrote:
done
https://github.com/llvm/llvm-project/pull/124834
__
https://github.com/aeubanks updated
https://github.com/llvm/llvm-project/pull/124834
>From 7c40169ec7430ec64aaeb053e423eca1ceff7f0d Mon Sep 17 00:00:00 2001
From: Arthur Eubanks
Date: Tue, 28 Jan 2025 20:36:58 +
Subject: [PATCH 1/4] [clang][X86] Support
__attribute__((model("small"/"large"
https://github.com/aeubanks updated
https://github.com/llvm/llvm-project/pull/124834
>From 7c40169ec7430ec64aaeb053e423eca1ceff7f0d Mon Sep 17 00:00:00 2001
From: Arthur Eubanks
Date: Tue, 28 Jan 2025 20:36:58 +
Subject: [PATCH 1/3] [clang][X86] Support
__attribute__((model("small"/"large"
@@ -5,7 +5,7 @@
// RUN: %clang_cc1 -triple riscv64 -verify=expected,riscv64 -fsyntax-only %s
// RUN: %clang_cc1 -triple x86_64 -verify=expected,x86_64 -fsyntax-only %s
aeubanks wrote:
does the change to this test make sense, or am I missing something that putti
@@ -2949,6 +2950,13 @@ static void handleSectionAttr(Sema &S, Decl *D, const
ParsedAttr &AL) {
}
}
+static bool isValidCodeModelAttr(Sema &S, StringRef Str) {
+ bool IsX8664Target =
+ S.Context.getTargetInfo().getTriple().getArch() == llvm::Triple::x86_64;
+ bool IsX
https://github.com/aeubanks updated
https://github.com/llvm/llvm-project/pull/124834
>From 7c40169ec7430ec64aaeb053e423eca1ceff7f0d Mon Sep 17 00:00:00 2001
From: Arthur Eubanks
Date: Tue, 28 Jan 2025 20:36:58 +
Subject: [PATCH 1/2] [clang][X86] Support
__attribute__((model("small"/"large"
@@ -5,7 +5,7 @@
// RUN: %clang_cc1 -triple riscv64 -verify=expected,riscv64 -fsyntax-only %s
// RUN: %clang_cc1 -triple x86_64 -verify=expected,x86_64 -fsyntax-only %s
aeubanks wrote:
I thought nvptx64 was the GPU-side of things, the GPU side is also using code
https://github.com/aeubanks created
https://github.com/llvm/llvm-project/pull/124834
Following up #72078, on x86-64 this allows a global to be considered small or
large regardless of the code model. For example, x86-64's medium code model by
default classifies globals as small or large dependi
https://github.com/aeubanks approved this pull request.
https://github.com/llvm/llvm-project/pull/119365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -594,9 +580,9 @@ BasicAAResult::DecomposeGEPExpression(const Value *V, const
DataLayout &DL,
SearchTimes++;
const Instruction *CxtI = dyn_cast(V);
- unsigned MaxIndexSize = DL.getMaxIndexSizeInBits();
aeubanks wrote:
looks like `getMaxIndexSizeInBits
aeubanks wrote:
I believe the failure reported in the original bot is only under expensive
checks (`-DLLVM_ENABLE_EXPENSIVE_CHECKS=ON`)
https://github.com/llvm/llvm-project/pull/113780
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
aeubanks wrote:
perhaps the `flock` cmake check doesn't work on windows for some reason? maybe
wrong include?
https://github.com/llvm/llvm-project/pull/111332
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
aeubanks wrote:
I believe Chrome is also seeing many test failures due to this
(https://crbug.com/374115887), although I haven't yet confirmed it's due to
this specific commit.
https://github.com/llvm/llvm-project/pull/86318
___
cfe-commits mailing l
https://github.com/aeubanks approved this pull request.
relanding lgtm since the exposed issue was fixed
https://github.com/llvm/llvm-project/pull/112749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
aeubanks wrote:
I've reverted this in 9e6d24f61f3a6730465f3427463dd958cdcd8b9a
https://github.com/llvm/llvm-project/pull/91101
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Arthur Eubanks
Date: 2024-10-16T21:21:34Z
New Revision: 9e6d24f61f3a6730465f3427463dd958cdcd8b9a
URL:
https://github.com/llvm/llvm-project/commit/9e6d24f61f3a6730465f3427463dd958cdcd8b9a
DIFF:
https://github.com/llvm/llvm-project/commit/9e6d24f61f3a6730465f3427463dd958cdcd8b9a.diff
LOG
aeubanks wrote:
This causes broken IR:
```
$ opt -O3 -disable-output /tmp/a.ll
Range bit width must match type bit width!
tail call void @llvm.memset.p0.i64(ptr noundef align 1 %dst, i8 noundef
range(i32 0, 256) %v8, i64 noundef range(i64 -2147483648, 21474836
aeubanks wrote:
for such a wide-reaching change, it would have been nice to add the new
function in one commit, update users in other commits, then remove the old
function in one last commit. makes it easier to revert the removal of the old
function, and makes it easier for out of tree users t
aeubanks wrote:
ah there's a stack trace in an asserts build of clang
```
F 00:00:1728077756.9778713296 logging.cc:62] assert.h assertion failed
at
third_party/llvm/llvm-project/clang/lib/Sema/SemaTemplateInstantiate.cpp:4602
in llvm::PointerUnion
*clang::LocalInstantiationScope::find
aeubanks wrote:
this has also caused the following issue to pop up in our modules build
```
error: variable 'param' cannot be implicitly captured in a lambda with no
capture-default specified
```
hopefully the error provides some guidance for where to look, but I can try to
get a reduced repr
https://github.com/aeubanks commented:
I see that MMI really is a Codegen concept and not a Target concept, so that's
why it takes an LLVMTargetMachine instead of TargetMachine. However, the
`static_cast`s everywhere are extremely unfortunate. And it doesn't make sense
to make the return type
https://github.com/aeubanks commented:
ah there's more context in https://reviews.llvm.org/D123964
https://github.com/llvm/llvm-project/pull/110443
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
@@ -1162,6 +1165,7 @@ void EmitAssemblyHelper::RunCodegenPipeline(
// does not work with the codegen pipeline.
// FIXME: make the new PM work with the codegen pipeline.
legacy::PassManager CodeGenPasses;
+ std::unique_ptr MMI;
aeubanks wrote:
can this j
@@ -106,16 +106,18 @@ class MachineModuleInfo {
const Function *LastRequest = nullptr; ///< Used for shortcut/cache.
MachineFunction *LastResult = nullptr; ///< Used for shortcut/cache.
- MachineModuleInfo &operator=(MachineModuleInfo &&MMII) = delete;
+ /// Deleted copy
https://github.com/aeubanks edited
https://github.com/llvm/llvm-project/pull/110443
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aeubanks commented:
I'm still trying to wrap my head around LLVMTargetMachine vs TargetMachine, let
me do some reading
https://github.com/llvm/llvm-project/pull/110443
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://
aeubanks wrote:
hmm yeah it does seem that `MCContext` is hard to unentangle from
`MMI`/`MachineFunction`
is it possible to split out the "MMIWP doesn't own MMI" change? that seems less
controversial and easier to review/merge and makes the `MCContext` changes
easier to look at
https://githu
aeubanks wrote:
sorry for the delay
after looking at MMI/MCContext, I agree that MMI shouldn't own MCContext, but
do we even need a reference from MMI to MCContext? they are different layers of
codegen IIUC. if it's possible to completely separate them we should do that
(please correct me if
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Kyungwoo Lee
,Dmitry
Polukhin ,Dmitry Polukhin
Message-ID:
In-Reply-To:
aeubanks wrote:
here's something reduced, let me know if you need the command to create the pch
file as well
```
https://github.com/llvm/llvm-project/pull/104512
_
https://github.com/aeubanks created
https://github.com/llvm/llvm-project/pull/108452
With the legacy runtime directory layout, the runtime libraries are under
`lib/clang/20/lib/windows` and have an arch suffix.
>From c45f5df3c0ba7afd6c5e14e8e49ffa853abc7147 Mon Sep 17 00:00:00 2001
From: Arthu
Valentin Clement =?utf-8?b?KOODkOODrOODsw==?=,Kyungwoo Lee
,Dmitry
Polukhin ,Dmitry Polukhin
Message-ID:
In-Reply-To:
aeubanks wrote:
let me try to come up with a reduced repro
https://github.com/llvm/llvm-project/pull/104512
___
cfe-commits mail
aeubanks wrote:
this looks like it has false positives: https://crbug.com/366074092
can we revert in the meantime?
https://github.com/llvm/llvm-project/pull/107213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
@@ -136,7 +160,7 @@ append_list_if(MINGW "${MINGW_LIBRARIES}" ASAN_DYNAMIC_LIBS)
add_compiler_rt_object_libraries(RTAsan_dynamic
OS ${SANITIZER_COMMON_SUPPORTED_OS}
ARCHS ${ASAN_SUPPORTED_ARCH}
- SOURCES ${ASAN_SOURCES} ${ASAN_CXX_SOURCES}
+ SOURCES ${ASAN_SOURCES}
--
aeubanks wrote:
previous passing output
```
2: =
3: ==7382==ERROR: AddressSanitizer: requested allocation size 0x101
(0x1001008 after adjustments for alignment, red zones etc.) exceeds maximum
supported size o
aeubanks wrote:
I think this is also somehow affecting asan tests on macos:
https://green.lab.llvm.org/job/llvm.org/job/clang-stage1-RA/2034/
was able to reproduce locally
`build/cmake/runtimes/runtimes-bins/compiler-rt/test/sanitizer_common/asan-arm64-Darwin/allocator_returns_null.cpp`
faili
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Kyungwoo Lee
,Dmitry
Polukhin ,Dmitry Polukhin
Message-ID:
In-Reply-To:
aeubanks wrote:
this is causing a crash with precompiled headers. I can try to reduce, but
hopefully the problem is obvious from this assert/stack trace?
```
clang++: ../..
1 - 100 of 532 matches
Mail list logo
