[PATCH] D149165: [clangd] Deduplicate missing-include findings

ArturGainullin added a comment. In D149165#4309463 , @kadircet wrote: > Thanks @ArturGainullin ! you're right, i've sent out > 5e74a3dc2da879d98204f2360e2e33571b93b91b > . @kadircet T

[PATCH] D149165: [clangd] Deduplicate missing-include findings

ArturGainullin added a comment. Hello! After this change IncludeCleaner.GenerateMissingHeaderDiags unit test from ClangdTests.exe is failing on Windows for Debug build. Could you please take a look. It looks like error appears because comparator doesn't satisfy strict weak ordering. I.e. it fa

[PATCH] D100361: [Driver] Make the findVCToolChainViaEnvironment case-insensitive

ArturGainullin added a comment. In D100361#2686823 , @rnk wrote: > Example: > https://github.com/llvm/llvm-project/blob/main/clang/unittests/Driver/ToolChainTest.cpp#L29 Thank you for the example! I will take a look and may consider adding a test as a

[PATCH] D100361: [Driver] Make the findVCToolChainViaEnvironment case-insensitive

This revision was automatically updated to reflect the committed changes. Closed by commit rG192c6023e1e2: [Driver] Make the findVCToolChainViaEnvironment case-insensitive (authored by ArturGainullin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10

[PATCH] D100361: [Driver] Make the findVCToolChainViaEnvironment case-insensitive

ArturGainullin created this revision. ArturGainullin added reviewers: rnk, hamzasood. ArturGainullin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. PATH usage on Windows is case-insensitive. There could be situations when toolchain path ca

[PATCH] D96538: [SYCL] Ignore file-scope asm during device-side SYCL compilation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGff50b121e336: [SYCL] Ignore file-scope asm during device-side SYCL compilation. (authored by ArturGainullin). Repository: rG LLVM Github Monorepo

[PATCH] D96538: [SYCL] Ignore file-scope asm during device-side SYCL compilation.

ArturGainullin updated this revision to Diff 323456. ArturGainullin added a comment. Rebase for retesting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96538/new/ https://reviews.llvm.org/D96538 Files: clang/lib/CodeGen/CodeGenModule.cpp clan

[PATCH] D96538: [SYCL] Ignore file-scope asm during device-side SYCL compilation.

ArturGainullin created this revision. ArturGainullin added reviewers: bader, elizabethandrews. Herald added subscribers: Anastasia, ebevhan, yaxunl. ArturGainullin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github