[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 253463. atmnpatel added a comment. Added error based on OpenMP version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 Files:

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel added a comment. > In D75591#1936152 , @lebedev.ri > wrote: > It should be handled consistently with how other newer openmp features are > handled with older openmp version specified. In terms of consistency, the newer openmp features are

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 251854. atmnpatel added a comment. Fixed linter error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 Files:

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 251847. atmnpatel added a comment. Comment fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 Files:

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel marked 3 inline comments as done. atmnpatel added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5102 Diag(P.second->getExprLoc(), diag::err_omp_no_dsa_for_variable) << P.first << P.second->getSourceRange();

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5102 Diag(P.second->getExprLoc(), diag::err_omp_no_dsa_for_variable) << P.first << P.second->getSourceRange(); Diag(DSAStack->getDefaultDSALocation(),

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel added a comment. Yep, it is still an open issue. I am actually unsure of how to do that, and I'd love some pointers. As far as default(private) goes, I am also unsure of how to do it without retaining the prior values of the variables. I will take a look over this weekend and see if

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 249570. atmnpatel added a comment. Modified the unit test for CodeGen of default(firstprivate) to more accurately reflect the IR. >From the perspective of the AST, the variables that are firstprivate from a >default clause are managed in a way that is

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 248310. atmnpatel added a comment. Herald added a reviewer: lebedev.ri. Modifies clang-tidy to include the new clause, and changes the value of DSA_firstprivate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 248098. atmnpatel added a comment. Fixes typos that causes certain unit tests to fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 Files:

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel created this revision. atmnpatel added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, guansong. Herald added projects: clang, LLVM. This implements the default(firstprivate) clause as defined in OpenMP Technical Report 8 (2.22.4). Repository: rG LLVM

[PATCH] D74513: [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang

atmnpatel added a comment. I am unable to commit this myself, can someone commit for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74513/new/ https://reviews.llvm.org/D74513 ___ cfe-commits

[PATCH] D74513: [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang

atmnpatel updated this revision to Diff 244334. atmnpatel added a comment. Removes specified values in favor of defaults in the DefaultKind enum. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74513/new/ https://reviews.llvm.org/D74513 Files:

[PATCH] D74513: [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang

atmnpatel created this revision. atmnpatel added reviewers: jdoerfert, JonChesterfield. Herald added subscribers: llvm-commits, cfe-commits, guansong. Herald added projects: clang, LLVM. This swaps out the OpenMPDefaultClauseKind enum with a llvm::omp::DefaultKind enum which is stored in

<    1   2