[PATCH] D146595: [clang] Add "debug_trampoline" attribute

augusto2112 updated this revision to Diff 511515. augusto2112 added a comment. Updated MetadataTest.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146595/new/ https://reviews.llvm.org/D146595 Files: clang/docs/ReleaseNotes.rst clang/include

[PATCH] D146595: [clang] Add "debug_trampoline" attribute

augusto2112 added a comment. @aaron.ballman thanks all the code reviews. In D146595#4240608 , @aaron.ballman wrote: > Additionally, should you be allowed to write this on a lambda to skip over > the function call operator? (If so, you may need to move

[PATCH] D146595: [clang] Add "debug_trampoline" attribute

augusto2112 updated this revision to Diff 511513. augusto2112 added a comment. Added release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146595/new/ https://reviews.llvm.org/D146595 Files: clang/docs/ReleaseNotes.rst clang/include/clang

[PATCH] D146595: [clang] Add "transparent_stepping" attribute

augusto2112 updated this revision to Diff 511512. augusto2112 added a comment. Updated git commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146595/new/ https://reviews.llvm.org/D146595 Files: clang/include/clang/Basic/Attr.td clang

[PATCH] D146595: [clang] Add "transparent_stepping" attribute

augusto2112 updated this revision to Diff 511511. augusto2112 marked 4 inline comments as done. augusto2112 added a comment. Updated to debug_trampoline, and addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146595/new/ https://revie

[PATCH] D146595: [clang] Add "transparent_stepping" attribute

augusto2112 added a comment. In D146595#4235333 , @aprantl wrote: > I hope I'm not kicking off a long bike-shedding thread, but I would propose > to either call the attribute `transparent` to match the DWARF attribute name, > or if we want to be more de

[PATCH] D146595: [clang] Add "transparent_stepping" attribute

augusto2112 added a comment. @aaron.ballman @dblaikie I've changed the patch to introduce a more general "transparent_stepping" attribute, which doesn't take in a string (similar to what David suggested), please take a look and let me know what you think. Repository: rG LLVM Github Monorepo

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

augusto2112 updated this revision to Diff 509810. augusto2112 added a comment. Updating to "transparent_stepping" attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146595/new/ https://reviews.llvm.org/D146595 Files: clang/include/clang/Bas

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

augusto2112 added a comment. In D146595#4225170 , @aaron.ballman wrote: > In D146595#4225132 , @aprantl wrote: > >> In D146595#4225048 , @dblaikie >> wrote: >> >>> I kno

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

augusto2112 added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6775 +static void handleTrampolineMangledTarget(Sema &S, Decl *D, + const ParsedAttr &AL) { augusto2112 wrote: > erichkeane wrote: > > I don'

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

augusto2112 added a subscriber: DavidSpickett. augusto2112 added a comment. > I'm coming around to maybe this is the best tradeoff, though not /super/ > enthusiastic - if there was some way to annotate in a way that's easier for > users (like a bit on the function - "transparent" or something -

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

augusto2112 marked an inline comment as done. augusto2112 added inline comments. Comment at: clang/include/clang/Basic/Attr.td:776 + let Subjects = SubjectList<[Function, ObjCMethod]>; + let Args = [StringArgument<"Name">]; + let Documentation = [TrampolineDocs]; -

[PATCH] D146595: [clang] Add clang trampoline attribute

augusto2112 updated this revision to Diff 507922. augusto2112 added a comment. Addressed feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146595/new/ https://reviews.llvm.org/D146595 Files: clang/include/clang/Basic/Attr.td clang/include

[PATCH] D146595: [clang] Add clang trampoline attribute

augusto2112 added a comment. >>> What would happen if, instead, these trampolining functions were annotated >>> nodebug? I guess then you wouldn't have the top level one as an entry point >>> for the user, as there would be no debug info for it? >> >> These trampoline functions can call other

[PATCH] D146595: [clang] Add clang trampoline attribute

augusto2112 marked 4 inline comments as done. augusto2112 added a comment. > Should there be some check that that symbol exists? (the current test uses > the unmangled name "bar" for instance - which gives the wrong impression?) You mean as part of the attribute validation? > What would happen

[PATCH] D146595: [clang] Add clang trampoline attribute

augusto2112 added a comment. > This is quite fragile, for a few reasons. > It's too easy for the user to get undiagnosed typos. e.g., they want to > dispatch to bar but accidentally dispatch to barf or bar() instead. > How does this work with overloaded functions? Templated functions with > spec

[PATCH] D146595: [clang] Add clang trampoline attribute

augusto2112 updated this revision to Diff 507422. augusto2112 added a comment. Herald added a subscriber: jdoerfert. Fix pragma-attribute-supported-attributes-list.test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146595/new/ https://reviews.llvm.

[PATCH] D146595: [clang] Add clang trampoline attribute

augusto2112 added a comment. In D146595#4213412 , @aprantl wrote: > So this attribute will lower into a `DW_AT_trampoline("target_func_name")` > attribute on the `DW_TAG_subprogram` of the function definition? Exactly, there's already functionality to l

[PATCH] D146595: [clang] Add clang trampoline attribute

augusto2112 created this revision. augusto2112 added reviewers: aprantl, arphaman, jingham. Herald added a subscriber: hiraditya. Herald added a reviewer: aaron.ballman. Herald added a project: All. augusto2112 requested review of this revision. Herald added projects: clang, LLVM. Herald added subs

[PATCH] D143399: [Tooling/Inclusion] Move the generated mapping .inc file to private places.

augusto2112 added a comment. Hi @hokein, this broke the LLDB incremental build (https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/50629/console). How do we fix it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143399/new/ https://reviews.

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

augusto2112 added a comment. Actually, never mind, I think I can fix the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129881/new/ https://reviews.llvm.org/D129881 ___ cfe-commits mailing list cfe

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

augusto2112 added a comment. Hi @aaron.ballman, it looks like this broke 2 tests in the lldb test suite (https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/45560/). Can we revert this to keep CI green? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll