[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

azharudd added a comment. In D124474#3475550 , @beanz wrote: > In D124474#3475539 , @azharudd > wrote: > >> In this case I'm just trying to make it work with existing build >> configurations where it is being

[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

azharudd added a comment. In D124474#3475432 , @beanz wrote: > I question whether we should be extending this or killing it off... Is there > a reason you're using `LLVM_BUILD_EXTERNAL_COMPILER_RT` instead of > `LLVM_ENABLE_RUNTIMES=compiler-rt`? In

[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

azharudd created this revision. azharudd added reviewers: yln, delcypher, beanz, phosek. Herald added a subscriber: mgorny. Herald added a project: All. azharudd requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When building with

[PATCH] D85773: [Driver][XRay][test] Update the macOS support check

This revision was automatically updated to reflect the committed changes. Closed by commit rGd22985c41087: [Driver][XRay][test] Update the macOS support check (authored by azharudd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85773/new/

[PATCH] D85773: [Driver][XRay][test] Update the macOS support check

azharudd added a comment. In D85773#2211929 , @dberris wrote: > LGTM from me if XRay actually does work on non-x86_64 macOS. The code says that it is supported only on x86_64 macOS. The way this test is written, it should fail on platforms where it is

[PATCH] D85773: [Driver][XRay][test] Update the macOS support check

azharudd created this revision. azharudd added a reviewer: arphaman. Herald added subscribers: cfe-commits, dexonsmith, dberris. Herald added a project: clang. azharudd requested review of this revision. For macOS, the code says, the XRay flag is only supported on x86_64. Updating the test and

[PATCH] D66296: [BUNDLER]Improve the test, NFC.

azharudd added a comment. Looks like this is failing on Darwin: http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/1193/consoleFull#-2382751928254eaf0-7326-4999-85b0-388101f2d404

[PATCH] D53912: [Headers] [MS] Add intrin0.h

azharudd added a comment. In https://reviews.llvm.org/D53912#1281584, @rnk wrote: > This sounds like it would defeat what I'm assuming is the intended purpose of > intrin0.h, which is to reduce compile time. intrin.h is kind of enormous, and > the compile time problems are well-documented. We

[PATCH] D53912: [Headers] [MS] Add intrin0.h

azharudd created this revision. azharudd added reviewers: rnk, mgrang. Herald added subscribers: jfb, mgorny. xatomic.h header in VS 2017 includes instead of like before. Adding an intrin0.h header which internally includes when compiling for the Windows platform. Repository: rC Clang