[PATCH] D50122: Complex Variable defined in InitCapture Crash fix

2018-08-08 Thread Balaji Iyer via Phabricator via cfe-commits
bviyer added a comment. Ping! Repository: rC Clang https://reviews.llvm.org/D50122 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49952: Check for NULL Destination-Type when creating ArrayConstant

2018-08-06 Thread Balaji Iyer via Phabricator via cfe-commits
bviyer marked an inline comment as done. bviyer added a comment. John, I have updated the test case as you requested (I think). I am a bit new to Clang, so apologize if I mistook your request. https://reviews.llvm.org/D49952 ___ cfe-commits mailing

[PATCH] D49952: Check for NULL Destination-Type when creating ArrayConstant

2018-08-06 Thread Balaji Iyer via Phabricator via cfe-commits
bviyer updated this revision to Diff 159353. https://reviews.llvm.org/D49952 Files: lib/CodeGen/CGExprConstant.cpp test/CodeGenCXX/empty-struct-init-list.cpp Index: test/CodeGenCXX/empty-struct-init-list.cpp === --- /dev/null +

[PATCH] D50122: Complex Variable defined in InitCapture Crash fix

2018-08-02 Thread Balaji Iyer via Phabricator via cfe-commits
bviyer updated this revision to Diff 158870. bviyer added a comment. Simplified the case a bit more as requested by Erik. I also induced some errors in the test so that if someone symbolic-linked clang to /bin/true, the test will fail. Repository: rC Clang https://reviews.llvm.org/D50122 F

[PATCH] D49952: Check for NULL Destination-Type when creating ArrayConstant

2018-08-01 Thread Balaji Iyer via Phabricator via cfe-commits
bviyer updated this revision to Diff 158676. bviyer added a comment. Added FileCheck as requested by John McCall Made comments start with "//" instead of /* Removed expected-no-diagnostics from the test case (as requested by Erik) Repository: rC Clang https://reviews.llvm.org/D49952 Files:

[PATCH] D50122: Complex Variable defined in InitCapture Crash fix

2018-07-31 Thread Balaji Iyer via Phabricator via cfe-commits
bviyer created this revision. bviyer added reviewers: erik.pilkington, ahatanak, arphaman, dexonsmith. Herald added a subscriber: cfe-commits. When a variable is defined in the init capture and it is of type struct that is dependent on additional structure, its definition is not found. An excepti

[PATCH] D49952: Check for NULL Destination-Type when creating ArrayConstant

2018-07-31 Thread Balaji Iyer via Phabricator via cfe-commits
bviyer updated this revision to Diff 158392. bviyer added a comment. Forgot to pass the -emit-llvm to the test case. https://reviews.llvm.org/D49952 Files: lib/CodeGen/CGExprConstant.cpp test/CodeGenCXX/empty-struct-init-list.cpp Index: test/CodeGenCXX/empty-struct-init-list.cpp =

[PATCH] D49952: Check for NULL Destination-Type when creating ArrayConstant

2018-07-31 Thread Balaji Iyer via Phabricator via cfe-commits
bviyer updated this revision to Diff 158391. bviyer added a comment. Fixed code as suggested by John McCall. Repository: rC Clang https://reviews.llvm.org/D49952 Files: lib/CodeGen/CGExprConstant.cpp test/CodeGenCXX/empty-struct-init-list.cpp Index: test/CodeGenCXX/empty-struct-init-li

[PATCH] D49952: Check for NULL Destination-Type when creating ArrayConstant

2018-07-27 Thread Balaji Iyer via Phabricator via cfe-commits
bviyer created this revision. bviyer added reviewers: arphaman, dexonsmith, ahatanak, rjmccall. While emitting Array Constant, if the destination type is null-pointer, it will cause an assert. This patch will check if the destination type is null, and if so then it will just return nullptr as th

[PATCH] D49766: Fix a crash when an error occurs in Template and the initializer is a nullptr for C++17

2018-07-27 Thread Balaji Iyer via Phabricator via cfe-commits
bviyer updated this revision to Diff 157730. bviyer added a comment. Fixed the comment as you suggested. I do not have check in rights yet. Can you please check it in for me? Repository: rC Clang https://reviews.llvm.org/D49766 Files: include/clang/AST/TemplateBase.h test/SemaObjCXX/cla

[PATCH] D49766: Fix a crash when an error occurs in Template and the initializer is a nullptr for C++17

2018-07-27 Thread Balaji Iyer via Phabricator via cfe-commits
bviyer updated this revision to Diff 157721. bviyer added a comment. I have fixed all the changes requested by Erik along with shortening the test case. Repository: rC Clang https://reviews.llvm.org/D49766 Files: include/clang/AST/TemplateBase.h test/SemaObjCXX/class-templ-error-null-in

[PATCH] D49766: Fix a crash when an error occurs in Template and the initializer is a nullptr for C++17

2018-07-24 Thread Balaji Iyer via Phabricator via cfe-commits
bviyer created this revision. bviyer added reviewers: arphaman, erik.pilkington, dexonsmith. Herald added a subscriber: cfe-commits. When the error has occurred for one of the variables inside a template, the Loc function will try to find the end-location of the final item. If this variable is d

[PATCH] D48506: Fix for Crash in nested name specifier decltype

2018-07-09 Thread Balaji Iyer via Phabricator via cfe-commits
bviyer abandoned this revision. bviyer added a comment. Thank you Eric. I abandoned the revision as you suggested. Repository: rC Clang https://reviews.llvm.org/D48506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D48506: Fix for Crash in nested name specifier decltype

2018-07-09 Thread Balaji Iyer via Phabricator via cfe-commits
bviyer added a comment. Herald added a subscriber: dexonsmith. Ping! Repository: rC Clang https://reviews.llvm.org/D48506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48506: Fix for Crash in nested name specifier decltype

2018-06-22 Thread Balaji Iyer via Phabricator via cfe-commits
bviyer created this revision. bviyer added reviewers: rsmith, arphaman. There was a crash when qualtype is null in the function Sema::ActOnCXXNestedNameSpecifierDecltype. If it is null then just return without processing it further. Repository: rC Clang https://reviews.llvm.org/D48506 File