[clang-tools-extra] [clang-tidy][NFC] Enable 'readability-redundant-declaration' check in clang-tidy config (PR #156164)

2025-08-30 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor closed https://github.com/llvm/llvm-project/pull/156164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] Enable 'readability-redundant-declaration' check in clang-tidy config (PR #156164)

2025-08-30 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor created https://github.com/llvm/llvm-project/pull/156164 Closes https://github.com/llvm/llvm-project/issues/156163 >From b3aa1b3c24680dcaff3dee3ec5f82a23b343b018 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Sat, 30 Aug 2025 11:13:44 +0300 Subject: [PATCH] [cl

[clang-tools-extra] [clang-tidy] support query based custom check (PR #131804)

2025-08-29 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor approved this pull request. https://github.com/llvm/llvm-project/pull/131804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add new '-hide-progress' option to tidy-scripts for suppressing progress information (PR #154416)

2025-08-29 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/154416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add new '-hide-progress' option to tidy-scripts for suppressing progress information (PR #154416)

2025-08-29 Thread Baranov Victor via cfe-commits
vbvictor wrote: Ping @carlosgalvezp @HerrCai0907 @5chmidti @PiotrZSL for opinions. I believe we should not bloat scripts with many options but separating "quiet" from "progress" seem beneficial, hence new option is introduced. https://github.com/llvm/llvm-project/pull/154416 _

[clang-tools-extra] [clang-tidy] Add new '-hide-progress' option to tidy-scripts for suppressing progress information (PR #154416)

2025-08-29 Thread Baranov Victor via cfe-commits
vbvictor wrote: > I actually like the progress information (the rest not so much) and it might > give an indication if it is stuck or still running. It also contains > information (timing) to compare between runs and indicate which files are hot > spots. I reworked my implementation by adding

[clang-tools-extra] [clang-tidy] Improve "-quiet" option in tidy-scripts by suppressing progress information (PR #154416)

2025-08-29 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154416 >From dab1d21d7561fcaa9cfcbf8b77384e5ad2c11a6d Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Fri, 29 Aug 2025 17:32:50 +0300 Subject: [PATCH] [clang-tidy] Add new -hide-progress option to tidy-scripts fo

[clang-tools-extra] [Clang-Tidy] Handle nested-name-specifier in "llvm-prefer-isa-or-dyn-cast-in-conditionals" (PR #155982)

2025-08-29 Thread Baranov Victor via cfe-commits
vbvictor wrote: Thank you for the improvements of the check! Did you try running on LLVM code to check for any miscodegen/FP? https://clang.llvm.org/extra/clang-tidy/#running-clang-tidy-in-parallel https://github.com/llvm/llvm-project/pull/155982 ___

[clang-tools-extra] [clang-tidy][NFC] Add custom .clang-format with 'QualifierAlignment: Left' (PR #155852)

2025-08-29 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor closed https://github.com/llvm/llvm-project/pull/155852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] New bugprone-method-hiding check (PR #154746)

2025-08-28 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,141 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy][NFC] Add custom .clang-format with 'QualifierAlignment: Left' (PR #155852)

2025-08-28 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor created https://github.com/llvm/llvm-project/pull/155852 ["QualifierAlignment: Left"](https://clang.llvm.org/docs/ClangFormatStyleOptions.html#qualifieralignment) is an established way of writing code in `clang-tools-extra/clang-tidy`. We should enforce it in CI.

[clang-tools-extra] [clang-tidy] Add detection in container's method except `empty` in `readability-container-size-empty` (PR #154017)

2025-08-28 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor closed https://github.com/llvm/llvm-project/pull/154017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] New bugprone-method-hiding check (PR #154746)

2025-08-28 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,35 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang-tools-extra] Add WarnOnModificationOfCopiedLoopVariable to performance-for-range-c… (PR #155731)

2025-08-27 Thread Baranov Victor via cfe-commits
vbvictor wrote: As an alternative solution, your Idea can be a separate check but you should file an issue first to gather some initial feedback. https://github.com/llvm/llvm-project/pull/155731 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [llvm] [TEST] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-27 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From b9e917fb7da29c1dc70e0e89b972fc3e2a631b4f Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Thu, 21 Aug 2025 21:20:33 +0300 Subject: [PATCH 1/5] Add clang-tidy violations for testing purpose --- .../cl

[clang-tools-extra] [llvm] [TEST] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-27 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From b9e917fb7da29c1dc70e0e89b972fc3e2a631b4f Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Thu, 21 Aug 2025 21:20:33 +0300 Subject: [PATCH 1/6] Add clang-tidy violations for testing purpose --- .../cl

[clang-tools-extra] [llvm] [TEST] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-27 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From b9e917fb7da29c1dc70e0e89b972fc3e2a631b4f Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Thu, 21 Aug 2025 21:20:33 +0300 Subject: [PATCH 1/5] Add clang-tidy violations for testing purpose --- .../cl

[clang-tools-extra] [llvm] [TEST] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-27 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From b9e917fb7da29c1dc70e0e89b972fc3e2a631b4f Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Thu, 21 Aug 2025 21:20:33 +0300 Subject: [PATCH 1/5] Add clang-tidy violations for testing purpose --- .../cl

[clang-tools-extra] [clang-tidy] New bugprone-method-hiding check (PR #154746)

2025-08-27 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,30 @@ +.. title:: clang-tidy - bugprone-method-hiding + +bugprone-method-hiding += + +Finds derived class methods that hide a (non-virtual) base class method. + +In order to be considered "hiding", methods must have the same signature +(i.e. the

[clang-tools-extra] [llvm] [TEST] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-27 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From b9e917fb7da29c1dc70e0e89b972fc3e2a631b4f Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Thu, 21 Aug 2025 21:20:33 +0300 Subject: [PATCH 01/10] Add clang-tidy violations for testing purpose --- .../

[clang-tools-extra] [clang-tidy] New bugprone-method-hiding check (PR #154746)

2025-08-27 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,141 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] New bugprone-method-hiding check (PR #154746)

2025-08-27 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,141 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Teach `readability-uppercase-literal-suffix` about C++23 and C23 suffixes (PR #148275)

2025-08-26 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,162 @@ +// TODO: When Clang adds support for decimal floating point types, enable these tests by: +//1. Removing all the #if 0 + #endif guards. +//2. Removing all occurrences of the string "DISABLED-" in this file. +//3. Deleting this message. + +// RUN: %c

[clang-tools-extra] [clang-tidy] Add new check 'llvm-use-ranges' (PR #152047)

2025-08-26 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/152047 >From bb17fb65d031190efff6a6ec1c0ca6d9c0d35abb Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Tue, 5 Aug 2025 01:15:02 +0300 Subject: [PATCH 1/6] [clang-tidy] Add new check 'llvm-use-ranges' --- .../clan

[clang-tools-extra] [clang-tidy] Teach `readability-uppercase-literal-suffix` about C++23 and C23 suffixes (PR #148275)

2025-08-26 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,162 @@ +// TODO: When Clang adds support for decimal floating point types, enable these tests by: +//1. Removing all the #if 0 + #endif guards. +//2. Removing all occurrences of the string "DISABLED-" in this file. +//3. Deleting this message. + +// RUN: %c

[clang-tools-extra] [clang-tidy] Teach `readability-uppercase-literal-suffix` about C++23 and C23 suffixes (PR #148275)

2025-08-26 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/148275 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] New bugprone-method-hiding check (PR #154746)

2025-08-26 Thread Baranov Victor via cfe-commits
vbvictor wrote: > The check name is a bit too vague/general, I would call it > `bugprone-derived-method-shadowing-base-method` or similar. You can easily > apply the renaming with the `rename_check.py`. But let's wait until there's > some consensus on this. Agree, initially I was thinking abo

[clang-tools-extra] [clang-tidy] do not diagnose array types within implicit instantiations of a template (PR #132924)

2025-08-26 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor approved this pull request. LGTM, but I'd wait for review from @5chmidti because he had the initiative for optimization. https://github.com/llvm/llvm-project/pull/132924 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang-tools-extra] [clang-tidy] Teach `readability-uppercase-literal-suffix` about C++23 and C23 suffixes (PR #148275)

2025-08-26 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,162 @@ +// TODO: When Clang adds support for decimal floating point types, enable these tests by: +//1. Removing all the #if 0 + #endif guards. +//2. Removing all occurrences of the string "DISABLED-" in this file. +//3. Deleting this message. + +// RUN: %c

[clang-tools-extra] [clang-tidy] Teach `readability-uppercase-literal-suffix` about C++23 and C23 suffixes (PR #148275)

2025-08-26 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,162 @@ +// TODO: When Clang adds support for decimal floating point types, enable these tests by: +//1. Removing all the #if 0 + #endif guards. +//2. Removing all occurrences of the string "DISABLED-" in this file. +//3. Deleting this message. + +// RUN: %c

[clang-tools-extra] [clang-tidy] Teach `readability-uppercase-literal-suffix` about C++23 and C23 suffixes (PR #148275)

2025-08-26 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,162 @@ +// TODO: When Clang adds support for decimal floating point types, enable these tests by: +//1. Removing all the #if 0 + #endif guards. +//2. Removing all occurrences of the string "DISABLED-" in this file. +//3. Deleting this message. + +// RUN: %c

[clang-tools-extra] [clang-tidy] Teach `readability-uppercase-literal-suffix` about C++23 and C23 suffixes (PR #148275)

2025-08-26 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,162 @@ +// TODO: When Clang adds support for decimal floating point types, enable these tests by: +//1. Removing all the #if 0 + #endif guards. +//2. Removing all occurrences of the string "DISABLED-" in this file. +//3. Deleting this message. + +// RUN: %c

[clang] [clang-tools-extra] [clang-tidy] Add portability-avoid-platform-specific-fundamental-types (PR #146970)

2025-08-26 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,183 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [clang-tools-extra] [clang-tidy] Add portability-avoid-platform-specific-fundamental-types (PR #146970)

2025-08-26 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,183 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] do not diagnose array types within implicit instantiations of a template (PR #132924)

2025-08-26 Thread Baranov Victor via cfe-commits
@@ -39,6 +39,51 @@ AST_MATCHER(clang::ParmVarDecl, isArgvOfMain) { return FD ? FD->isMain() : false; } +AST_MATCHER(clang::TypeLoc, isWithinImplicitTemplateInstantiation) { + const auto IsImplicitTemplateInstantiation = [](const auto *Node) { +return (Node != nullptr) &

[clang-tools-extra] [clang-tidy] Limit modernize-use-constraints to standard enable_if (PR #155237)

2025-08-25 Thread Baranov Victor via cfe-commits
vbvictor wrote: AFAIK, the check now will not crash if `enable_if` with incorrect signature is encountered. - If first arg is not `bool` - bail out - If parameter count is not 1 or to - bail out - If 2nd arg is incorrect - do not warn (As I understand from the tests.. maybe wrong) @localspook d

[clang-tools-extra] [llvm] [TEST] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-25 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From b9e917fb7da29c1dc70e0e89b972fc3e2a631b4f Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Thu, 21 Aug 2025 21:20:33 +0300 Subject: [PATCH 1/4] Add clang-tidy violations for testing purpose --- .../cl

[clang-tools-extra] [llvm] [TEST] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-25 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From b9e917fb7da29c1dc70e0e89b972fc3e2a631b4f Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Thu, 21 Aug 2025 21:20:33 +0300 Subject: [PATCH 1/5] Add clang-tidy violations for testing purpose --- .../cl

[clang-tools-extra] [llvm] [TEST] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-25 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From b9e917fb7da29c1dc70e0e89b972fc3e2a631b4f Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Thu, 21 Aug 2025 21:20:33 +0300 Subject: [PATCH 1/4] Add clang-tidy violations for testing purpose --- .../cl

[clang-tools-extra] [llvm] [TEST] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-25 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From b9e917fb7da29c1dc70e0e89b972fc3e2a631b4f Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Thu, 21 Aug 2025 21:20:33 +0300 Subject: [PATCH 1/7] Add clang-tidy violations for testing purpose --- .../cl

[clang-tools-extra] [llvm] [TEST] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-25 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From b9e917fb7da29c1dc70e0e89b972fc3e2a631b4f Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Thu, 21 Aug 2025 21:20:33 +0300 Subject: [PATCH 1/6] Add clang-tidy violations for testing purpose --- .../cl

[clang-tools-extra] [llvm] [TEST] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-25 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From b9e917fb7da29c1dc70e0e89b972fc3e2a631b4f Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Thu, 21 Aug 2025 21:20:33 +0300 Subject: [PATCH 1/5] Add clang-tidy violations for testing purpose --- .../cl

[clang-tools-extra] [llvm] [TEST] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-25 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From b9e917fb7da29c1dc70e0e89b972fc3e2a631b4f Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Thu, 21 Aug 2025 21:20:33 +0300 Subject: [PATCH 1/4] Add clang-tidy violations for testing purpose --- .../cl

[clang-tools-extra] [clang-tidy] Limit modernize-use-constraints to standard enable_if (PR #155237)

2025-08-25 Thread Baranov Victor via cfe-commits
vbvictor wrote: Should this be already fixed by https://github.com/llvm/llvm-project/pull/152938? Initially the check crushed because it expected to have first parameter as bool, now we explicitly check for it. https://github.com/llvm/llvm-project/pull/155237 _

[clang-tools-extra] [clang-tidy] modernize-use-std-format: Correct replacement types when signed stdint types are used, and when enums are printed in hex. #150343 (PR #155200)

2025-08-24 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/155200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] modernize-use-std-format: Correct replacement types when signed stdint types are used, and when enums are printed in hex. #150343 (PR #155200)

2025-08-24 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/155200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] modernize-use-std-format: Correct replacement types when signed stdint types are used, and when enums are printed in hex. #150343 (PR #155200)

2025-08-24 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor commented: Please add tests and release notes about your change in `clang-tools-extra/docs/ReleaseNotes.rst` https://github.com/llvm/llvm-project/pull/155200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang-tools-extra] [clang-tidy][NFC] clean up some matchers in `modernize-type-traits` (PR #155180)

2025-08-24 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/155180 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [TEST] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-24 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From b9e917fb7da29c1dc70e0e89b972fc3e2a631b4f Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Thu, 21 Aug 2025 21:20:33 +0300 Subject: [PATCH 1/3] Add clang-tidy violations for testing purpose --- .../cl

[clang-tools-extra] [llvm] [TEST] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-24 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From b9e917fb7da29c1dc70e0e89b972fc3e2a631b4f Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Thu, 21 Aug 2025 21:20:33 +0300 Subject: [PATCH 1/3] Add clang-tidy violations for testing purpose --- .../cl

[clang-tools-extra] [llvm] [TEST] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-24 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From b9e917fb7da29c1dc70e0e89b972fc3e2a631b4f Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Thu, 21 Aug 2025 21:20:33 +0300 Subject: [PATCH 1/3] Add clang-tidy violations for testing purpose --- .../cl

[clang-tools-extra] [llvm] [TEST] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-24 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From b9e917fb7da29c1dc70e0e89b972fc3e2a631b4f Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Thu, 21 Aug 2025 21:20:33 +0300 Subject: [PATCH 1/5] Add clang-tidy violations for testing purpose --- .../cl

[clang-tools-extra] [llvm] [TEST] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-24 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From b9e917fb7da29c1dc70e0e89b972fc3e2a631b4f Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Thu, 21 Aug 2025 21:20:33 +0300 Subject: [PATCH 1/4] Add clang-tidy violations for testing purpose --- .../cl

[clang-tools-extra] [llvm] [TEST] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-24 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From b9e917fb7da29c1dc70e0e89b972fc3e2a631b4f Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Thu, 21 Aug 2025 21:20:33 +0300 Subject: [PATCH 1/3] Add clang-tidy violations for testing purpose --- .../cl

[clang-tools-extra] [llvm] [TEST] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-24 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From b9e917fb7da29c1dc70e0e89b972fc3e2a631b4f Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Thu, 21 Aug 2025 21:20:33 +0300 Subject: [PATCH 1/3] Add clang-tidy violations for testing purpose --- .../cl

[clang-tools-extra] [llvm] [TEST] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-24 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From b9e917fb7da29c1dc70e0e89b972fc3e2a631b4f Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Thu, 21 Aug 2025 21:20:33 +0300 Subject: [PATCH 1/3] Add clang-tidy violations for testing purpose --- .../cl

[clang-tools-extra] [llvm] [TEST] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-24 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From b9e917fb7da29c1dc70e0e89b972fc3e2a631b4f Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Thu, 21 Aug 2025 21:20:33 +0300 Subject: [PATCH 1/3] Add clang-tidy violations for testing purpose --- .../cl

[clang-tools-extra] [clang-tidy] Add detection in container's method except `empty` in `readability-container-size-empty` (PR #154017)

2025-08-23 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/154017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Skip system macros in readability-identifier-naming check (PR #132016)

2025-08-23 Thread Baranov Victor via cfe-commits
vbvictor wrote: > Yes, the patch can be merged and gets rid of about half the remaining > warnings in system headers! I've removed the condition about checking for the > `SystemHeaders` flag, for consistency with similar code in this file for > ignoring the `Decl`s, which further simplifies th

[clang] [clang-tools-extra] [lldb] [llvm] [mlir] [NFC] Fix typos 'seperate' -> 'separate' (PR #144368)

2025-08-23 Thread Baranov Victor via cfe-commits
vbvictor wrote: Hi, could you rebase on fresh main and fix conflicts (should be easy). After that, could be merged https://github.com/llvm/llvm-project/pull/144368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [clang-tools-extra] [clang][AST][clang-tidy] Do not set a reduced traversal scope in ASTM… (PR #132725)

2025-08-23 Thread Baranov Victor via cfe-commits
vbvictor wrote: Since patch https://github.com/llvm/llvm-project/pull/151035 is merged, do we still need this one, or it could be closed? https://github.com/llvm/llvm-project/pull/132725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang-tools-extra] [clang-tidy] Skip system macros in readability-identifier-naming check (PR #132016)

2025-08-23 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor approved this pull request. LGTM Are you willing to merge this patch or there were some problems encountered? https://github.com/llvm/llvm-project/pull/132016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang-tools-extra] [clang-tidy] Add new check 'llvm-use-ranges' (PR #152047)

2025-08-23 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/152047 >From bb17fb65d031190efff6a6ec1c0ca6d9c0d35abb Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Tue, 5 Aug 2025 01:15:02 +0300 Subject: [PATCH 1/5] [clang-tidy] Add new check 'llvm-use-ranges' --- .../clan

[clang-tools-extra] [clang-tidy] Ignore default ctor with user provided argument in `readability-container-size-empty` (PR #154782)

2025-08-23 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor approved this pull request. LGTM I think we should make follow up patch (not high priority) with either making an option to disable "empty by comparing to default-constructed object" or making a regex-option to filter such containers https://github.com/llvm/llvm-pro

[clang-tools-extra] [clang-tidy] Ignore default ctor with user provided argument in `readability-container-size-empty` (PR #154782)

2025-08-23 Thread Baranov Victor via cfe-commits
@@ -908,3 +908,37 @@ class foo : public std::string{ }; } + +namespace GH154762 { +class TypeRange { + std::vector b; + +public: + TypeRange(std::vector b = {}); + TypeRange(int); + bool operator==(const TypeRange& other) const; + + size_t size() const { +return b.siz

[clang-tools-extra] [clang-tidy] Ignore default ctor with user provided argument in `readability-container-size-empty` (PR #154782)

2025-08-23 Thread Baranov Victor via cfe-commits
@@ -908,3 +908,37 @@ class foo : public std::string{ }; } + +namespace GH154762 { +class TypeRange { + std::vector b; + +public: + TypeRange(std::vector b = {}); + TypeRange(int); + bool operator==(const TypeRange& other) const; + + size_t size() const { +return b.siz

[clang] [clang-tools-extra] [clang-tidy] `bugprone-unchecked-optional-access`: handle `BloombergLP::bdlb:NullableValue::makeValue` to prevent false-positives (PR #144313)

2025-08-23 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/144313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang-tidy] `bugprone-unchecked-optional-access`: handle `BloombergLP::bdlb:NullableValue::makeValue` to prevent false-positives (PR #144313)

2025-08-23 Thread Baranov Victor via cfe-commits
@@ -985,6 +985,20 @@ auto buildTransferMatchSwitch() { isOptionalMemberCallWithNameMatcher(hasName("isNull")), transferOptionalIsNullCall) + // NullableValue::makeValue, NullableValue::makeValueInplace + // Only NullableValue has these methods, bu

[clang-tools-extra] [clang-tidy] Support direct initialization in modernize smart pointer (PR #154732)

2025-08-23 Thread Baranov Victor via cfe-commits
@@ -81,18 +81,16 @@ void MakeSmartPtrCheck::registerMatchers(ast_matchers::MatchFinder *Finder) { auto IsPlacement = hasAnyPlacementArg(anything()); Finder->addMatcher( - traverse( - TK_AsIs, - cxxBindTemporaryExpr(has(ignoringParenImpCasts( ---

[clang-tools-extra] [clang-tidy] Support direct initialization in modernize smart pointer (PR #154732)

2025-08-23 Thread Baranov Victor via cfe-commits
@@ -190,9 +188,15 @@ void MakeSmartPtrCheck::checkConstruct(SourceManager &SM, ASTContext *Ctx, ConstructCallEnd = ConstructCallStart.getLocWithOffset(LAngle); } + std::string FinalMakeSmartPtrFunctionName = MakeSmartPtrFunctionName.str(); + auto Parents = Ctx->getPar

[clang-tools-extra] [clang-tidy] Ignore default ctor with user provided argument in `readability-container-size-empty` (PR #154782)

2025-08-23 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/154782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Ignore default ctor with user provided argument in `readability-container-size-empty` (PR #154782)

2025-08-23 Thread Baranov Victor via cfe-commits
@@ -908,3 +908,27 @@ class foo : public std::string{ }; } + +namespace GH154762 { +class TypeRange { + std::vector b; + +public: + TypeRange(std::vector b = {}); + TypeRange(int); + bool operator==(const TypeRange& other) const; + + size_t size() const { +return b.siz

[clang-tools-extra] [clang-tidy] Mark bunch of checks as C++-only (PR #155083)

2025-08-23 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor approved this pull request. I guess LGTM too:) https://github.com/llvm/llvm-project/pull/155083 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add new check 'llvm-use-ranges' (PR #152047)

2025-08-22 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/152047 >From bb17fb65d031190efff6a6ec1c0ca6d9c0d35abb Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Tue, 5 Aug 2025 01:15:02 +0300 Subject: [PATCH 1/4] [clang-tidy] Add new check 'llvm-use-ranges' --- .../clan

[clang-tools-extra] [clang-tidy] Add new check 'llvm-use-ranges' (PR #152047)

2025-08-22 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/152047 >From bb17fb65d031190efff6a6ec1c0ca6d9c0d35abb Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Tue, 5 Aug 2025 01:15:02 +0300 Subject: [PATCH 1/3] [clang-tidy] Add new check 'llvm-use-ranges' --- .../clan

[clang-tools-extra] Add option to allow pre/post increment/decrement operator in cppcoreg… (PR #155015)

2025-08-22 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/155015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add new check 'llvm-use-ranges' (PR #152047)

2025-08-22 Thread Baranov Victor via cfe-commits
vbvictor wrote: Ping https://github.com/llvm/llvm-project/pull/152047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] Fix "llvm-prefer-static-over-anonymous-namespace" warnings 1/N (PR #153885)

2025-08-22 Thread Baranov Victor via cfe-commits
vbvictor wrote: > Personally I find the guidelines a bit silly since they lead to a sandwich of > static-anon namespace-static-anon-namespace. But those are the guidelines we > have :) Yeah, but I guess it makes a lot easier to spot a function without internal linkage during review (although

[clang-tools-extra] [llvm] [TEST] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-22 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/154223 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] Fix "llvm-prefer-static-over-anonymous-namespace" warnings 1/N (PR #153885)

2025-08-22 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor closed https://github.com/llvm/llvm-project/pull/153885 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [WIP] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-21 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From b9e917fb7da29c1dc70e0e89b972fc3e2a631b4f Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Thu, 21 Aug 2025 21:20:33 +0300 Subject: [PATCH 1/3] Add clang-tidy violations for testing purpose --- .../cl

[clang-tools-extra] [llvm] [WIP] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-21 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From b9e917fb7da29c1dc70e0e89b972fc3e2a631b4f Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Thu, 21 Aug 2025 21:20:33 +0300 Subject: [PATCH 1/2] Add clang-tidy violations for testing purpose --- .../cl

[clang-tools-extra] [llvm] [WIP] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-21 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/154223 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] Fix "llvm-prefer-static-over-anonymous-namespace" warnings 1/N (PR #153885)

2025-08-21 Thread Baranov Victor via cfe-commits
vbvictor wrote: Should be fairly easy to review @carlosgalvezp There will be more patches coming with fixing this check. https://github.com/llvm/llvm-project/pull/153885 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang-tools-extra] [llvm] [WIP] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-21 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From b9e917fb7da29c1dc70e0e89b972fc3e2a631b4f Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Thu, 21 Aug 2025 21:20:33 +0300 Subject: [PATCH 1/2] Add clang-tidy violations for testing purpose --- .../cl

[clang-tools-extra] [clang-tidy][doc] Improve option docs for readability-identifier-naming (PR #154806)

2025-08-21 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor approved this pull request. Thank you, LGTM https://github.com/llvm/llvm-project/pull/154806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] New bugprone-method-hiding check (PR #154746)

2025-08-21 Thread Baranov Victor via cfe-commits
@@ -4,6 +4,9 @@ // See https://llvm.org/LICENSE.txt for license information. // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // +// SPDX-FileCopyrightText: Portions Copyright 2025 Siemens and/or its affiliates +// May 2025 modified by Siemens and/or its affiliates b

[clang-tools-extra] [clang-tidy] New bugprone-method-hiding check (PR #154746)

2025-08-21 Thread Baranov Victor via cfe-commits
@@ -4,6 +4,9 @@ // See https://llvm.org/LICENSE.txt for license information. // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // +// SPDX-FileCopyrightText: Portions Copyright 2025 Siemens and/or its affiliates +// May 2025 modified by Siemens and/or its affiliates b

[clang-tools-extra] [llvm] [WIP] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-20 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From 9c1c60147968df4d411f013378618b5d72313456 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Tue, 19 Aug 2025 02:02:16 +0300 Subject: [PATCH 01/30] test clang-tidy violation --- .../clang-tidy/performan

[clang-tools-extra] [llvm] [WIP] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-20 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From 9c1c60147968df4d411f013378618b5d72313456 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Tue, 19 Aug 2025 02:02:16 +0300 Subject: [PATCH 01/29] test clang-tidy violation --- .../clang-tidy/performan

[clang-tools-extra] [llvm] [WIP] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-20 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From 9c1c60147968df4d411f013378618b5d72313456 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Tue, 19 Aug 2025 02:02:16 +0300 Subject: [PATCH 01/28] test clang-tidy violation --- .../clang-tidy/performan

[clang-tools-extra] [llvm] [WIP] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-20 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From 9c1c60147968df4d411f013378618b5d72313456 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Tue, 19 Aug 2025 02:02:16 +0300 Subject: [PATCH 01/27] test clang-tidy violation --- .../clang-tidy/performan

[clang-tools-extra] [llvm] [WIP] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-20 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From 9c1c60147968df4d411f013378618b5d72313456 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Tue, 19 Aug 2025 02:02:16 +0300 Subject: [PATCH 01/26] test clang-tidy violation --- .../clang-tidy/performan

[clang-tools-extra] [clang-tidy] Improve "-quiet" option in tidy-scripts by suppressing progress information (PR #154416)

2025-08-20 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154416 >From 3d87ccf38a518def2bd44dbddb661360a64158a2 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Tue, 19 Aug 2025 22:39:19 +0300 Subject: [PATCH 1/4] [clang-tidy] Improve "-quiet" option in tidy-scripts by s

[clang-tools-extra] [clang-tidy] Improve "-quiet" option in tidy-scripts by suppressing progress information (PR #154416)

2025-08-20 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154416 >From 3d87ccf38a518def2bd44dbddb661360a64158a2 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Tue, 19 Aug 2025 22:39:19 +0300 Subject: [PATCH 1/3] [clang-tidy] Improve "-quiet" option in tidy-scripts by s

[clang-tools-extra] [llvm] [WIP] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-20 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From 9c1c60147968df4d411f013378618b5d72313456 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Tue, 19 Aug 2025 02:02:16 +0300 Subject: [PATCH 01/25] test clang-tidy violation --- .../clang-tidy/performan

[clang-tools-extra] [clang-tidy] Improve "-quiet" option in tidy-scripts by suppressing progress information (PR #154416)

2025-08-20 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154416 >From 3d87ccf38a518def2bd44dbddb661360a64158a2 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Tue, 19 Aug 2025 22:39:19 +0300 Subject: [PATCH 1/2] [clang-tidy] Improve "-quiet" option in tidy-scripts by s

[clang-tools-extra] [llvm] [WIP] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-20 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From 9c1c60147968df4d411f013378618b5d72313456 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Tue, 19 Aug 2025 02:02:16 +0300 Subject: [PATCH 01/24] test clang-tidy violation --- .../clang-tidy/performan

[clang-tools-extra] [clang-tidy] performance-unnecessary-copy-initialization: Enhance the check for the scenario with MemberExpr initialization. (PR #151936)

2025-08-20 Thread Baranov Victor via cfe-commits
@@ -273,6 +273,18 @@ void UnnecessaryCopyInitialization::registerMatchers(MatchFinder *Finder) { Finder->addMatcher(LocalVarCopiedFrom(declRefExpr( to(varDecl(hasLocalStorage()).bind(OldVarDeclId, this); + + auto DeclRefToCo

[clang-tools-extra] [llvm] [WIP] Add clang tidy premerge CI [WIP] (PR #154223)

2025-08-20 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/154223 >From 9c1c60147968df4d411f013378618b5d72313456 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Tue, 19 Aug 2025 02:02:16 +0300 Subject: [PATCH 01/23] test clang-tidy violation --- .../clang-tidy/performan

  1   2   3   4   5   6   7   8   9   10   >