Re: [clang-tools-extra] r318840 - [FindAllSymbols] Cache regexes, creating them is expensive

2017-11-23 Thread Benjamin Kramer via cfe-commits
t; note: in instantiation of member function > 'std::__1::vector, > std::__1::allocator > >::reserve' > requested here > this->RegexHeaderMappingTable.reserve(RegexHeaderMappingTable->size()); > ^ > /w/src/llvm.org/include/llv

[clang-tools-extra] r318840 - [FindAllSymbols] Cache regexes, creating them is expensive

2017-11-22 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Nov 22 07:38:23 2017 New Revision: 318840 URL: http://llvm.org/viewvc/llvm-project?rev=318840&view=rev Log: [FindAllSymbols] Cache regexes, creating them is expensive This is a bit annoying because LLVM regexes are always mutable to store errors. Assert that there are never

r318292 - [libclang] Fix cursors for in-class initializer of field declarations

2017-11-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Nov 15 04:20:41 2017 New Revision: 318292 URL: http://llvm.org/viewvc/llvm-project?rev=318292&view=rev Log: [libclang] Fix cursors for in-class initializer of field declarations Fixes PR33745. Patch by Nikolai Kosjar! Differential Revision: https://reviews.llvm.org/D40027

r317052 - Make helper function static. NFC.

2017-10-31 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Oct 31 16:23:36 2017 New Revision: 317052 URL: http://llvm.org/viewvc/llvm-project?rev=317052&view=rev Log: Make helper function static. NFC. Modified: cfe/trunk/lib/AST/Type.cpp Modified: cfe/trunk/lib/AST/Type.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/li

[clang-tools-extra] r316832 - [clangd] Fix clang-tidy warnings.

2017-10-28 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Oct 28 10:32:56 2017 New Revision: 316832 URL: http://llvm.org/viewvc/llvm-project?rev=316832&view=rev Log: [clangd] Fix clang-tidy warnings. No functionality change intended. Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.h clang-tools-extra/trunk/clangd/

[clang-tools-extra] r316774 - [clangd] Don't crash on extremely large JSON messages.

2017-10-27 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Oct 27 10:06:41 2017 New Revision: 316774 URL: http://llvm.org/viewvc/llvm-project?rev=316774&view=rev Log: [clangd] Don't crash on extremely large JSON messages. Found by clangd-fuzzer. Added: clang-tools-extra/trunk/test/clangd/too_large.test Modified: clang-tools

[clang-tools-extra] r316770 - [clangd] Harden clangd a bit against garbage input.

2017-10-27 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Oct 27 09:33:15 2017 New Revision: 316770 URL: http://llvm.org/viewvc/llvm-project?rev=316770&view=rev Log: [clangd] Harden clangd a bit against garbage input. There can be nullptrs here if the YAML fails to parse. Found by clangd-fuzzer! Modified: clang-tools-extra/tru

Re: [clang-tools-extra] r316650 - [clangd] Don't use /// for non-doxygen comments.

2017-10-26 Thread Benjamin Kramer via cfe-commits
On Thu, Oct 26, 2017 at 3:16 PM, Jonas Hahnfeld wrote: > Am 2017-10-26 06:07, schrieb Benjamin Kramer via cfe-commits: >> >> Author: d0k >> Date: Thu Oct 26 03:07:04 2017 >> New Revision: 316650 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=316650

[clang-tools-extra] r316659 - [clangd] Report an error on findDefinitions/signatureHelp on an unopened file instead of crashing.

2017-10-26 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Oct 26 05:28:13 2017 New Revision: 316659 URL: http://llvm.org/viewvc/llvm-project?rev=316659&view=rev Log: [clangd] Report an error on findDefinitions/signatureHelp on an unopened file instead of crashing. Found by clangd-fuzzer. Modified: clang-tools-extra/trunk/clan

[clang-tools-extra] r316652 - [clangd] Don't crash on empty textDocument/didChange.

2017-10-26 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Oct 26 03:36:20 2017 New Revision: 316652 URL: http://llvm.org/viewvc/llvm-project?rev=316652&view=rev Log: [clangd] Don't crash on empty textDocument/didChange. Found by clangd-fuzzer. Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp clang-tools-extra/t

[clang-tools-extra] r316650 - [clangd] Don't use /// for non-doxygen comments.

2017-10-26 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Oct 26 03:07:04 2017 New Revision: 316650 URL: http://llvm.org/viewvc/llvm-project?rev=316650&view=rev Log: [clangd] Don't use /// for non-doxygen comments. Modified: clang-tools-extra/trunk/clangd/fuzzer/ClangdFuzzer.cpp clang-tools-extra/trunk/clangd/tool/ClangdMai

[clang-tools-extra] r316649 - [clangd] Add a simple fuzzer. It crashes a lot :)

2017-10-26 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Oct 26 03:03:11 2017 New Revision: 316649 URL: http://llvm.org/viewvc/llvm-project?rev=316649&view=rev Log: [clangd] Add a simple fuzzer. It crashes a lot :) Added: clang-tools-extra/trunk/clangd/fuzzer/ clang-tools-extra/trunk/clangd/fuzzer/CMakeLists.txt clang-

r316646 - Fix overloaded static functions in SemaCodeComplete

2017-10-26 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Oct 26 01:41:28 2017 New Revision: 316646 URL: http://llvm.org/viewvc/llvm-project?rev=316646&view=rev Log: Fix overloaded static functions in SemaCodeComplete https://bugs.llvm.org/show_bug.cgi?id=33904 Happens when static function is accessed via the class variable. That l

r316344 - [ASTMatchers] Expose forEachOverriden in dynamic AST matchers.

2017-10-23 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Oct 23 09:48:46 2017 New Revision: 316344 URL: http://llvm.org/viewvc/llvm-project?rev=316344&view=rev Log: [ASTMatchers] Expose forEachOverriden in dynamic AST matchers. Modified: cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp Modified: cfe/trunk/lib/ASTMatchers/Dynami

r316301 - Create fewer copies of StringMaps. No functionality change intended.

2017-10-22 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Oct 22 13:16:28 2017 New Revision: 316301 URL: http://llvm.org/viewvc/llvm-project?rev=316301&view=rev Log: Create fewer copies of StringMaps. No functionality change intended. Modified: cfe/trunk/lib/Frontend/PrecompiledPreamble.cpp cfe/trunk/lib/Parse/ParseStmtAsm.

Re: r315811 - Re-land r315787, "[Sema] Warn about unused variables if we can constant evaluate the initializer."

2017-10-19 Thread Benjamin Kramer via cfe-commits
45 PM, Alexander Kornienko > wrote: >> >> >> On Sat, Oct 14, 2017 at 5:59 PM, Benjamin Kramer via cfe-commits >> wrote: >>> >>> Author: d0k >>> Date: Sat Oct 14 08:59:34 2017 >>> New Revision: 315811 >>> >>> URL: http

r316177 - [Sema] Fix assertion failure when checking for unused variables in a dependent context.

2017-10-19 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Oct 19 12:07:13 2017 New Revision: 316177 URL: http://llvm.org/viewvc/llvm-project?rev=316177&view=rev Log: [Sema] Fix assertion failure when checking for unused variables in a dependent context. Modified: cfe/trunk/lib/Sema/SemaDecl.cpp cfe/trunk/test/SemaCXX/warn-

Re: r315811 - Re-land r315787, "[Sema] Warn about unused variables if we can constant evaluate the initializer."

2017-10-19 Thread Benjamin Kramer via cfe-commits
We should check VD->getInit()->isValueDependent() before we call evaluateValue. I wasn't able to come up with a test case that triggers the assert though :( On Thu, Oct 19, 2017 at 5:45 PM, Alexander Kornienko wrote: > > > On Sat, Oct 14, 2017 at 5:59 PM, Benjamin Kramer via

r316127 - [Driver] Fix use after free in Hexagon toolchain code.

2017-10-18 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Oct 18 14:43:42 2017 New Revision: 316127 URL: http://llvm.org/viewvc/llvm-project?rev=316127&view=rev Log: [Driver] Fix use after free in Hexagon toolchain code. No functionality change intended. Modified: cfe/trunk/lib/Driver/ToolChains/Hexagon.cpp Modified: cfe/trun

r315845 - [Lex] Remove unused variables. No functionality change.

2017-10-14 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Oct 14 21:27:37 2017 New Revision: 315845 URL: http://llvm.org/viewvc/llvm-project?rev=315845&view=rev Log: [Lex] Remove unused variables. No functionality change. Modified: cfe/trunk/include/clang/Lex/VariadicMacroSupport.h cfe/trunk/lib/Lex/TokenLexer.cpp Modified

r315811 - Re-land r315787, "[Sema] Warn about unused variables if we can constant evaluate the initializer."

2017-10-14 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Oct 14 08:59:34 2017 New Revision: 315811 URL: http://llvm.org/viewvc/llvm-project?rev=315811&view=rev Log: Re-land r315787, "[Sema] Warn about unused variables if we can constant evaluate the initializer." The warnings in libc++ tests were fixed in the meantime. Modified:

[libcxx] r315809 - Placate unused variable warnings uncovered by improvements to clang's -Wunused-variable

2017-10-14 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Oct 14 08:52:38 2017 New Revision: 315809 URL: http://llvm.org/viewvc/llvm-project?rev=315809&view=rev Log: Placate unused variable warnings uncovered by improvements to clang's -Wunused-variable Modified: libcxx/trunk/test/libcxx/depr/depr.c.headers/complex.h.pass.cpp

r315787 - [Sema] Warn about unused variables if we can constant evaluate the initializer.

2017-10-13 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Oct 13 18:30:49 2017 New Revision: 315787 URL: http://llvm.org/viewvc/llvm-project?rev=315787&view=rev Log: [Sema] Warn about unused variables if we can constant evaluate the initializer. If the variable construction can be constant evaluated it doesn't have side effects, so

r315772 - [Sema] Avoid iterator invalidation when code completing.

2017-10-13 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Oct 13 15:14:34 2017 New Revision: 315772 URL: http://llvm.org/viewvc/llvm-project?rev=315772&view=rev Log: [Sema] Avoid iterator invalidation when code completing. It's possible for the code completion consumer to add new decls to the current scope while lookup happens on i

[clang-tools-extra] r315277 - [clang-tidy] Use a more efficient map for the virtual near miss check.

2017-10-10 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Oct 10 00:21:51 2017 New Revision: 315277 URL: http://llvm.org/viewvc/llvm-project?rev=315277&view=rev Log: [clang-tidy] Use a more efficient map for the virtual near miss check. DenseMap performs better here. No functionality change intended. Modified: clang-tools-extr

r315276 - [ASTMatchers] Don't create a copy of a std::set when iterating over it.

2017-10-10 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Oct 10 00:21:34 2017 New Revision: 315276 URL: http://llvm.org/viewvc/llvm-project?rev=315276&view=rev Log: [ASTMatchers] Don't create a copy of a std::set when iterating over it. This is a bit awkward because lookup returns a copy instead of a reference. No functionality ch

Re: r315194 - Make SourceLocation, QualType and friends have constexpr constructors.

2017-10-09 Thread Benjamin Kramer via cfe-commits
gt; warning C4709: comma operator within array index expression > > Please have a look? > > Thanks > > Galina > > On Sun, Oct 8, 2017 at 1:53 PM, Benjamin Kramer via cfe-commits > wrote: >> >> Author: d0k >> Date: Sun Oct 8 13:53:36 2017 >> New Rev

r315197 - Certain versions of clang require an explicit initialization for literal const members.

2017-10-08 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Oct 8 14:28:47 2017 New Revision: 315197 URL: http://llvm.org/viewvc/llvm-project?rev=315197&view=rev Log: Certain versions of clang require an explicit initialization for literal const members. include/clang/Lex/PreprocessorLexer.h:79:3: error: constructor for 'clang::Pre

r315196 - Remove unused variables. No functionality change.

2017-10-08 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Oct 8 14:23:02 2017 New Revision: 315196 URL: http://llvm.org/viewvc/llvm-project?rev=315196&view=rev Log: Remove unused variables. No functionality change. Modified: cfe/trunk/lib/AST/ASTContext.cpp cfe/trunk/lib/AST/ItaniumMangle.cpp cfe/trunk/lib/CodeGen/CGOp

r315194 - Make SourceLocation, QualType and friends have constexpr constructors.

2017-10-08 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Oct 8 13:53:36 2017 New Revision: 315194 URL: http://llvm.org/viewvc/llvm-project?rev=315194&view=rev Log: Make SourceLocation, QualType and friends have constexpr constructors. No functionality change intended. Modified: cfe/trunk/include/clang/AST/CharUnits.h cfe

r315185 - Remove unused variables. No functionality change.

2017-10-08 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Oct 8 12:11:02 2017 New Revision: 315185 URL: http://llvm.org/viewvc/llvm-project?rev=315185&view=rev Log: Remove unused variables. No functionality change. Modified: cfe/trunk/lib/AST/RecordLayoutBuilder.cpp cfe/trunk/lib/CodeGen/CGExprComplex.cpp cfe/trunk/lib

r314391 - Use std::is_trivial instead of is_trivially_copyable.

2017-09-28 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Sep 28 01:50:30 2017 New Revision: 314391 URL: http://llvm.org/viewvc/llvm-project?rev=314391&view=rev Log: Use std::is_trivial instead of is_trivially_copyable. The oldest versions of GCC we support (before 5) didn't support that trait. is_trivial is stronger superset that

[clang-tools-extra] r314119 - [clangd] Fix missing "message" key when responding with unsupported method

2017-09-25 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Sep 25 10:16:47 2017 New Revision: 314119 URL: http://llvm.org/viewvc/llvm-project?rev=314119&view=rev Log: [clangd] Fix missing "message" key when responding with unsupported method The language server protocol dictates that a ResponseError should have a [message string][1]

r314066 - Silence unused variable warning in Release builds.

2017-09-23 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Sep 23 09:08:48 2017 New Revision: 314066 URL: http://llvm.org/viewvc/llvm-project?rev=314066&view=rev Log: Silence unused variable warning in Release builds. Modified: cfe/trunk/lib/CodeGen/CGExprScalar.cpp Modified: cfe/trunk/lib/CodeGen/CGExprScalar.cpp URL: http://

r312710 - Fixing incorrectly capitalised regexps.

2017-09-07 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Sep 7 02:54:03 2017 New Revision: 312710 URL: http://llvm.org/viewvc/llvm-project?rev=312710&view=rev Log: Fixing incorrectly capitalised regexps. Patch by Sam Allen! Modified: cfe/trunk/test/CodeGen/x86_32-xsave.c cfe/trunk/test/CodeGen/x86_64-xsave.c cfe/trun

r312336 - std::function -> llvm::function_ref. NFC.

2017-09-01 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Sep 1 09:51:51 2017 New Revision: 312336 URL: http://llvm.org/viewvc/llvm-project?rev=312336&view=rev Log: std::function -> llvm::function_ref. NFC. Modified: cfe/trunk/include/clang/Analysis/CloneDetection.h cfe/trunk/include/clang/Parse/Parser.h cfe/trunk/lib/

r312186 - [Sema] Make SpecialMemberDecl a PointerIntPair so we can stash it in a SmallPtrSet.

2017-08-30 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Aug 30 15:51:50 2017 New Revision: 312186 URL: http://llvm.org/viewvc/llvm-project?rev=312186&view=rev Log: [Sema] Make SpecialMemberDecl a PointerIntPair so we can stash it in a SmallPtrSet. We have enough spare bits in the alignment of CXXRecordDecl. No functionality chan

[clang-tools-extra] r312166 - [cppcoreguidelines] Don't rely on SmallPtrSet iteration order.

2017-08-30 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Aug 30 13:18:40 2017 New Revision: 312166 URL: http://llvm.org/viewvc/llvm-project?rev=312166&view=rev Log: [cppcoreguidelines] Don't rely on SmallPtrSet iteration order. The fixit emission breaks if the iteration order changes and also missed to emit fixits for some edge ca

r311286 - [ODRHash] Move into anonymous namespace. NFC.

2017-08-20 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Aug 20 06:02:57 2017 New Revision: 311286 URL: http://llvm.org/viewvc/llvm-project?rev=311286&view=rev Log: [ODRHash] Move into anonymous namespace. NFC. Modified: cfe/trunk/lib/AST/ODRHash.cpp Modified: cfe/trunk/lib/AST/ODRHash.cpp URL: http://llvm.org/viewvc/llvm-pr

[clang-tools-extra] r310532 - [clang-tidy] Don't compute the edit distance if it's over the threshold.

2017-08-09 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Aug 9 15:09:29 2017 New Revision: 310532 URL: http://llvm.org/viewvc/llvm-project?rev=310532&view=rev Log: [clang-tidy] Don't compute the edit distance if it's over the threshold. No functional change intended. Modified: clang-tools-extra/trunk/clang-tidy/misc/VirtualN

r310278 - Add some missing -no-canonical-prefixes.

2017-08-07 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Aug 7 11:31:01 2017 New Revision: 310278 URL: http://llvm.org/viewvc/llvm-project?rev=310278&view=rev Log: Add some missing -no-canonical-prefixes. Modified: cfe/trunk/test/Driver/openmp-offload.c Modified: cfe/trunk/test/Driver/openmp-offload.c URL: http://llvm.org/v

r309888 - Remove unused diagnostic. NFC.

2017-08-02 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Aug 2 14:16:50 2017 New Revision: 309888 URL: http://llvm.org/viewvc/llvm-project?rev=309888&view=rev Log: Remove unused diagnostic. NFC. Modified: cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td Modified: cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td URL

r308604 - [vfs] Assert that the status is known in equivalent().

2017-07-20 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Jul 20 04:57:02 2017 New Revision: 308604 URL: http://llvm.org/viewvc/llvm-project?rev=308604&view=rev Log: [vfs] Assert that the status is known in equivalent(). Otherwise we'd silently compare uninitialized data. Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp Mo

r307472 - [CodeGen] Fold variable into assert.

2017-07-08 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Jul 8 07:14:57 2017 New Revision: 307472 URL: http://llvm.org/viewvc/llvm-project?rev=307472&view=rev Log: [CodeGen] Fold variable into assert. Avoids warnings in Release builds. Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp Modified: cfe/trunk/lib/CodeGen/CodeGen

r306873 - [clang-rename] Just return instead of calling exit(3) from main.

2017-06-30 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Jun 30 13:24:32 2017 New Revision: 306873 URL: http://llvm.org/viewvc/llvm-project?rev=306873&view=rev Log: [clang-rename] Just return instead of calling exit(3) from main. Modified: cfe/trunk/tools/clang-rename/ClangRename.cpp Modified: cfe/trunk/tools/clang-rename/Cla

[clang-tools-extra] r306823 - Revert "Modify test so that it looks for patterns in stderr as well"

2017-06-30 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Jun 30 06:23:24 2017 New Revision: 306823 URL: http://llvm.org/viewvc/llvm-project?rev=306823&view=rev Log: Revert "Modify test so that it looks for patterns in stderr as well" This reverts commit r303735. No longer needed after r306822 sends the diagnostics to the proper ou

r306822 - [Driver] Actually report errors during parsing instead of stopping when there's an error somewhere.

2017-06-30 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Jun 30 06:21:27 2017 New Revision: 306822 URL: http://llvm.org/viewvc/llvm-project?rev=306822&view=rev Log: [Driver] Actually report errors during parsing instead of stopping when there's an error somewhere. This is a more principled version of r303756. That change was both

Re: r304207 - Allow for unfinished #if blocks in preambles

2017-06-23 Thread Benjamin Kramer via cfe-commits
Since this change went in I'm seeing spurious errors whenever editing a header file, filed https://bugs.llvm.org/show_bug.cgi?id=33574 for that. On Tue, May 30, 2017 at 1:54 PM, Erik Verbruggen via cfe-commits wrote: > Author: erikjv > Date: Tue May 30 06:54:55 2017 > New Revision: 304207 > > URL

r305103 - Bringt back -triple so the test passes on non-x86.

2017-06-09 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Jun 9 14:47:36 2017 New Revision: 305103 URL: http://llvm.org/viewvc/llvm-project?rev=305103&view=rev Log: Bringt back -triple so the test passes on non-x86. Modified: cfe/trunk/test/Sema/2010-05-31-palignr.c Modified: cfe/trunk/test/Sema/2010-05-31-palignr.c URL: htt

r305094 - [ASTMatchers] Fix use after free.

2017-06-09 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Jun 9 12:55:42 2017 New Revision: 305094 URL: http://llvm.org/viewvc/llvm-project?rev=305094&view=rev Log: [ASTMatchers] Fix use after free. Found by asan. Modified: cfe/trunk/lib/ASTMatchers/Dynamic/Parser.cpp Modified: cfe/trunk/lib/ASTMatchers/Dynamic/Parser.cpp UR

r304892 - [Sema] Silence unused variable warning.

2017-06-07 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Jun 7 05:23:17 2017 New Revision: 304892 URL: http://llvm.org/viewvc/llvm-project?rev=304892&view=rev Log: [Sema] Silence unused variable warning. Modified: cfe/trunk/lib/Sema/SemaExpr.cpp Modified: cfe/trunk/lib/Sema/SemaExpr.cpp URL: http://llvm.org/viewvc/llvm-proj

Re: r304515 - Support lazy stat'ing of files referenced by module maps.

2017-06-02 Thread Benjamin Kramer via cfe-commits
I committed a workaround in r304568. On Fri, Jun 2, 2017 at 6:59 PM, Alexander Kornienko via cfe-commits wrote: > I've not yet figured out exactly, but I have a suspicion that this commit > causes crashes when run under asan. Specifically, when running > test/Modules/preprocess-module.cpp > > The

r304568 - [Modules] Fix use after scope.

2017-06-02 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Jun 2 12:30:24 2017 New Revision: 304568 URL: http://llvm.org/viewvc/llvm-project?rev=304568&view=rev Log: [Modules] Fix use after scope. Found by asan. Modified: cfe/trunk/lib/Serialization/ASTWriter.cpp Modified: cfe/trunk/lib/Serialization/ASTWriter.cpp URL: http:

r304205 - [PPC] Make altivec conversion function macros.

2017-05-30 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue May 30 06:37:29 2017 New Revision: 304205 URL: http://llvm.org/viewvc/llvm-project?rev=304205&view=rev Log: [PPC] Make altivec conversion function macros. The second argument must be a constant, otherwise instruction selection will fail. always_inline is not enough for isel

r304167 - Unbreak long test after r304127.

2017-05-29 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon May 29 13:11:11 2017 New Revision: 304167 URL: http://llvm.org/viewvc/llvm-project?rev=304167&view=rev Log: Unbreak long test after r304127. Modified: cfe/trunk/test/CodeGen/arm_neon_intrinsics.c Modified: cfe/trunk/test/CodeGen/arm_neon_intrinsics.c URL: http://llvm.o

r304030 - Remove unused diagnostics. NFC.

2017-05-26 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri May 26 15:14:12 2017 New Revision: 304030 URL: http://llvm.org/viewvc/llvm-project?rev=304030&view=rev Log: Remove unused diagnostics. NFC. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td URL:

r304028 - Make helper functions static. NFC.

2017-05-26 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri May 26 15:08:24 2017 New Revision: 304028 URL: http://llvm.org/viewvc/llvm-project?rev=304028&view=rev Log: Make helper functions static. NFC. Modified: cfe/trunk/lib/AST/DeclBase.cpp cfe/trunk/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp cfe/trunk/lib/Frontend/TextDiagn

r303686 - [Frontend] Don't index into an empty string.

2017-05-23 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue May 23 15:48:21 2017 New Revision: 303686 URL: http://llvm.org/viewvc/llvm-project?rev=303686&view=rev Log: [Frontend] Don't index into an empty string. Found by msan! Modified: cfe/trunk/lib/Frontend/TextDiagnostic.cpp Modified: cfe/trunk/lib/Frontend/TextDiagnostic.c

[clang-tools-extra] r303625 - [clangd] Explicitly link against pthread.

2017-05-23 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue May 23 05:29:54 2017 New Revision: 303625 URL: http://llvm.org/viewvc/llvm-project?rev=303625&view=rev Log: [clangd] Explicitly link against pthread. Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt URL: ht

[clang-tools-extra] r303623 - [clangd] Pick up deps via LLVM components, which will hopefully include pthread.

2017-05-23 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue May 23 05:17:48 2017 New Revision: 303623 URL: http://llvm.org/viewvc/llvm-project?rev=303623&view=rev Log: [clangd] Pick up deps via LLVM components, which will hopefully include pthread. Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt Modified: clang-tools-ext

[clang-tools-extra] r303376 - [clangd] Make formatting.test asynchronous again.

2017-05-18 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu May 18 15:10:04 2017 New Revision: 303376 URL: http://llvm.org/viewvc/llvm-project?rev=303376&view=rev Log: [clangd] Make formatting.test asynchronous again. This test doesn't rely on the order of asynchronous messages, enable threads so we have at least some coverage for th

[clang-tools-extra] r303242 - Revert "[include-fixer] Don't throw exception when parsing unknown arguments in vim script."

2017-05-17 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed May 17 04:24:28 2017 New Revision: 303242 URL: http://llvm.org/viewvc/llvm-project?rev=303242&view=rev Log: Revert "[include-fixer] Don't throw exception when parsing unknown arguments in vim script." This reverts commit r302934. It's wrong, edits the wrong file and was com

Re: [clang-tools-extra] r302934 - [include-fixer] Don't throw exception when parsing unknown arguments in

2017-05-12 Thread Benjamin Kramer via cfe-commits
On Fri, May 12, 2017 at 9:01 PM, Haojian Wu via cfe-commits wrote: > Author: hokein > Date: Fri May 12 14:01:02 2017 > New Revision: 302934 > > URL: http://llvm.org/viewvc/llvm-project?rev=302934&view=rev > Log: > [include-fixer] Don't throw exception when parsing unknown arguments in > vim script

r301825 - Silence unused variable warning. NFC.

2017-05-01 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon May 1 15:00:23 2017 New Revision: 301825 URL: http://llvm.org/viewvc/llvm-project?rev=301825&view=rev Log: Silence unused variable warning. NFC. Modified: cfe/trunk/lib/AST/ExprConstant.cpp Modified: cfe/trunk/lib/AST/ExprConstant.cpp URL: http://llvm.org/viewvc/llvm-

[clang-tools-extra] r300991 - [Clangd] Failed to decode params using 1.x-compatible request message

2017-04-21 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Apr 21 10:51:23 2017 New Revision: 300991 URL: http://llvm.org/viewvc/llvm-project?rev=300991&view=rev Log: [Clangd] Failed to decode params using 1.x-compatible request message textDocument/completion sends a TextDocumentPositionParams message in the 2.x and 3.x. But in 1.x

[clang-tools-extra] r300990 - [Clangd] Support Authority-less URIs

2017-04-21 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Apr 21 10:51:18 2017 New Revision: 300990 URL: http://llvm.org/viewvc/llvm-project?rev=300990&view=rev Log: [Clangd] Support Authority-less URIs Clangd strips URIs by removing the file:// part but some clients can send file: which is also valid according to RFC 3896. For exa

r300873 - [Driver] Add a missing -no-canonical-prefixes to test.

2017-04-20 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Apr 20 14:06:24 2017 New Revision: 300873 URL: http://llvm.org/viewvc/llvm-project?rev=300873&view=rev Log: [Driver] Add a missing -no-canonical-prefixes to test. Modified: cfe/trunk/test/Driver/avr-mmcu.c Modified: cfe/trunk/test/Driver/avr-mmcu.c URL: http://llvm.org

Re: r300443 - Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace a friend, and a visible friend can properly replace an invisible friend but not vice verse, and definitions

2017-04-17 Thread Benjamin Kramer via cfe-commits
This broke our internal build of libc++ with modules. Reduced test case attached, courtesy of Richard Smith! With your patch it doesn't compiler anymore: While building module 'x': In file included from :2: In file included from ./c.h:1: ./a.h:3:32: error: inline declaration of 'f' follows non-inl

r300497 - Revert "Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace a friend, and a visible friend can properly replace an invisible friend but not vice verse, and definit

2017-04-17 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Apr 17 15:57:40 2017 New Revision: 300497 URL: http://llvm.org/viewvc/llvm-project?rev=300497&view=rev Log: Revert "Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace a friend, and a visible friend can properly replace an invisible friend but not

r300006 - Silence unused variable warning in release builds.

2017-04-11 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Apr 11 18:06:49 2017 New Revision: 36 URL: http://llvm.org/viewvc/llvm-project?rev=36&view=rev Log: Silence unused variable warning in release builds. Modified: cfe/trunk/lib/AST/ExternalASTMerger.cpp Modified: cfe/trunk/lib/AST/ExternalASTMerger.cpp URL: http:

Re: [PATCH] Use the correct ObjC++ personality

2017-04-01 Thread Benjamin Kramer via cfe-commits
Landed in r299306 with a test case. Yes, even one-liners should have a test case. On Thu, Mar 30, 2017 at 10:30 PM, Jonathan Schleifer via cfe-commits wrote: >> Testcase? > > Shouldn't be necessary for such a simple and extremely obvious one-liner. > > -- > Jonathan >

r299306 - [ObjC++] Use the correct EH personality in GNU mode

2017-04-01 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Apr 1 12:59:01 2017 New Revision: 299306 URL: http://llvm.org/viewvc/llvm-project?rev=299306&view=rev Log: [ObjC++] Use the correct EH personality in GNU mode Previously, it would just always use the ObjC DWARF personality, even with SjLj or SEH exceptions. Patch by Jonath

r299191 - [msan] Turn off lifetime markers even when use after scope checking is on.

2017-03-31 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Mar 31 04:19:25 2017 New Revision: 299191 URL: http://llvm.org/viewvc/llvm-project?rev=299191&view=rev Log: [msan] Turn off lifetime markers even when use after scope checking is on. Since r299174 use after scope checking is on by default. Even though msan doesn't check for

r298443 - Apply clang-tidy's performance-unnecessary-value-param to parts of clang.

2017-03-21 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Mar 21 16:35:04 2017 New Revision: 298443 URL: http://llvm.org/viewvc/llvm-project?rev=298443&view=rev Log: Apply clang-tidy's performance-unnecessary-value-param to parts of clang. No functionality change intended. Modified: cfe/trunk/include/clang/Driver/ToolChain.h

[clang-tools-extra] r298442 - Apply clang-tidy's performance-unnecessary-value-param to clang-tidy.

2017-03-21 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Mar 21 16:34:58 2017 New Revision: 298442 URL: http://llvm.org/viewvc/llvm-project?rev=298442&view=rev Log: Apply clang-tidy's performance-unnecessary-value-param to clang-tidy. No functionality change intended. Modified: clang-tools-extra/trunk/clang-tidy/cppcoreguide

[clang-tools-extra] r297779 - [clangd] Fix not being able to attach a debugger on macOS

2017-03-14 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Mar 14 15:41:28 2017 New Revision: 297779 URL: http://llvm.org/viewvc/llvm-project?rev=297779&view=rev Log: [clangd] Fix not being able to attach a debugger on macOS Clangd is often waiting for input on getline as it awaits requests. If the getline is interrupted, it causes

Re: r296927 - Add arch-specific directory to search path

2017-03-06 Thread Benjamin Kramer via cfe-commits
On Mon, Mar 6, 2017 at 7:00 PM, Pirama Arumuga Nainar wrote: > Adding Reid, Michal > > > On Mon, Mar 6, 2017 at 5:01 AM, Benjamin Kramer wrote: >> >> On Sat, Mar 4, 2017 at 12:20 AM, Pirama Arumuga Nainar via cfe-commits >> wrote: >> > Author: pirama >> > Date: Fri Mar 3 17:20:49 2017 >> > New

Re: r296927 - Add arch-specific directory to search path

2017-03-06 Thread Benjamin Kramer via cfe-commits
On Sat, Mar 4, 2017 at 12:20 AM, Pirama Arumuga Nainar via cfe-commits wrote: > Author: pirama > Date: Fri Mar 3 17:20:49 2017 > New Revision: 296927 > > URL: http://llvm.org/viewvc/llvm-project?rev=296927&view=rev > Log: > Add arch-specific directory to search path > > Summary: > > This change a

[clang-tools-extra] r296737 - [clangd] Fix a potential race by copying the FixIts out of ASTManager before releasing the lock.

2017-03-02 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Mar 2 04:25:00 2017 New Revision: 296737 URL: http://llvm.org/viewvc/llvm-project?rev=296737&view=rev Log: [clangd] Fix a potential race by copying the FixIts out of ASTManager before releasing the lock. Also document the locking semantics a bit better. Modified: clan

[clang-tools-extra] r296637 - [clangd] Unbreak the shared build.

2017-03-01 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Mar 1 10:23:40 2017 New Revision: 296637 URL: http://llvm.org/viewvc/llvm-project?rev=296637&view=rev Log: [clangd] Unbreak the shared build. Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt URL: http://ll

[clang-tools-extra] r296636 - [clangd] Add support for FixIts.

2017-03-01 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Mar 1 10:16:29 2017 New Revision: 296636 URL: http://llvm.org/viewvc/llvm-project?rev=296636&view=rev Log: [clangd] Add support for FixIts. Summary: This uses CodeActions to show 'apply fix' actions when code actions are requested for a location. The actions themselves make

[clang-tools-extra] r296390 - [clangd] Make clangd install to bin

2017-02-27 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Feb 27 15:40:35 2017 New Revision: 296390 URL: http://llvm.org/viewvc/llvm-project?rev=296390&view=rev Log: [clangd] Make clangd install to bin This allows the install target to also install clangd to bin, so that it can be deployed and used outside the build tree. Patch by

r296034 - [CodeGen] Silence unused variable warning in Release builds.

2017-02-23 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Feb 23 16:47:56 2017 New Revision: 296034 URL: http://llvm.org/viewvc/llvm-project?rev=296034&view=rev Log: [CodeGen] Silence unused variable warning in Release builds. Modified: cfe/trunk/lib/CodeGen/CGVTables.cpp Modified: cfe/trunk/lib/CodeGen/CGVTables.cpp URL: htt

r295820 - [ODRHash] Avoid dereferencing end() of a SmallVector.

2017-02-22 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Feb 22 04:19:45 2017 New Revision: 295820 URL: http://llvm.org/viewvc/llvm-project?rev=295820&view=rev Log: [ODRHash] Avoid dereferencing end() of a SmallVector. Found by MSAN. Modified: cfe/trunk/lib/Serialization/ASTReader.cpp Modified: cfe/trunk/lib/Serialization/AS

[clang-tools-extra] r295715 - [clang-tidy] Reword the "code outside header guard" warning.

2017-02-21 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Feb 21 05:25:45 2017 New Revision: 295715 URL: http://llvm.org/viewvc/llvm-project?rev=295715&view=rev Log: [clang-tidy] Reword the "code outside header guard" warning. The check doesn't really know if the code it is warning about came before or after the header guard, so ph

r295320 - Silence sign compare warning. NFC.

2017-02-16 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Feb 16 08:08:41 2017 New Revision: 295320 URL: http://llvm.org/viewvc/llvm-project?rev=295320&view=rev Log: Silence sign compare warning. NFC. ExprConstant.cpp:6344:20: warning: comparison of integers of different signs: 'const size_t' (aka 'const unsigned long') and 'typena

[clang-tools-extra] r295198 - [clangd] Fix another use after free that I missed because COW strings.

2017-02-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Feb 15 11:04:57 2017 New Revision: 295198 URL: http://llvm.org/viewvc/llvm-project?rev=295198&view=rev Log: [clangd] Fix another use after free that I missed because COW strings. Modified: clang-tools-extra/trunk/clangd/ProtocolHandlers.cpp Modified: clang-tools-extra/t

[clang-tools-extra] r295196 - [clangd] Silence GCC warning about falling off a fully covered switch.

2017-02-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Feb 15 10:58:44 2017 New Revision: 295196 URL: http://llvm.org/viewvc/llvm-project?rev=295196&view=rev Log: [clangd] Silence GCC warning about falling off a fully covered switch. Modified: clang-tools-extra/trunk/clangd/ASTManager.cpp Modified: clang-tools-extra/trunk/c

[clang-tools-extra] r295194 - [clangd] Synchronize logs access.

2017-02-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Feb 15 10:44:11 2017 New Revision: 295194 URL: http://llvm.org/viewvc/llvm-project?rev=295194&view=rev Log: [clangd] Synchronize logs access. I don't think that this is necessary for correctness, but makes tsan much more useful. Modified: clang-tools-extra/trunk/clangd/

[clang-tools-extra] r295193 - [clangd] Initialize the thread after the mutex.

2017-02-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Feb 15 10:34:58 2017 New Revision: 295193 URL: http://llvm.org/viewvc/llvm-project?rev=295193&view=rev Log: [clangd] Initialize the thread after the mutex. Otherwise locking the mutex yields a racy assertion failure on picky implementations. Modified: clang-tools-extra/

[clang-tools-extra] r295187 - [clangd] Fix use after free.

2017-02-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Feb 15 09:56:14 2017 New Revision: 295187 URL: http://llvm.org/viewvc/llvm-project?rev=295187&view=rev Log: [clangd] Fix use after free. Modified: clang-tools-extra/trunk/clangd/ProtocolHandlers.cpp Modified: clang-tools-extra/trunk/clangd/ProtocolHandlers.cpp URL: htt

[clang-tools-extra] r295184 - [clangd] Add missing include.

2017-02-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Feb 15 09:19:13 2017 New Revision: 295184 URL: http://llvm.org/viewvc/llvm-project?rev=295184&view=rev Log: [clangd] Add missing include. Modified: clang-tools-extra/trunk/clangd/DocumentStore.h Modified: clang-tools-extra/trunk/clangd/DocumentStore.h URL: http://llvm.

[clang-tools-extra] r295180 - [clangd] Wire up ASTUnit and publish diagnostics with it.

2017-02-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Feb 15 09:04:20 2017 New Revision: 295180 URL: http://llvm.org/viewvc/llvm-project?rev=295180&view=rev Log: [clangd] Wire up ASTUnit and publish diagnostics with it. Summary: This requires an accessible compilation database. The parsing is done asynchronously on a separate t

[clang-tools-extra] r295049 - [clang-tidy] Add support for NOLINTNEXTLINE.

2017-02-14 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Feb 14 06:47:56 2017 New Revision: 295049 URL: http://llvm.org/viewvc/llvm-project?rev=295049&view=rev Log: [clang-tidy] Add support for NOLINTNEXTLINE. Reviewers: alexfh Subscribers: JDevlieghere, cfe-commits Differential Revision: https://reviews.llvm.org/D29899 Added:

[clang-tools-extra] r294974 - [clang-tidy] Reduce indentation. NFC.

2017-02-13 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Feb 13 12:03:10 2017 New Revision: 294974 URL: http://llvm.org/viewvc/llvm-project?rev=294974&view=rev Log: [clang-tidy] Reduce indentation. NFC. Modified: clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp Modified: clang-tools-extra/trunk/clang-tidy/Cl

r294963 - [ASTUnit] Clear out diagnostic state after creating the preamble.

2017-02-13 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Feb 13 10:16:43 2017 New Revision: 294963 URL: http://llvm.org/viewvc/llvm-project?rev=294963&view=rev Log: [ASTUnit] Clear out diagnostic state after creating the preamble. If the preamble had diagnostic state this would leave behind invalid state in the DiagnosticsEngine a

r294838 - Make helpers static. NFC.

2017-02-11 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Feb 11 06:21:17 2017 New Revision: 294838 URL: http://llvm.org/viewvc/llvm-project?rev=294838&view=rev Log: Make helpers static. NFC. Modified: cfe/trunk/lib/Analysis/OSLog.cpp cfe/trunk/lib/Sema/SemaTemplateDeduction.cpp Modified: cfe/trunk/lib/Analysis/OSLog.cpp U

r294820 - Update XFAIL line after r294781.

2017-02-10 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Feb 10 20:00:03 2017 New Revision: 294820 URL: http://llvm.org/viewvc/llvm-project?rev=294820&view=rev Log: Update XFAIL line after r294781. Modified: cfe/trunk/test/Driver/XRay/xray-instrument-cpu.c Modified: cfe/trunk/test/Driver/XRay/xray-instrument-cpu.c URL: http:

[clang-tools-extra] r294760 - [clangd] Move isDone from the JSONOutput to ShutdownHandler.

2017-02-10 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Feb 10 11:25:38 2017 New Revision: 294760 URL: http://llvm.org/viewvc/llvm-project?rev=294760&view=rev Log: [clangd] Move isDone from the JSONOutput to ShutdownHandler. This is just as easy to check from main but prevents random code from shutting down the server. Modified:

[clang-tools-extra] r294747 - [clangd] Refactor stream output into a single thread-safe output object.

2017-02-10 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Feb 10 08:08:40 2017 New Revision: 294747 URL: http://llvm.org/viewvc/llvm-project?rev=294747&view=rev Log: [clangd] Refactor stream output into a single thread-safe output object. This abstracts away the passing of raw_ostreams everywhere, thread safety will be used soon.

<    1   2   3   4   5   6   7   8   9   10   >