r257341 - [clang-format] Fix comment aligning when there are changes within the comment

2016-01-11 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Jan 11 10:27:16 2016 New Revision: 257341 URL: http://llvm.org/viewvc/llvm-project?rev=257341&view=rev Log: [clang-format] Fix comment aligning when there are changes within the comment As soon as a comment had whitespace changes inside of the token, we couldn't identify the

Re: [PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

2016-01-11 Thread Benjamin Kramer via cfe-commits
bkramer updated this revision to Diff 44513. bkramer added a comment. - Moved newline check into replaceWhitespaceInToken - Removed duplicated TokenLength computation http://reviews.llvm.org/D16058 Files: lib/Format/WhitespaceManager.cpp lib/Format/WhitespaceManager.h unittests/Format/For

Re: [PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

2016-01-11 Thread Benjamin Kramer via cfe-commits
bkramer updated this revision to Diff 44508. bkramer added a comment. - Renamed flag to IsInsideToken and enabled it for all in-token replacements. - TokenLength now gets updated to contain all changes on the same line if they're in the same token. http://reviews.llvm.org/D16058 Files: lib/F

Re: [PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

2016-01-11 Thread Benjamin Kramer via cfe-commits
bkramer updated this revision to Diff 44472. bkramer added a comment. Why not both? http://reviews.llvm.org/D16058 Files: lib/Format/WhitespaceManager.cpp lib/Format/WhitespaceManager.h unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp ===

[PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

2016-01-11 Thread Benjamin Kramer via cfe-commits
bkramer created this revision. bkramer added a reviewer: djasper. bkramer added a subscriber: cfe-commits. Herald added a subscriber: klimek. As soon as a comment had whitespace changes inside of the token, we couldn't identify the whole comment as a trailing comment anymore and alignment stopped

Re: [PATCH] D15743: Fix assert hit when tree-transforming template template parameter packs.

2016-01-11 Thread Benjamin Kramer via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This looks good. getAsTemplateOrTemplatePattern mirrors the existing switch in TreeTransform. http://reviews.llvm.org/D15743 ___ cfe-commits m

Re: r257260 - [vfs] Normalize working directory if requested.

2016-01-10 Thread Benjamin Kramer via cfe-commits
Fixed in r257286, sorry for the breakage. On Sun, Jan 10, 2016 at 7:59 AM, Ismail Donmez wrote: > Hi, > >> + NormalizedFS.setCurrentWorkingDirectory("/b/c"); >> + NormalizedFS.setCurrentWorkingDirectory("."); >> + ASSERT_EQ("/b/c", NormalizedFS.getCurrentWorkingDirectory().get()); >> + Normal

r257287 - Simplify test code with initializer lists.

2016-01-10 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Jan 10 04:45:19 2016 New Revision: 257287 URL: http://llvm.org/viewvc/llvm-project?rev=257287&view=rev Log: Simplify test code with initializer lists. No functional change intended. Modified: cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp Modified: cfe/trunk/unitt

r257286 - Make test work on windows by turning \ in paths back into /.

2016-01-10 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Jan 10 04:36:59 2016 New Revision: 257286 URL: http://llvm.org/viewvc/llvm-project?rev=257286&view=rev Log: Make test work on windows by turning \ in paths back into /. Modified: cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp Modified: cfe/trunk/unittests/Basic/Vir

r257260 - [vfs] Normalize working directory if requested.

2016-01-09 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Jan 9 10:33:16 2016 New Revision: 257260 URL: http://llvm.org/viewvc/llvm-project?rev=257260&view=rev Log: [vfs] Normalize working directory if requested. FixedCompilationDatabase sets the working dir to "." by default. For chdir(".") this is a noop but this lead to InMemor

Re: r257259 - Make clang::format::reformat work with non 0-terminated strings.

2016-01-09 Thread Benjamin Kramer via cfe-commits
On Sat, Jan 9, 2016 at 4:56 PM, Daniel Jasper via cfe-commits wrote: > Author: djasper > Date: Sat Jan 9 09:56:57 2016 > New Revision: 257259 > > URL: http://llvm.org/viewvc/llvm-project?rev=257259&view=rev > Log: > Make clang::format::reformat work with non 0-terminated strings. > > Modified: >

Re: [PATCH] D14329: Show inclusions from a preamble in clang_getInclusions.

2016-01-06 Thread Benjamin Kramer via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. LGTM, thanks for the fix! Comment at: tools/libclang/CIndexInclusionStack.cpp:32 @@ -36,13 +31,3 @@ SmallVector InclusionStack; - unsigned n = SM.local_sloc_entry_size(

Re: [clang-tools-extra] r256562 - [clang-tidy] Fix a use-after-free bug found by asan

2015-12-29 Thread Benjamin Kramer via cfe-commits
On Tue, Dec 29, 2015 at 5:14 PM, Alexander Kornienko via cfe-commits wrote: > Author: alexfh > Date: Tue Dec 29 10:14:38 2015 > New Revision: 256562 > > URL: http://llvm.org/viewvc/llvm-project?rev=256562&view=rev > Log: > [clang-tidy] Fix a use-after-free bug found by asan > > Modified: > >

r256377 - Replace llvm::utostr calls in Twine context with Twines. NFC.

2015-12-24 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Dec 24 04:07:37 2015 New Revision: 256377 URL: http://llvm.org/viewvc/llvm-project?rev=256377&view=rev Log: Replace llvm::utostr calls in Twine context with Twines. NFC. Modified: cfe/trunk/lib/AST/ItaniumMangle.cpp cfe/trunk/lib/Basic/Targets.cpp Modified: cfe/trun

r255635 - [libclang] Add a flag to create the precompiled preamble on the first parse.

2015-12-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Dec 15 03:30:31 2015 New Revision: 255635 URL: http://llvm.org/viewvc/llvm-project?rev=255635&view=rev Log: [libclang] Add a flag to create the precompiled preamble on the first parse. Summary: The current default is to create the preamble on the first reparse, aka second pa

Re: [PATCH] D15490: [libclang] Add a flag to create the precompiled preamble on the first parse.

2015-12-14 Thread Benjamin Kramer via cfe-commits
bkramer updated this revision to Diff 42749. bkramer added a comment. Add test case. http://reviews.llvm.org/D15490 Files: include/clang-c/Index.h include/clang/Frontend/ASTUnit.h lib/Frontend/ASTUnit.cpp test/Index/complete-preamble.cpp tools/c-index-test/c-index-test.c tools/libcl

[PATCH] D15490: [libclang] Add a flag to create the precompiled preamble on the first parse.

2015-12-14 Thread Benjamin Kramer via cfe-commits
bkramer created this revision. bkramer added reviewers: doug.gregor, klimek. bkramer added a subscriber: cfe-commits. The current default is to create the preamble on the first reparse, aka second parse. This is useful for clients that do not want to block when opening a file because serializing t

[PATCH] D15147: [clang-format] Reflow block comments when they're over the column limit

2015-12-02 Thread Benjamin Kramer via cfe-commits
bkramer created this revision. bkramer added reviewers: djasper, klimek. bkramer added a subscriber: cfe-commits. Herald added a subscriber: klimek. /* a * a*/ Now becomes /* * a a*/ instead of /* * a * a*/ This is implemented by glueing the next line on while f

r254446 - Avoid picking up system headers in unittest by providing a fake libstdc++ with a ridiculously high version number.

2015-12-01 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Dec 1 13:42:07 2015 New Revision: 254446 URL: http://llvm.org/viewvc/llvm-project?rev=254446&view=rev Log: Avoid picking up system headers in unittest by providing a fake libstdc++ with a ridiculously high version number. The host libstdc++ may be horribly broken and we wa

r253654 - Regenerate ASTMatchersReference without CRLF.

2015-11-20 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Nov 20 01:57:46 2015 New Revision: 253654 URL: http://llvm.org/viewvc/llvm-project?rev=253654&view=rev Log: Regenerate ASTMatchersReference without CRLF. Modified: cfe/trunk/docs/LibASTMatchersReference.html Modified: cfe/trunk/docs/LibASTMatchersReference.html URL: ht

r253466 - [libclang] Add entry points that take a full command line including argv[0].

2015-11-18 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Nov 18 10:14:27 2015 New Revision: 253466 URL: http://llvm.org/viewvc/llvm-project?rev=253466&view=rev Log: [libclang] Add entry points that take a full command line including argv[0]. This provides both a more uniform interface and makes libclang behave like clang tooling w

Re: [PATCH] D14695: [libclang] Add entry points that take a full command line including argv[0].

2015-11-16 Thread Benjamin Kramer via cfe-commits
bkramer updated this revision to Diff 40269. bkramer added a comment. - Add a test case to make sure argv[0] handling actually works. - Clarify comments a bit. http://reviews.llvm.org/D14695 Files: include/clang-c/Index.h lib/Frontend/CreateInvocationFromCommandLine.cpp tools/diagtool/Sho

[PATCH] D14695: [libclang] Add entry points that take a full command line including argv[0].

2015-11-16 Thread Benjamin Kramer via cfe-commits
bkramer created this revision. bkramer added a reviewer: klimek. bkramer added a subscriber: cfe-commits. This provides both a more uniform interface and makes libclang behave like clang tooling wrt relative paths against argv[0]. This is necessary for finding paths to a c++ standard library relat

Re: [PATCH] D11944: Nativize filename in FileManager::getFile().

2015-11-02 Thread Benjamin Kramer via cfe-commits
bkramer added a comment. Can you try setting up the virtual files with the vfs::InMemoryFileSystem stuff? There are some examples how to set up with OverlayFileSystem in tree. InMemoryFileSystem was written with windows path separators in mind, I just never tried to run it on windows :) http:

Re: [PATCH] D13844: [libclang] Visit TypeAliasTemplateDecl

2015-11-01 Thread Benjamin Kramer via cfe-commits
bkramer accepted this revision. bkramer added a comment. Looks good to me too, do you have commit access? http://reviews.llvm.org/D13844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

r251528 - Move global classes into anonymous namespaces. NFC.

2015-10-28 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Oct 28 12:16:26 2015 New Revision: 251528 URL: http://llvm.org/viewvc/llvm-project?rev=251528&view=rev Log: Move global classes into anonymous namespaces. NFC. Modified: cfe/trunk/lib/AST/ExprConstant.cpp cfe/trunk/lib/CodeGen/CGCall.cpp Modified: cfe/trunk/lib/AST/

r251514 - Put global classes into the appropriate namespace.

2015-10-28 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Oct 28 08:54:16 2015 New Revision: 251514 URL: http://llvm.org/viewvc/llvm-project?rev=251514&view=rev Log: Put global classes into the appropriate namespace. Most of the cases belong into an anonymous namespace. No functionality change intended. Modified: cfe/trunk/inc

[clang-tools-extra] r251499 - [tidy] Remove stray iostream include from test.

2015-10-27 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Oct 28 00:16:37 2015 New Revision: 251499 URL: http://llvm.org/viewvc/llvm-project?rev=251499&view=rev Log: [tidy] Remove stray iostream include from test. It is unused and we cannot rely on standard headers being present while executing tests. Modified: clang-tools-ext

Re: [PATCH] D13891: Apply modernize-use-default to llvm.

2015-10-27 Thread Benjamin Kramer via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Two minor comments, otherwise looks good: 1. beware of the GCC 4.7 issues and trivial class initializer issues we hit with this kind of changes earlier. 2. I prefer to leave utils/unittest/g

Re: [PATCH] D13920: Minor fix in ToolChainTest.cpp to allow user defined GCC toolchain.

2015-10-27 Thread Benjamin Kramer via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This should be fine. Sorry for the breakage. http://reviews.llvm.org/D13920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

r251432 - Remove unused diagnostic. NFC.

2015-10-27 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Oct 27 13:34:47 2015 New Revision: 251432 URL: http://llvm.org/viewvc/llvm-project?rev=251432&view=rev Log: Remove unused diagnostic. NFC. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td URL:

Re: Getting fully qualified names of random qualtypes

2015-10-26 Thread Benjamin Kramer via cfe-commits
Some high level style comments: 1. Please convert the file to LLVM style for the things that clang-format doesn't change. In particular PascalCase for all variables and cameCase for all function names. 2. We don't do author attribution in file comments, sorry. 3. Try to avoid commented out/#if 0'd

[clang-tools-extra] r251279 - Drop dead return after llvm_unreachable. NFC.

2015-10-26 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Oct 26 04:57:00 2015 New Revision: 251279 URL: http://llvm.org/viewvc/llvm-project?rev=251279&view=rev Log: Drop dead return after llvm_unreachable. NFC. Modified: clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp Modified: clang-tools-extra/trun

[clang-tools-extra] r251265 - assert(false) -> llvm_unreachable.

2015-10-25 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Oct 25 17:03:00 2015 New Revision: 251265 URL: http://llvm.org/viewvc/llvm-project?rev=251265&view=rev Log: assert(false) -> llvm_unreachable. Modified: clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp Modified: clang-tools-extra/trunk/clang-tid

r251110 - [AST] Plug a memory leak when promoting a single ParentMap entry to a vector.

2015-10-23 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Oct 23 08:24:18 2015 New Revision: 251110 URL: http://llvm.org/viewvc/llvm-project?rev=251110&view=rev Log: [AST] Plug a memory leak when promoting a single ParentMap entry to a vector. Found by asan! Modified: cfe/trunk/lib/AST/ASTContext.cpp Modified: cfe/trunk/lib/A

r251101 - [AST] Re-add TypeLocs and NestedNameSpecifierLocs to the ParentMap.

2015-10-23 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Oct 23 04:04:55 2015 New Revision: 251101 URL: http://llvm.org/viewvc/llvm-project?rev=251101&view=rev Log: [AST] Re-add TypeLocs and NestedNameSpecifierLocs to the ParentMap. This relands r250831 after some fixes to shrink the ParentMap overall with one addtional tweak: nod

[PATCH] D14011: [AST] Re-add TypeLocs and NestedNameSpecifierLocs to the ParentMap.

2015-10-23 Thread Benjamin Kramer via cfe-commits
bkramer created this revision. bkramer added reviewers: klimek, djasper. bkramer added a subscriber: cfe-commits. Herald added a subscriber: klimek. This relands r250831 after some fixes to shrink the ParentMap overall with one addtional tweak: nodes with pointer identity (e.g. Decl* and friends)

r251026 - Unbreak the shared cmake build. libToolingCore now depends on libAST.

2015-10-22 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Oct 22 10:45:54 2015 New Revision: 251026 URL: http://llvm.org/viewvc/llvm-project?rev=251026&view=rev Log: Unbreak the shared cmake build. libToolingCore now depends on libAST. Modified: cfe/trunk/lib/Tooling/Core/CMakeLists.txt Modified: cfe/trunk/lib/Tooling/Core/CMa

r251022 - [Tooling] Add a utility function to replace one nested name with another.

2015-10-22 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Oct 22 10:04:10 2015 New Revision: 251022 URL: http://llvm.org/viewvc/llvm-project?rev=251022&view=rev Log: [Tooling] Add a utility function to replace one nested name with another. One problem in clang-tidy and other clang tools face is that there is no way to lookup an arb

Re: [PATCH] D13931: [Tooling] Add a utility function to replace one nested name with another.

2015-10-22 Thread Benjamin Kramer via cfe-commits
bkramer updated this revision to Diff 38130. bkramer added a comment. Enforce :: at the beginning of the new name. http://reviews.llvm.org/D13931 Files: include/clang/Tooling/Core/Lookup.h lib/Tooling/Core/CMakeLists.txt lib/Tooling/Core/Lookup.cpp unittests/Tooling/CMakeLists.txt uni

Re: [PATCH] D13931: [Tooling] Add a utility function to replace one nested name with another.

2015-10-22 Thread Benjamin Kramer via cfe-commits
bkramer updated this revision to Diff 38122. bkramer added a comment. Add more comments and polish test cases. http://reviews.llvm.org/D13931 Files: include/clang/Tooling/Core/Lookup.h lib/Tooling/Core/CMakeLists.txt lib/Tooling/Core/Lookup.cpp unittests/Tooling/CMakeLists.txt unittes

Re: [PATCH] D13931: [Tooling] Add a utility function to replace one nested name with another.

2015-10-22 Thread Benjamin Kramer via cfe-commits
bkramer updated this revision to Diff 38117. bkramer added a comment. - Removed "fully qualified" in favor of just "qualified" to clarify that the name should be qualified but the leading "::" is not necessary. - Renamed isNameSpecifierGlobal - Removed always true conditional from test http://r

r251009 - [AST] Remove redundant template keywords.

2015-10-22 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Oct 22 06:26:35 2015 New Revision: 251009 URL: http://llvm.org/viewvc/llvm-project?rev=251009&view=rev Log: [AST] Remove redundant template keywords. GCC complains about them, clang does not. Modified: cfe/trunk/lib/AST/ASTContext.cpp Modified: cfe/trunk/lib/AST/ASTCon

r251008 - [AST] Store Decl* and Stmt* directly into the ParentMap.

2015-10-22 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Oct 22 06:21:40 2015 New Revision: 251008 URL: http://llvm.org/viewvc/llvm-project?rev=251008&view=rev Log: [AST] Store Decl* and Stmt* directly into the ParentMap. These are by far the most common types to be parents in the AST so it makes sense to optimize for them. Put th

[PATCH] D13976: [AST] Store Decl* and Stmt* directly into the ParentMap.

2015-10-22 Thread Benjamin Kramer via cfe-commits
bkramer created this revision. bkramer added reviewers: klimek, djasper. bkramer added a subscriber: cfe-commits. These are by far the most common types to be parents in the AST so it makes sense to optimize for them. Put them directly into the value of the map. This currently saves 32 bytes per p

r250905 - Shrink DynTypedNode by one pointer from 40 to 32 bytes (on x86_64).

2015-10-21 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Oct 21 11:33:15 2015 New Revision: 250905 URL: http://llvm.org/viewvc/llvm-project?rev=250905&view=rev Log: Shrink DynTypedNode by one pointer from 40 to 32 bytes (on x86_64). The MemoizationData cache was introduced to avoid a series of enum compares at the cost of making D

Re: [PATCH] D13946: Shrink DynTypedNode by one pointer from 40 to 32 bytes (on x86_64).

2015-10-21 Thread Benjamin Kramer via cfe-commits
bkramer updated this revision to Diff 38023. bkramer added a comment. Update casts to avoid potential undefined behavior. Now every pointer goes through const void*. http://reviews.llvm.org/D13946 Files: include/clang/AST/ASTTypeTraits.h unittests/ASTMatchers/Dynamic/RegistryTest.cpp Inde

[PATCH] D13946: Shrink DynTypedNode by one pointer from 40 to 32 bytes (on x86_64).

2015-10-21 Thread Benjamin Kramer via cfe-commits
bkramer created this revision. bkramer added a reviewer: sbenza. bkramer added a subscriber: cfe-commits. Herald added a subscriber: klimek. The MemoizationData cache was introduced to avoid a series of enum compares at the cost of making DynTypedNode bigger. This change reverts to using an enum c

Re: r250831 - [AST] Put TypeLocs and NestedNameSpecifierLocs into the ParentMap.

2015-10-21 Thread Benjamin Kramer via cfe-commits
is means, this change is effectively > increasing the parent map by 10x and it was already large to begin with. > > Please revert and lets come up with a different solution. > > On Tue, Oct 20, 2015 at 5:08 PM, Benjamin Kramer via cfe-commits > wrote: >> >> Author:

r250889 - Revert "[AST] Put TypeLocs and NestedNameSpecifierLocs into the ParentMap."

2015-10-21 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Oct 21 05:07:26 2015 New Revision: 250889 URL: http://llvm.org/viewvc/llvm-project?rev=250889&view=rev Log: Revert "[AST] Put TypeLocs and NestedNameSpecifierLocs into the ParentMap." Putting DynTypedNode in the ParentMap bloats its memory foot print. Before the void* key ha

[PATCH] D13931: [Tooling] Add a utility function to replace one nested name with another.

2015-10-21 Thread Benjamin Kramer via cfe-commits
bkramer created this revision. bkramer added a reviewer: klimek. bkramer added a subscriber: cfe-commits. Herald added a subscriber: klimek. One problem in clang-tidy and other clang tools face is that there is no way to lookup an arbitrary name in the AST, that's buried deep inside Sema and might

r250831 - [AST] Put TypeLocs and NestedNameSpecifierLocs into the ParentMap.

2015-10-20 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Oct 20 10:08:46 2015 New Revision: 250831 URL: http://llvm.org/viewvc/llvm-project?rev=250831&view=rev Log: [AST] Put TypeLocs and NestedNameSpecifierLocs into the ParentMap. Firstly this changes the type of parent map to be keyed on DynTypedNode to simplify the following ch

[PATCH] D13897: [AST] Put TypeLocs and NestedNameSpecifierLocs into the ParentMap.

2015-10-20 Thread Benjamin Kramer via cfe-commits
bkramer created this revision. bkramer added reviewers: klimek, sbenza. bkramer added a subscriber: cfe-commits. Herald added a subscriber: klimek. Firstly this changes the type of parent map to be keyed on DynTypedNode to simplify the following changes. This comes with a DenseMapInfo for DynTyped

Re: [PATCH] D13890: Apply modernize-use-default to clang.

2015-10-20 Thread Benjamin Kramer via cfe-commits
bkramer added a comment. feel free to submit http://reviews.llvm.org/D13890 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13892: Apply modernize-use-default to compiler-rt.

2015-10-20 Thread Benjamin Kramer via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg with comments. Comment at: lib/tsan/rtl/tsan_mutex.cc:130 @@ -129,3 @@ -InternalDeadlockDetector::InternalDeadlockDetector() { - // Rely on zero initialization because s

Re: [PATCH] D13890: Apply modernize-use-default to clang.

2015-10-20 Thread Benjamin Kramer via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Looks good with one comment. Comment at: lib/StaticAnalyzer/Core/MemRegion.cpp:141-143 @@ -140,5 +141,1 @@ -MemRegionManager::~MemRegionManager() { - // All regions and the

Re: r250418 - [CodeGen] Remove dead code. NFC.

2015-10-20 Thread Benjamin Kramer via cfe-commits
PM, Michael Gottesman via cfe-commits >> wrote: >> >> >> On Oct 15, 2015, at 8:29 AM, Benjamin Kramer via cfe-commits >> wrote: >> >> Author: d0k >> Date: Thu Oct 15 10:29:40 2015 >> New Revision: 250418 >> >> URL: http://llvm.org/

r250804 - Revert accidental commit. This isn't ready yet.

2015-10-20 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Oct 20 02:53:14 2015 New Revision: 250804 URL: http://llvm.org/viewvc/llvm-project?rev=250804&view=rev Log: Revert accidental commit. This isn't ready yet. Modified: cfe/trunk/lib/Tooling/Core/CMakeLists.txt cfe/trunk/unittests/Tooling/CMakeLists.txt Modified: cfe/t

r250803 - Put back dead code that's used out-of-tree.

2015-10-20 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Oct 20 02:50:21 2015 New Revision: 250803 URL: http://llvm.org/viewvc/llvm-project?rev=250803&view=rev Log: Put back dead code that's used out-of-tree. Partially reverts r250418. Modified: cfe/trunk/lib/CodeGen/CodeGenABITypes.cpp cfe/trunk/lib/Tooling/Core/CMakeLis

Re: [PATCH] D13810: Replacements in different files do not overlap.

2015-10-16 Thread Benjamin Kramer via cfe-commits
bkramer accepted this revision. bkramer added a reviewer: bkramer. bkramer added a comment. test looks good too, thanks! http://reviews.llvm.org/D13810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

Re: [PATCH] D13810: Replacements in different files do not overlap.

2015-10-16 Thread Benjamin Kramer via cfe-commits
bkramer added a subscriber: bkramer. bkramer added a comment. Is there a way to unittest this? http://reviews.llvm.org/D13810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r250510 - Empty undefined static variable -> local variable.

2015-10-16 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Oct 16 07:11:15 2015 New Revision: 250510 URL: http://llvm.org/viewvc/llvm-project?rev=250510&view=rev Log: Empty undefined static variable -> local variable. Resolves a -Wundefined-internal warning from clang. Modified: clang-tools-extra/trunk/clang-tidy/ClangTidyDiagn

[libcxx] r250508 - Fix an unfortunate yet old typo that never got attention before r250507.

2015-10-16 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Oct 16 06:26:26 2015 New Revision: 250508 URL: http://llvm.org/viewvc/llvm-project?rev=250508&view=rev Log: Fix an unfortunate yet old typo that never got attention before r250507. Should fix the xcode libc++ build. Modified: libcxx/trunk/src/stdexcept.cpp Modified: li

[libcxx] r250507 - Remove a long-standing __has_include hack.

2015-10-16 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Oct 16 06:14:30 2015 New Revision: 250507 URL: http://llvm.org/viewvc/llvm-project?rev=250507&view=rev Log: Remove a long-standing __has_include hack. This was put in to get libc++ building without libcxxabi. We now have macros that show that we are building against libcxxab

Re: r250418 - [CodeGen] Remove dead code. NFC.

2015-10-15 Thread Benjamin Kramer via cfe-commits
On Thu, Oct 15, 2015 at 6:12 PM, Adrian Prantl wrote: > >> On Oct 15, 2015, at 8:29 AM, Benjamin Kramer via cfe-commits >> wrote: >> >> Author: d0k >> Date: Thu Oct 15 10:29:40 2015 >> New Revision: 250418 >> >> URL: http://llvm.org/viewvc/l

r250428 - Put back doxygen comment accidentally dropped in r250418.

2015-10-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Oct 15 11:46:25 2015 New Revision: 250428 URL: http://llvm.org/viewvc/llvm-project?rev=250428&view=rev Log: Put back doxygen comment accidentally dropped in r250418. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.h Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.h URL: http:/

r250418 - [CodeGen] Remove dead code. NFC.

2015-10-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Oct 15 10:29:40 2015 New Revision: 250418 URL: http://llvm.org/viewvc/llvm-project?rev=250418&view=rev Log: [CodeGen] Remove dead code. NFC. Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp cfe/trunk/lib/CodeGen/CGCall.cpp cfe/trunk/lib/CodeGen/CGCleanup.cpp cfe

r250164 - [Driver] Use the parent_path of the clang executable as the default InstalledDir

2015-10-13 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Oct 13 10:19:32 2015 New Revision: 250164 URL: http://llvm.org/viewvc/llvm-project?rev=250164&view=rev Log: [Driver] Use the parent_path of the clang executable as the default InstalledDir This is what most people want anyways. Clang -cc1's main() will override this but for

r250155 - Remove unused diagnostic. NFC.

2015-10-13 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Oct 13 05:10:03 2015 New Revision: 250155 URL: http://llvm.org/viewvc/llvm-project?rev=250155&view=rev Log: Remove unused diagnostic. NFC. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td URL:

r250060 - [VFS] Let the user decide if they want path normalization.

2015-10-12 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Oct 12 11:16:39 2015 New Revision: 250060 URL: http://llvm.org/viewvc/llvm-project?rev=250060&view=rev Log: [VFS] Let the user decide if they want path normalization. This is a more principled version of what I did earlier. Path normalization is generally a good thing, but m

Re: [PATCH] D13658: [VFS] Let the user decide if they want path normalization.

2015-10-12 Thread Benjamin Kramer via cfe-commits
bkramer updated this revision to Diff 37124. bkramer added a comment. Addressed review comments. http://reviews.llvm.org/D13658 Files: include/clang/Basic/VirtualFileSystem.h lib/Basic/VirtualFileSystem.cpp unittests/Basic/VirtualFileSystemTest.cpp Index: unittests/Basic/VirtualFileSyste

[PATCH] D13658: [VFS] Let the user decide if they want path normalization.

2015-10-12 Thread Benjamin Kramer via cfe-commits
bkramer created this revision. bkramer added a reviewer: klimek. bkramer added a subscriber: cfe-commits. This is a more principled version of what I did earlier. Path normalization is generally a good thing, but may break users in strange environments, e. g. using lots of symlinks. Let the user c

r250037 - [VFS] Unbreak test.

2015-10-12 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Oct 12 08:39:33 2015 New Revision: 250037 URL: http://llvm.org/viewvc/llvm-project?rev=250037&view=rev Log: [VFS] Unbreak test. Modified: cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp Modified: cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp URL: http://llvm.

r250036 - [VFS] Don't try to be heroic with '.' in paths.

2015-10-12 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Oct 12 08:30:38 2015 New Revision: 250036 URL: http://llvm.org/viewvc/llvm-project?rev=250036&view=rev Log: [VFS] Don't try to be heroic with '.' in paths. Actually the only special path we have to handle is ./foo, the rest is tricky to get right so do the same thing as the

r250021 - [VFS] remove handling of '..' for now.

2015-10-12 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Oct 12 04:22:07 2015 New Revision: 250021 URL: http://llvm.org/viewvc/llvm-project?rev=250021&view=rev Log: [VFS] remove handling of '..' for now. This can fail badly if we're overlaying a real file system and there are symlinks there. Just keep the path as-is for now. This

r249832 - [VFS] Rename RedirectingFS internals to avoid collisions with public clang classes

2015-10-09 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Oct 9 08:28:13 2015 New Revision: 249832 URL: http://llvm.org/viewvc/llvm-project?rev=249832&view=rev Log: [VFS] Rename RedirectingFS internals to avoid collisions with public clang classes Hopefully fixes the MSVC build. NFC intended. Modified: cfe/trunk/lib/Basic/Vi

r249829 - [VFS] Wire up multilib toolchain code to the VFS.

2015-10-09 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Oct 9 08:03:18 2015 New Revision: 249829 URL: http://llvm.org/viewvc/llvm-project?rev=249829&view=rev Log: [VFS] Wire up multilib toolchain code to the VFS. This lets a VFSified driver actually validate the GCC paths. Modified: cfe/trunk/lib/Driver/ToolChains.cpp c

r249830 - [VFS] Just normalize away .. and . in paths for in-memory file systems.

2015-10-09 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Oct 9 08:03:22 2015 New Revision: 249830 URL: http://llvm.org/viewvc/llvm-project?rev=249830&view=rev Log: [VFS] Just normalize away .. and . in paths for in-memory file systems. This simplifies the code and gets us support for .. for free. Modified: cfe/trunk/include/

r249831 - [VFS] Wire up driver VFS through tooling.

2015-10-09 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Oct 9 08:03:25 2015 New Revision: 249831 URL: http://llvm.org/viewvc/llvm-project?rev=249831&view=rev Log: [VFS] Wire up driver VFS through tooling. Sadly I don't currently have a way to tests this as the driver is always initialized with the default triple and finding syst

r249815 - [VFS] Port tooling to use the in-memory file system.

2015-10-09 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Oct 9 04:54:37 2015 New Revision: 249815 URL: http://llvm.org/viewvc/llvm-project?rev=249815&view=rev Log: [VFS] Port tooling to use the in-memory file system. This means file remappings can now be managed by ClangTool (or a ToolInvocation user) instead of by ToolInvocation

r249693 - [VFS] Use VFS instead of virtual files in PPCallbacks test.

2015-10-08 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Oct 8 09:20:14 2015 New Revision: 249693 URL: http://llvm.org/viewvc/llvm-project?rev=249693&view=rev Log: [VFS] Use VFS instead of virtual files in PPCallbacks test. Modified: cfe/trunk/unittests/Lex/PPCallbacksTest.cpp Modified: cfe/trunk/unittests/Lex/PPCallbacksTes

r249676 - [Driver] Use Twine instead of itostr. NFC.

2015-10-08 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Oct 8 05:31:17 2015 New Revision: 249676 URL: http://llvm.org/viewvc/llvm-project?rev=249676&view=rev Log: [Driver] Use Twine instead of itostr. NFC. No need to construct temporary std::strings here. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Dri

Re: r249556 - [VFS] Port driver tool chains to VFS.

2015-10-07 Thread Benjamin Kramer via cfe-commits
:DiagnosticConsumer::HandleDiagnostic(clang::DiagnosticsEngine::Level, > clang::Diagnostic const&)' > collect2: error: ld returned 1 exit status > > using Diagnostics requires linking to libclangBasic. Please consider the > attached patch. r249608. Thanks! - Ben > > O

r249608 - Fix a shared CMake build by linking with libclangBasic.

2015-10-07 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Oct 7 15:19:25 2015 New Revision: 249608 URL: http://llvm.org/viewvc/llvm-project?rev=249608&view=rev Log: Fix a shared CMake build by linking with libclangBasic. Patch by Jan Vesely! Modified: cfe/trunk/unittests/Driver/CMakeLists.txt Modified: cfe/trunk/unittests/Dr

r249556 - [VFS] Port driver tool chains to VFS.

2015-10-07 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Oct 7 10:48:01 2015 New Revision: 249556 URL: http://llvm.org/viewvc/llvm-project?rev=249556&view=rev Log: [VFS] Port driver tool chains to VFS. There are still some loose ends here but it's sufficient so we can detect GCC headers that are inside of a VFS. Added: cfe/t

r249532 - [VFS] Refactor VFSFromYAML a bit.

2015-10-07 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Oct 7 05:05:44 2015 New Revision: 249532 URL: http://llvm.org/viewvc/llvm-project?rev=249532&view=rev Log: [VFS] Refactor VFSFromYAML a bit. - Rename it to RedirectingFileSystem. This is what it does, YAML is just a serialization format for it. - Consistently use unique_p

[clang-tools-extra] r249526 - [VFS] Switch clang-tidy tests to use an in-memory fs.

2015-10-07 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Oct 7 03:35:23 2015 New Revision: 249526 URL: http://llvm.org/viewvc/llvm-project?rev=249526&view=rev Log: [VFS] Switch clang-tidy tests to use an in-memory fs. Again, this is both cleaner and completely removes any depedency on the host file system. Modified: clang-to

r249525 - [VFS] Also drop '.' when adding files to an in-memory FS.

2015-10-07 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Oct 7 03:32:50 2015 New Revision: 249525 URL: http://llvm.org/viewvc/llvm-project?rev=249525&view=rev Log: [VFS] Also drop '.' when adding files to an in-memory FS. Otherwise we won't be able to find them later. Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp c

Re: [PATCH] D13474: [VFS] Port tooling to use the in-memory file system.

2015-10-06 Thread Benjamin Kramer via cfe-commits
bkramer updated this revision to Diff 36632. bkramer added a comment. - Don't rebuild VFS for every compile command - Still have to guard against multiple runs of one Tool, ClangToolTest.ArgumentAdjusters does that. http://reviews.llvm.org/D13474 Files: include/clang/Tooling/Tooling.h lib/

r249413 - [Tooling] Don't run a tool invocation without a FileManager.

2015-10-06 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Oct 6 10:04:13 2015 New Revision: 249413 URL: http://llvm.org/viewvc/llvm-project?rev=249413&view=rev Log: [Tooling] Don't run a tool invocation without a FileManager. Fixes a crash regression from r249410. Modified: cfe/trunk/lib/Tooling/Tooling.cpp Modified: cfe/tru

[PATCH] D13474: [VFS] Port tooling to use the in-memory file system.

2015-10-06 Thread Benjamin Kramer via cfe-commits
bkramer created this revision. bkramer added a reviewer: klimek. bkramer added a subscriber: cfe-commits. Herald added a subscriber: klimek. This means file remappings can now be managed by ClangTool (or a ToolInvocation user) instead of by ToolInvocation itself. The ToolInvocation remapping is st

r249408 - [Tooling] Remove dead code.

2015-10-06 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Oct 6 09:45:13 2015 New Revision: 249408 URL: http://llvm.org/viewvc/llvm-project?rev=249408&view=rev Log: [Tooling] Remove dead code. It took me some time to figure out why this is not working as expected: std:error_code converts to true if there is an error. This means we

r249409 - [VFS] Put the incoming name in the file status to make InMemoryFS behave more like a real FS.

2015-10-06 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Oct 6 09:45:16 2015 New Revision: 249409 URL: http://llvm.org/viewvc/llvm-project?rev=249409&view=rev Log: [VFS] Put the incoming name in the file status to make InMemoryFS behave more like a real FS. Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp cfe/trunk/un

r249410 - [Tooling] Reuse FileManager in ASTUnit.

2015-10-06 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Oct 6 09:45:20 2015 New Revision: 249410 URL: http://llvm.org/viewvc/llvm-project?rev=249410&view=rev Log: [Tooling] Reuse FileManager in ASTUnit. ASTUnit was creating multiple FileManagers and throwing them away. Reuse the one from Tooling. No functionality change now but

r249389 - [VFS] Port SimpleFormatContext to InMemoryFileSystem.

2015-10-06 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Oct 6 05:23:34 2015 New Revision: 249389 URL: http://llvm.org/viewvc/llvm-project?rev=249389&view=rev Log: [VFS] Port SimpleFormatContext to InMemoryFileSystem. Modified: cfe/trunk/lib/Index/SimpleFormatContext.h Modified: cfe/trunk/lib/Index/SimpleFormatContext.h URL:

r249388 - [VFS] Port applyAllReplacements to InMemoryFileSystem.

2015-10-06 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Oct 6 05:23:17 2015 New Revision: 249388 URL: http://llvm.org/viewvc/llvm-project?rev=249388&view=rev Log: [VFS] Port applyAllReplacements to InMemoryFileSystem. Modified: cfe/trunk/lib/Tooling/Core/Replacement.cpp Modified: cfe/trunk/lib/Tooling/Core/Replacement.cpp U

r249385 - [VFS] Transition clang-format to use an in-memory FS.

2015-10-06 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Oct 6 05:04:08 2015 New Revision: 249385 URL: http://llvm.org/viewvc/llvm-project?rev=249385&view=rev Log: [VFS] Transition clang-format to use an in-memory FS. Apart from being cleaner this also means that clang-format no longer has access to the host file system. This isn

Re: r249314 - [VFS] Move class out of method so it looks less like Java.

2015-10-05 Thread Benjamin Kramer via cfe-commits
On Mon, Oct 5, 2015 at 11:13 PM, Richard Smith wrote: > On Mon, Oct 5, 2015 at 6:55 AM, Benjamin Kramer via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: d0k >> Date: Mon Oct 5 08:55:09 2015 >> New Revision: 249314 >> >> URL: http:/

r249355 - Remove duplicated default arguments. NFC.

2015-10-05 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Oct 5 16:20:19 2015 New Revision: 249355 URL: http://llvm.org/viewvc/llvm-project?rev=249355&view=rev Log: Remove duplicated default arguments. NFC. Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp URL: http://llv

r249319 - [VFS] Fix the windows build by including the right headers.

2015-10-05 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Oct 5 09:06:36 2015 New Revision: 249319 URL: http://llvm.org/viewvc/llvm-project?rev=249319&view=rev Log: [VFS] Fix the windows build by including the right headers. Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cp

<    4   5   6   7   8   9   10   >