[PATCH] D157251: [X86][regcall] Do not produce @ number suffix if it is regcall4

2023-08-08 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 548479. yubing added a comment. small fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157251/new/ https://reviews.llvm.org/D157251 Files: clang/lib/AST/Mangle.cpp clang/test/CodeGen/mangle-windows-regcall

[PATCH] D157251: [X86][regcall] Do not produce @ number suffix if it is regcall4

2023-08-08 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 548478. yubing added a comment. small fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157251/new/ https://reviews.llvm.org/D157251 Files: clang/lib/AST/Mangle.cpp clang/test/CodeGen/mangle-windows-regcall

[PATCH] D157251: [X86][regcall] Do not produce @ number suffix if it is regcall4

2023-08-08 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 548477. yubing added a comment. Herald added a subscriber: mstorsjo. add testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157251/new/ https://reviews.llvm.org/D157251 Files: clang/lib/AST/Mangle.cpp c

[PATCH] D157251: [X86][regcall] Do not produce @ number suffix if it is regcall4

2023-08-06 Thread Bing Yu via Phabricator via cfe-commits
yubing created this revision. Herald added a project: All. yubing requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D157251 Files: clang/lib/AST/Mangle.cpp Index: clang/lib/

cfe-commits@lists.llvm.org

2023-08-02 Thread Bing Yu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6ee497aa0b48: [X86][Regcall] Add an option to respect regcall ABI v.4 in win64&win32 (authored by yubing). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1558

cfe-commits@lists.llvm.org

2023-07-31 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 545927. yubing added a comment. update testcase due to w=>x Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155863/new/ https://reviews.llvm.org/D155863 Files: clang/include/clang/Basic/LangOptions.def clang/

cfe-commits@lists.llvm.org

2023-07-31 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 545924. yubing added a comment. address c++ windows's mangling prefix w=>x Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155863/new/ https://reviews.llvm.org/D155863 Files: clang/include/clang/Basic/LangOptio

cfe-commits@lists.llvm.org

2023-07-24 Thread Bing Yu via Phabricator via cfe-commits
yubing added inline comments. Comment at: llvm/lib/Target/X86/X86CallingConv.td:98-103 +def RC_X86_64_RegCallv4_Win : RC_X86_64_RegCall { + let GPR_8 = [AL, CL, DL, DIL, SIL, R8B, R9B, R11B, R12B, R14B, R15B]; + let GPR_16 = [AX, CX, DX, DI, SI, R8W, R9W, R11W, R12W, R14W, R15W

cfe-commits@lists.llvm.org

2023-07-24 Thread Bing Yu via Phabricator via cfe-commits
yubing added inline comments. Comment at: llvm/lib/Target/X86/X86CallingConv.td:98-103 +def RC_X86_64_RegCallv4_Win : RC_X86_64_RegCall { + let GPR_8 = [AL, CL, DL, DIL, SIL, R8B, R9B, R11B, R12B, R14B, R15B]; + let GPR_16 = [AX, CX, DX, DI, SI, R8W, R9W, R11W, R12W, R14W, R15W

cfe-commits@lists.llvm.org

2023-07-24 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 543437. yubing added a comment. small fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155863/new/ https://reviews.llvm.org/D155863 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/Driv

cfe-commits@lists.llvm.org

2023-07-24 Thread Bing Yu via Phabricator via cfe-commits
yubing added inline comments. Comment at: llvm/lib/Target/X86/X86CallingConv.td:468 +defm X86_32_RegCallv4_Win : +X86_RegCall_base; defm X86_Win64_RegCall : pengfei wrote: > This will define RetCC_* as well but it is not used, hence will emit warning. >

cfe-commits@lists.llvm.org

2023-07-24 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 543433. yubing added a comment. make retcc respect regcall ABI v.4 as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155863/new/ https://reviews.llvm.org/D155863 Files: clang/include/clang/Basic/LangOptio

cfe-commits@lists.llvm.org

2023-07-20 Thread Bing Yu via Phabricator via cfe-commits
yubing added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155863/new/ https://reviews.llvm.org/D155863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

cfe-commits@lists.llvm.org

2023-07-20 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 542575. yubing added a comment. small fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155863/new/ https://reviews.llvm.org/D155863 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/Driv

cfe-commits@lists.llvm.org

2023-07-20 Thread Bing Yu via Phabricator via cfe-commits
yubing created this revision. Herald added subscribers: pengfei, hiraditya. Herald added a project: All. yubing requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo https://review

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

2022-08-23 Thread Bing Yu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6d8ddf53cc80: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit (authored by yubing). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

2022-08-23 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 455041. yubing added a comment. address sign-conversion issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132141/new/ https://reviews.llvm.org/D132141 Files: clang/lib/Headers/immintrin.h clang/test/CodeG

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

2022-08-23 Thread Bing Yu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG07e34763b027: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit (authored by yubing). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

2022-08-23 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 454738. yubing added a comment. Execute the second rdrand32 despite of whether the first one fail or not Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132141/new/ https://reviews.llvm.org/D132141 Files: clang

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

2022-08-22 Thread Bing Yu via Phabricator via cfe-commits
yubing added inline comments. Comment at: clang/lib/Headers/immintrin.h:301 + unsigned long long tmp; + if (__builtin_ia32_rdrand32_step((unsigned int *)&tmp) & + __builtin_ia32_rdrand32_step(((unsigned int *)&tmp) + 1)) { RKSimon wrote: > RKSimon wrote: >

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

2022-08-21 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 454357. yubing added a comment. address craig's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132141/new/ https://reviews.llvm.org/D132141 Files: clang/lib/Headers/immintrin.h clang/test/CodeGen/X8

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

2022-08-21 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 454356. yubing added a comment. address simon's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132141/new/ https://reviews.llvm.org/D132141 Files: clang/lib/Headers/immintrin.h clang/test/CodeGen/X8

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

2022-08-18 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 453866. yubing added a comment. fix a small issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132141/new/ https://reviews.llvm.org/D132141 Files: clang/lib/Headers/immintrin.h clang/test/CodeGen/X86/rdran

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

2022-08-18 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 453865. yubing added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132141/new/ https://reviews.llvm.org/D132141 Files: clang/lib/Headers/immintrin.h clang/test/CodeGen/X86/rdrand

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

2022-08-18 Thread Bing Yu via Phabricator via cfe-commits
yubing created this revision. Herald added a subscriber: pengfei. Herald added a project: All. yubing requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D132141 Files: clang/li

[PATCH] D115630: [CodeGen] Require use of Address::invalid() for invalid address

2021-12-14 Thread Bing Yu via Phabricator via cfe-commits
yubing added inline comments. Comment at: clang/lib/CodeGen/Address.h:79 class ConstantAddress : public Address { + ConstantAddress(nullptr_t) : Address(nullptr) {} + Has anyone encountered buildfail due to missing "std" before nullptr_t? Repository: rG LLV

[PATCH] D87981: [X86] AMX programming model.

2021-06-15 Thread Bing Yu via Phabricator via cfe-commits
yubing added inline comments. Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:4675 } +case Intrinsic::x86_tilestored64_internal: { + unsigned Opc = X86::PTILESTOREDV; It seems there should be a check here, according to line4575: ``` if (!Subtar

[PATCH] D103784: [X86] Support __tile_stream_loadd intrinsic for new AMX interface

2021-06-11 Thread Bing Yu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56d5c46b494d: [X86] Support __tile_stream_loadd intrinsic for new AMX interface (authored by yubing). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D103784: [X86] Support __tile_stream_loadd intrinsic for new AMX interface

2021-06-09 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 350803. yubing added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103784/new/ https://reviews.llvm.org/D103784 Files: clang/include/clang/Basic/BuiltinsX86_64.def clang/lib/Headers/amxint

[PATCH] D103784: [X86] Support __tile_stream_loadd intrinsic for new AMX interface

2021-06-09 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 350797. yubing added a comment. Address yuanke's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103784/new/ https://reviews.llvm.org/D103784 Files: clang/include/clang/Basic/BuiltinsX86_64.def clang

[PATCH] D103784: [X86] Support __tile_stream_loadd intrinsic for new AMX interface

2021-06-06 Thread Bing Yu via Phabricator via cfe-commits
yubing created this revision. Herald added subscribers: pengfei, hiraditya. yubing requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Adding support for __tile_stream_loadd intrinsic. Repository: rG LLVM Github Monorepo

[PATCH] D96110: [X86] Pass to transform tdpbf16ps intrinsics to scalar operation.

2021-03-21 Thread Bing Yu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG113f077f808f: [X86] Pass to transform tdpbf16ps intrinsics to scalar operation. (authored by yubing). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96110/new

[PATCH] D96110: [X86] Pass to transform tdpbf16ps intrinsics to scalar operation.

2021-03-21 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 332190. yubing added a comment. Rebase after https://reviews.llvm.org/D98773 is merged. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96110/new/ https://reviews.llvm.org/D96110 Files: llvm/lib/Target/X86/X86L

[PATCH] D96110: [X86] Pass to transform tdpbf16ps intrinsics to scalar operation.

2021-03-18 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 331766. yubing added a comment. address Pengfei's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96110/new/ https://reviews.llvm.org/D96110 Files: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp llvm/

[PATCH] D96110: [X86] Pass to transform tdpbf16ps intrinsics to scalar operation.

2021-03-18 Thread Bing Yu via Phabricator via cfe-commits
yubing added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:318-319 +// calculate idxa, idxb, idxc +// %eltc = extractelement <256 x i32> %vec.c.inner.phi, i16 %idxc +// %eltcf32 = bitcast i32 %eltc to float +// %elta = extractelement <

[PATCH] D87981: [X86] AMX programming model.

2021-03-18 Thread Bing Yu via Phabricator via cfe-commits
yubing added inline comments. Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:90 +INITIALIZE_PASS_BEGIN(X86PreTileConfig, "tilepreconfig", + "Tile Register Configure", false, false) +INITIALIZE_PASS_DEPENDENCY(MachineDominatorTree) It sh

[PATCH] D98685: [X86][AMX] Rename amx-bf16 intrinsic according to correct naming convention

2021-03-16 Thread Bing Yu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG320b72e9cd77: [X86][AMX] Rename amx-bf16 intrinsic according to correct naming convention (authored by yubing). Repository: rG LLVM Github Monorep

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

2021-03-16 Thread Bing Yu via Phabricator via cfe-commits
yubing added a comment. In D93594#2628497 , @nikic wrote: > It looks like this has caused a compile-time regression at `O0`: > https://llvm-compile-time-tracker.com/compare.php?from=9341bcbdc93a251b632ffaa51a84452a7a4a5e4e&to=4f198b0c27b04e830a3069aaf4b39

[PATCH] D96110: [X86] Pass to transform tdpbf16ps intrinsics to scalar operation.

2021-03-16 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 330898. yubing added a comment. just do a rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96110/new/ https://reviews.llvm.org/D96110 Files: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp llvm/test/CodeG

[PATCH] D98685: [X86][AMX] Rename amx-bf16 intrinsic according to correct naming convention __tile_tdpbf16ps should be renamed with __tile_dpbf16ps

2021-03-16 Thread Bing Yu via Phabricator via cfe-commits
yubing created this revision. Herald added a subscriber: pengfei. yubing requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D98685 Files: clang/lib/Headers/amxintrin.h clang/

[PATCH] D97358: [X86] Support amx-bf16 intrinsic.

2021-03-16 Thread Bing Yu via Phabricator via cfe-commits
yubing added inline comments. Comment at: clang/lib/Headers/amxintrin.h:326 +__DEFAULT_FN_ATTRS_BF16 +static void __tile_tdpbf16ps(__tile1024i *dst, __tile1024i src1, + __tile1024i src2) { Should we align this with "tile_dpbssd" by ren

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

2021-03-15 Thread Bing Yu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4f198b0c27b0: [X86] Pass to transform amx intrinsics to scalar operation. (authored by yubing). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

2021-03-08 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 329204. yubing added a comment. Fix buildfail when it is -DBUILD_SHARED_LIBS=ON Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93594/new/ https://reviews.llvm.org/D93594 Files: llvm/include/llvm/CodeGen/Passes

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

2021-03-08 Thread Bing Yu via Phabricator via cfe-commits
yubing added a comment. In D93594#2606157 , @RKSimon wrote: > @yubing I've reverted this as it was failing on a lot of buildbots: > http://lab.llvm.org:8011/#/builders/109/builds/9867 Hi, @RKSimon @nicolasvasilache , it seems we haven't told libLLVMX86C

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

2021-03-06 Thread Bing Yu via Phabricator via cfe-commits
yubing added a comment. Thanks all for reporting and reverting this. I will do bugfix asap. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93594/new/ https://reviews.llvm.org/D93594 ___ cfe-commits mailin

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

2021-03-05 Thread Bing Yu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8198d83965ba: [X86] Pass to transform amx intrinsics to scalar operation. (authored by LuoYuanke, committed by yubing). Changed prior to commit: h

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

2021-03-04 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 328408. yubing added a comment. Address pengfei's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93594/new/ https://reviews.llvm.org/D93594 Files: llvm/include/llvm/CodeGen/Passes.h llvm/lib/Target/

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

2021-03-02 Thread Bing Yu via Phabricator via cfe-commits
yubing added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:311 + Value *ResElt = B.CreateAdd(EltC, SubVecR); + Value *NewVecC = B.CreateInsertElement(VecCPhi, ResElt, IdxC); + Value *NewVecD = B.CreateInsertElement(VecDPhi, ResElt, IdxC); -

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

2021-03-01 Thread Bing Yu via Phabricator via cfe-commits
yubing marked 15 inline comments as done. yubing added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:311 + Value *ResElt = B.CreateAdd(EltC, SubVecR); + Value *NewVecC = B.CreateInsertElement(VecCPhi, ResElt, IdxC); + Value *NewVecD = B.CreateInser

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

2021-03-01 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 327362. yubing edited the summary of this revision. yubing added a comment. address comments above Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93594/new/ https://reviews.llvm.org/D93594 Files: llvm/include/

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

2021-02-28 Thread Bing Yu via Phabricator via cfe-commits
yubing added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:99 + Loop *RowLoop = LI.AllocateLoop(); + Loop *ColLoop = LI.AllocateLoop(); + RowLoop->addChildLoop(ColLoop); pengfei wrote: > Not sure how about the arithmetic intrinsics

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

2021-02-24 Thread Bing Yu via Phabricator via cfe-commits
yubing added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:311 + Value *ResElt = B.CreateAdd(EltC, SubVecR); + Value *NewVecC = B.CreateInsertElement(VecCPhi, ResElt, IdxC); + Value *NewVecD = B.CreateInsertElement(VecDPhi, ResElt, IdxC); -

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

2021-02-23 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 325964. yubing added a comment. Fix some comments and commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93594/new/ https://reviews.llvm.org/D93594 Files: llvm/include/llvm/CodeGen/Passes.h llvm/l

[PATCH] D96110: [X86] Pass to transform tdpbf16ps intrinsics to scalar operation.

2021-02-22 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 325688. yubing added a comment. Modify some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96110/new/ https://reviews.llvm.org/D96110 Files: clang/include/clang/Basic/BuiltinsX86_64.def clang/lib/He

[PATCH] D96110: [X86] Pass to transform tdpbf16ps intrinsics to scalar operation.

2021-02-22 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 325685. yubing added a comment. Fix incorrect naming for dpbf16's bb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96110/new/ https://reviews.llvm.org/D96110 Files: clang/include/clang/Basic/BuiltinsX86_64.de

[PATCH] D96110: [X86] Pass to transform tdpbf16ps intrinsics to scalar operation.

2021-02-22 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 325683. yubing added a comment. Rebase and add a testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96110/new/ https://reviews.llvm.org/D96110 Files: clang/include/clang/Basic/BuiltinsX86_64.def clang/

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

2021-02-22 Thread Bing Yu via Phabricator via cfe-commits
yubing marked 13 inline comments as done. yubing added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:487 + SmallVector WorkList; + for (BasicBlock *BB : depth_first(&Func)) { +for (BasicBlock::iterator II = BB->begin(), IE = BB->end(); II != IE;

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

2021-02-22 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 325670. yubing added a comment. Address comments above Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93594/new/ https://reviews.llvm.org/D93594 Files: llvm/include/llvm/CodeGen/Passes.h llvm/lib/Target/X86/

[PATCH] D96110: [X86] Pass to transform tdpbf16ps intrinsics to scalar operation.

2021-02-20 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 325170. yubing edited the summary of this revision. yubing added a comment. Address comments above and refactor some code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96110/new/ https://reviews.llvm.org/D96110

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

2021-02-19 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 325155. yubing marked 5 inline comments as done. yubing added a comment. Small fix for some code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93594/new/ https://reviews.llvm.org/D93594 Files: llvm/include/ll

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

2021-02-19 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 325152. yubing added a comment. Address the commments above. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93594/new/ https://reviews.llvm.org/D93594 Files: llvm/include/llvm/CodeGen/Passes.h llvm/lib/Targe

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

2021-02-19 Thread Bing Yu via Phabricator via cfe-commits
yubing added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:211-212 +IRBuilderBase &B, DomTreeUpdater &DTU, +LoopInfo &LI, Value *Row, Value *Col, +

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

2021-02-08 Thread Bing Yu via Phabricator via cfe-commits
yubing added inline comments. Comment at: llvm/test/CodeGen/X86/AMX/amx-low-intrinsics.ll:77 +; CHECK-NEXT:[[TILEDPBSSD_UNROLL_ROWS_IV:%.*]] = phi i16 [ 0, [[ENTRY:%.*]] ], [ [[TILEDPBSSD_UNROLL_ROWS_STEP:%.*]], [[TILEDPBSSD_UNROLL_ROWS_LATCH:%.*]] ] +; CHECK-NEXT:[[VEC

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

2021-02-05 Thread Bing Yu via Phabricator via cfe-commits
yubing added a comment. Strange. llvm/test/CodeGen/X86/AMX/amx-low-intrinsics.ll can pass in my local machine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93594/new/ https://reviews.llvm.org/D93594 __

[PATCH] D96110: [X86] Pass to transform tdpbf16ps intrinsics to scalar operation.

2021-02-05 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 321675. yubing added a comment. Rebase and add a testcase for dpbf16ps intrinsic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96110/new/ https://reviews.llvm.org/D96110 Files: clang/include/clang/Basic/Buil

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

2021-02-05 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 321673. yubing added a comment. Rebase and fix the bug in amx_api.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93594/new/ https://reviews.llvm.org/D93594 Files: llvm/include/llvm/CodeGen/Passes.h llvm/li

[PATCH] D96110: [X86] Pass to transform tdpbf16ps intrinsics to scalar operation.

2021-02-04 Thread Bing Yu via Phabricator via cfe-commits
yubing created this revision. Herald added subscribers: pengfei, hiraditya. yubing requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96110 Files: clang/incl

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

2021-01-28 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 319797. yubing added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix some bugs in lowerTileDPBSSD, lowerTileStore, lowerTileLoad Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D86668: Fix Calling Convention of __float128 and long double(128bits) in i386

2020-08-27 Thread Bing Yu via Phabricator via cfe-commits
yubing updated this revision to Diff 288218. yubing added a comment. Modify a testcase: clang/test/CodeGenCXX/float128-declarations.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86668/new/ https://reviews.llvm.org/D86668 Files: clang/lib/Cod

[PATCH] D86668: Fix Calling Convention of __float128 and long double(128bits) in i386

2020-08-26 Thread Bing Yu via Phabricator via cfe-commits
yubing created this revision. yubing added reviewers: craig.topper, LuoYuanke, LiuChen3. Herald added a project: clang. Herald added a subscriber: cfe-commits. yubing requested review of this revision. This patch make __float128/long double(128bits) passed on the stack with 16-byte alignment, ac