[PATCH] D128406: clang: Tweak behaviour of warn_empty_while_body and warn_empty_if_body

bmoody added a comment. I don't have merge access so please merge on my behalf :) Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128406/new/ https://reviews.llvm.org/D128406 ___ cfe-commits

[PATCH] D128406: clang: Tweak behaviour of warn_empty_while_body and warn_empty_if_body

bmoody created this revision. bmoody added reviewers: rnk, gribozavr. Herald added a project: All. bmoody requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use the if/while statement right paren location instead of the end of the condition

[PATCH] D65913: Fix segfault caused by the "libstdc++ eager exception spec hack"

bmoody created this revision. bmoody added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Segfault occurs when the hack is applied to a function decl containing an unparsed default argument. Parser::HandleMemberFunctionDeclDelays was assuming that if a

[PATCH] D60997: Fix unquoted spaces in args in clang --verbose output

bmoody added a comment. I don't have commit access, so you are welcome to commit on my behalf. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60997/new/ https://reviews.llvm.org/D60997 ___ cfe-commits

[PATCH] D60997: Fix unquoted spaces in args in clang --verbose output

bmoody created this revision. bmoody added a reviewer: hans. Herald added a project: clang. Herald added a subscriber: cfe-commits. The behaviour of not quoting spaces appears to have been introduced by mistake in revision b212b34f19472469c1d20ada3161c3523268d5be

[PATCH] D57072: Don't codegen an unreachable return block

bmoody added a comment. Herald added a subscriber: jdoerfert. Herald added a project: clang. Ping! Any chance you could commit this on my behalf? Otherwise I can try the mailing list. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57072/new/

[PATCH] D57072: Don't codegen an unreachable return block

bmoody added a comment. Great, I don't have commit access so you're welcome to commit on my behalf. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57072/new/ https://reviews.llvm.org/D57072 ___ cfe-commits

[PATCH] D57072: Don't codegen an unreachable return block

bmoody created this revision. bmoody added reviewers: craig.topper, dberris, rjmccall. Herald added a subscriber: cfe-commits. This patch adds a check at the end of CodeGenFunction::FinishFunction to delete the return block if it isn't reachable. Without this patch applied the code generated

[PATCH] D52855: Fix source loc for tokens that immediately follow an escaped newline

bmoody created this revision. bmoody added a reviewer: rsmith. Herald added a subscriber: cfe-commits. Previously the location of a token immediately following an escaped newline was the location of the backslash character in the escaped newline. The change to