[clang] 627e01f - [coroutines] Don't build promise init with no args

2020-04-02 Thread Brian Gesiak via cfe-commits
Author: Brian Gesiak Date: 2020-04-02T21:44:54-04:00 New Revision: 627e01feb718dd1aa8e184545976b7229de312a2 URL: https://github.com/llvm/llvm-project/commit/627e01feb718dd1aa8e184545976b7229de312a2 DIFF: https://github.com/llvm/llvm-project/commit/627e01feb718dd1aa8e184545976b7229de312a2.diff

[clang] 048239e - [Coroutines][6/6] Clang schedules new passes

2020-02-18 Thread Brian Gesiak via cfe-commits
Author: Brian Gesiak Date: 2020-02-19T01:03:28-05:00 New Revision: 048239e46e490d441f21f3e26073ec38f19e8a10 URL: https://github.com/llvm/llvm-project/commit/048239e46e490d441f21f3e26073ec38f19e8a10 DIFF: https://github.com/llvm/llvm-project/commit/048239e46e490d441f21f3e26073ec38f19e8a10.diff

[clang] 376cf43 - [coroutines][PR41909] Generalize fix from D62550

2019-12-16 Thread Brian Gesiak via cfe-commits
Author: Brian Gesiak Date: 2019-12-16T17:43:04-05:00 New Revision: 376cf43729c8025eecbd2969522c5687f2a3919f URL: https://github.com/llvm/llvm-project/commit/376cf43729c8025eecbd2969522c5687f2a3919f DIFF: https://github.com/llvm/llvm-project/commit/376cf43729c8025eecbd2969522c5687f2a3919f.diff

[clang] 8682d29 - [Format] Add format check for coroutine keywords with negative numbers

2019-11-30 Thread Brian Gesiak via cfe-commits
Author: Brian Gesiak Date: 2019-11-30T15:47:58-05:00 New Revision: 8682d29a28772bab0283a141b8701bfaea8881a6 URL: https://github.com/llvm/llvm-project/commit/8682d29a28772bab0283a141b8701bfaea8881a6 DIFF: https://github.com/llvm/llvm-project/commit/8682d29a28772bab0283a141b8701bfaea8881a6.diff

[clang] 0b3d1d1 - [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

2019-11-22 Thread Brian Gesiak via cfe-commits
Author: Brian Gesiak Date: 2019-11-22T11:39:13-05:00 New Revision: 0b3d1d1348da78c8b12e89f138577b0a8ffd4b2f URL: https://github.com/llvm/llvm-project/commit/0b3d1d1348da78c8b12e89f138577b0a8ffd4b2f DIFF: https://github.com/llvm/llvm-project/commit/0b3d1d1348da78c8b12e89f138577b0a8ffd4b2f.diff

r375258 - [Format] Add format check for throwing negative numbers

2019-10-18 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Fri Oct 18 09:59:02 2019 New Revision: 375258 URL: http://llvm.org/viewvc/llvm-project?rev=375258&view=rev Log: [Format] Add format check for throwing negative numbers Summary: The code `throw -1;` is currently formatted by clang-format as `throw - 1;`. This diff adds a fi

r368675 - [CodeGen] Disable UBSan for coroutine functions

2019-08-13 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Tue Aug 13 05:02:25 2019 New Revision: 368675 URL: http://llvm.org/viewvc/llvm-project?rev=368675&view=rev Log: [CodeGen] Disable UBSan for coroutine functions Summary: As explained in http://lists.llvm.org/pipermail/llvm-dev/2018-March/121924.html, the LLVM coroutines tra

r362348 - [coroutines][PR41909] Don't build dependent coroutine statements for generic lambda

2019-06-02 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Sun Jun 2 17:47:32 2019 New Revision: 362348 URL: http://llvm.org/viewvc/llvm-project?rev=362348&view=rev Log: [coroutines][PR41909] Don't build dependent coroutine statements for generic lambda Summary: https://bugs.llvm.org/show_bug.cgi?id=41909 describes an issue in w

r356865 - Un-revert "[coroutines][PR40978] Emit error for co_yield within catch block"

2019-03-24 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Sun Mar 24 17:53:10 2019 New Revision: 356865 URL: http://llvm.org/viewvc/llvm-project?rev=356865&view=rev Log: Un-revert "[coroutines][PR40978] Emit error for co_yield within catch block" Summary: https://reviews.llvm.org/D59076 added a new coroutine error that prevented

r356774 - Revert "[coroutines][PR40978] Emit error for co_yield within catch block"

2019-03-22 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Fri Mar 22 09:08:29 2019 New Revision: 356774 URL: http://llvm.org/viewvc/llvm-project?rev=356774&view=rev Log: Revert "[coroutines][PR40978] Emit error for co_yield within catch block" The commit https://reviews.llvm.org/rC356296 is causing a regression in nested catch sc

r356296 - [coroutines][PR40978] Emit error for co_yield within catch block

2019-03-15 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Fri Mar 15 13:25:49 2019 New Revision: 356296 URL: http://llvm.org/viewvc/llvm-project?rev=356296&view=rev Log: [coroutines][PR40978] Emit error for co_yield within catch block Summary: As reported in https://bugs.llvm.org/show_bug.cgi?id=40978, it's an error to use the `c

r352831 - [SemaCXX] Param diagnostic matches overload logic

2019-01-31 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Thu Jan 31 19:30:29 2019 New Revision: 352831 URL: http://llvm.org/viewvc/llvm-project?rev=352831&view=rev Log: [SemaCXX] Param diagnostic matches overload logic Summary: Given the following test program: ``` class C { public: int A(int a, int& b); }; int C::A(const in

[clang-tools-extra] r350916 - Adapt to CXXMethodDecl::getThisType change (NFC)

2019-01-10 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Thu Jan 10 18:12:31 2019 New Revision: 350916 URL: http://llvm.org/viewvc/llvm-project?rev=350916&view=rev Log: Adapt to CXXMethodDecl::getThisType change (NFC) Summary: https://reviews.llvm.org/D56509 changed the API of the CXXMethodDecl::getThisType method. Adapt to the

r350914 - [AST] Remove ASTContext from getThisType (NFC)

2019-01-10 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Thu Jan 10 17:54:53 2019 New Revision: 350914 URL: http://llvm.org/viewvc/llvm-project?rev=350914&view=rev Log: [AST] Remove ASTContext from getThisType (NFC) Summary: https://reviews.llvm.org/D54862 removed the usages of `ASTContext&` from within the `CXXMethodDecl::getTh

r350501 - [SemaCXX] Fix ICE for unexpanded parameter pack

2019-01-06 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Sun Jan 6 19:25:59 2019 New Revision: 350501 URL: http://llvm.org/viewvc/llvm-project?rev=350501&view=rev Log: [SemaCXX] Fix ICE for unexpanded parameter pack Summary: The documentation for RecursiveASTVisitor::TraverseDecl states that the Decl being traversed may be null

r346074 - [coroutines] Fix fallthrough warning on try/catch

2018-11-03 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Sat Nov 3 15:35:17 2018 New Revision: 346074 URL: http://llvm.org/viewvc/llvm-project?rev=346074&view=rev Log: [coroutines] Fix fallthrough warning on try/catch Summary: The test case added in this diff would incorrectly warn that control flow may fall through without ret

r343949 - [coro]Pass rvalue reference for named local variable to return_value

2018-10-07 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Sun Oct 7 20:08:39 2018 New Revision: 343949 URL: http://llvm.org/viewvc/llvm-project?rev=343949&view=rev Log: [coro]Pass rvalue reference for named local variable to return_value Summary: Addressing https://bugs.llvm.org/show_bug.cgi?id=37265. Implements [class.copy]/33

r341327 - Removing -debug-info-macros from option suggestions test

2018-09-03 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Mon Sep 3 09:55:02 2018 New Revision: 341327 URL: http://llvm.org/viewvc/llvm-project?rev=341327&view=rev Log: Removing -debug-info-macros from option suggestions test Summary: https://reviews.llvm.org/D46776 added better support for prefixes for the "did you mean ...?" c

r337103 - Add caching when looking up coroutine_traits

2018-07-14 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Sat Jul 14 11:21:44 2018 New Revision: 337103 URL: http://llvm.org/viewvc/llvm-project?rev=337103&view=rev Log: Add caching when looking up coroutine_traits Summary: Currently clang looks up the coroutine_traits ClassTemplateDecl everytime it looks up the promise type. Thi

r336750 - [SemaCXX] Remove comment from coroutines test, NFC

2018-07-10 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Tue Jul 10 18:00:53 2018 New Revision: 336750 URL: http://llvm.org/viewvc/llvm-project?rev=336750&view=rev Log: [SemaCXX] Remove comment from coroutines test, NFC Summary: The file name was accidentally included when the test file was added. Test Plan: check-clang Modif

r336748 - Remove qualtype qualifier in coroutine error to prevent assert in debug

2018-07-10 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Tue Jul 10 17:45:48 2018 New Revision: 336748 URL: http://llvm.org/viewvc/llvm-project?rev=336748&view=rev Log: Remove qualtype qualifier in coroutine error to prevent assert in debug Summary: A forward-declared coroutine_traits should trip an error; we need a complete typ

r335655 - [AST] Fix typo in LazyOffsetPtr::get docs (NFC)

2018-06-26 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Tue Jun 26 13:05:18 2018 New Revision: 335655 URL: http://llvm.org/viewvc/llvm-project?rev=335655&view=rev Log: [AST] Fix typo in LazyOffsetPtr::get docs (NFC) Modified: cfe/trunk/include/clang/AST/ExternalASTSource.h Modified: cfe/trunk/include/clang/AST/ExternalAST

r335422 - [Coroutines] Less IR for noexcept await_resume

2018-06-23 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Sat Jun 23 11:57:26 2018 New Revision: 335422 URL: http://llvm.org/viewvc/llvm-project?rev=335422&view=rev Log: [Coroutines] Less IR for noexcept await_resume Summary: In his review of https://reviews.llvm.org/D45860, @GorNishanov suggested avoiding generating additional e

r335420 - [Sema] isValidCoroutineContext FIXME and citations

2018-06-23 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Sat Jun 23 11:01:02 2018 New Revision: 335420 URL: http://llvm.org/viewvc/llvm-project?rev=335420&view=rev Log: [Sema] isValidCoroutineContext FIXME and citations Summary: Add citations to the Coroutines TS to the `isValidCoroutineContext` function, as well as a FIXME and

r332806 - [Driver] Temporarily remove test for LLVM findNearest

2018-05-19 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Sat May 19 05:44:02 2018 New Revision: 332806 URL: http://llvm.org/viewvc/llvm-project?rev=332806&view=rev Log: [Driver] Temporarily remove test for LLVM findNearest Summary: This fixes a failure caused by the revert of https://reviews.llvm.org/rL332805. Modified: cf

r332804 - [Driver] Loosen test for LLVM findNearest

2018-05-19 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Sat May 19 04:46:58 2018 New Revision: 332804 URL: http://llvm.org/viewvc/llvm-project?rev=332804&view=rev Log: [Driver] Loosen test for LLVM findNearest Summary: When https://reviews.llvm.org/D46776 landed to improve the behavior of `llvm::OptTable::findNearest`, a PS4 bu

r331519 - [Coroutines] Catch exceptions in await_resume

2018-05-04 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Fri May 4 07:02:37 2018 New Revision: 331519 URL: http://llvm.org/viewvc/llvm-project?rev=331519&view=rev Log: [Coroutines] Catch exceptions in await_resume Summary: http://wg21.link/P0664r2 section "Evolution/Core Issues 24" describes a proposed change to Coroutines TS t

r330530 - Add tests for llvm-bcanalyzer stream types

2018-04-21 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Sat Apr 21 17:04:35 2018 New Revision: 330530 URL: http://llvm.org/viewvc/llvm-project?rev=330530&view=rev Log: Add tests for llvm-bcanalyzer stream types Summary: Add tests for the improved stream type detection added to `llvm-bcanalyzer` in https://reviews.llvm.org/D4197

r328951 - [Coroutines] Schedule coro-split before asan

2018-04-01 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Sun Apr 1 16:55:21 2018 New Revision: 328951 URL: http://llvm.org/viewvc/llvm-project?rev=328951&view=rev Log: [Coroutines] Schedule coro-split before asan Summary: The docs for the LLVM coroutines intrinsic `@llvm.coro.id` state that "The second argument, if not null, de

r328949 - [Coroutines] Find custom allocators in class scope

2018-04-01 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Sun Apr 1 15:59:22 2018 New Revision: 328949 URL: http://llvm.org/viewvc/llvm-project?rev=328949&view=rev Log: [Coroutines] Find custom allocators in class scope Summary: https://reviews.llvm.org/rL325291 implemented Coroutines TS N4723 section [dcl.fct.def.coroutine]/7,

Re: r325291 - [Coroutines] Use allocator overload when available

2018-02-16 Thread Brian Gesiak via cfe-commits
emaCXX/coroutines.cpp Line 816 (directive at >>> /home/buildslave/buildslave/clang-cmake-armv7-a15/llvm/tools >>> /clang/test/SemaCXX/coroutines.cpp:815): candidate function not viable: >>> requires 2 arguments, but 1 was provided >>> File /home/buildslave/buil

r325342 - [Coroutines] Use target-agnostic size_t in test

2018-02-16 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Fri Feb 16 06:11:27 2018 New Revision: 325342 URL: http://llvm.org/viewvc/llvm-project?rev=325342&view=rev Log: [Coroutines] Use target-agnostic size_t in test Summary: Fix a test failure on ARM hosts that was caused by a difference in the type of size_t, by using a target

Re: r325291 - [Coroutines] Use allocator overload when available

2018-02-16 Thread Brian Gesiak via cfe-commits
emaCXX/coroutines.cpp Line 839 (directive at >> /home/buildslave/buildslave/clang-cmake-armv7-a15/llvm/tools >> /clang/test/SemaCXX/coroutines.cpp:838): candidate function not viable: >> requires 4 arguments, but 1 was provided >> 8 errors generated. >> >> Can you

Re: r325291 - [Coroutines] Use allocator overload when available

2018-02-16 Thread Brian Gesiak via cfe-commits
> tools/clang/test/SemaCXX/coroutines.cpp:838): candidate function not > viable: requires 4 arguments, but 1 was provided > 8 errors generated. > > Can you take a look? > > Douglas Yung > > > -Original Message- > > From: cfe-commits [mailto:cfe-commi

r325291 - [Coroutines] Use allocator overload when available

2018-02-15 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Thu Feb 15 12:37:22 2018 New Revision: 325291 URL: http://llvm.org/viewvc/llvm-project?rev=325291&view=rev Log: [Coroutines] Use allocator overload when available Summary: Depends on https://reviews.llvm.org/D42605. An implementation of the behavior described in `[dcl.fct

r325288 - [Sema] Toggle diags when finding allocators (NFCI)

2018-02-15 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Thu Feb 15 12:09:25 2018 New Revision: 325288 URL: http://llvm.org/viewvc/llvm-project?rev=325288&view=rev Log: [Sema] Toggle diags when finding allocators (NFCI) Summary: Many methods in Sema take a `bool Diagnose` parameter. Examples of such methods include `Sema::FindDe

r323381 - [coroutines] Pass coro func args to promise ctor

2018-01-24 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Wed Jan 24 14:15:42 2018 New Revision: 323381 URL: http://llvm.org/viewvc/llvm-project?rev=323381&view=rev Log: [coroutines] Pass coro func args to promise ctor Summary: Use corutine function arguments to initialize a promise type, but only if the promise type defines a co

r322517 - [Driver] Suggest valid integrated tools

2018-01-15 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Mon Jan 15 13:05:40 2018 New Revision: 322517 URL: http://llvm.org/viewvc/llvm-project?rev=322517&view=rev Log: [Driver] Suggest valid integrated tools Summary: There are only two valid integrated Clang driver tools: `-cc1` and `-cc1as`. If a user asks for an unknown tool,

r322447 - [docs] Use monospace for PCH option flags

2018-01-13 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Sat Jan 13 10:34:07 2018 New Revision: 322447 URL: http://llvm.org/viewvc/llvm-project?rev=322447&view=rev Log: [docs] Use monospace for PCH option flags Summary: Use monospace for option flags in the PCH section, instead of the italics that were being used previously. I

r322445 - [Driver] Add "did you mean?" suggestions to -cc1as

2018-01-13 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Sat Jan 13 09:09:11 2018 New Revision: 322445 URL: http://llvm.org/viewvc/llvm-project?rev=322445&view=rev Log: [Driver] Add "did you mean?" suggestions to -cc1as Summary: In https://reviews.llvm.org/D41733, the driver was modified such that, when a user provided a mispell

r322220 - [Driver] Test for correct '--version' suggestion

2018-01-10 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Wed Jan 10 12:23:45 2018 New Revision: 30 URL: http://llvm.org/viewvc/llvm-project?rev=30&view=rev Log: [Driver] Test for correct '--version' suggestion Summary: The `llvm::OptTable::findNearest` bug fixed in https://reviews.llvm.org/D41873 manifested itself as the

r322118 - [Frontend] Remove unused FileMgr in pp arg parse

2018-01-09 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Tue Jan 9 13:26:47 2018 New Revision: 322118 URL: http://llvm.org/viewvc/llvm-project?rev=322118&view=rev Log: [Frontend] Remove unused FileMgr in pp arg parse Summary: A FIXME added 8 years ago (2010) in https://reviews.llvm.org/rL118203 mentioned that a FileManager shou

r321917 - [Driver] Suggest correctly spelled driver options

2018-01-05 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Fri Jan 5 16:25:40 2018 New Revision: 321917 URL: http://llvm.org/viewvc/llvm-project?rev=321917&view=rev Log: [Driver] Suggest correctly spelled driver options Summary: Depends on https://reviews.llvm.org/D41732. Utilities such as `opt`, when invoked with arguments that

r310838 - [Parse] Fix typo in header docs (NFC)

2017-08-14 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Mon Aug 14 07:29:11 2017 New Revision: 310838 URL: http://llvm.org/viewvc/llvm-project?rev=310838&view=rev Log: [Parse] Fix typo in header docs (NFC) Summary: Fix typo "delcarations", added in rL310609 and rL310627. Modified: cfe/trunk/include/clang/Parse/ParseAST.h

r310627 - [Parse] Document Parser::SkipFunctionBodies

2017-08-10 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Thu Aug 10 10:02:04 2017 New Revision: 310627 URL: http://llvm.org/viewvc/llvm-project?rev=310627&view=rev Log: [Parse] Document Parser::SkipFunctionBodies Reviewers: erikjv, doug.gregor Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D36531 Mod

r310609 - [Parse] Document PrintStats, SkipFunctionBodies

2017-08-10 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Thu Aug 10 08:30:35 2017 New Revision: 310609 URL: http://llvm.org/viewvc/llvm-project?rev=310609&view=rev Log: [Parse] Document PrintStats, SkipFunctionBodies Summary: Add documentation for `clang::ParseAST` parameters `PrintStats` and `SkipFunctionBodies`. Also, remove a

r308205 - [Basic] Detect Git submodule version in CMake

2017-07-17 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Mon Jul 17 12:22:57 2017 New Revision: 308205 URL: http://llvm.org/viewvc/llvm-project?rev=308205&view=rev Log: [Basic] Detect Git submodule version in CMake Summary: When searching for Git version control information, libBasic's CMake checks for the path '.git/logs/HEAD'.

r307193 - Add docs for -foptimization-record-file=

2017-07-05 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Wed Jul 5 12:55:51 2017 New Revision: 307193 URL: http://llvm.org/viewvc/llvm-project?rev=307193&view=rev Log: Add docs for -foptimization-record-file= Summary: The Clang option was previously not included in the User's Manual. Reviewers: anemet, davidxl, hfinkel Review

r306948 - Un-revert "[Driver] Add -fdiagnostics-hotness-threshold"

2017-06-30 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Fri Jun 30 22:45:26 2017 New Revision: 306948 URL: http://llvm.org/viewvc/llvm-project?rev=306948&view=rev Log: Un-revert "[Driver] Add -fdiagnostics-hotness-threshold" Summary: Un-revert https://reviews.llvm.org/D34868, but with a slight tweak to the documentation to fix

r306946 - Revert "[Driver] Add -fdiagnostics-hotness-threshold"

2017-06-30 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Fri Jun 30 21:54:53 2017 New Revision: 306946 URL: http://llvm.org/viewvc/llvm-project?rev=306946&view=rev Log: Revert "[Driver] Add -fdiagnostics-hotness-threshold" Summary: The commit caused a documentation breakage. Modified: cfe/trunk/docs/UsersManual.rst cfe

r306945 - [Driver] Add -fdiagnostics-hotness-threshold

2017-06-30 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Fri Jun 30 21:44:38 2017 New Revision: 306945 URL: http://llvm.org/viewvc/llvm-project?rev=306945&view=rev Log: [Driver] Add -fdiagnostics-hotness-threshold Summary: Depends on https://reviews.llvm.org/D34867. Add a Clang frontend option to enable optimization remark hotn

r306862 - [ORE] Use LLVM's "diagnostics hotness" spelling

2017-06-30 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Fri Jun 30 12:37:11 2017 New Revision: 306862 URL: http://llvm.org/viewvc/llvm-project?rev=306862&view=rev Log: [ORE] Use LLVM's "diagnostics hotness" spelling Summary: Depends on https://reviews.llvm.org/D34864. To unify Clang and LLVM's spelling of "diagnostic[s] hotnes

r306079 - [Frontend] 'Show hotness' can be used with a sampling profile

2017-06-22 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Thu Jun 22 21:38:45 2017 New Revision: 306079 URL: http://llvm.org/viewvc/llvm-project?rev=306079&view=rev Log: [Frontend] 'Show hotness' can be used with a sampling profile Summary: Prior to this change, using `-fdiagnostics-show-hotness` with a sampling profile specified

Re: [PATCH] D11772: [libclang] Add period to typedef kind docblock

2015-08-15 Thread Brian Gesiak via cfe-commits
modocache added a comment. Cool, thanks @compnerd! http://reviews.llvm.org/D11772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12047: test/SemaObjC: Remove cruft in unused getter test

2015-08-15 Thread Brian Gesiak via cfe-commits
modocache added a comment. > Why do you think it's a cruft? Seems it's a bit more verbose than it should be The verbosity is the cruft, in my opinion. Why spend thirty lines of code to demonstrate behavior that could be demonstrated in just five? > but what is missing in your test is inheritan

[PATCH] D12050: docs: Prefer 'check-clang' to 'clang-test'

2015-08-14 Thread Brian Gesiak via cfe-commits
modocache created this revision. modocache added a subscriber: cfe-commits. r159483 changed the canonical name of the Clang test target from 'clang-test' to 'check-clang'. Although the old name is still a valid alias, update the documentation to use the new, canonical target name. http://reviews.

[PATCH] D12048: Verify no result unused warning on macro expansion

2015-08-14 Thread Brian Gesiak via cfe-commits
modocache created this revision. modocache added a reviewer: cfe-commits. Depends on http://reviews.llvm.org/D12047. Add a unit test which demonstrates the bug reported in https://llvm.org/bugs/show_bug.cgi?id=24404. If the macro is enclosed within parentheses, the warning is reported as expecte

[PATCH] D12047: test/SemaObjC: Remove cruft in unused getter test

2015-08-14 Thread Brian Gesiak via cfe-commits
modocache created this revision. modocache added a reviewer: cfe-commits. The tests that verify that accessing a property without using the result emits a warning were needlessly complicated. Remove several layers of abstraction to make the tests much simpler to read and reason about. http://revi

Re: [PATCH] D11772: [libclang] Add period to typedef kind docblock

2015-08-11 Thread Brian Gesiak via cfe-commits
modocache added a comment. I do! Thanks, @compnerd! http://reviews.llvm.org/D11772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11773: [libclang] Document IB attribute cursor kinds

2015-08-11 Thread Brian Gesiak via cfe-commits
modocache added a comment. Because I happen to know what these kinds are! ;) But I agree--they should all be documented. I can look into what the other kinds mean and add appropriate documentation for those as well. Maybe in another commit? http://reviews.llvm.org/D11773 __

Re: [PATCH] D11797: [libclang] Expose the ElaboratedType

2015-08-09 Thread Brian Gesiak via cfe-commits
modocache accepted this revision. modocache added a reviewer: modocache. modocache added a comment. This revision is now accepted and ready to land. Looks good to me! I don't have commit access, though, so you'll probably have to find a committer to review/commit for you, @skalinichev. http://r

Re: [PATCH] D11797: [libclang] Expose the ElaboratedType

2015-08-07 Thread Brian Gesiak via cfe-commits
modocache added a subscriber: modocache. Comment at: bindings/python/clang/cindex.py:1875 @@ -1873,1 +1874,3 @@ +def getElabaratedTypeUnderlyingType(self): +""" Awesome, thanks for updating the Python bindings as well! As with the C function, I beli

Re: [PATCH] D2916: [libclang][python] Add test for Index read

2015-08-07 Thread Brian Gesiak via cfe-commits
modocache added a reviewer: ddunbar. modocache added a subscriber: ddunbar. modocache added a comment. Adding @ddunbar, who added the original FIXME, as a reviewer. http://reviews.llvm.org/D2916 ___ cfe-commits mailing list cfe-commits@lists.llvm.or