Re: [PATCH] D24069: Document option '-rtlib' in clang's man page and help info

bruno added inline comments. Comment at: docs/CommandGuide/clang.rst:114 @@ -110,1 +113,3 @@ + compiler-rt. + .. option:: -ansi zlei wrote: > bruno wrote: > > It might be worth mentioning what's the default behaviour in case the flag > > isn't specified? > This

Re: [PATCH] D24091: [Driver] Warn on -nodefaultlibs and -fsanitize

bruno added inline comments. Comment at: include/clang/Basic/DiagnosticDriverKinds.td:276 @@ +275,3 @@ +def warn_drv_sanitizers_and_nodefaultlibs : Warning< + "Passing -nodefaultlibs and -fsanitize has resulted in linking sanitizer runtimes.">, +

Re: [PATCH] D24091: [Driver] Warn on -nodefaultlibs and -fsanitize

bruno added a comment. Hi Chris, Thanks for doing this. Comment at: lib/Driver/Driver.cpp:1554 @@ -1551,1 +1553,3 @@ +Args.hasArg(options::OPT_fsanitize_EQ)) + Diag(clang::diag::warn_drv_sanitizers_and_nodefaultlibs); } How hard is to fire the

Re: [PATCH] D24069: Document option '-rtlib' in clang's man page and help info

bruno added a subscriber: bruno. bruno added a comment. Hi Lei, Thanks for the doc improvement! Comment at: docs/CommandGuide/clang.rst:114 @@ -110,1 +113,3 @@ + compiler-rt. + .. option:: -ansi It might be worth mentioning what's the default behaviour in

Re: [PATCH] D23905: [Modules] Add 'gnuinlineasm' to the 'requires-declaration' feature-list.

bruno closed this revision. bruno added a comment. Thanks Richard. r280159 https://reviews.llvm.org/D23905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r280159 - [Modules] Add 'gnuinlineasm' to the 'requires-declaration' feature-list.

Author: bruno Date: Tue Aug 30 16:25:42 2016 New Revision: 280159 URL: http://llvm.org/viewvc/llvm-project?rev=280159=rev Log: [Modules] Add 'gnuinlineasm' to the 'requires-declaration' feature-list. This adds support for modules that require (no-)gnu-inline-asm environment, such as the compiler

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

bruno added a subscriber: bruno. bruno added a comment. Regardless of the way we decide to go with this, it would be nice if a driver level warning is used to tell users about any non-obvious assumed behavior when these flags are used together. https://reviews.llvm.org/D24048

Re: [PATCH] D24042: [test] Add libLTO as a clang test dependency on Darwin

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Nice, LGTM https://reviews.llvm.org/D24042 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23852: [SemaObjC] Fix crash while parsing type arguments and protocols

bruno added a comment. Ping! https://reviews.llvm.org/D23852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23905: [Modules] Add 'gnuinlineasm' to the 'requires-declaration' feature-list.

bruno added a comment. Ping! https://reviews.llvm.org/D23905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23837: Fix colored diagnostics from tools

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Thanks, LGTM https://reviews.llvm.org/D23837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23852: [SemaObjC] Fix crash while parsing type arguments and protocols

bruno updated the summary for this revision. bruno updated this revision to Diff 69456. bruno added a comment. Updated patch and changed approach after Doug's comment. https://reviews.llvm.org/D23852 Files: lib/Parse/ParseDecl.cpp lib/Parse/ParseObjc.cpp lib/Parse/Parser.cpp

Re: [PATCH] D23905: [Modules] Add 'gnuinlineasm' to the 'requires-declaration' feature-list.

bruno updated this revision to Diff 69392. bruno added a comment. Update patch after Richard's comment https://reviews.llvm.org/D23905 Files: docs/Modules.rst lib/Basic/Module.cpp lib/Headers/module.modulemap

Re: [PATCH] D23905: [Modules] Add 'gnuinlineasm' to the 'requires-declaration' feature-list.

On Thu, Aug 25, 2016 at 9:52 PM, Richard Smith wrote: > On 25 Aug 2016 7:37 p.m., "Bruno Cardoso Lopes" > wrote: > > bruno created this revision. > bruno added a reviewer: rsmith. > bruno added subscribers: cfe-commits, eladcohen. > > This adds

Re: [PATCH] D23859: [Preprocessor] Add a macro for -fno-gnu-inline-asm

bruno abandoned this revision. bruno added a comment. Abandon in favor of https://reviews.llvm.org/D23905 https://reviews.llvm.org/D23859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D23905: [Modules] Add 'gnuinlineasm' to the 'requires-declaration' feature-list.

bruno created this revision. bruno added a reviewer: rsmith. bruno added subscribers: cfe-commits, eladcohen. This adds support for modules that require (no-)gnu-inline-asm environment, such as the compiler builtin cpuid submodule. This is the gnu-inline-asm variant of

Re: [PATCH] D23860: [Sema][Comments] Add support for TypeAliasTemplate

bruno closed this revision. bruno added a comment. Applied your suggestions and committed r279754. Thanks! https://reviews.llvm.org/D23860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r279754 - [Sema][Comments] Add support for TypeAliasTemplate

Author: bruno Date: Thu Aug 25 12:09:33 2016 New Revision: 279754 URL: http://llvm.org/viewvc/llvm-project?rev=279754=rev Log: [Sema][Comments] Add support for TypeAliasTemplate Emit proper diagnostics when -Wdocumentation is used with constructs such as: template using fn = int(T aaa, int

[PATCH] D23860: [Sema][Comments] Add support for TypeAliasTemplate

bruno created this revision. bruno added a reviewer: gribozavr. bruno added a subscriber: cfe-commits. Emit proper diagnostics when -Wdocumentation is used with constructs such as: template using fn = int(T aaa, int ccc); Previously clang wouldn't recognize the function and complain with

r279691 - [Sema][Comments] Factor out function type loc logic. NFCI

Author: bruno Date: Wed Aug 24 19:22:08 2016 New Revision: 279691 URL: http://llvm.org/viewvc/llvm-project?rev=279691=rev Log: [Sema][Comments] Factor out function type loc logic. NFCI This is in prepatation for @param TypeAliasTemplate support. Modified: cfe/trunk/lib/AST/Comment.cpp

[PATCH] D23859: [Preprocessor] Add a macro for -fno-gnu-inline-asm

bruno created this revision. bruno added reviewers: rsmith, echristo. bruno added subscribers: cfe-commits, friss. Herald added a subscriber: mehdi_amini. When building with -fno-gnu-inline-asm and -fmodules on Darwin, the compilation might fail if some of the implicit modules try to use gnu asm

Re: [PATCH] D23783: [Sema][Comments] Support @param with c++ 'using' keyword

bruno closed this revision. bruno added a comment. r279662 https://reviews.llvm.org/D23783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r279662 - [Sema][Comments] Support @param with c++ 'using' keyword

Author: bruno Date: Wed Aug 24 16:11:43 2016 New Revision: 279662 URL: http://llvm.org/viewvc/llvm-project?rev=279662=rev Log: [Sema][Comments] Support @param with c++ 'using' keyword Give appropriate warnings with -Wdocumentation for @param comments that refer to function aliases defined with

[PATCH] D23852: [SemaObjC] Fix crash while parsing type arguments and protocols

bruno created this revision. bruno added a reviewer: doug.gregor. bruno added subscribers: cfe-commits, manmanren. Fix a crash-on-invalid. When parsing type arguments and protocols, ParseTypeName() tries to find matching tokens for '[', '(', etc whenever they appear among potential type names.

Re: [PATCH] D23837: Fix colored diagnostics from tools

bruno added a comment. Hi Olivier, Can you add a test? Can you also include some context to the patch? Thanks, https://reviews.llvm.org/D23837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r279481 - [SemaObjC] Do not RebuildObjCMessageExpr without valid method decl

Author: bruno Date: Mon Aug 22 16:50:22 2016 New Revision: 279481 URL: http://llvm.org/viewvc/llvm-project?rev=279481=rev Log: [SemaObjC] Do not RebuildObjCMessageExpr without valid method decl Fix crash-on-invalid in ObjC Sema by avoiding to rebuild a message expression to a 'super' class in

[PATCH] D23783: [Sema][Comments] Support @param with c++ 'using' keyword

bruno created this revision. bruno added a reviewer: rsmith. bruno added a subscriber: cfe-commits. Give appropriate warnings with -Wdocumentation for @param comments that refer to function aliases defined with 'using'. Very similar to typedef's behavior. Support for TypeAliasTemplateDecl comes

r278543 - Reapply [VFS] Skip non existent files from the VFS tree

Author: bruno Date: Fri Aug 12 13:18:24 2016 New Revision: 278543 URL: http://llvm.org/viewvc/llvm-project?rev=278543=rev Log: Reapply [VFS] Skip non existent files from the VFS tree Reapply r278457 with test fixed to not abouse fs case sensitivity. When the VFS uses a YAML file, the real file

r278459 - Revert "[VFS] Skip non existent files from the VFS tree"

Author: bruno Date: Thu Aug 11 21:17:26 2016 New Revision: 278459 URL: http://llvm.org/viewvc/llvm-project?rev=278459=rev Log: Revert "[VFS] Skip non existent files from the VFS tree" Breaking bots: http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/27281/ This reverts

Re: [PATCH] D23422: [VFS] Add 'ignore-non-existent-contents' field to YAML

bruno accepted this revision. bruno added a reviewer: bruno. bruno added a comment. This revision is now accepted and ready to land. Applied your comments, and committed in r278456! Thanks https://reviews.llvm.org/D23422 ___ cfe-commits mailing

r278457 - [VFS] Skip non existent files from the VFS tree

Author: bruno Date: Thu Aug 11 20:51:04 2016 New Revision: 278457 URL: http://llvm.org/viewvc/llvm-project?rev=278457=rev Log: [VFS] Skip non existent files from the VFS tree When the VFS uses a YAML file, the real file path for a virtual file is described in the "external-contents" field.

r278456 - [VFS] Add 'ignore-non-existent-contents' field to YAML files

Author: bruno Date: Thu Aug 11 20:50:53 2016 New Revision: 278456 URL: http://llvm.org/viewvc/llvm-project?rev=278456=rev Log: [VFS] Add 'ignore-non-existent-contents' field to YAML files Add 'ignore-non-existent-contents' to tell the VFS whether an invalid path obtained via 'external-contents'

[PATCH] D23422: [VFS] Add 'ignore-non-existent-contents' field to YAML

bruno created this revision. bruno added a reviewer: benlangmuir. bruno added a subscriber: cfe-commits. Add 'ignore-non-existent-contents' to tell the VFS whether an invalid path obtained via 'external-contents' should cause iteration on the VFS to stop. If 'true', the VFS should ignore the

Re: r278264 - Reapply [Sema] Add sizeof diagnostics for bzero

On Thu, Aug 11, 2016 at 5:43 AM, Joerg Sonnenberger via cfe-commits wrote: > > On Wed, Aug 10, 2016 at 02:36:01PM -0700, Bruno Cardoso Lopes wrote: > > Hi Joerg, > > > > > Given that bzero is pretty much non-standard at this point, I strongly > > > dislike the approach

r278379 - [Sema] Add more strict check for sizeof diagnostics for bzero

Author: bruno Date: Thu Aug 11 13:33:15 2016 New Revision: 278379 URL: http://llvm.org/viewvc/llvm-project?rev=278379=rev Log: [Sema] Add more strict check for sizeof diagnostics for bzero Follow-up from r278264 after Joerg's feedback. Since bzero is not standard, be more strict: also check if

Re: [PATCH] D23125: Modules: add command line option to support loading prebuilt modules on demand, without parsing any module map

bruno added inline comments. Comment at: lib/Frontend/CompilerInstance.cpp:1438-1450 @@ -1437,3 +1437,15 @@ // Search for a module with the given name. Module = PP->getHeaderSearchInfo().lookupModule(ModuleName); -if (!Module) { +HeaderSearchOptions = +

Re: r278264 - Reapply [Sema] Add sizeof diagnostics for bzero

Hi Joerg, > Given that bzero is pretty much non-standard at this point, I strongly > dislike the approach of checking only the function name. Thanks for the feedback. bzero it's widely used though, I think it's a usability win to perform a diagnostic here, despite bzero being non-standard. Is

Re: r277787 - [Sema] Add sizeof diagnostics for bzero

This typo was exactly the reason why, r278264. Thanks On Fri, Aug 5, 2016 at 10:09 AM, David Majnemer <david.majne...@gmail.com> wrote: > > > On Thu, Aug 4, 2016 at 4:55 PM, Bruno Cardoso Lopes via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> >> Author

r278264 - Reapply [Sema] Add sizeof diagnostics for bzero

Author: bruno Date: Wed Aug 10 13:34:47 2016 New Revision: 278264 URL: http://llvm.org/viewvc/llvm-project?rev=278264=rev Log: Reapply [Sema] Add sizeof diagnostics for bzero Reapply r277787. For memset (and others) we can get diagnostics like: struct stat { int x; }; void foo(struct stat

Re: [libcxx] r278191 - test/hard_link_count(): Fix test on darwin

Thanks Matthias! On Tue, Aug 9, 2016 at 6:02 PM, Matthias Braun via cfe-commits wrote: > Author: matze > Date: Tue Aug 9 20:02:28 2016 > New Revision: 278191 > > URL: http://llvm.org/viewvc/llvm-project?rev=278191=rev > Log: > test/hard_link_count(): Fix test on

Re: [libcxx] r273034 - Add Filesystem TS -- Complete

Ping! On Thu, Aug 4, 2016 at 8:03 AM, Adrian Prantl wrote: > >> On Aug 3, 2016, at 1:56 PM, Bruno Cardoso Lopes >> wrote: >> >> Hi Eric, >> >> After we upgraded our green dragon bots to El Captain (10.11), the >> test below started to fail on some of

Re: r277787 - [Sema] Add sizeof diagnostics for bzero

at this issue. > > > Best regards, > Gabor Ballabas > > > On 08/05/2016 01:55 AM, Bruno Cardoso Lopes via cfe-commits wrote: >> >> Author: bruno >> Date: Thu Aug 4 18:55:22 2016 >> New Revision: 277787 >> >> URL: http://llvm.org/viewvc/llvm-project

r277830 - Revert "[Sema] Add sizeof diagnostics for bzero"

Author: bruno Date: Fri Aug 5 11:41:00 2016 New Revision: 277830 URL: http://llvm.org/viewvc/llvm-project?rev=277830=rev Log: Revert "[Sema] Add sizeof diagnostics for bzero" This reverts commit r277787, which caused PR28870. Modified: cfe/trunk/lib/AST/Decl.cpp

Re: [PATCH] D22525: [Sema] Add sizeof diagnostics for bzero

bruno closed this revision. bruno added a comment. Thanks! Committed in r277787 https://reviews.llvm.org/D22525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r277787 - [Sema] Add sizeof diagnostics for bzero

Author: bruno Date: Thu Aug 4 18:55:22 2016 New Revision: 277787 URL: http://llvm.org/viewvc/llvm-project?rev=277787=rev Log: [Sema] Add sizeof diagnostics for bzero For memset (and others) we can get diagnostics like: struct stat { int x; }; void foo(struct stat *stamps) {

Re: [libcxx] r273034 - Add Filesystem TS -- Complete

Hi Eric, After we upgraded our green dragon bots to El Captain (10.11), the test below started to fail on some of our machines: -- test/std/experimental/filesystem/fs.op.funcs/fs.op.hard_lk_ct/hard_link_count.pass.cpp TEST_CASE(hard_link_count_for_directory) { uintmax_t DirExpect =

Re: r277542 - [CUDA] Fix libdevice selection.

Hi Artem, This broke http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/26856, can you take a look? Thanks, On Tue, Aug 2, 2016 at 4:12 PM, Artem Belevich via cfe-commits wrote: > Author: tra > Date: Tue Aug 2 18:12:51 2016 > New Revision:

Re: r276907 - Add flags to toggle preservation of assembly comments

Hi Nirav, This test is failing on darwin: http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/26574 Can you take a look? On Wed, Jul 27, 2016 at 12:57 PM, Nirav Dave via cfe-commits wrote: > Author: niravd > Date: Wed Jul 27 14:57:40 2016 >

Re: [PATCH] D22183: [SemObjC] Fix TypoExpr handling in TransformObjCDictionaryLiteral

bruno closed this revision. bruno added a comment. Thanks Manman, Committed r276020 https://reviews.llvm.org/D22183 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r276020 - [SemaObjC] Improve ObjCDictionaryLiteral and ObjCArryLiteral diagnostics

Author: bruno Date: Tue Jul 19 15:21:18 2016 New Revision: 276020 URL: http://llvm.org/viewvc/llvm-project?rev=276020=rev Log: [SemaObjC] Improve ObjCDictionaryLiteral and ObjCArryLiteral diagnostics Sema actions on ObjCDictionaryLiteral and ObjCArryLiteral are currently done as a side-effect of

[PATCH] D22525: [Sema] Add sizeof diagnostics for bzero

bruno created this revision. bruno added a reviewer: zaks.anna. bruno added a subscriber: cfe-commits. For memset (and others) we can get diagnostics like: struct stat { int x; }; void foo(struct stat *stamps) { memset(stamps, 0, sizeof(stamps)); } t.c:7:28: warning: 'memset' call

Re: [PATCH] D22183: [SemObjC] Fix TypoExpr handling in TransformObjCDictionaryLiteral

bruno added a comment. Ping! https://reviews.llvm.org/D22183 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22248: [Sema] Create a separate group for incompatible function pointer warning

bruno closed this revision. bruno added a comment. Thanks, r275907. https://reviews.llvm.org/D22248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r275907 - [Sema] Create a separate group for incompatible function pointer warning

Author: bruno Date: Mon Jul 18 15:37:06 2016 New Revision: 275907 URL: http://llvm.org/viewvc/llvm-project?rev=275907=rev Log: [Sema] Create a separate group for incompatible function pointer warning Give incompatible function pointer warning its own diagnostic group but still leave it as a

[PATCH] D22474: [CodeGen] Suppress C++ static destructor registration

bruno created this revision. bruno added reviewers: rsmith, doug.gregor. bruno added subscribers: cfe-commits, dexonsmith. C++ static destructors can be problematic in multi-threaded environment. Some of the issues users often complain about include: 1. Teardown ordering: crashes when one

Re: [PATCH] D22010: Add more gcc compatibility names to clang's cpuid.h

bruno added a subscriber: bruno. Comment at: lib/Headers/cpuid.h:114 @@ -109,2 +113,3 @@ #define bit_AVX 0x1000 +#define bit_F16C0x2000 #define bit_RDRND 0x4000 Isn't this one also meant for gcc compat?

Re: [PATCH] D22285: Support -masm= flag for x86 assembly targets

bruno added a subscriber: bruno. bruno accepted this revision. bruno added a reviewer: bruno. bruno added a comment. This revision is now accepted and ready to land. LGTM with one small fix, see below. Comment at: lib/Driver/Tools.cpp:6379 @@ +6378,3 @@ +void

Re: [PATCH] D22200: [libc++] Fix macOS Sierra build issues by declaring basic_string(const allocator_type& __a) noexcept.

bruno added a subscriber: bruno. bruno added a comment. Hi, Can you provide more details on what the build issues are? It seems that the line you introduce is covered in the ifdef below, wonder why it's not triggering in your build? Repository: rL LLVM https://reviews.llvm.org/D22200

Re: [PATCH] D22183: [SemObjC] Fix TypoExpr handling in TransformObjCDictionaryLiteral

bruno updated this revision to Diff 64162. bruno added a comment. Thanks for the review Manman, I found a much better approach. Updated the patch to reflect that! https://reviews.llvm.org/D22183 Files: lib/Parse/ParseObjc.cpp test/SemaObjC/objc-array-literal.m

Re: [PATCH] D22248: [Sema] Create a separate group for incompatible function pointer warning

bruno added a comment. Ping! https://reviews.llvm.org/D22248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22248: [Sema] Create a separate group for incompatible function pointer warning

bruno created this revision. bruno added reviewers: bob.wilson, doug.gregor, krememek. bruno added subscribers: cfe-commits, dexonsmith. Give incompatible pointer warning for function pointers its own diagnostic group while leaving it as a subgroup of incompatible-pointer-types. This is in

[PATCH] D22183: [SemObjC] Fix TypoExpr handling in TransformObjCDictionaryLiteral

bruno created this revision. bruno added reviewers: manmanren, doug.gregor. bruno added a subscriber: cfe-commits. Calls to TransformExpr for NSDictionary elements (keys and values) in TransformObjCDictionaryLiteral might fail to obtain TypoCorrections. This is OK, but the early exits with

Re: [PATCH] D21700: [SemaExpr] Support lax conversions in assignments with vector and scalars with same size

bruno closed this revision. bruno added a comment. Thanks Reid, Committed r274646. http://reviews.llvm.org/D21700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r274646 - [SemaExpr] Support assignments from vector to scalars with same size

Author: bruno Date: Wed Jul 6 13:05:23 2016 New Revision: 274646 URL: http://llvm.org/viewvc/llvm-project?rev=274646=rev Log: [SemaExpr] Support assignments from vector to scalars with same size Before r266366, clang used to support constructs like: typedef __attribute__((vector_size(8)))

Re: [PATCH] D21700: [SemaExpr] Support lax conversions in assignments with vector and scalars with same size

bruno updated this revision to Diff 62802. bruno added a comment. Update patch after Reid's suggestions. http://reviews.llvm.org/D21700 Files: lib/Sema/SemaExpr.cpp test/Sema/vector-cast.c Index: test/Sema/vector-cast.c ===

Re: [PATCH] D21700: [SemaExpr] Support lax conversions in assignments with vector and scalars with same size

bruno added a comment. In http://reviews.llvm.org/D21700#470103, @rnk wrote: > After writing r266366, we discovered that GCC accepts none of the code in > that test case, so we should consider turning -flax-vector-conversions off by > default. Makes sense, specially given the non obvious

Re: [PATCH] D21641: Use ArgList::hasFlag to check if -miamcu/-mno-iamcu is passed. NFC.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Cool, thanks! LGTM http://reviews.llvm.org/D21641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21700: [SemaExpr] Support lax conversions in assignments with vector and scalars with same size

bruno added a comment. Ping! http://reviews.llvm.org/D21700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21700: [SemaExpr] Support lax conversions in assignments with vector and scalars with same size

bruno created this revision. bruno added reviewers: rnk, rsmith. bruno added a subscriber: cfe-commits. Before r266366, clang used to support constructs like: typedef __attribute__((vector_size(8))) double float64x1_t; typedef __attribute__((vector_size(16))) double float64x2_t;

Re: r273147 - [X86] Add -mno-iamcu option.

Hi Andrey, On Mon, Jun 20, 2016 at 3:31 AM, Andrey Turetskiy via cfe-commits wrote: > Author: aturetsk > Date: Mon Jun 20 05:31:39 2016 > New Revision: 273147 > > URL: http://llvm.org/viewvc/llvm-project?rev=273147=rev > Log: > [X86] Add -mno-iamcu option. > > Add

Re: [PATCH] D21338: cc1_main: Do not print statistics in -disable_free mode.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Assuming that it's guaranteed that the other path would always print out the statistics, LGTM Repository: rL LLVM http://reviews.llvm.org/D21338

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Sure! LGTM http://reviews.llvm.org/D19274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

bruno added a comment. FTR, I finally test it out for compile time and could not notice any difference besides noise. Thanks Eric! http://reviews.llvm.org/D19843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

bruno added inline comments. Comment at: lib/Lex/PPDirectives.cpp:179 @@ +178,3 @@ +"exception", "iterator", "random", "strstream", "vector", +"forward_list", "limits", "ratio", "system_error", + Applying your patch reveled a bunch of ^M (carriage-return)

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

bruno added a comment. Before this goes in again, I want to double check that this doesn't affect compile time on darwin + frameworks. Will get back to you asap. Comment at: lib/Lex/PPDirectives.cpp:218 @@ +217,3 @@ + SmallString<32> LowerInclude{Include}; + for (char& Ch :

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

> The information about whether the file is in a system path is already being > computed, so it would incur no extra overhead. I'm not sure that's the right > fix. You are more than welcome to revert the (clang) commit while we think > of the right fix. I'm not sure what the right fix is either,

r271758 - [Modules] Improve diagnostics for LockFileManager errors

Author: bruno Date: Fri Jun 3 20:13:22 2016 New Revision: 271758 URL: http://llvm.org/viewvc/llvm-project?rev=271758=rev Log: [Modules] Improve diagnostics for LockFileManager errors Uses error message now provided by LockFileManager in LLVM r271755. rdar://problem/26529101 Modified:

Re: [PATCH] D20942: [LockFileManager] Improve error output by adding error messages

bruno closed this revision. bruno added a comment. Applied your suggestions and committed in r271755! Thanks http://reviews.llvm.org/D20942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

I think this should be reverted until we figure out how to solve it. Moreover, it looks expensive to check for each file if it's within a system path. I would really like to measure compile time for this change before it goes definitely in. On Fri, Jun 3, 2016 at 4:53 PM, Justin Bogner via

Re: [PATCH] D20942: [LockFileManager] Improve error output by adding error messages

bruno added a subscriber: llvm-commits. bruno added a comment. Adding the right list for this +llvm-commits http://reviews.llvm.org/D20942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D20942: [LockFileManager] Improve error output by adding error messages

bruno created this revision. bruno added a reviewer: benlangmuir. bruno added subscribers: cfe-commits, dexonsmith. This is currently used by clang to lock access to modules; improve the error message so that clang can use better output messages from locking error issues.

Re: [PATCH] D20867: [PCH] Fix timestamp check on windows hosts.

bruno added inline comments. Comment at: test/PCH/include-timestamp.cpp:5 @@ +4,3 @@ +// Check timestamp is included by default. +// RUN: %clang_cc1 -x c++-header -emit-pch -o %t %S/Inputs/include-timestamp-pch.h +// RUN: touch %S/Inputs/include-timestamp.h Can

Re: [PATCH] D20404: [Driver] Fix driver support for color diagnostics

bruno closed this revision. bruno added a comment. Committed in r271042 http://reviews.llvm.org/D20404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20266: [Modules] Use vfs for (recursive) directory iteration

bruno closed this revision. bruno added a comment. Committed in r269661 http://reviews.llvm.org/D20266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18585: [CrashReproducer] Add a module map callback for added headers

bruno closed this revision. bruno added a comment. Committed in r264971 http://reviews.llvm.org/D18585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20451: [Parser] Fix look ahead after EOF while parsing objc message and lambdas

bruno closed this revision. bruno added a comment. Thanks Doug! Committed r271314 http://reviews.llvm.org/D20451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r271314 - [Parser] Fix look ahead after EOF while parsing objc message and lambdas

Author: bruno Date: Tue May 31 13:46:31 2016 New Revision: 271314 URL: http://llvm.org/viewvc/llvm-project?rev=271314=rev Log: [Parser] Fix look ahead after EOF while parsing objc message and lambdas If a closing ')' isn't found for a macro instantiation inside a '[', the next token is EOF, this

r271042 - [Driver] Fix driver support for color diagnostics

Author: bruno Date: Fri May 27 15:43:00 2016 New Revision: 271042 URL: http://llvm.org/viewvc/llvm-project?rev=271042=rev Log: [Driver] Fix driver support for color diagnostics Diagnostics that happen during driver time do not have color output support unless -fcolor-diagonostic is explicitly

Re: [PATCH] D20451: [Parser] Fix look ahead after EOF while parsing objc message and lambdas

bruno added a comment. Ping! http://reviews.llvm.org/D20451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20404: [Driver] Fix driver support for color diagnostics

bruno added a comment. Ping! http://reviews.llvm.org/D20404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20675: Compilation for Intel MCU (Part 3/3)

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D20675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

bruno added inline comments. Comment at: lib/Driver/Tools.cpp:3657 @@ +3656,3 @@ + if (IsIAMCU && types::isCXX(Input.getType())) +D.Diag(diag::err_drv_cxx_not_supported) << getToolChain().getTriple().str(); + aturetsk wrote: > bruno wrote: > > Taking a look

Re: [PATCH] D20338: [PCH] Fixed overridden files always invalidating preamble even when unchanged

bruno added a comment. You can probably find a way to test this by taking a look at unittests/Basic/VirtualFileSystemTest.cpp Repository: rL LLVM http://reviews.llvm.org/D20338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

bruno added a comment. Hi, Comment at: lib/Driver/Tools.cpp:3657 @@ +3656,3 @@ + if (IsIAMCU && types::isCXX(Input.getType())) +D.Diag(diag::err_drv_cxx_not_supported) << getToolChain().getTriple().str(); + Taking a look at this again I don't think

Re: r269769 - [PCH] Fixed bug with preamble invalidation when overridden files change

Ping on the testcase :-) On Tue, May 17, 2016 at 9:36 AM, Nico Weber via cfe-commits wrote: > Is it possible to write a test for this? > > On Tue, May 17, 2016 at 10:34 AM, Cameron Desrochers via cfe-commits > wrote: >> >> Author:

Re: [PATCH] D20243: [PCH] Disable inclusion of timestamps when generating pch files on windows.

bruno added a subscriber: bruno. bruno added a comment. Hi Pierre, Comment at: test/PCH/pragma-once-timestamp.cpp:17 @@ +16,3 @@ + +// REQUIRES: system-windows + Can you move this to the beginning of the file? It makes it easier to spot that this is windows

Re: [PATCH] D20338: [PCH] Fixed overridden files always invalidating preamble even when unchanged

bruno added a subscriber: bruno. bruno added a comment. Hi Cameron, Can you add a testcase? Repository: rL LLVM http://reviews.llvm.org/D20338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20451: [Parser] Fix look ahead after EOF while parsing objc message and lambdas

bruno added a comment. Ping! http://reviews.llvm.org/D20451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20404: [Driver] Fix driver support for color diagnostics

bruno added a comment. Ping! http://reviews.llvm.org/D20404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20404: [Driver] Fix driver support for color diagnostics

bruno added reviewers: dexonsmith, silvas. bruno removed subscribers: silvas, dexonsmith. bruno updated this revision to Diff 57993. bruno added a comment. Great idea Duncan, attached a new patch! http://reviews.llvm.org/D20404 Files: include/clang/Frontend/CompilerInvocation.h

<    1   2   3   4   5   6   >