Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

bruno accepted this revision. bruno added a reviewer: bruno. bruno added a comment. Thanks, Committed r259311! http://reviews.llvm.org/D15173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r259311 - [Parser] Update CachedTokens while parsing ObjectiveC template argument list

Author: bruno Date: Sat Jan 30 18:47:51 2016 New Revision: 259311 URL: http://llvm.org/viewvc/llvm-project?rev=259311=rev Log: [Parser] Update CachedTokens while parsing ObjectiveC template argument list Consider the following ObjC++ snippet: -- @protocol PA; @protocol PB; @class NSArray;

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

Ping! On Wed, Jan 20, 2016 at 11:22 AM, Bruno Cardoso Lopes wrote: > bruno updated this revision to Diff 45421. > bruno added a comment. > > Update patch after Richard comments > > > http://reviews.llvm.org/D15173 > > Files: > include/clang/Lex/Preprocessor.h >

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

bruno updated this revision to Diff 45421. bruno added a comment. Update patch after Richard comments http://reviews.llvm.org/D15173 Files: include/clang/Lex/Preprocessor.h lib/Lex/PPCaching.cpp lib/Parse/ParseTemplate.cpp test/Parser/objcxx11-protocol-in-template.mm Index:

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

Hi Richard, >> + // The advance from '>>' to '>' in a ObjectiveC template argument list >> needs >> + // to be properly reflected in the token cache to allow correct >> interaction >> + // between annotation and backtracking. >> + if (ObjCGenericList && PrevTok.getKind() ==

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

Ping :-) On Mon, Jan 11, 2016 at 8:49 AM, Bruno Cardoso Lopes wrote: > bruno added a comment. > > Ping! > > > http://reviews.llvm.org/D15173 > > > -- Bruno Cardoso Lopes http://www.brunocardoso.cc ___ cfe-commits mailing

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

bruno updated this revision to Diff 44306. bruno added a comment. Hi Richard, Thanks for the detailed explanation, it now makes sense to me. I updated the patch with another approach! Let me know if it's the right direction. http://reviews.llvm.org/D15173 Files:

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

bruno updated this revision to Diff 44180. bruno added a comment. Hi Richard, Thanks for the comments. Updated the patch! In http://reviews.llvm.org/D15173#313235, @rsmith wrote: > I think that this will leave us with a broken token stream. In your example, > the cached token stream starts as

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

bruno added a comment. Ping! http://reviews.llvm.org/D15173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

bruno added a comment. Hi Argyrios, Thanks for the suggestions, will apply them. The assertion seems important to catch subtle bugs, are you sure it should be placed inside a "#ifndef NDEBUG”? http://reviews.llvm.org/D15173 ___ cfe-commits

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

bruno added a comment. Ping! http://reviews.llvm.org/D15173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

bruno created this revision. bruno added reviewers: doug.gregor, akyrtzi. bruno added subscribers: cfe-commits, dexonsmith. Consider the following ObjC++ snippet: @protocol PA; @protocol PB; @class NSArray; typedef int some_t; id FA(NSArray *h, some_t group); This would hit an

Re: r253481 - Re-committing r253473 after hopefully fixing the bot breakage. There was a copy-pasta issue that my local testing did not catch.

Hi Aaron, There's one test failing now: https://smooshbase.apple.com/ci/job/apple-clang-stage1-configure-R_master_check/7042/ FAIL: Clang-Unit :: ASTMatchers/Release+Asserts/ASTMatchersTests/Matcher.VarDecl_StorageDuration (8227 of 24324) TEST 'Clang-Unit ::

Re: r253481 - Re-committing r253473 after hopefully fixing the bot breakage. There was a copy-pasta issue that my local testing did not catch.

Ops, missed you follow up r253486 again. Thanks, On Wed, Nov 18, 2015 at 11:07 AM, Bruno Cardoso Lopes wrote: > Hi Aaron, > > There's one test failing now: > https://smooshbase.apple.com/ci/job/apple-clang-stage1-configure-R_master_check/7042/ > > FAIL: Clang-Unit :: >

Re: [clang-tools-extra] r253401 - [clang-tidy] add check cppcoreguidelines-pro-bounds-constant-array-index

Hi Matthias, This is failing on the green dragon bot: http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/13184/ http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/13184/consoleFull#54616856949ba4694-19c4-4d7e-bec5-911270d8a58c Thanks, On Tue, Nov 17, 2015 at 3:43

Re: r252834 - Provide a frontend based error for always_inline functions that require

Hi Eric, This is very nice! After the addition of this feature, LNT started crashing on x86_64h: FAIL: SingleSource/UnitTests/Vector/SSE/sse_expandfft.compile_time (3 of 2244) FAIL: SingleSource/UnitTests/Vector/SSE/sse_isamax.compile_time (4 of 2244) FAIL:

r249143 - [DarwinDriver] Reapply: Use -lto_library to specify the path for libLTO.dylib

Author: bruno Date: Fri Oct 2 10:10:33 2015 New Revision: 249143 URL: http://llvm.org/viewvc/llvm-project?rev=249143=rev Log: [DarwinDriver] Reapply: Use -lto_library to specify the path for libLTO.dylib Reapply r248935. Usually, when using LTO with a clang installation newer than the system's

r248935 - Revert "[DarwinDriver] Use -lto_library to specify the path for libLTO.dylib"

Author: bruno Date: Wed Sep 30 15:11:02 2015 New Revision: 248935 URL: http://llvm.org/viewvc/llvm-project?rev=248935=rev Log: Revert "[DarwinDriver] Use -lto_library to specify the path for libLTO.dylib" Revert r248932. Bots complaining about new warnings where they shouldn't. Modified:

r248932 - [DarwinDriver] Use -lto_library to specify the path for libLTO.dylib

Author: bruno Date: Wed Sep 30 14:55:07 2015 New Revision: 248932 URL: http://llvm.org/viewvc/llvm-project?rev=248932=rev Log: [DarwinDriver] Use -lto_library to specify the path for libLTO.dylib Usually, when using LTO with a clang installation newer than the system's one, there's a

Re: [PATCH] D13117: [DarwinDriver] Use -lto_library to specify the path for libLTO.dylib

bruno updated this revision to Diff 35664. bruno added a comment. Added test per Duncan's comment. Repository: rL LLVM http://reviews.llvm.org/D13117 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/Tools.cpp test/Driver/darwin-ld.c Index: test/Driver/darwin-ld.c

[PATCH] D13117: [DarwinDriver] Use -lto_library to specify the path for libLTO.dylib

bruno created this revision. bruno added a reviewer: dexonsmith. bruno added subscribers: cfe-commits, kledzik, bob.wilson. bruno set the repository for this revision to rL LLVM. Usually, when using LTO with a clang installation newer than the system one, there's a libLTO.dylib version mismatch

<    1   2   3   4   5   6