Re: [PATCH] Bug 15109: Implement -Wdouble-promotion for clang

2015-10-28 Thread Carl Norum via cfe-commits
e something > >> like "implicit conversion increases floating-point precision: %0 to %1"? > > > > Sure thing. > > > >> - Please get rid of the empty line after `else if (TargetBT->getKind() > > >> SourceBT->getKind()) {` > > > &g

Re: [PATCH] Bug 15109: Implement -Wdouble-promotion for clang

2015-10-28 Thread Carl Norum via cfe-commits
Will send a patch shortly. > >> After those are fixed, LGTM -- will you need me to commit this for you? > > I think so yes. > > -- Carl > > >> On Tue, Oct 27, 2015 at 9:45 PM, Carl Norum via cfe-commits >> wrote: >> Hi folks, >> >> I ha

Re: [PATCH] Bug 15109: Implement -Wdouble-promotion for clang

2015-10-28 Thread Carl Norum via cfe-commits
else if (TargetBT->getKind() > > SourceBT->getKind()) {` NP. Will send a patch shortly. > After those are fixed, LGTM -- will you need me to commit this for you? I think so yes. -- Carl > On Tue, Oct 27, 2015 at 9:45 PM, Carl Norum via cfe-commits > wrote: > Hi folks, >

[PATCH] Bug 15109: Implement -Wdouble-promotion for clang

2015-10-27 Thread Carl Norum via cfe-commits
Hi folks, I had need of this warning, so I cobbled something together. Can someone please check it out and let me know if it's reasonable? I'm certainly no expert at this stuff. Patch attached for review, thanks! -- Carl double-promotion.patch Description: Binary data ___