[clang] Reapply "[Clang][Sema] Earlier type checking for builtin unary operators (#90500)" (PR #92283)

2024-05-16 Thread Caslyn Tonelli via cfe-commits
Caslyn wrote: Hi @sdkrystian & @erichkeane - my apologies! Yes, indeed this code calls its own increment operator and it should be `++*this` - I failed to see that. Thanks for the feedback here and helping us fix this bug in our code. https://github.com/llvm/llvm-project/pull/92283

[clang] Reapply "[Clang][Sema] Earlier type checking for builtin unary operators (#90500)" (PR #92283)

2024-05-16 Thread Caslyn Tonelli via cfe-commits
Caslyn wrote: Hi @sdkrystian - this appears to break in a circumstance where a custom iterator class defines the postfix operator: ``` FAILED: host_x64/obj/src/lib/zbitl/tests/zbitl-unittests.mem-config-test.cc.o ../../prebuilt/third_party/clang/custom/bin/clang++ -MD -MF

[clang] [llvm] [openmp] [libcxx] [lld] [lto] Add minimum macos sdk requirement to test (PR #77695)

2024-01-29 Thread Caslyn Tonelli via cfe-commits
https://github.com/Caslyn closed https://github.com/llvm/llvm-project/pull/77695 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [openmp] [libcxx] [lld] [lto] Add minimum macos sdk requirement to test (PR #77695)

2024-01-29 Thread Caslyn Tonelli via cfe-commits
@@ -5,6 +5,8 @@ ; RUN: %ld64 -lto_library %llvmshlibdir/libLTO.dylib -dylib -arch x86_64 -macos_version_min 10.10.0 -o %t.dylib %t.o -save-temps -undefined dynamic_lookup -exported_symbol _bar -lSystem -mllvm -lto-discard-value-names=false ; RUN: llvm-dis

[llvm] [libcxx] [lld] [openmp] [clang] [lto] Add minimum macos sdk requirement to test (PR #77695)

2024-01-24 Thread Caslyn Tonelli via cfe-commits
@@ -5,6 +5,8 @@ ; RUN: %ld64 -lto_library %llvmshlibdir/libLTO.dylib -dylib -arch x86_64 -macos_version_min 10.10.0 -o %t.dylib %t.o -save-temps -undefined dynamic_lookup -exported_symbol _bar -lSystem -mllvm -lto-discard-value-names=false ; RUN: llvm-dis

[llvm] [openmp] [clang] [libcxx] [lld] [lto] Add minimum macos sdk requirement to test (PR #77695)

2024-01-11 Thread Caslyn Tonelli via cfe-commits
@@ -5,6 +5,8 @@ ; RUN: %ld64 -lto_library %llvmshlibdir/libLTO.dylib -dylib -arch x86_64 -macos_version_min 10.10.0 -o %t.dylib %t.o -save-temps -undefined dynamic_lookup -exported_symbol _bar -lSystem -mllvm -lto-discard-value-names=false ; RUN: llvm-dis

[openmp] [lld] [llvm] [libcxx] [clang] [lto] Add minimum macos sdk requirement to test (PR #77695)

2024-01-10 Thread Caslyn Tonelli via cfe-commits
https://github.com/Caslyn ready_for_review https://github.com/llvm/llvm-project/pull/77695 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[openmp] [lld] [llvm] [libcxx] [clang] [lto] Add minimum macos sdk requirement to test (PR #77695)

2024-01-10 Thread Caslyn Tonelli via cfe-commits
https://github.com/Caslyn updated https://github.com/llvm/llvm-project/pull/77695 >From 742c541068ff8764681c1546314c7b0bc5b2893a Mon Sep 17 00:00:00 2001 From: Caslyn Tonelli Date: Wed, 10 Jan 2024 14:16:25 -0800 Subject: [PATCH] [lto] Add minimum macos sdk requirement to test ---

[clang] [ASTMatchers] Fix classIsDerivedFrom for recusrive cases (PR #67307)

2023-09-25 Thread Caslyn Tonelli via cfe-commits
Caslyn wrote: Hi @sam-mccall - thank you, and apologies for the false alarm. After closer inspection, it looks like https://github.com/llvm/llvm-project/issues/66114#issuecomment-1732319259 explains the particular failures we're seeing. Indeed, no relation to this PR - please consider this

[clang] [ASTMatchers] Fix classIsDerivedFrom for recusrive cases (PR #67307)

2023-09-25 Thread Caslyn Tonelli via cfe-commits
Caslyn wrote: Hi @ilya-biryukov - it seems this PR caused a couple test failures in RecursiveASTVisitorTests/ on the Fuchsia windows-x64 builder. Could you take a look to verify whether an additional fix (or revert) is needed? [clang-windows-x64-test