Author: mcrosier
Date: Wed Apr 11 07:20:37 2018
New Revision: 329810
URL: http://llvm.org/viewvc/llvm-project?rev=329810=rev
Log:
[Driver] Don't forward -m[no-]unaligned-access options to GCC when
assembling/linking
Differential Revision: https://reviews.llvm.org/D45092
Modified:
Author: mcrosier
Date: Tue Apr 10 13:30:16 2018
New Revision: 329754
URL: http://llvm.org/viewvc/llvm-project?rev=329754=rev
Log:
[Driver] Handle the default case missed in r329748.
Differential Revision: https://reviews.llvm.org/D45499
Modified:
cfe/trunk/lib/Driver/ToolChains/NaCl.cpp
Author: mcrosier
Date: Wed Nov 29 08:42:44 2017
New Revision: 319323
URL: http://llvm.org/viewvc/llvm-project?rev=319323=rev
Log:
[Driver] Turns out the GNU assembler does support falkor/saphira.
Modified:
cfe/trunk/lib/Driver/ToolChains/Gnu.cpp
cfe/trunk/test/Driver/as-mcpu.c
Modified:
Hi Erik,
You might consider posting your patch to Phabricator. You'll likely get
more feedback/traction there..
https://llvm.org/docs/Phabricator.html
Chad
On 10/6/2017 8:15 AM, Erik Viktorsson via cfe-commits wrote:
Committing a patch to Bugzilla 31373
Author: mcrosier
Date: Thu Aug 24 07:32:55 2017
New Revision: 311660
URL: http://llvm.org/viewvc/llvm-project?rev=311660=rev
Log:
[Driver][AArch64] Add tests for RDM feature.
Differential Revision: https://reviews.llvm.org/D37106
Added:
cfe/trunk/test/Driver/aarch64-rdm.c
Added:
Author: mcrosier
Date: Tue Jan 10 12:55:11 2017
New Revision: 291582
URL: http://llvm.org/viewvc/llvm-project?rev=291582=rev
Log:
[ARM] Use generic bitreverse intrinsic, rather than ARM specific rbit.
The backend already supports lowering this intrinsic to a rbit instruction.
Modified:
Author: mcrosier
Date: Tue Jan 10 11:20:28 2017
New Revision: 291574
URL: http://llvm.org/viewvc/llvm-project?rev=291574=rev
Log:
[AArch64] Use generic bitreverse intrinsic, rather than AArch64 specific.
Differential Revision: https://reviews.llvm.org/D28400
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287037: [AArch64] Add driver tests for Qualcomm's Falkor
CPU. (authored by mcrosier).
Changed prior to commit:
https://reviews.llvm.org/D26674?vs=78002=78070#toc
Repository:
rL LLVM
Author: mcrosier
Date: Tue Nov 15 15:34:31 2016
New Revision: 287037
URL: http://llvm.org/viewvc/llvm-project?rev=287037=rev
Log:
[AArch64] Add driver tests for Qualcomm's Falkor CPU.
Differential Revision: https://reviews.llvm.org/D26674
Modified:
cfe/trunk/test/Driver/aarch64-cpus.c
mcrosier created this revision.
mcrosier added reviewers: rengolin, t.p.northover.
mcrosier added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
LLVM implementation here: https://reviews.llvm.org/D26673.
Chad
https://reviews.llvm.org/D26674
Files:
test/Driver/aarch64-cpus.c
Author: mcrosier
Date: Thu Jul 7 11:37:21 2016
New Revision: 274767
URL: http://llvm.org/viewvc/llvm-project?rev=274767=rev
Log:
Revert "[aarch64] Update datalayout for aarch64 tests"
This reverts commit r273289, which was a follow to r273280, which was
reverted because the change was not
Author: mcrosier
Date: Thu Jul 7 11:37:19 2016
New Revision: 274766
URL: http://llvm.org/viewvc/llvm-project?rev=274766=rev
Log:
Revert "[AArch64] Change the preferred alignment for char and short to word
alignment"
This reverts commit r273280 as the change was not properly approved.
mcrosier added a comment.
In http://reviews.llvm.org/D19827#419870, @mamai wrote:
> I think the blog comment is right. The pragma should make the loop unroll
> even in /Os. I think it is essential to allow the user to optimize some
> specific loops even if he generally wants to optimize for
Author: mcrosier
Date: Thu Feb 11 12:09:31 2016
New Revision: 260555
URL: http://llvm.org/viewvc/llvm-project?rev=260555=rev
Log:
[Driver] Add support for Qualcomm's Kryo CPU.
http://reviews.llvm.org/D17124
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/trunk/lib/Driver/Tools.cpp
mcrosier closed this revision.
mcrosier added a comment.
Committed r260555.
http://reviews.llvm.org/D17124
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mcrosier added a comment.
In http://reviews.llvm.org/D17124#350130, @rengolin wrote:
> I'm assuming you also have the LLVM counterpart?
Yes, but I haven't made them public just yet.
http://reviews.llvm.org/D17122
http://reviews.llvm.org/D17119
http://reviews.llvm.org/D17124
mcrosier accepted this revision.
mcrosier added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks, Frank.
http://reviews.llvm.org/D16966
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: mcrosier
Date: Tue Jan 26 09:46:29 2016
New Revision: 258813
URL: http://llvm.org/viewvc/llvm-project?rev=258813=rev
Log:
[Driver] Update FIXME comment now that PR4941 has been addressed.
The actual fix should be addressed by someone who can test on Darwin.
Modified:
Author: mcrosier
Date: Tue Jan 26 09:52:05 2016
New Revision: 258814
URL: http://llvm.org/viewvc/llvm-project?rev=258814=rev
Log:
[Driver] Make sure -fno-math-builtin option is being passed by the driver.
Support for the -fno-math-builtin option was added in r186899. The codegen side
is being
Author: mcrosier
Date: Tue Jan 26 10:16:53 2016
New Revision: 258815
URL: http://llvm.org/viewvc/llvm-project?rev=258815=rev
Log:
Revert "[Driver] Make sure -fno-math-builtin option is being passed by the
driver."
This reverts commit r258814.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
All,
In r258814 I upgraded the -fno-math-builtin option from a cc1 only option
to a full blown compiler option. However, after a bit of searching I
can't seem to find documentation of this actually being a supported option
by gcc. Therefore, I reverted the change. I can see the potential
mcrosier added a subscriber: mcrosier.
Comment at: cfe/trunk/include/clang/Driver/CC1Options.td:681
@@ -680,1 +680,3 @@
HelpText<"Enable function overloads based on CUDA target attributes.">;
+def fcuda_allow_variadic_functions : Flag<["-"],
"fcuda-allow-variadic-functions">,
mcrosier added inline comments.
Comment at: cfe/trunk/include/clang/Driver/CC1Options.td:681
@@ -680,1 +680,3 @@
HelpText<"Enable function overloads based on CUDA target attributes.">;
+def fcuda_allow_variadic_functions : Flag<["-"],
"fcuda-allow-variadic-functions">,
+
mcrosier added inline comments.
Comment at: cfe/trunk/include/clang/Driver/CC1Options.td:681
@@ -680,1 +680,3 @@
HelpText<"Enable function overloads based on CUDA target attributes.">;
+def fcuda_allow_variadic_functions : Flag<["-"],
"fcuda-allow-variadic-functions">,
+
mcrosier added a subscriber: mcrosier.
mcrosier added a comment.
Would it make sense to include an additional test (in test/Driver) that shows
the -fprofile-ir-instr option being passed from the driver to the frontend?
Such a test case would land in clang_f_opt.c, which has many examples.
Author: mcrosier
Date: Wed Jan 6 08:35:46 2016
New Revision: 256937
URL: http://llvm.org/viewvc/llvm-project?rev=256937=rev
Log:
[Driver] Add support for -fno-builtin-foo options.
Addresses PR4941 and rdar://6756912.
http://reviews.llvm.org/D15195
Modified:
mcrosier closed this revision.
mcrosier added a comment.
Committed in r256937. Thanks, Bob.
http://reviews.llvm.org/D15195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mcrosier accepted this revision.
mcrosier added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
http://reviews.llvm.org/D15749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: mcrosier
Date: Fri Dec 18 14:08:40 2015
New Revision: 256023
URL: http://llvm.org/viewvc/llvm-project?rev=256023=rev
Log:
Fix an unused variable warning from r256012.
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
URL:
Author: mcrosier
Date: Thu Dec 17 13:01:55 2015
New Revision: 255916
URL: http://llvm.org/viewvc/llvm-project?rev=255916=rev
Log:
[x86] Filecheck is case sensitive. Capitalize directives.
Modified:
cfe/trunk/test/CodeGen/avx512f-builtins.c
Modified:
Author: mcrosier
Date: Thu Dec 17 12:54:42 2015
New Revision: 255915
URL: http://llvm.org/viewvc/llvm-project?rev=255915=rev
Log:
[x86] Filecheck is case sensitive. Capitalize directives.
Modified:
cfe/trunk/test/CodeGen/avx512er-builtins.c
Modified:
mcrosier updated this revision to Diff 42854.
mcrosier added a comment.
Remove the FIXME, per Hal and Bob's request. I confirmed that gcc does not
warn for invalid -fno-builtin-foo options.
Also, pass the vector by reference and insert, rather than making an
unnecessary copy on the return in
mcrosier added a comment.
In http://reviews.llvm.org/D15195#307136, @hfinkel wrote:
> Can you use a StringSet instead of a vector and avoid all (most) of the code
> iterating over the vector of builtins being disabled?
Hi Hal,
I began converting the code to use StringSets, but I soon realized
mcrosier added a comment.
Ping.
http://reviews.llvm.org/D15195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mcrosier created this revision.
mcrosier added reviewers: majnemer, doug.gregor, ddunbar, chandlerc,
bob.wilson, rnk, krememek.
mcrosier added a subscriber: cfe-commits.
The changes adds support for -fno-builtin-foo options.
This addresses PR4941 and rdar://6756912.
Please take a look.
Chad
Author: mcrosier
Date: Mon Nov 23 15:05:04 2015
New Revision: 253914
URL: http://llvm.org/viewvc/llvm-project?rev=253914=rev
Log:
Fix a warning about commas at the end of enumerator lists.
Modified:
cfe/trunk/include/clang-c/Index.h
Modified: cfe/trunk/include/clang-c/Index.h
URL:
mcrosier added a comment.
@chandlerc: Adding Chandler in case he has an opinion on how to move forward or
how we could go about tuning the cold threshold.
http://reviews.llvm.org/D13304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mcrosier added a comment.
FWIW, a llvm based solution was discussed in http://reviews.llvm.org/D12979,
but the clang solution is obviously more robust and easier to implement.
Comment at: lib/CodeGen/CodeGenFunction.h:287
@@ +286,3 @@
+ // True if the current insertion point
38 matches
Mail list logo
