[PATCH] D159213: [AIX][ClangRepl] Disable new tests on AIX

shchenz accepted this revision. shchenz added a comment. LGTM. Thanks for fixing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159213/new/ https://reviews.llvm.org/D159213 ___ cfe-commits mailing list

[PATCH] D156076: [PowerPC][Clang] Remove constraint for initial-exec TLS mode on AIX

shchenz accepted this revision as: shchenz. shchenz added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156076/new/ https://reviews.llvm.org/D156076 ___ cfe-commits mailing list

[PATCH] D156344: Disable call to fma for soft-float

shchenz added a comment. In D156344#4583767 , @long5hot wrote: > In D156344#4583559 , @shchenz wrote: > >> compiler-rt builtins library should not just undefining fma for PPC, right >> (see >>

[PATCH] D156344: Disable call to fma for soft-float

shchenz added a comment. compiler-rt builtins library should not just undefining fma for PPC, right (see https://gcc.gnu.org/onlinedocs/gccint/Soft-float-library-routines.html)? If so, maybe we should at least first try not generating fma for soft-float at the first place where fmul + fadd is

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz added a comment. > What is left for this to be reverted, in the quest to fully enable IAS for > AIX? See `XCOFFAsmParser::ParseDirectiveCSect()` and I think qual symbol names in AIX assembly(quite common for AIX assembly) can also not be parsed with llvm's asm parser. Repository:

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

shchenz added a comment. Seems passing `-Wl,-bplugin_opt:-no-integrated-as=1` from clang driver does not work as expected. Is this expected or by design(We can only use -fno-integrated-as but no -Wl,-bplugin_opt:-no-integrated-as=1)? clang -flto -Wl,-bplugin_opt:-no-integrated-as=1 *.c -v

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

shchenz added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:700 +CmdArgs.push_back(Args.MakeArgString( +Twine(PluginOptPrefix) + "-no-integrated-as=" + NoIntegratedAs)); + else if (!UseIntegratedAs) { qiongsiwu1 wrote: >

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

shchenz added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:700 +CmdArgs.push_back(Args.MakeArgString( +Twine(PluginOptPrefix) + "-no-integrated-as=" + NoIntegratedAs)); + else if (!UseIntegratedAs) { qiongsiwu1 wrote: >

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

shchenz added a comment. @qiongsiwu1 Hi, thanks for the patch. Almost good to me, except one small nit. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:700 +CmdArgs.push_back(Args.MakeArgString( +Twine(PluginOptPrefix) + "-no-integrated-as=" +

[PATCH] D148490: [AIX] use system assembler for assembly files

This revision was automatically updated to reflect the committed changes. Closed by commit rG4b27ad735c8d: [AIX] use system assembler for assembly files (authored by shchenz). Changed prior to commit: https://reviews.llvm.org/D148490?vs=521233=528257#toc Repository: rG LLVM Github Monorepo

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz added inline comments. Comment at: clang/test/Driver/target-as.s:1 // Make sure the -march is passed down to cc1as. // RUN: %clang -target i386-unknown-freebsd -### -c -integrated-as %s \ MaskRay wrote: > shchenz wrote: > > MaskRay wrote: > > >

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz added inline comments. Comment at: clang/test/Driver/target-as.s:1 // Make sure the -march is passed down to cc1as. // RUN: %clang -target i386-unknown-freebsd -### -c -integrated-as %s \ MaskRay wrote: > aix-as.c will be more appropriate. Do you mean

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148490/new/ https://reviews.llvm.org/D148490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D150758: [AIX] make integrated-as as default on AIX.

shchenz added inline comments. Comment at: llvm/lib/MC/MCAsmInfoXCOFF.cpp:55 HasDotTypeDotSizeDirective = false; - UseIntegratedAssembler = false; + UseIntegratedAssembler = true; ParseInlineAsmUsingAsmParser = true; brad wrote: > Instead of setting the

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz added a comment. > I am not sure you need 6 RUN lines to test this. Whether a target uses > integrated assembler has an existing test file and you can reuse that. I don't have strong prefer which one we should use, a new file or reuse file. Since you point out, I change to reuse a

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz updated this revision to Diff 521233. shchenz added a comment. update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148490/new/ https://reviews.llvm.org/D148490 Files: clang/lib/Driver/ToolChain.cpp clang/test/Driver/target-as.s

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz added a comment. gentle ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148490/new/ https://reviews.llvm.org/D148490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D150181: [XCOFF][DWARF] XCOFF64 should be able to select the dwarf version under intergrated-as mode.

shchenz accepted this revision as: shchenz. shchenz added a comment. This revision is now accepted and ready to land. I think this is correct. DWARF spec indicates that DWARF64 should not be set as default. So it is right to change to DWARF32 by default for integrated-as mode for XCOFF64. LGTM

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz added a comment. gentle ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148490/new/ https://reviews.llvm.org/D148490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz updated this revision to Diff 517011. shchenz added a comment. address @qiucf comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148490/new/ https://reviews.llvm.org/D148490 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148490/new/ https://reviews.llvm.org/D148490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz created this revision. shchenz added reviewers: hubert.reinterpretcast, nemanjai, PowerPC. shchenz added a project: LLVM. Herald added a project: All. shchenz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Change to system

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

shchenz added a comment. I think this is a good direction. For example we can avoid the crash in https://github.com/llvm/llvm-project/issues/60959 and give a clear diagnostic message. However, manually adding the required target feature seems a little mistakable, like the one below. I guess

[PATCH] D140544: [DebugInfo] make DW_LANG_C11 respect -gstrict-dwarf

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. shchenz marked an inline comment as done. Closed by commit rGb1d7010caa43: [DebugInfo] make DW_LANG_C11 respect -gstrict-dwarf (authored by shchenz). Repository: rG

[PATCH] D140544: [DebugInfo] make DW_LANG_C11 respect -gstrict-dwarf

shchenz marked an inline comment as done. shchenz added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:582 } else if (LO.C11) { -LangTag = llvm::dwarf::DW_LANG_C11; +if (CGO.DebugStrictDwarf && CGO.DwarfVersion < 5) + LangTag =

[PATCH] D140544: [DebugInfo] make DW_LANG_C11 respect -gstrict-dwarf

shchenz updated this revision to Diff 484994. shchenz added a comment. address @dblaikie comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140544/new/ https://reviews.llvm.org/D140544 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D140544: [DebugInfo] make DW_LANG_C11 respect -gstrict-dwarf

shchenz created this revision. shchenz added reviewers: dblaikie, probinson, aprantl. shchenz added a project: LLVM. Herald added a project: All. shchenz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D138105: [PowerPC] Support test data class intrinsic of 128-bit float

shchenz accepted this revision as: shchenz. shchenz added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138105/new/ https://reviews.llvm.org/D138105

[PATCH] D138105: [PowerPC] Support test data class intrinsic of 128-bit float

shchenz added a comment. The error message needs to be updated too: def err_ppc_invalid_test_data_class_type : Error< "expected a 'float' or 'double' for the first argument">; And can we add a test case for ibm float128 in the clang? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

shchenz accepted this revision. shchenz added a comment. This revision is now accepted and ready to land. LGTM except one minor in the testcase. Thanks for adding this improvement. Comment at: clang/test/Driver/debug-options.c:121 // RUN: %clang -### -c -g %s -target

[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

shchenz added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.h:91 llvm::DebuggerKind getDefaultDebuggerTuning() const override { -return llvm::DebuggerKind::DBX; +return llvm::DebuggerKind::Default; } This sounds not right. Omitting

[PATCH] D135908: [clang][LTO] Setting Desired Default AIX Debugging Options

shchenz accepted this revision. shchenz added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:588 +else if (A->getOption().matches(options::OPT_ggdb) || +

[PATCH] D135908: [clang][LTO] Setting Desired Default AIX Debugging Options

shchenz added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:589 + // On platforms other than AIX, gdb is the default option. + // On AIX, dbx will be automatically pick up in the presense of the + // debugger tuning argument, so set gdb

[PATCH] D133488: [clang][PowerPC][NFC] Add base test case for PPC64 VAArg aggregate smaller than a slot

shchenz accepted this revision. shchenz added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133488/new/ https://reviews.llvm.org/D133488

[PATCH] D131953: [PowerPC][Coroutines] Add tail-call check with context information for coroutines

shchenz accepted this revision as: shchenz. shchenz added a comment. This LGTM. Although `supportsTailCallFor` is not completely equal to how PPC backend checks tail call support, we can continuously improve this when we have more caller of `supportsTailCallFor()` in future. Repository: rG

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

shchenz added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:10744 +Store = DAG.getStore( +Op->getOperand(0), DL, +DAG.getNode(ISD::XOR, DL, VT, Load, DAG.getAllOnesConstant(DL, VT)), Nit: Maybe we need to set the

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

shchenz added inline comments. Comment at: clang/test/CodeGen/PowerPC/builtins-ppc-stackprotect.c:11 +// RUN: FileCheck %s +// RUN: %clang_cc1 -O2 -triple powerpc64-unknown-aix \ +// RUN: -emit-llvm %s -o - -target-cpu pwr7 | \ nit: do we need -O2?

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

shchenz accepted this revision as: shchenz. shchenz added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127189/new/ https://reviews.llvm.org/D127189

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

shchenz added inline comments. Comment at: clang/include/clang/Driver/Options.td:3611 HelpText<"Enable the default Altivec ABI on AIX (AIX only). Uses only volatile vector registers.">; +def maix_quadword_atomics : Flag<["-"], "maix64-quadword-atomics">, + Group,

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

shchenz added a comment. Thanks for the explanation. I am more clear now about the background. Comment at: clang/include/clang/Driver/Options.td:3611 HelpText<"Enable the default Altivec ABI on AIX (AIX only). Uses only volatile vector registers.">; +def

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

shchenz added a comment. Can we use the feature bit `FeatureQuadwordAtomic` to decide whether QuadAtomic is supported or not on AIX? Like what we do for Linux. The reason we need this option is: we may need to compile a lock free libatomic on a Power7 or below target? If so, do we have similar

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

shchenz accepted this revision as: shchenz. shchenz added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the enablement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129461/new/ https://reviews.llvm.org/D129461

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

shchenz added a comment. Seems current revision is not right. You select the wrong base commit when you create the diff? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129016/new/ https://reviews.llvm.org/D129016

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

shchenz added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:232 +path::remove_filename(P); +addSystemInclude(DriverArgs, CC1Args, P); } qiucf wrote: > shchenz wrote: > > Can we use `path::parent_path(P)` directly in

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

shchenz added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:232 +path::remove_filename(P); +addSystemInclude(DriverArgs, CC1Args, P); } Can we use `path::parent_path(P)` directly in `addSystemInclude()`? `remove_filename()` sounds

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

shchenz added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:226 + // Add the PowerPC intrinsic headers (/include/ppc_wrappers) + if (!DriverArgs.hasArg(clang::driver::options::OPT_nostdinc) && + !DriverArgs.hasArg(options::OPT_nobuiltininc)) {

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

shchenz added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:170 + ppc_wrappers/immintrin.h + ppc_wrappers/tmmintrin.h + ppc_wrappers/x86intrin.h chapuni wrote: > It doesn't contain , forgot? @qiucf Looks like an error here? Repository: rG

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

shchenz added a comment. Sorry, I am really not familiar with these FE stuffs. Need approval from other reviewers who know more about this part. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:522 EmitCXXThreadLocalInitFunc(); + if (getTriple().isOSAIX()) { +

[PATCH] D128652: [PowerPC] Finished kill_canary implementation and debugging

shchenz added a comment. Please make sure the patch is able to compile first. I fixed two build failures, it still fails : ( Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:221 + def int_ppc_kill_canary + : GCCBuiltin<"__builtin_ppc_kill_canary">, +

[PATCH] D125916: [PowerPC] Defined and lowered llvm.ppc.kill.canary intrinsic

shchenz added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:11136 +MachineFrameInfo = MF.getFrameInfo(); +int SPI = MFI.getStackProtectorIndex(); // should return -1 + Why should return -1? Comment at:

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

shchenz added a comment. Thanks for doing this. I am not familiar with the frontend, so I may be wrong/stupid in the follow comments : ) Hope other experts like @hubert.reinterpretcast can give more meaningful comments. I tested on AIX, seems for static variable `static int x = foo();` in

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

shchenz added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:519 .Default(false); + Features["crbits"] = llvm::StringSwitch(CPU) +.Case("ppc64le", true) shchenz wrote: > nemanjai

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

shchenz added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:519 .Default(false); + Features["crbits"] = llvm::StringSwitch(CPU) +.Case("ppc64le", true) nemanjai wrote: > shchenz

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

shchenz accepted this revision as: shchenz. shchenz added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing. Comment at: clang/lib/Basic/Targets/PPC.cpp:519 .Default(false); + Features["crbits"] =

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

shchenz added a comment. > This patch turns on support for CR bit accesses for Power8 and above. The > reason why CR bits are turned on as the default for Power8 and above is that > because later architectures make use of builtins and instructions that > require CR bit accesses (such as the

[PATCH] D123372: [PowerPC] add XLC compat builtin __abs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c776c70a76e: [PowerPC] add XLC compat builtin __abs (authored by shchenz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123372: [PowerPC] add XLC compat builtin __abs

shchenz added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123372/new/ https://reviews.llvm.org/D123372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123372: [PowerPC] add XLC compat builtin __abs

shchenz created this revision. shchenz added reviewers: stefanp, nemanjai, jsji, qiucf, PowerPC. Herald added a subscriber: kbarton. Herald added a project: All. shchenz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is supplement

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

shchenz accepted this revision as: shchenz. shchenz added a comment. This revision is now accepted and ready to land. Herald added a project: All. LGTM. Two nits about the comments and tests. Please wait for some days in case other reviews have some comments. Comment at:

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

shchenz added a comment. > hiding the semantics from the optimizer is sometimes a good thing and > sometimes a bad thing). Agree. Imagining a case when the neg and fma (from fnmsub) can both be CSE-ed with another neg and fma, so we can totally eliminate the fnmsub. But after we convert it to

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

shchenz accepted this revision. shchenz added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the explanation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

shchenz added a comment. Look almost good! Thanks for doing this. Comment at: clang/test/ASTMerge/codegen-body/test.c:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: %clang_cc1 -emit-pch -o %t.1.ast %S/Inputs/body1.c Jake-Egan wrote: > shchenz wrote: > > Do we

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

shchenz added inline comments. Comment at: clang/test/ASTMerge/anonymous-fields/test.cpp:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: %clang_cc1 -emit-pch -o %t.1.ast %S/Inputs/anonymous-fields1.cpp Do we still need this? `-emit-obj` is already excluded?

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

shchenz added a comment. In D115503#3199459 , @Esme wrote: > In D115503#3195171 , @dblaikie > wrote: > >> Ah, cool - could you include % growth on those rows > > Thanks, I edited the table in the previous

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

shchenz added inline comments. Comment at: clang/test/ClangScanDeps/modules-full-by-mod-name.cpp:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: rm -rf %t.dir Jake-Egan wrote: > jsji wrote: > > there is no `fmodule-format=obj` here, why are we failing here? > > >

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

shchenz accepted this revision as: shchenz. shchenz added a comment. This revision is now accepted and ready to land. Thanks for fixing this. LGTM. Please wait for @dblaikie comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115503/new/

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

shchenz added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-access.cpp:28 +class C { +public: Esme wrote: > dblaikie wrote: > > shchenz wrote: > > > Will we generate a redundant flag if we define a private type in the > > > class or a public

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

shchenz added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-access.cpp:28 +class C { +public: Will we generate a redundant flag if we define a private type in the class or a public type in the struct/union? Maybe we could add a case for that

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

shchenz added a comment. This seems not right. Now we disable too many debug cases for object mode even for 32bit target. Maybe we should test clang (built with `--default-target-triple=powerpc64-ibm-aix`) after our backend support 64-bit object mode(`-filetype=obj`) Repository: rG LLVM

[PATCH] D111336: [AIX] Disable tests failing due to missing DWARF sections

shchenz accepted this revision. shchenz added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111336/new/ https://reviews.llvm.org/D111336

[PATCH] D111169: [AIX] Disable tests failing due to assert on DWARF object writing

shchenz added a comment. In D69#3048311 , @Jake-Egan wrote: > In D69#3047761 , @shchenz wrote: > >> Thanks for working on this. >> >> Could you please help to rerun the affected cases after applying

[PATCH] D111169: [AIX] Disable tests failing due to assert on DWARF object writing

shchenz added a comment. Thanks for working on this. Could you please help to rerun the affected cases after applying D97184 ? That patch is approved and I will deliver it soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105512: [AIX] Don't pass no-integrated-as by default

shchenz accepted this revision. shchenz added a comment. This revision is now accepted and ready to land. LGTM. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105512/new/ https://reviews.llvm.org/D105512

[PATCH] D105512: [AIX] Don't pass no-integrated-as by default

shchenz added a comment. I think it is ok to not passing `-no-integrated-as` to cc1 as the default value for backend for XCOFF is no integrated assembler. Can we make the logic be simpler here? Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5043 + // option to disable

[PATCH] D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

shchenz accepted this revision. shchenz added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104118/new/ https://reviews.llvm.org/D104118

[PATCH] D104291: [Debug-Info] strict dwarf for DW_LANG_C_plus_plus_14

shchenz added a comment. In D104291#2821581 , @stuart wrote: >> There is no `CPlusPlus03` in `LangOptions`, so it is better not to merge >> `DW_LANG_C_plus_plus_03` support with D99250 >> . > > Oh - I see, `c++03` is

[PATCH] D104291: [Debug-Info] strict dwarf for DW_LANG_C_plus_plus_14

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4590b406c02e: [Debug-Info] guard DW_LANG_C_plus_plus_14 under strict dwarf (authored by shchenz). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D104291: [Debug-Info] strict dwarf for DW_LANG_C_plus_plus_14

shchenz added a comment. Thanks for review @stuart In D104291#2819398 , @stuart wrote: > This looks good to me. > > @jzzheng22 informs me there was a comment in D99250 > to the effect that DW_LANG_C_plus_plus_03 > is

[PATCH] D104291: [Debug-Info] strict dwarf for DW_LANG_C_plus_plus_14

shchenz created this revision. shchenz added reviewers: dblaikie, aprantl, Esme, stuart, PowerPC. shchenz added a project: debug-info. shchenz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This partially reverts the change in

[PATCH] D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

shchenz added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:579 LangTag = llvm::dwarf::DW_LANG_ObjC; + } else if (LO.OpenCL && CGM.getCodeGenOpts().DwarfVersion >= 5) { +LangTag = llvm::dwarf::DW_LANG_OpenCL; stuart wrote: > shchenz

[PATCH] D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

shchenz added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:579 LangTag = llvm::dwarf::DW_LANG_ObjC; + } else if (LO.OpenCL && CGM.getCodeGenOpts().DwarfVersion >= 5) { +LangTag = llvm::dwarf::DW_LANG_OpenCL; I think for non-strict

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz added a comment. Thanks for your review! @dblaikie @aprantl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100630/new/ https://reviews.llvm.org/D100630 ___ cfe-commits mailing list

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

This revision was automatically updated to reflect the committed changes. Closed by commit rG99d45ed22fd9: [Debug-Info] handle DW_TAG_rvalue_reference_type at strict DWARF. (authored by shchenz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz requested review of this revision. shchenz added a comment. OK, thanks David @dblaikie . Ping for your comments, we need some discussion here to decide we should fix this in FE or BE. See more in https://reviews.llvm.org/D100630#2762354 @aprantl @probinson and other reviewers ^- ^

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz added a comment. @dblaikie Hi David, should we change to use the FE solution? Maybe we should fix the issue where it happens? We should not let the FE generate the un-strict dwarf tag in FE and then fix it in the BE. I have changed this patch to fix this strict DWARF issue in FE. What

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz updated this revision to Diff 346680. shchenz added a comment. 1: use the solution in the FE Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100630/new/ https://reviews.llvm.org/D100630 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz added a comment. In D100630#2760972 , @dblaikie wrote: > This isn't the sort of thing I'd like to leave to a FIXME later - seems like > the sort of thing we shouldn't create now to fix later. > > @aprantl mind having a second look at this to

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz added a comment. Thanks for your comments! @dblaikie @aprantl . I think we have an agreement that we should handle the strict dwarf tag in the backend. And for duplicated tags issue, since it may need a while to fix, I have added a TODO in the code change and also update to test case

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz updated this revision to Diff 345333. shchenz added a comment. 1: add the FIXME for the duplicated tags issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100630/new/ https://reviews.llvm.org/D100630 Files:

[PATCH] D100826: [Debug-Info][NFC] add -gstrict-dwarf support in backend

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0ca4c46ca35: [Debug-Info] add -gstrict-dwarf support in backend (authored by shchenz). Changed prior to commit: https://reviews.llvm.org/D100826?vs=339840=345022#toc Repository: rG LLVM Github

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:398-399 + +// Assertion for other cases. +assert(true && "Tag is generated not following strict DWARF!"); + } dblaikie wrote: > side note: Not sure what this assertion

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz updated this revision to Diff 344300. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100630/new/ https://reviews.llvm.org/D100630 Files: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp llvm/test/DebugInfo/PowerPC/strict-dwarf-tags.ll Index:

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz added a comment. In D100630#2749594 , @dblaikie wrote: > In D100630#2749550 , @shchenz wrote: > >> In D100630#2748899 , @dblaikie >> wrote: >> >>> Does this

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz added a comment. In D100630#2748899 , @dblaikie wrote: > Does this cause duplicate DW_TAG_reference_types in the output, if the input > IR Has both DW_TAG_reference_type and DW_TAG_rvalue_reference_types? Yes, it will cause such issue in

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz updated this revision to Diff 344269. shchenz marked an inline comment as done. shchenz added a comment. 1: address @dblaikie comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100630/new/ https://reviews.llvm.org/D100630 Files:

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz added a comment. In D100630#2745272 , @dblaikie wrote: > Mixed feelings - is this the only place where we're changing behavior for > strict-DWARF in the frontend/clang? (maybe it'd be better to do it all in the > same place, down in the backend

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz updated this revision to Diff 343983. shchenz added a comment. Herald added subscribers: llvm-commits, hiraditya, nemanjai. Herald added a project: LLVM. update according to @dblaikie comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz added a comment. gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100630/new/ https://reviews.llvm.org/D100630 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D100826: [Debug-Info][NFC] add -gstrict-dwarf support in backend

shchenz updated this revision to Diff 339840. shchenz added a comment. 1: put test cases in single file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100826/new/ https://reviews.llvm.org/D100826 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D100809: [Debug-Info] implement -gstrict-dwarf

This revision was automatically updated to reflect the committed changes. Closed by commit rG26f138eed4af: [Debug-Info] implement -gstrict-dwarf (authored by shchenz). Changed prior to commit: https://reviews.llvm.org/D100809?vs=338752=339464#toc Repository: rG LLVM Github Monorepo CHANGES

  1   2   >