[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous added a comment. Ping @rsmith @dblaikie @MaskRay @Xiangling_L @lebedev.ri Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 ___ cfe-commits mailing list cf

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous added a comment. Ping @rsmith @dblaikie @MaskRay @Xiangling_L @lebedev.ri Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 ___ cfe-commits mailing list cf

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous added a comment. Ping @rsmith @dblaikie @MaskRay @haowei @Xiangling_L @lebedev.ri Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 ___ cfe-commits mailing

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous added a comment. Ping @rsmith @dblaikie @MaskRay @haowei @Xiangling_L @lebedev.ri Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 ___ cfe-commits mailing

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous added a comment. Ping @rsmith @dblaikie @MaskRay @haowei @Xiangling_L @lebedev.ri Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 ___ cfe-commits mailing

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:10117 +TSK == TSK_ExplicitInstantiationDefinition && Prev && +!Context.hasSameTypeIgnoreLifetime(Prev->getType(), R)) { + Diag(T->getTypeLoc().getBeginLoc(), nomanous

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous marked an inline comment as done. nomanous added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:10111-10124 +// Check the static member's type given in the explicit instantiation +// definition against the one in the class template. This won't happe

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous marked 3 inline comments as done. nomanous added a comment. Ping @rsmith @dblaikie @MaskRay @haowei @Xiangling_L @lebedev.ri Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous updated this revision to Diff 317299. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaTemplate.cpp clang/test/SemaCXX/

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous added a comment. In D90448#2504022 , @condy wrote: > The tests failed though Which? Do you mean the unit test? It seems to be irrelevant with this revision. This revision doesn't change the code covered by that test. The failure should be cause

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous added a comment. In D90448#2500829 , @lebedev.ri wrote: > Tests missing I mistakenly missed that file in the last commit. I'll add it soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous added a comment. Ping @rsmith @dblaikie Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous added a comment. Ping @rsmith @chandlerc @majnemer @aaron.ballman @dblaikie Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 ___ cfe-commits mailing list

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous updated this revision to Diff 303749. nomanous added a comment. Some more format fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 Files: clang/include/clang/AST/ASTContext.h clang/include

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous updated this revision to Diff 303712. nomanous added a comment. Some format fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 Files: clang/include/clang/AST/ASTContext.h clang/include/clan

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous updated this revision to Diff 303709. nomanous added a comment. In this update I delete some extra test code, move several comments and split the new type comparing code into a new function to make sure that the commonly used old type comparing function not affected by it. Repository:

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous added a comment. In D90448#2376710 , @dblaikie wrote: > How's this compare to the similar checks for variable templates? Is there > some code/checking we could share here? The code of checks for variable templates is just before the additional c

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous added a comment. Ping @rsmith @chandlerc @majnemer @lvoufo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous added a comment. Does anyone know why Harbormaster doesn't rebuild this revision after I update it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 ___

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous updated this revision to Diff 301872. nomanous added a comment. Change some format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Basic/DiagnosticSemaKinds.td clang

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous created this revision. nomanous added reviewers: rsmith, chandlerc, Eugene.Zelenko, majnemer, lvoufo. Herald added a project: clang. Herald added a subscriber: cfe-commits. nomanous requested review of this revision. Add type check for explicit instantiation of template classes' static da

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

nomanous added a comment. In D87962#2312617 , @aaron.ballman wrote: > LGTM! Do you need someone to commit on your behalf? Yes I need! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87962/new/ https://reviews.llvm.org/D87962 ___

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

nomanous updated this revision to Diff 296118. nomanous added a comment. In this revision I delete the useless main function in the new test case and rename ext_multichar_character_literal & ext_four_char_character_literal to warn_multichar_character_literal & warn_four_char_character_literal.

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

nomanous updated this revision to Diff 295771. nomanous added a comment. I restore some needless modification in the previous patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87962/new/ https://reviews.llvm.org/D87962 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

nomanous updated this revision to Diff 295766. nomanous added a comment. I change the four-char constants back to "Warning" in this revision, but set it to be ignored by default. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87962/new/ https://reviews.llvm.org/D87962 Files: clang/in

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

nomanous updated this revision to Diff 295559. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87962/new/ https://reviews.llvm.org/D87962 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang/test/CXX/lex/lex.literal/lex.ccon/p1.cpp clang/test/FixIt/format.m clang/test/Lexer

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

nomanous added a comment. In D87962#2298021 , @aaron.ballman wrote: > Multichar literals are implementation-defined in C and conditionally > supported with implementation-defined semantics in C++. I agree that it may > make sense to warn about their use

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

nomanous added a comment. Ping @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87962/new/ https://reviews.llvm.org/D87962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

nomanous created this revision. nomanous added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. nomanous requested review of this revision. The multi-character character constants should be implementation-defined according to the C standard but actually w