[PATCH] D122425: Pass -disable-llvm-passes to avoid running llvm passes

xbolva00 added a comment. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122425/new/ https://reviews.llvm.org/D122425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types.

xbolva00 added a comment. >> Maybe we should try improve our tooling to detect violations in parallel to >> the effort in this patch? I am planning on trying to resurrect the >> type-sanitizer patches. I've also been playing around with a simple tool >> that's inserting assertions to check 2 po

[PATCH] D122077: [InstCombine] Fold (ctpop(X) == 1) | (X == 0) into ctpop(X) < 2

xbolva00 added a comment. In D122077#3413550 , @joerg wrote: > Why is this fold preferable to `(X & (X-1)) == 0`? At least on all > architectures without native population count, the binary-and based test is > preferable and it might even be better with

[PATCH] D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types.

xbolva00 added a comment. Can you put provide some flag? Or -fstrict-aliasing controls this generation? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122573/new/ https://reviews.llvm.org/D122573 ___ cfe

[PATCH] D122271: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators

xbolva00 added a comment. In D122271#3413193 , @uabelho wrote: > Hi, > > I noticed these to warning when compiling libunwind/src/UnwindLevel1.c with > this patch: > > 00:22:48 > /repo/bbiswjenk/fem2s10-eiffel176/workspace/llvm/sdk_1_20_ki_dev_test/lib

[PATCH] D122425: Pass -disable-llvm-passes to avoid running llvm passes

xbolva00 added a comment. You should answer any review comments before any commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122425/new/ https://reviews.llvm.org/D122425 ___ cfe-commits mailing list

[PATCH] D122425: Pass -disable-llvm-passes to avoid running llvm passes

xbolva00 added inline comments. Comment at: clang/test/CodeGenCXX/nrvo.cpp:2 // NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py -// RUN: %clang_cc1 -triple i386-unknown-unknown -emit-llvm -O1 -o - %s | FileCheck %s -// RUN: %clang_cc1 -triple i386-unk

[PATCH] D122271: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators

xbolva00 added a comment. In D122271#3408060 , @kamaub wrote: > This option appears to incorrectly warn warning that `unsigned NumEntries = > getNumEntries();` is "set but not used" in > llvm/include/llvm/ADT/DenseMap.h:129 >

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

xbolva00 added a comment. In D100581#3404624 , @xbolva00 wrote: > @mbenfield found false positive > > void test(void) { > static int counter = 0; > counter += 5; > } posted https://reviews.llvm.org/D122374 Repository: rG LLVM Github Monor

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

xbolva00 added a comment. Herald added subscribers: pcwang-thead, luke957. Herald added a project: All. @mbenfield found false positive void test(void) { static int counter = 0; counter += 5; } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D122271: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators

This revision was automatically updated to reflect the committed changes. Closed by commit rG460fc440ad8d: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators (authored by xbolva00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D121593: [clangd][WIP] Provide clang-include-cleaner

xbolva00 added a comment. This sounds really cool! >> Overall I suspect making this a tidy check would make it more useful to more >> people. Yup, it would be super useful addition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121593/new/ https

[PATCH] D122271: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators

xbolva00 created this revision. xbolva00 added reviewers: efriedma, yonghong-song. Herald added a project: All. xbolva00 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang fails to diagnose: void test() { int j = 0; for (i

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

xbolva00 added a comment. >> the remaining changes are code formatting Please remove code formatting changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122248/new/ https://reviews.llvm.org/D122248 _

[PATCH] D121715: [Clang] Fix an unused-but-set-variable warning with volatile variable

xbolva00 added a comment. void test() { int j = 0; for (int i = 0; i < 1000; i++) j++; return; } Should not we warn in this case? (Currently no warning) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121715/new/

[PATCH] D121715: [Clang] Fix an unused-but-set-variable warning with volatile variable

xbolva00 added a comment. >> This is not quite right since 'j' is indeed used due to '+=' operator. is “set” - load, increment, store - but not used after “store”. So technically this is okay no? If there is j = j + 1 .. do we warn ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D122029: Change __auto_type behavior with qualifiers to match GCC behavior

xbolva00 added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:10294 +} +if (const auto *AT = LHS->getAs()) { + if (AT->isGNUAutoType()) Same? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122029/new/ https://reviews.llvm.org/D12

[PATCH] D122077: [InstCombine] Fold (ctpop(X) == 1) | (X == 0) into ctpop(X) < 2

xbolva00 added inline comments. Comment at: llvm/test/Transforms/InstCombine/ispow2.ll:538 ; Negative test - wrong predicate (but this could reduce). hkmatsumoto wrote: > xbolva00 wrote: > > Now reduced. > Since this is almost the first time contributing to

[PATCH] D122077: [InstCombine] Fold (ctpop(X) == 1) | (X == 0) into ctpop(X) < 2

xbolva00 added inline comments. Comment at: llvm/test/Transforms/InstCombine/icmp-or.ll:371 + +define i1 @ctpop_or_eq_to_ctpop(i32 %0) { +; CHECK-LABEL: @ctpop_or_eq_to_ctpop( Please add a test with vector type. Comment at: llvm/test/Transforms

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

xbolva00 added a comment. Why this should be maintained and developed by LLVM/Clang developers and not by Chromium? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121797/new/ https://reviews.llvm.org/D121797 ___

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

xbolva00 added a comment. Add Clang release note as well please. Comment at: clang/docs/MisExpect.rst:58 + Relaxes misexpect checking to tolerate profiling values within N% of the + expected branch weight. e.g., a vlaue of ``N=5`` allows misexpect to check against + ``0

[PATCH] D121896: [Clang] Added info about noinline/always_inline statement attributes to release notes

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb2f2fecc151: [Clang] Added info about noinline/always_inline statement attributes to release… (authored by xbolva00). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

xbolva00 added a comment. Herald added a project: All. In D120305#3347191 , @MaskRay wrote: > In D120305#3347177 , @nikic wrote: > >> Yes, because you reverted the change for that one buildbot, of course it is >>

[PATCH] D120717: [Clang] always_inline statement attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG003c0b9307bc: [Clang] always_inline statement attribute (authored by xbolva00). Herald added a project: clang. Herald added a subscriber: cfe-commit

[PATCH] D121586: [Clang][VE] Add the rest of intrinsics to clang

xbolva00 added inline comments. Comment at: clang/include/clang/Basic/BuiltinsVEVL.gen.def:35 +// TODO: Vector mask registers +// Depend on https://reviews.llvm.org/D88905 +// BUILTIN(__builtin_ve_vl_vst_vssml, "vV256dLUiv*V256bUi", "n") Why leave dead code under

[PATCH] D121374: [flang][driver] Add support for `-mllvm`

xbolva00 added inline comments. Comment at: flang/test/Driver/mllvm.f90:1 +! Test the `-mlvm` option + awarzynski wrote: > xbolva00 wrote: > > mllvm > Does it matter? `-mllvm` is consistent with other tests in this directory > (e.g. > https://github.com/llvm/ll

[PATCH] D121374: [flang][driver] Add support for `-mllvm`

xbolva00 added inline comments. Comment at: flang/test/Driver/mllvm.f90:1 +! Test the `-mlvm` option + mllvm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121374/new/ https://reviews.llvm.org/D121374

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

xbolva00 added a comment. Please also consider https://github.com/llvm/llvm-project/issues/46534 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115907/new/ https://reviews.llvm.org/D115907 ___ cfe-commits

[PATCH] D119061: [Clang] noinline call site attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG223b82402235: [Clang] noinline call site attribute (authored by xbolva00). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHA

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

xbolva00 added a comment. What is the status of this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86559/new/ https://reviews.llvm.org/D86559 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 updated this revision to Diff 411589. xbolva00 added a comment. Fixed failing Parser test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/incl

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

xbolva00 added a comment. >> Given that the bot does not have a high success rate (track record) for at >> least the past month, I am unsure I am supposed to revert my change. What is interesting that always the patch author is the person to be blamed even when there are situations where it is

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

xbolva00 added a comment. >> error: Segmentation fault (core dumped) This happens quite often on these ppc bots - they are known for unstability and slow cycles. >> Open https://lab.llvm.org/buildbot/#/builders/57 , click "Success Rate" tab, >> the rate is lower compared to other bots recently

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 updated this revision to Diff 411495. xbolva00 added a comment. Small doc update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 added a comment. I think I will update release notes later, after always_inline variant of this patch. So looks like we are almost done here? :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 updated this revision to Diff 411489. xbolva00 added a comment. Addressed review comments. Feel free to suggest better wording :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061 Files: clang/include/clang/Basic/Attr.td clang/inclu

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 added inline comments. Comment at: clang/test/Sema/attr-noinline.cpp:23 + + [[gnu::noinline]] bar(); // expected-warning {{'noinline' attribute is ignored in statements as it only applies to functions}} +} aaron.ballman wrote: > xbolva00 wrote: > > aar

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 added inline comments. Comment at: clang/test/Sema/attr-noinline.cpp:23 + + [[gnu::noinline]] bar(); // expected-warning {{'noinline' attribute is ignored in statements as it only applies to functions}} +} aaron.ballman wrote: > It might be nice to cla

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

xbolva00 added a comment. In D120305#3344938 , @nikic wrote: > Hm, it looks like enabling PIE has a pretty big negative compile-time impact, > with a 20% regression on sqlite3: > http://llvm-compile-time-tracker.com/compare.php?from=611122892e6d5813444b

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1764 +def NoInline : DeclOrStmtAttr { + let Spellings = [Clang<"noinline">, Declspec<"noinline">]; + let Documentation = [NoInlineDocs]; aaron.ballman wrote: > xbolva00 wrote: > > Wha

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 updated this revision to Diff 411383. xbolva00 added a comment. Herald added a subscriber: jdoerfert. Fixed tests. Addressed review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061 Files: clang/include/clang/Basic/Attr.td

[PATCH] D114425: [clang] Add __builtin_bswap128

xbolva00 added inline comments. Comment at: clang/docs/ReleaseNotes.rst:64 +- Maximum _ExtInt size was decreased from 16,777,215 bits to 8,388,608 bits. + Motivation for this was discussed in PR51829. +- Configuration file syntax extended with token. This expands to ---

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 added a comment. In D119061#3340884 , @kuhar wrote: > LGTM but please get at least one additional approval before submitting Thank you. Yeah, I would like to get lgtm from @aaron.ballman here :) CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 added a comment. ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

xbolva00 added a comment. In D93298#3332058 , @jrtc27 wrote: > In D93298#3332038 , @xbolva00 wrote: > It appears that this is causing an assertion segfault in a rustc test over at our experimental rust +

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

xbolva00 added a comment. >> It appears that this is causing an assertion segfault in a rustc test over >> at our experimental rust + llvm@head bot: I dont think that patch author is required to debug this issue for "experimental rust + llvm@head" - downstream. >> Since I don't have a rust env

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG2c91754a13f3: [Clang] Add attributes alloc_size and alloc_align to mm_malloc (authored by xbolva00). Repository: rG LLV

[PATCH] D114425: [clang] Add __builtin_bswap128

xbolva00 added a comment. In D114425#3329303 , @philnik wrote: > In D114425#3225908 , @erichkeane > wrote: > >> In D114425#3225892 , @craig.topper >> wrote: >> >>> I kin

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1764 +def NoInline : DeclOrStmtAttr { + let Spellings = [Clang<"noinline">, Declspec<"noinline">]; + let Documentation = [NoInlineDocs]; What I need to mention here. With Clang<"noinl

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 added inline comments. Comment at: clang/test/CodeGen/attr-noinline.cpp:11 + +void foo(int i) { + [[clang::noinline]] bar(); kuhar wrote: > Could you also add a test function that is already marked as noinline at the > declaration? Yes, added CHANGES

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 updated this revision to Diff 408588. xbolva00 added a comment. More tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 updated this revision to Diff 408580. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Code

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 updated this revision to Diff 408578. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Code

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:522 + let Content = [{ +This function attribute suppresses the inlining of a function at the call sites +of the function. Feel free to suggest better wording :)

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 updated this revision to Diff 408573. xbolva00 added a comment. Added check to warn for conflicting attributes. More docs, tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061 Files: clang/include/clang/Basic/Attr.td clang/inclu

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 added a comment. Fixes for inliners landed, working on this now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D84225: [CFE] Add nomerge function attribute to inline assembly.

xbolva00 added a subscriber: aaron.ballman. xbolva00 added inline comments. Comment at: clang/lib/Sema/SemaStmtAttr.cpp:186 void VisitCallExpr(const CallExpr *E) { FoundCallExpr = true; } + void VisitAsmStmt(const AsmStmt *S) { FoundCallExpr = true; } pengf

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

xbolva00 added a comment. @void It would be cool to mention this new feature in release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 ___ cfe-commits m

[PATCH] D119451: [clang] inheritance fix for nomerge attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb2936caf77e0: [clang] inheritance fix for nomerge attribute (authored by xbolva00). Herald added a project: clang. Herald added a subscriber: cfe-com

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 added a comment. Interestly, clang/llvm happily ignores noinline on static functions, gcc does not. https://godbolt.org/z/jr3Wx87rb CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061 ___ cfe-

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 added a comment. >> It would be good to check with a language expert if this can break some >> code. I'm thinking of situations when someone relies on a function being >> emitted (or not) and ending up with linking issues. I'm not an expert here, >> but this is a past concern I vaguely

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 added a comment. >> Do you plan to also add inline and flatten? You mean always_inline? Yes, after noinline. The flatten call site attribute - theoretically why not, but it needs to be reworked in LLVM (like always_inline_recursively) before any patch like this one. >> When I worked o

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 planned changes to this revision. xbolva00 added a comment. Plan: 1. https://reviews.llvm.org/D119451 2. fix inliner in LLVM 3. continue with this patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061

[PATCH] D119271: CGCall: also emit LLVM `allocalign` attribute when handling AllocAlign

xbolva00 added inline comments. Comment at: clang/test/CodeGen/alloc-align-attr.c:14 // CHECK-NEXT:[[CASTED_ALIGN:%.*]] = zext i32 [[TMP0]] to i64 // CHECK-NEXT:call void @llvm.assume(i1 true) [ "align"(i32* [[CALL]], i64 [[CASTED_ALIGN]]) ] // CHECK-NEXT:[[TMP1:%

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

xbolva00 added a comment. >> I think we need to deal with the reality that there are non-ABI conforming >> [system-dependent] allocators out there, Definitely not a good thing, just ticking bomb. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11880

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 added a comment. Thanks! @jdoerfert ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 updated this revision to Diff 406583. xbolva00 added a comment. protect against user macros CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 Files: clang/lib/Headers/mm_malloc.h clang/test/Headers/Inputs/include/malloc.h clang/te

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

xbolva00 added a comment. Also, __builtin_malloc(...) can be used to avoid any alignment assumptions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118804/new/ https://reviews.llvm.org/D118804 ___ cfe-co

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

xbolva00 added a comment. llvm 14 - yes llvm 13.0.2 is not planned. If you need a workaround, use -fno-builtin-malloc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118804/new/ https://reviews.llvm.org/D118804 ___

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

xbolva00 accepted this revision. xbolva00 added a comment. This revision is now accepted and ready to land. LG. Please wait a day in case any new comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118804/new/ https://reviews.llvm.org/D118804

[PATCH] D84225: [CFE] Add nomerge function attribute to inline assembly.

xbolva00 added inline comments. Comment at: clang/lib/Sema/SemaStmtAttr.cpp:186 void VisitCallExpr(const CallExpr *E) { FoundCallExpr = true; } + void VisitAsmStmt(const AsmStmt *S) { FoundCallExpr = true; } This is totally wrong, just big hack to smuggle i

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

xbolva00 requested changes to this revision. xbolva00 added inline comments. This revision now requires changes to proceed. Comment at: clang/test/CodeGen/alloc-fns-alignment.c:37 - -void *aligned_alloc_large_constant_test(size_t n) { - return aligned_alloc(4096, n); ---

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

xbolva00 added a comment. In D118804#3292179 , @MaskRay wrote: > In D118804#3292176 , @xbolva00 > wrote: > Reintroducing an optimization like this with an additional check that the allocation size is l

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

xbolva00 added a comment. Can you also confirm that there is no similar related to op new? Yes, we “can” this assumption by removing it but.. there should be consensus whether just this code is problematic or problem is bigger (as we use NewAlign..) Repository: rG LLVM Github Monorepo CHAN

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

xbolva00 added a comment. >> Reintroducing an optimization like this with an additional check that the >> allocation size is large enough should be valid everywhere. Should not be hard, could you do it? Then LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

xbolva00 added a comment. >> mimalloc uses 8-byte alignment for 64-bit Darwin, not 16-byte alignment. Than they are doing something fishy if I understood rjmccall’s comment correctly about darwin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1188

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

xbolva00 added a comment. Or can we bailout just for gnu? and preserve this for darwin? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118804/new/ https://reviews.llvm.org/D118804 ___ cfe-commits mailing

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

xbolva00 added a comment. So better to find solution / agreement with gcc devs too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118804/new/ https://reviews.llvm.org/D118804 ___ cfe-commits mailing list

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

xbolva00 requested changes to this revision. xbolva00 added a comment. This revision now requires changes to proceed. GCC also does same assumptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118804/new/ https://reviews.llvm.org/D118804 ___

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 added a comment. In D117091#3272589 , @aaron.ballman wrote: > There's a testing issue on Windows: > > TEST 'Clang :: Headers/mm_malloc.c' FAILED > > Script: > -- > : 'RUN: at line 1'; > c:\ws

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 added a comment. In D117091#3272594 , @jdoerfert wrote: > Don't test with O1 , add the > dummy include folder to the include path > (`clang/test/Headers/Inputs/include`), stdlib.h is already there, ma

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 updated this revision to Diff 404397. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 Files: clang/lib/Headers/mm_malloc.h clang/test/Headers/Inputs/include/malloc.h clang/test/Headers/mm_malloc.c Index: clang/test/Headers/mm_ma

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 updated this revision to Diff 404395. xbolva00 added a comment. Added newline CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 Files: clang/lib/Headers/mm_malloc.h clang/test/Headers/Inputs/include/malloc.h clang/test/Headers/mm_

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 updated this revision to Diff 404394. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 Files: clang/lib/Headers/mm_malloc.h clang/test/Headers/Inputs/include/malloc.h clang/test/Headers/mm_malloc.c Index: clang/test/Headers/mm_ma

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 updated this revision to Diff 404393. xbolva00 added a comment. Herald added a subscriber: mstorsjo. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 Files: clang/lib/Headers/mm_malloc.h clang/test/Headers/I

[PATCH] D118385: [NFC] Optimize FoldingSet usage where it matters

xbolva00 added inline comments. Comment at: llvm/include/llvm/ADT/FoldingSet.h:328 /// Add* - Add various data types to Bit data. - void AddPointer(const void *Ptr); - void AddInteger(signed I); - void AddInteger(unsigned I); - void AddInteger(long I); - void AddInteger(u

[PATCH] D117600: [CGCall] Annotate operator new with inaccessiblememonly if AssumeSaneOperatorNew is on

xbolva00 added a comment. Test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117600/new/ https://reviews.llvm.org/D117600 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D117965: [AlwaysInliner] Enable call site inlining to make flatten attribute working again (#53360)

xbolva00 added a comment. In D117965#3270744 , @thakis wrote: > Could this have caused http://45.33.8.238/linux/66347/step_7.txt ? Yeah, possible as inliner removes internal unused functions (small change before commit, missed check-clang). I will rev

[PATCH] D117965: [AlwaysInliner] Enable call site inlining to make flatten attribute working again (#53360)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGceec4383681c: [AlwaysInliner] Enable call site inlining to make flatten attribute working… (authored by xbolva00). Changed prior to commit: https:

[PATCH] D117965: [AlwaysInliner] Enable call site inlining to make flatten attribute working again (#53360)

xbolva00 added inline comments. Comment at: llvm/lib/Transforms/IPO/AlwaysInliner.cpp:95 - // Remember to try and delete this function afterward. This both avoids - // re-walking the rest of the module and avoids dealing with any iterator - // invalidation issues

[PATCH] D117965: [AlwaysInliner] Enable call site inlining to make flatten attribute working again (#53360)

xbolva00 updated this revision to Diff 402997. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117965/new/ https://reviews.llvm.org/D117965 Files: clang/test/CodeGen/flatten.c clang/test/CodeGenCXX/flatten.cpp llvm/lib/Transforms/IPO/AlwaysInliner.cpp llvm/test/Transforms/Coroutine

[PATCH] D117965: [AlwaysInliner] Enable call site inlining to make flatten attribute working again (#53360)

xbolva00 added a comment. Thanks, addressed review comments. > we should reconsider the attribute support I agree. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117965/new/ https://reviews.llvm.org/D117965 ___ cfe-commits mailing list cfe-c

[PATCH] D117965: [AlwaysInliner] Enable call site inlining to make flatten attribute working again (#53360)

xbolva00 updated this revision to Diff 402994. xbolva00 retitled this revision from "[AlwaysInliner] Enable call site inlining to make flatten attribute working again (PR53360)" to "[AlwaysInliner] Enable call site inlining to make flatten attribute working again (#53360)". Herald added a subscri

[PATCH] D117965: [AlwaysInliner] Enable call site inlining to make flatten attribute working again (PR53360)

xbolva00 added a comment. There is also second use case which I mentioned and I am interested in. >> I'd vote for properly implementing [1] or removing our support for flatten. I would rather prefer to restore atleast something which was working before new PM and then improve it, instead of fu

[PATCH] D117965: [AlwaysInliner] Enable call site inlining to make flatten attribute working again (PR53360)

xbolva00 added a comment. Aiming this fix for LLVM 14.0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117965/new/ https://reviews.llvm.org/D117965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 added a comment. In D117091#3267980 , @reames wrote: > In D117091#3265986 , @xbolva00 > wrote: > >> Ping @reames > > Not qualified to review clang/c++ library semantic changes. > > Also, did we implement

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 added a comment. Ping @reames CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

<    1   2   3   4   5   6   7   8   9   10   >