[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: lib/Sema/SemaExpr.cpp:11067 + + // Do not diagnose 2 ^ 64, but allow special case (2 ^ 64) - 1. + if (SubLHS && SubRHS && (LeftSideValue != 2 || RightSideValue != 64))

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: lib/Sema/SemaExpr.cpp:11067 + + // Do not diagnose 2 ^ 64, but allow special case (2 ^ 64) - 1. + if (SubLHS && SubRHS && (LeftSideValue != 2 || RightSideValue != 64))

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: lib/Sema/SemaExpr.cpp:11067 + + // Do not diagnose 2 ^ 64, but allow special case (2 ^ 64) - 1. + if (SubLHS && SubRHS && (LeftSideValue != 2 || RightSideValue != 64))

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

xbolva00 added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:59 + ``getelementptr inbounds`` can not change the null status of a pointer, + meaning it can not produce non-null pointer given null base pointer, and + likewise given non-null base pointer it can not

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

xbolva00 added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:59 + ``getelementptr inbounds`` can not change the null status of a pointer, + meaning it can not produce non-null pointer given null base pointer, and + likewise given non-null base pointer it can not

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

xbolva00 added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:59 + ``getelementptr inbounds`` can not change the null status of a pointer, + meaning it can not produce non-null pointer given null base pointer, and + likewise given non-null base pointer it can not

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

xbolva00 added inline comments. Comment at: compiler-rt/test/ubsan/TestCases/Pointer/index-overflow.cpp:15 + // ERR2: runtime error: pointer index expression with base {{.*}} overflowed to + // ERR1: runtime error: subtracting integral value of non-null pointer 0x{{.*}} from

[PATCH] D66711: [clang] Warning for non-final classes with final destructors

xbolva00 added a comment. rL370737 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66711/new/ https://reviews.llvm.org/D66711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: lib/Sema/SemaExpr.cpp:11031-11032 // Do not diagnose macros. - if (Loc.isMacroID()) + if (Loc.isMacroID() || XorLHS.get()->getBeginLoc().isMacroID() || +

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 updated this revision to Diff 218258. xbolva00 added a comment. Fixed review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp

[PATCH] D66621: [clang] Devirtualization for classes with destructors marked as 'final'

xbolva00 added a comment. >> For now, I need help committing this, if anyone would be so kind! rL370597 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66621/new/ https://reviews.llvm.org/D66621

[PATCH] D66621: [clang] Devirtualization for classes with destructors marked as 'final'

This revision was automatically updated to reflect the committed changes. Closed by commit rL370597: [clang] Devirtualization for classes with destructors marked as final (authored by xbolva00, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D66711: [clang] Warning for non-final classes with final destructors

This revision was automatically updated to reflect the committed changes. Closed by commit rL370594: [clang] Warning for non-final classes with final destructors (authored by xbolva00, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

xbolva00 added inline comments. Comment at: cfe/trunk/lib/Sema/SemaInit.cpp:3112 SmallVector InitExpressions; + bool HasArrayDesignator = false; warning: variable ‘HasArrayDesignator’ set but not used [-Wunused-but-set-variable] bool HasArrayDesignator

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. >> tbh, I would appreciate if you would leave the definition of >> diagnoseXorMisusedAsPow() where it is and add a forward declare of the >> function earlier in the file. I uploaded the patch almost 2 weeks ago and nobody complained so I thought it is okay. Uploaded,

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 updated this revision to Diff 218115. xbolva00 added a comment. Fixed review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. In D66397#1647455 , @aaron.ballman wrote: > Adding @rsmith to see if we can make forward progress on this patch again. On the other side, I don't want to waste Richard's time since I dont want to extend (variables and macros

[PATCH] D66765: [analyzer] (Urgent!) Add 9.0.0. release notes.

xbolva00 added inline comments. Comment at: clang/docs/ReleaseNotes.rst:251 + + - ``-analyzer-checker-help-alpha``: The list of incomplet and inkorrekt +checkers not yet advised to be turned on. Please fix this Repository: rG LLVM Github Monorepo

[PATCH] D66765: [analyzer] (Urgent!) Add 9.0.0. release notes.

xbolva00 added inline comments. Comment at: clang/docs/ReleaseNotes.rst:263 + + - ``-analyzer-checker-option-help-alpha``: The list of incomplet and inkorrekt +not yet advised to be specified. Detto Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D66711: [clang] Warning for non-final classes with final destructors

xbolva00 accepted this revision. xbolva00 added a comment. This revision is now accepted and ready to land. Looks fine Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66711/new/ https://reviews.llvm.org/D66711 ___

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. Another bug found by -Wxor-used-as-pow :) https://github.com/christinaa/PcapPlusPlus/commit/4646a004f5168bcb78fe2dce78afa08d794c1450 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. I am strongly in favour to just land this as is. :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a subscriber: regehr. xbolva00 added a comment. >> I now agree that it makes sense to warn when the operands are macros or >> variables. I could re-add macro support and then @jfb or @regehr would blame this diagnostic because of macro support =] variables could open a new box

[PATCH] D66621: [clang] Devirtualization for classes with destructors marked as 'final'

xbolva00 added a comment. Aha okay :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66621/new/ https://reviews.llvm.org/D66621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 updated this revision to Diff 216724. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp test/SemaCXX/warn-xor-as-pow.cpp Index: test/SemaCXX/warn-xor-as-pow.cpp

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 updated this revision to Diff 216723. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp test/SemaCXX/warn-xor-as-pow.cpp Index: test/SemaCXX/warn-xor-as-pow.cpp

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. Removed macro support (again...). I agree with Nico, this warning is on by default so should be as exact as possible without many false positives. While we all know that the Chromium's false positive case could be rewritten for better code readability, on the other

[PATCH] D66621: [clang] Devirtualization for classes with destructors marked as 'final'

xbolva00 added a comment. https://reviews.llvm.org/rGcb30590da10ba80a133222588efedab7e5fc9bdd does not help here? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66621/new/ https://reviews.llvm.org/D66621 ___

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 updated this revision to Diff 216720. xbolva00 added a comment. Addressed Bruno Ricci's tips. Removed macro support. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397 Files: include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. >> What was the motivation for firing on more than bare literals? First patch supported diagnosing macros. There is no exact motivation why, simply “I just did it” to present working prototype. Based on review, things were adjusted. Some reviewers wanted to keep full

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. >> other warning that behaves differently for ordinary and hex literals Such literals should indicate that the user knows what he/she is doing (bit tricks, ..). I agree that there should be a additional docs (as we mentioned it and kindly pinged @hans) and not force

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. >> I think adding parens and casts are fairly well-understood to suppress >> warnings. It should work here as well. #define ALPHA_OFFSET (3). Did anobody from Chromium try it? >> They have varying levels of C++ proficiency I consider things like hex decimals or

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. I think everybody should be fine with this now :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. Implemented @Quuxplusone's idea to improve silence note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 updated this revision to Diff 216478. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp test/SemaCXX/warn-xor-as-pow.cpp Index: test/SemaCXX/warn-xor-as-pow.cpp

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 updated this revision to Diff 216458. xbolva00 edited the summary of this revision. xbolva00 added a comment. Detect digit separators. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397 Files: lib/Sema/SemaExpr.cpp

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. Swap trick is cool, we can suggest it always(vs. ‘xor’) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. Could the following text be acceptable? replace expression with '0xA ^ 1' or ‘10 xor 1’ to silence this warning (In C mode without xor macro “replace expression with '0xA ^ 1' to silence this warning”) I am not fan of “the ‘xor’ alternative token” CHANGES SINCE

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. >> C++14 binary literals Thanks, noted. >> Suggest “xor” We could. Aaron what do you think? But I still like “0x” more. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. But it seems everything is autogenerated and nothing is “custom message”. Any custom change is removed by next autogeneration. Possibly @hans could tell us if there is a way CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. I fixed and enabled this checker to warn for macros too. @aaron.ballman is right. Yes, as he said... If the user has a time to add -Wno-xor to build systems, he/she has also time to improve code readability and use hexadecimal literals. But I am a bit worried

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 updated this revision to Diff 216399. xbolva00 added a comment. Fixed review nits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397 Files: lib/Sema/SemaExpr.cpp test/SemaCXX/warn-xor-as-pow.cpp Index:

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. I agree. And I think they should just use const int instead of macros after all. Maybe we should just improve silence hint if rhs is macro? #define ALPHA_OFFSET 0x3 ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. >> File >> /home/bruno/software/llvm-project/clang/test/SemaCXX/warn-xor-as-pow.cpp >> Line 119: result of '2 ^ ALPHA_OFFSET' is 1; did you mean '1 << >> ALPHA_OFFSET' (8)? This should not warn. Please verify that patch was applied correctly and you use newly

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. Any objections to this patch except “macro” question? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

xbolva00 added a comment. This needs to be commited https://reviews.llvm.org/D66487 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64838/new/ https://reviews.llvm.org/D64838 ___ cfe-commits mailing list

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

xbolva00 added a comment. Added some reviewers Patch improves suboptimal diagnostic, which misses bugs like: https://bugs.llvm.org/show_bug.cgi?id=43052 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57660/new/ https://reviews.llvm.org/D57660

[PATCH] D57659: [Sema] SequenceChecker: Add some comments + related small NFCs in preparation of the following patches

xbolva00 accepted this revision. xbolva00 added a comment. This revision is now accepted and ready to land. This seems ok (not sure why stalled) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57659/new/ https://reviews.llvm.org/D57659

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. >> suggested source-code fixit of #define ALPHA_OFFSET 0x3 No, there is a note “replace with 0x2 ^ ALPHA_OFFSET” to silence it. While we can suggest as you wrote: #define ALPHA_OFFSET 0x3 I really dont think it is worth to do. CHANGES SINCE LAST ACTION

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a subscriber: hans. xbolva00 added a comment. >> I think it's too soon to disable any macros. It is hard to say (this was discussed a lot). @tkanis or @hans what do you think? Maybe you could do experiments for us. Comment the code which disables this warning in macros and try

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. I think it is too soon to jump and disable all macros. We still catch all motivating cases, it found bugs in Chromium. Chromium's case makes sense but on the other hand, LHS does not make much sense to be a macro. #define TWO 2 and res = TWO ^ 32? And even for this

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 updated this revision to Diff 215957. xbolva00 added a comment. Do not warn if RHS is macro. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397 Files: lib/Sema/SemaExpr.cpp test/SemaCXX/warn-xor-as-pow.cpp Index:

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a subscriber: jfb. xbolva00 added a comment. I agree what @tkanis suggested and be silent if RHS is macro as real world code shows it. Opinions? @jfb @aaron.ballman Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. From post commit discussion, Nico Weber: 1. Hi, 2. 3. this results in a false positive on webrtc, on this code: 4. 5. https://cs.chromium.org/chromium/src/third_party/libwebp/src/enc/picture_csp_enc.c?q=picture_csp_enc.c=package:chromium=1002 6. 7. The code does this:

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 created this revision. xbolva00 added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Handle specific case (2 ^ 64) - 1 Repository: rC Clang https://reviews.llvm.org/D66397 Files: lib/Sema/SemaExpr.cpp

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

This revision was automatically updated to reflect the committed changes. Closed by commit rL369217: [Diagnostics] Diagnose misused xor as pow (authored by xbolva00, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D53666: [Tests] Updated tests for D53342

xbolva00 added a comment. Will be handled as NFC commit after D53342 lands. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53666/new/ https://reviews.llvm.org/D53666 ___ cfe-commits mailing list

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 updated this revision to Diff 215693. xbolva00 added a comment. Better comparison for "xor". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63423/new/ https://reviews.llvm.org/D63423 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 updated this revision to Diff 215592. xbolva00 added a comment. Fixed nits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63423/new/ https://reviews.llvm.org/D63423 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 added a comment. Any futher comments or is it OK now @jfb ? @aaron.ballman ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63423/new/ https://reviews.llvm.org/D63423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66173: [Codegen] Updated test for D66158

This revision was automatically updated to reflect the committed changes. Closed by commit rL368809: [Codegen] Updated test for D66158 (authored by xbolva00, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66173: [Codegen] Updated test for D66158

xbolva00 updated this revision to Diff 215039. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66173/new/ https://reviews.llvm.org/D66173 Files: test/CodeGen/struct-copy.c Index: test/CodeGen/struct-copy.c === ---

[PATCH] D66173: [Codegen] Updated test for D66158

xbolva00 updated this revision to Diff 214940. xbolva00 added a comment. Explicit memcpy CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66173/new/ https://reviews.llvm.org/D66173 Files: test/CodeGen/struct-copy.c Index: test/CodeGen/struct-copy.c

[PATCH] D66173: [Codegen] Updated test for D66158

xbolva00 added a comment. hm.. memset? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66173/new/ https://reviews.llvm.org/D66173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66173: [Codegen] Updated test for D66158

xbolva00 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D66173 Files: test/CodeGen/struct-copy.c Index: test/CodeGen/struct-copy.c

[PATCH] D66143: Don't use std::errc

xbolva00 added a comment. GCC 4.8 is still supported Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66143/new/ https://reviews.llvm.org/D66143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66143: Don't use std::errc

xbolva00 added a comment. This small change is okay anyway Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66143/new/ https://reviews.llvm.org/D66143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:508 def Varargs : DiagGroup<"varargs">; +def XorUsedAsPow : DiagGroup<"xor-used-as-pow">; aaron.ballman wrote: > xbolva00 wrote: > >

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 updated this revision to Diff 214534. xbolva00 added a comment. Addressed review notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63423/new/ https://reviews.llvm.org/D63423 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 added a comment. I will split enum constants handling to other patch in near future. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63082/new/ https://reviews.llvm.org/D63082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 updated this revision to Diff 214533. xbolva00 added a comment. Added UDL tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63423/new/ https://reviews.llvm.org/D63423 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D66044: Extend -Wtautological-overlap-compare to accept negative values and integer conversions

xbolva00 added a comment. Good improvement, thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66044/new/ https://reviews.llvm.org/D66044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 updated this revision to Diff 214525. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63423/new/ https://reviews.llvm.org/D63423 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 added a comment. Hello, I fixed your notes + added test cases. Only remaining question is what to do in "2 ^ 64" (65, 66, .. etc) case. I can emit "result of 2 ^ 64" is "XYZ", but this is rather poor diagnostic. What should we suggest for "2 ^ 64"? (@jfb The "2 ^ 64 - 1" case to be

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 updated this revision to Diff 214524. xbolva00 added a comment. svn added forgotten test file.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63423/new/ https://reviews.llvm.org/D63423 Files: include/clang/Basic/DiagnosticGroups.td

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 updated this revision to Diff 214523. xbolva00 added a comment. Addressed review notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63423/new/ https://reviews.llvm.org/D63423 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

xbolva00 added subscribers: hans, xbolva00. xbolva00 added a comment. Maybe this ABI issue should be fixed for 9.0 ? Not sure how important, but @hans maybe should track this one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64672/new/ https://reviews.llvm.org/D64672

[PATCH] D65300: [clang] [CodeGen] clang-misexpect prototype for compiler warnings

xbolva00 added a comment. In D65300#1608147 , @lebedev.ri wrote: > Thank you for working on this! > > I'm guessing this doesn't have a `-Werror=` mode? > > I still believe this should output a remark. > It will still be visible in the compiler console

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

xbolva00 added a comment. +1, looks good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64838/new/ https://reviews.llvm.org/D64838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D65706: [docs] Better documentation for -Weverything

xbolva00 added a comment. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65706/new/ https://reviews.llvm.org/D65706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D65300: [clang] [CodeGen] clang-misexpect prototype for compiler warnings

xbolva00 added inline comments. Comment at: clang/lib/CodeGen/MisExpect.cpp:140-146 +void EmitMisExpectWarning(const CallExpr *Call, CodeGenModule ) { + SourceLocation ExprLoc = Call->getBeginLoc(); + unsigned DiagID = CGM.getDiags().getCustomDiagID( +

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 added a comment. C FE: -IfStmt 0x55a225bc4dc8 | |-BinaryOperator 0x55a225bc4d48 'int' '||' | | |-BinaryOperator 0x55a225bc4d08 'int' '==' | | | |-ImplicitCastExpr 0x55a225bc4cf0 'int' | | | | `-ImplicitCastExpr 0x55a225bc4cd8 'enum fruit':'enum fruit' | | | |

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: test/SemaCXX/warn-int-in-bool-context.cpp:96 + + if (f == apple || orange) // expected-warning {{enum constant in boolean context}} +return a; aaron.ballman wrote: >

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 marked 2 inline comments as done. xbolva00 added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5609 +def warn_mul_in_bool_context : Warning< + "'*' in bool context, maybe you mean '&&'?">, + InGroup; jfb wrote: > xbolva00

[PATCH] D63139: [Diagnostics] Implement -Wswitch-unreachable

xbolva00 accepted this revision. xbolva00 added a comment. This revision is now accepted and ready to land. Since motivation examples are already handled by -Wunreachable-code, I will close this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63139/new/

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 marked 2 inline comments as done and an inline comment as not done. xbolva00 added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5609 +def warn_mul_in_bool_context : Warning< + "'*' in bool context, maybe you mean '&&'?">, + InGroup;

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 marked 4 inline comments as done and an inline comment as not done. xbolva00 added inline comments. Comment at: test/Sema/warn-int-in-bool-context.c:26 + r = a << 7; // expected-warning {{'<<' in boolean context; did you mean '<'?}} + r = ONE << b; //

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: test/Sema/warn-int-in-bool-context.c:32 + r = a ? -2 : 0; + r = a ? 3 : -2; + r = a ? 0 : TWO; // expected-warning {{'?:' with integer constants in boolean context}} jfb

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 marked 3 inline comments as done. xbolva00 added inline comments. Comment at: test/Sema/warn-int-in-bool-context.c:26 + r = a << 7; // expected-warning {{'<<' in boolean context; did you mean '<'?}} + r = ONE << b; // expected-warning {{'<<' in boolean context; did

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

xbolva00 added a comment. https://bugs.llvm.org/show_bug.cgi?id=42817 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63048/new/ https://reviews.llvm.org/D63048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

xbolva00 added a comment. Some ICC behaviour.. icc -dumpversion 19.0.3.199 printf("%d %d %s", __GNUC__, __GNUC_MINOR__, __VERSION__); ./a.out 7 4 Intel(R) C++ gcc 7.4 mode Should we bump __GNUC__, __GNUC_MINOR__ too? Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: test/SemaCXX/warn-int-in-bool-context.cpp:96 + + if (f == apple || orange) // expected-warning {{enum constant in boolean context}} +return a; @aaron.ballman : In C (but

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

xbolva00 added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:233 +GNUAttributeLoc = Tok.getLocation(); +MaybeParseGNUAttributes(Attrs); +goto Retry; Since you know that tok is kw_attr, I think you can use 'ParseGNUAttributes'.

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

xbolva00 added a comment. Thanks! Better and better:) Change in clang/test/Index/blocks.c seems not ideal, or is it okay? @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64838/new/ https://reviews.llvm.org/D64838

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

xbolva00 added inline comments. Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:1228 + if (MacroName.empty()) { +if (!PreferClangAttr) + MacroName = "[[fallthrough]]"; This code is not tested? I think you can use tests from my older patch.

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: test/SemaCXX/warn-int-in-bool-context.cpp:99 + + if (ans == yes || no) // expected-warning {{enum constant in boolean context}} +return a; aaron.ballman wrote: > Why do

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 added a comment. Ping. Seems like @rsmith is busy, so I added @jfb as a reviewer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63082/new/ https://reviews.llvm.org/D63082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63139: [Diagnostics] Implement -Wswitch-unreachable

xbolva00 added a subscriber: jfb. xbolva00 added a comment. Adding @jfb as reviewer to get more opinions what should be done next.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63139/new/ https://reviews.llvm.org/D63139 ___ cfe-commits

[PATCH] D63139: [Diagnostics] Implement -Wswitch-unreachable

xbolva00 added a comment. Ping again Is ‘CaseStmt´ AST C++ issue is a blocker for this patch or not? I would like to move forward - either land it or (if blocker) abandon it. If it is blocking issue, I can enable it for C only (better than nothing).. CHANGES SINCE LAST ACTION

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

xbolva00 added a comment. (But please wait for @aaron.ballman) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

<    2   3   4   5   6   7   8   9   10   11   >