[PATCH] D114003: LiteralSupport: Don't assert() on invalid input

DaanDeMeyer updated this revision to Diff 387723. DaanDeMeyer added a comment. Addressed comments by adding two new errors, one for character literals and one for numeric literals. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114003/new/ https://

[PATCH] D114003: LiteralSupport: Don't assert() on invalid input

DaanDeMeyer updated this revision to Diff 387667. DaanDeMeyer added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114003/new/ https://reviews.llvm.org/D114003 Files: clang/lib/Lex/LiteralSupport.cpp Index: clang/lib/Lex

[PATCH] D114003: LiteralSupport: Don't assert() on invalid input

DaanDeMeyer added a comment. Added some people that were recent reviewers of changes to this file and some clangd folks. I don't have the time to properly test this unfortunately (aside from verifying that it fixes all the clangd crashes I'm having), but putting the patch up anyway in case any

[PATCH] D114003: LiteralSupport: Don't assert() on invalid input

DaanDeMeyer created this revision. DaanDeMeyer added reviewers: eduucaldas, beccadax, sammccall, kadircet. DaanDeMeyer added a project: clang. Herald added a subscriber: usaxena95. DaanDeMeyer requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. When using cla

[PATCH] D95746: clang: Exclude efi_main from -Wmissing-prototypes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7dd42ecfa2a2: clang: Exclude efi_main from -Wmissing-prototypes (authored by DaanDeMeyer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D95746: clang: Exclude efi_main from -Wmissing-prototypes

DaanDeMeyer added a comment. I should be able to commit it myself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95746/new/ https://reviews.llvm.org/D95746 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D95746: clang: Exclude efi_main from -Wmissing-prototypes

DaanDeMeyer updated this revision to Diff 325224. DaanDeMeyer added a comment. Moved the test into the no-warn-missing-prototype test as requested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95746/new/ https://reviews.llvm.org/D95746 Files: c

[PATCH] D95746: clang: Exclude efi_main from -Wmissing-prototypes

DaanDeMeyer added a comment. Added a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95746/new/ https://reviews.llvm.org/D95746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D95746: clang: Exclude efi_main from -Wmissing-prototypes

DaanDeMeyer updated this revision to Diff 325114. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95746/new/ https://reviews.llvm.org/D95746 Files: clang/lib/Sema/SemaDecl.cpp clang/test/Sema/no-warn-missing-prototype-efi.c Index: clang/test/Sem

[PATCH] D95746: clang: Exclude efi_main from -Wmissing-prototypes

DaanDeMeyer updated this revision to Diff 320899. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95746/new/ https://reviews.llvm.org/D95746 Files: clang/lib/Sema/SemaDecl.cpp Index: clang/lib/Sema/SemaDecl.cpp

[PATCH] D95746: clang: Exclude efi_main from -Wmissing-prototypes

DaanDeMeyer added a comment. CI failures seem unrelated? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95746/new/ https://reviews.llvm.org/D95746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D95746: clang: Exclude efi_main from -Wmissing-prototypes

DaanDeMeyer created this revision. DaanDeMeyer added a reviewer: clang. DaanDeMeyer added a project: clang. DaanDeMeyer requested review of this revision. Herald added a subscriber: cfe-commits. When compiling UEFI applications, the main function is named efi_main() instead of main(). Let's exclud

[PATCH] D91509: [clangd] Add AST config to prebuild ASTs

DaanDeMeyer abandoned this revision. DaanDeMeyer added a comment. Abandoning as the end result is too slow even when including a limited number of files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91509/new/ https://reviews.llvm.org/D91509 ___

[PATCH] D91509: [clangd] Add AST config to prebuild ASTs

DaanDeMeyer updated this revision to Diff 305489. DaanDeMeyer added a comment. Fix all the bugs after doing some proper testing. One thing we don't handle yet is header files since those don't appear in the compilation database. Maybe we need to add prebuilding for those as well? Repository:

[PATCH] D91509: [clangd] Add AST config to prebuild ASTs

DaanDeMeyer updated this revision to Diff 305468. DaanDeMeyer added a comment. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91509/new/ https://reviews.llvm.org/D91509 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-tools-extr

[PATCH] D91509: [clangd] Add AST config to prebuild ASTs

DaanDeMeyer updated this revision to Diff 305396. DaanDeMeyer added a comment. Fixed formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91509/new/ https://reviews.llvm.org/D91509 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-too

[PATCH] D91509: [clangd] Add AST config to prebuild ASTs

DaanDeMeyer updated this revision to Diff 305394. DaanDeMeyer retitled this revision from "[clangd] RFC: Add --prebuild-asts option" to "[clangd] Add AST config to prebuild ASTs". DaanDeMeyer edited the summary of this revision. DaanDeMeyer added a comment. Herald added a project: clang. Herald ad

[PATCH] D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens

This revision was automatically updated to reflect the committed changes. Closed by commit rGf21c704553a8: clang-format: Add ControlStatementsExceptForEachMacros option to… (authored by DaanDeMeyer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7886

[PATCH] D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens

DaanDeMeyer added a comment. I pushed the commit to github. Thanks for the help! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78869/new/ https://reviews.llvm.org/D78869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens

DaanDeMeyer added a comment. I should have commit access now. Is there any documentation on how exactly to do a merge? Do I just add the commit to master and push? I apologize if this seems obvious, I just want to make sure I'm not inadvertently breaking something. CHANGES SINCE LAST ACTION

[PATCH] D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens

DaanDeMeyer added a comment. (I don't have commit access so it'd be great if someone could merge this for me, at least that's how my other contributions have been handled) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78869/new/ https://reviews.llvm.org/D78869 __

[PATCH] D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens

DaanDeMeyer marked 3 inline comments as done. DaanDeMeyer added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2311 + * ``SBPO_ControlStatementsExceptForEachMacros`` (in configuration: +``ControlStatementsExceptForEachMacros``) MyDeve

[PATCH] D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens

DaanDeMeyer updated this revision to Diff 260161. DaanDeMeyer added a comment. - Moved docs to Format.h and re-generated rst file using dump_format_style.py - Expanded comment with an explanation for why you might want to not have a space before the parens of a ForEach macro This isn't explicitl

[PATCH] D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens

DaanDeMeyer updated this revision to Diff 260157. DaanDeMeyer added a comment. Fixed formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78869/new/ https://reviews.llvm.org/D78869 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/For

[PATCH] D76197: clang-format: Use block indentation for braced initializations

DaanDeMeyer abandoned this revision. DaanDeMeyer added a comment. Turns out this is already possible by disabling Cpp11BracedListStyle. The proposed change introduced too many changes regardless so I'm abandoning this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76197/new/ https://re

[PATCH] D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens

DaanDeMeyer created this revision. DaanDeMeyer added a reviewer: clang-format. DaanDeMeyer added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. systemd recently added a clang-format file. One issue I encountered

[PATCH] D76197: clang-format: Use block indentation for braced initializations

DaanDeMeyer added a comment. Of course, if there's interest in adding this I'll fix all the tests but I wanted to make sure there was interest in adding this since it changes clang-format's behavior. Can you confirm that this change in behavior is a good thing and might be merged if I fix all t

[PATCH] D76197: clang-format: Use block indentation for braced initializations

DaanDeMeyer updated this revision to Diff 250429. DaanDeMeyer added a comment. New implementation that breaks fewer tests. It seems to be expected that block kind is `BK_Unknown` for C struct braced init lists. Is that supposed to be the case? There's still quite some tests failures but most of

[PATCH] D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops.

DaanDeMeyer added a comment. Is there CI infra that runs for each revision? I verified all the format unit tests still pass but I haven't run the entire test suite on my machine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75022/new/ https://reviews.llvm.org/D75022 ___

[PATCH] D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops.

DaanDeMeyer updated this revision to Diff 246512. DaanDeMeyer added a comment. Added extra unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75022/new/ https://reviews.llvm.org/D75022 Files: lib/Format/UnwrappedLineFormatter.cpp unittests/Format/FormatTest.cpp Index: unitt

[PATCH] D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops.

DaanDeMeyer updated this revision to Diff 246244. DaanDeMeyer added a comment. Added unit tests and fixed the case where stuff follows the do statement (like a comment). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75022/new/ https://reviews.llvm.org/D75022 Files: lib/Format/Unwrap

[PATCH] D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops.

DaanDeMeyer updated this revision to Diff 246150. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75022/new/ https://reviews.llvm.org/D75022 Files: clang/lib/Format/UnwrappedLineFormatter.cpp Index: clang/lib/Format/UnwrappedLineFormatter.cpp ===

[PATCH] D53481: [clangd] Support passing a relative path to -compile-commands-dir

DaanDeMeyer added a comment. You can commit them. Thanks for all the quick responses! https://reviews.llvm.org/D53481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53527: Fix range length comparison in DraftStore::UpdateDraft when Unicode characters are removed from the document

DaanDeMeyer updated this revision to Diff 170603. DaanDeMeyer added a comment. Update diff according to comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53527 Files: clangd/DraftStore.cpp clangd/SourceCode.cpp clangd/SourceCode.h unittests/clangd/SourceCodeTests

[PATCH] D53527: Fix range length comparison in DraftStore::UpdateDraft when Unicode characters are removed from the document

DaanDeMeyer created this revision. DaanDeMeyer added a reviewer: sammccall. DaanDeMeyer added a project: clang-tools-extra. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, ioeric, ilya-biryukov. See http://lists.llvm.org/pipermail/clangd-dev/2018-October/000171.html for conte

[PATCH] D53481: [clangd] Support passing a relative path to -compile-commands-dir

DaanDeMeyer updated this revision to Diff 170384. DaanDeMeyer added a comment. Updated diff according to comments. https://reviews.llvm.org/D53481 Files: clangd/tool/ClangdMain.cpp Index: clangd/tool/ClangdMain.cpp === --- clan

[PATCH] D53481: [clangd] Support passing a relative path to -compile-commands-dir

DaanDeMeyer created this revision. DaanDeMeyer added reviewers: clang-tools-extra, sammccall. DaanDeMeyer added a project: clang-tools-extra. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. This is useful when using clangd with CMake based proje