@@ -83,7 +83,13 @@ __llvm_profile_iterate_data(const __llvm_profile_data *Data)
{
/* This method is only used in value profiler mock testing. */
COMPILER_RT_VISIBILITY void *
__llvm_get_function_addr(const __llvm_profile_data *Data) {
- return Data->FunctionPointer;
+ void
@@ -83,7 +83,13 @@ __llvm_profile_iterate_data(const __llvm_profile_data *Data)
{
/* This method is only used in value profiler mock testing. */
COMPILER_RT_VISIBILITY void *
__llvm_get_function_addr(const __llvm_profile_data *Data) {
- return Data->FunctionPointer;
+ void
@@ -1877,6 +1946,32 @@ inline Registers_arm64::Registers_arm64(const void
*registers) {
memcpy(_vectorHalfRegisters,
static_cast(registers) + sizeof(GPRs),
sizeof(_vectorHalfRegisters));
+#if __has_feature(ptrauth_calls)
+ uint64_t pcRegister = 0;
+ memcp
@@ -1845,10 +1871,53 @@ class _LIBUNWIND_HIDDEN Registers_arm64 {
uint64_t getSP() const { return _registers.__sp; }
void setSP(uint64_t value) { _registers.__sp = value; }
- uint64_t getIP() const { return _registers.__pc; }
- void setIP(uint
@@ -541,7 +554,33 @@ struct scan_results
};
} // unnamed namespace
+}
+namespace {
+// The logical model for casting authenticated function pointers makes
+// it impossible to directly cast them without breaking the authentication,
+// as a result we need this pair of helpe
@@ -1845,10 +1871,53 @@ class _LIBUNWIND_HIDDEN Registers_arm64 {
uint64_t getSP() const { return _registers.__sp; }
void setSP(uint64_t value) { _registers.__sp = value; }
- uint64_t getIP() const { return _registers.__pc; }
- void setIP(uint
@@ -207,7 +211,8 @@ bool DwarfInstructions::isReturnAddressSignedWithPC(A
&addressSpace,
#endif
template
-int DwarfInstructions::stepWithDwarf(A &addressSpace, pint_t pc,
+int DwarfInstructions::stepWithDwarf(A &addressSpace,
kovdan01 wrote:
In this functio
@@ -207,7 +211,8 @@ bool DwarfInstructions::isReturnAddressSignedWithPC(A
&addressSpace,
#endif
template
-int DwarfInstructions::stepWithDwarf(A &addressSpace, pint_t pc,
+int DwarfInstructions::stepWithDwarf(A &addressSpace,
+ typen
https://github.com/kovdan01 edited
https://github.com/llvm/llvm-project/pull/143230
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -126,6 +130,36 @@ _LIBUNWIND_HIDDEN int __unw_set_reg(unw_cursor_t *cursor,
unw_regnum_t regNum,
// First, get the FDE for the old location and then update it.
co->getInfo(&info);
co->setInfoBasedOnIPRegister(false);
+
+#if __has_feature(ptrauth_calls)
+
@@ -1877,6 +1946,32 @@ inline Registers_arm64::Registers_arm64(const void
*registers) {
memcpy(_vectorHalfRegisters,
static_cast(registers) + sizeof(GPRs),
sizeof(_vectorHalfRegisters));
+#if __has_feature(ptrauth_calls)
kovdan01 wrote:
It
@@ -83,7 +83,13 @@ __llvm_profile_iterate_data(const __llvm_profile_data *Data)
{
/* This method is only used in value profiler mock testing. */
COMPILER_RT_VISIBILITY void *
__llvm_get_function_addr(const __llvm_profile_data *Data) {
- return Data->FunctionPointer;
+ void
@@ -1845,10 +1871,53 @@ class _LIBUNWIND_HIDDEN Registers_arm64 {
uint64_t getSP() const { return _registers.__sp; }
void setSP(uint64_t value) { _registers.__sp = value; }
- uint64_t getIP() const { return _registers.__pc; }
- void setIP(uint
@@ -1845,10 +1871,53 @@ class _LIBUNWIND_HIDDEN Registers_arm64 {
uint64_t getSP() const { return _registers.__sp; }
void setSP(uint64_t value) { _registers.__sp = value; }
- uint64_t getIP() const { return _registers.__pc; }
- void setIP(uint
@@ -83,7 +83,13 @@ __llvm_profile_iterate_data(const __llvm_profile_data *Data)
{
/* This method is only used in value profiler mock testing. */
COMPILER_RT_VISIBILITY void *
__llvm_get_function_addr(const __llvm_profile_data *Data) {
- return Data->FunctionPointer;
+ void
@@ -93,6 +98,13 @@ class _LIBUNWIND_HIDDEN Registers_x86 {
uint32_t getEDI() const { return _registers.__edi; }
void setEDI(uint32_t value) { _registers.__edi = value; }
+ typedef uint32_t reg_t;
+ typedef uint32_t link_reg_t;
+ void loadAndAuthenticateLin
@@ -1845,10 +1871,53 @@ class _LIBUNWIND_HIDDEN Registers_arm64 {
uint64_t getSP() const { return _registers.__sp; }
void setSP(uint64_t value) { _registers.__sp = value; }
- uint64_t getIP() const { return _registers.__pc; }
- void setIP(uint
@@ -1877,6 +1946,32 @@ inline Registers_arm64::Registers_arm64(const void
*registers) {
memcpy(_vectorHalfRegisters,
static_cast(registers) + sizeof(GPRs),
sizeof(_vectorHalfRegisters));
+#if __has_feature(ptrauth_calls)
+ uint64_t pcRegister = 0;
+ memcp
kovdan01 wrote:
> Any other feedback on this patch?
>
> For those who haven't followed the RFC, the RFC received positive reviews,
> and we have reached a consensus to move forward with the proposal.
> https://discourse.llvm.org/t/rfc-ptrauth-qualifier/80710/31
@ahatanak I personally have no
https://github.com/kovdan01 ready_for_review
https://github.com/llvm/llvm-project/pull/125280
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kovdan01 created
https://github.com/llvm/llvm-project/pull/125280
This patch does two things.
1. Previously, when checking driver arguments, we emitted an error for
unsupported values of `-mbranch-protection` when using pauthtest ABI. The
reason for that was ptrauth-returns
https://github.com/kovdan01 updated
https://github.com/llvm/llvm-project/pull/113150
>From 838b0d0ed5592b2a74560373252f17b49ae64ee7 Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Mon, 21 Oct 2024 10:58:04 +0300
Subject: [PATCH] [PAC][clang] Add new features to pauthtest ABI
Enable init/fi
https://github.com/kovdan01 updated
https://github.com/llvm/llvm-project/pull/113150
>From 8384b1df4f7bbf454580b7486988e1808df9825d Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Mon, 21 Oct 2024 10:58:04 +0300
Subject: [PATCH] [PAC][clang] Add new features to pauthtest ABI
Enable init/fi
https://github.com/kovdan01 closed
https://github.com/llvm/llvm-project/pull/119361
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kovdan01 updated
https://github.com/llvm/llvm-project/pull/119361
>From 944b2f8fb6357c5ef9efbdaf0c2c3dcd8cb9f890 Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Tue, 10 Dec 2024 08:48:09 +0300
Subject: [PATCH 1/2] [PAC][ELF][AArch64] Support signed personality function
p
https://github.com/kovdan01 ready_for_review
https://github.com/llvm/llvm-project/pull/119361
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kovdan01 wrote:
@MaskRay Regarding your comment
https://github.com/llvm/llvm-project/pull/113148#discussion_r1866992275:
> We should add a subclass of MachineModuleInfoELF similar to
> `AMDGPUMachineModuleInfo`, then move `HasSignedpersonality` there. Here you
> can use a static_cast.
Maybe
https://github.com/kovdan01 created
https://github.com/llvm/llvm-project/pull/119361
Re-apply #113148 after revert in #119331
If function pointer signing is enabled, sign personality function pointer
stored in `.DW.ref.__gxx_personality_v0` section with IA key, 0x7EAD =
`ptrauth_string_discri
https://github.com/kovdan01 ready_for_review
https://github.com/llvm/llvm-project/pull/119331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kovdan01 closed
https://github.com/llvm/llvm-project/pull/119331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kovdan01 created
https://github.com/llvm/llvm-project/pull/119331
Reverts llvm/llvm-project#113148
See buildbot failure https://lab.llvm.org/buildbot/#/builders/190/builds/11048
>From 4fe98aa2253925a6bc24bd30f2c654756c77cc28 Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Dat
https://github.com/kovdan01 closed
https://github.com/llvm/llvm-project/pull/113148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kovdan01 wrote:
@MaskRay Please let me know if latest changes fix your previous comments and if
this could be merged.
https://github.com/llvm/llvm-project/pull/113148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/kovdan01 updated
https://github.com/llvm/llvm-project/pull/113150
>From 74814fd9424853399196b7d1e73f6171b0f1980b Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Mon, 21 Oct 2024 10:58:04 +0300
Subject: [PATCH] [PAC][clang] Add new features to pauthtest ABI
Enable init/fi
https://github.com/kovdan01 closed
https://github.com/llvm/llvm-project/pull/113149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kovdan01 updated
https://github.com/llvm/llvm-project/pull/113150
>From f670756ad5e120a3c81025565ab96c3aea12cd3e Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Mon, 21 Oct 2024 10:58:04 +0300
Subject: [PATCH] [PAC][clang] Add new features to pauthtest ABI
Enable init/fi
https://github.com/kovdan01 edited
https://github.com/llvm/llvm-project/pull/113150
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kovdan01 wrote:
### Merge activity
* **Dec 5, 3:32 AM EST**: A user started a stack merge that includes this pull
request via
[Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/113149).
https://github.com/llvm/llvm-project/pull/113149
@@ -28,6 +29,21 @@ void AArch64_ELFTargetObjectFile::Initialize(MCContext &Ctx,
SupportDebugThreadLocalLocation = false;
}
+void AArch64_ELFTargetObjectFile::emitPersonalityValueImpl(
+MCStreamer &Streamer, const DataLayout &DL, const MCSymbol *Sym,
+const MachineMod
https://github.com/kovdan01 updated
https://github.com/llvm/llvm-project/pull/113148
>From 9d7f4eb9a99a7d765095f571f5a209164862fe49 Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Mon, 21 Oct 2024 13:28:58 +0300
Subject: [PATCH 1/3] [PAC][ELF][AArch64] Support signed personality function
p
https://github.com/kovdan01 updated
https://github.com/llvm/llvm-project/pull/113148
>From 9d7f4eb9a99a7d765095f571f5a209164862fe49 Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Mon, 21 Oct 2024 13:28:58 +0300
Subject: [PATCH 1/4] [PAC][ELF][AArch64] Support signed personality function
p
kovdan01 wrote:
> LGTM
>
> I expect some discussion in the description / commit message why
> AArch64JumpTableHardening is placed together with other `PointerAuth*`
> options.
@MaskRay Thanks for feedback, please let me know if the following description
addresses your comment:
> The flag is
https://github.com/kovdan01 edited
https://github.com/llvm/llvm-project/pull/113149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -35,6 +35,16 @@ AArch64TargetStreamer::AArch64TargetStreamer(MCStreamer &S)
AArch64TargetStreamer::~AArch64TargetStreamer() = default;
+void AArch64TargetStreamer::emitAuthValue(const MCExpr *Expr,
+ uint16_t Discriminator,
+
kovdan01 wrote:
@ahmedbougacha @ahatanak Please let me know if you have any objections on this.
https://github.com/llvm/llvm-project/pull/113149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
kovdan01 wrote:
Would be glad to see everyone's feedback on the changes.
https://github.com/llvm/llvm-project/pull/113148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kovdan01 updated
https://github.com/llvm/llvm-project/pull/113149
>From c4c6657bd4a191c79784b4f280b8b03ce3e06bdd Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Mon, 21 Oct 2024 11:32:02 +0300
Subject: [PATCH] [PAC][clang] Add `-faarch64-jump-table-hardening` driver flag
https://github.com/kovdan01 updated
https://github.com/llvm/llvm-project/pull/113149
>From 06b865d888142acf2c7a66ea487a14f34169 Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Mon, 21 Oct 2024 11:32:02 +0300
Subject: [PATCH] [PAC][clang] Add `-faarch64-jump-table-hardening` driver flag
kovdan01 wrote:
@ahmedbougacha @ahatanak Please let me know if you have any objections on this.
@MaskRay Would be glad to see your feedback as well. See also
https://github.com/llvm/llvm-project/pull/113152#issuecomment-2486394507
https://github.com/llvm/llvm-project/pull/113149
___
https://github.com/kovdan01 updated
https://github.com/llvm/llvm-project/pull/113148
>From 9d7f4eb9a99a7d765095f571f5a209164862fe49 Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Mon, 21 Oct 2024 13:28:58 +0300
Subject: [PATCH] [PAC][ELF][AArch64] Support signed personality function
point
https://github.com/kovdan01 updated
https://github.com/llvm/llvm-project/pull/113149
>From 270fa9e3e47a9e23031bfdd421695727fbee14c2 Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Mon, 21 Oct 2024 11:32:02 +0300
Subject: [PATCH] [PAC][clang] Add `-faarch64-jump-table-hardening` driver flag
https://github.com/kovdan01 closed
https://github.com/llvm/llvm-project/pull/96160
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kovdan01 edited
https://github.com/llvm/llvm-project/pull/96160
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kovdan01 updated
https://github.com/llvm/llvm-project/pull/96160
>From fd3919e8fcd6c40fc8dcb83b4d1d8dd2fee0e5bb Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Fri, 15 Nov 2024 10:46:27 +0300
Subject: [PATCH] [PAC][clang] Add signed GOT cc1 flag
Add `-fptrauth-elf-got` c
https://github.com/kovdan01 edited
https://github.com/llvm/llvm-project/pull/96160
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kovdan01 wrote:
Would be glad to see everyone's feedback on the changes.
https://github.com/llvm/llvm-project/pull/113148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kovdan01 updated
https://github.com/llvm/llvm-project/pull/113148
>From e192b193471831d004a715ce3b1684198342dba4 Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Mon, 21 Oct 2024 13:28:58 +0300
Subject: [PATCH] [PAC][ELF][AArch64] Support signed personality function
point
kovdan01 wrote:
Rebased on top of current main with fixing conflicts.
@MaskRay Would be glad if you give your feedback on this so the PR could be
finally merged if no issues are left.
https://github.com/llvm/llvm-project/pull/96160
___
cfe-commits mai
https://github.com/kovdan01 updated
https://github.com/llvm/llvm-project/pull/96160
>From 3a5ae0151d6fc0d5753450a4277852e5e090cabe Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Fri, 15 Nov 2024 10:46:27 +0300
Subject: [PATCH] [PAC][clang] Add signed GOT cc1 flag
Add `-fptrauth-elf-got` c
https://github.com/kovdan01 updated
https://github.com/llvm/llvm-project/pull/96160
>From 1ca6cf823585b03a6c580b23caafd1ff44d83aa7 Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Tue, 6 Aug 2024 20:02:07 +0300
Subject: [PATCH 1/3] [PAC][clang][Driver] Add signed GOT flag
Depends on #96159
https://github.com/kovdan01 edited
https://github.com/llvm/llvm-project/pull/96160
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kovdan01 edited
https://github.com/llvm/llvm-project/pull/96160
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kovdan01 updated
https://github.com/llvm/llvm-project/pull/96160
>From 1ca6cf823585b03a6c580b23caafd1ff44d83aa7 Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Tue, 6 Aug 2024 20:02:07 +0300
Subject: [PATCH 1/3] [PAC][clang][Driver] Add signed GOT flag
Depends on #96159
kovdan01 wrote:
> Using cc1 options looks fine.
Thanks!
> Sorry, I made a mistake by approving #85235, which added a lot of driver
> options. It's not clear who are the initial ELF ptrauth users, but I am not
> sure with a very small user base, there are a lot of demands to customize the
> p
kovdan01 wrote:
@MaskRay Would be glad to see your answer on the question above:
> If we only add cc1 flag and postpone adding driver flag, would it be OK?
https://github.com/llvm/llvm-project/pull/96160
___
cfe-commits mailing list
cfe-commits@lists.
kovdan01 wrote:
@ahmedbougacha @ahatanak Please let me know if you have any objections on this.
https://github.com/llvm/llvm-project/pull/113149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
kovdan01 wrote:
Would be glad to see everyone's feedback on the changes.
https://github.com/llvm/llvm-project/pull/113148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kovdan01 wrote:
@ahmedbougacha @ahatanak Please let me know if you have any objections on this.
https://github.com/llvm/llvm-project/pull/113149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
kovdan01 wrote:
Would be glad to see everyone's feedback on the changes.
https://github.com/llvm/llvm-project/pull/113148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kovdan01 updated
https://github.com/llvm/llvm-project/pull/96160
>From 1ca6cf823585b03a6c580b23caafd1ff44d83aa7 Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Tue, 6 Aug 2024 20:02:07 +0300
Subject: [PATCH 1/2] [PAC][clang][Driver] Add signed GOT flag
Depends on #96159
kovdan01 wrote:
> Given the complexity of the feature and lack of upstream runtime linker
> (rtld) support, it might be wise to delay exposing it through driver options
> until it's more mature. What do you think?
@MaskRay I suppose that if exposing this to driver options is considered
undesi
https://github.com/kovdan01 ready_for_review
https://github.com/llvm/llvm-project/pull/113149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kovdan01 edited
https://github.com/llvm/llvm-project/pull/113149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kovdan01 wrote:
* **#113150** https://app.graphite.dev/github/pr/llvm/llvm-project/113150?utm_source=stack-comment-icon";
target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite"
width="10px" height="10px"/>
* **#113149** https://app.graphite.dev/github/pr/llvm/llvm
https://github.com/kovdan01 created
https://github.com/llvm/llvm-project/pull/113149
None
>From 63c44aeddc461d193a64677d0d066d9cb0851b2a Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Mon, 21 Oct 2024 11:32:02 +0300
Subject: [PATCH] [PAC][clang] Add `-faarch64-jump-table-hardening` driver
https://github.com/kovdan01 ready_for_review
https://github.com/llvm/llvm-project/pull/113148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kovdan01 created
https://github.com/llvm/llvm-project/pull/113148
If function pointer signing is enabled, sign personality function pointer
stored in `.DW.ref.__gxx_personality_v0` section with IA key, 0x7EAD =
`ptrauth_string_discriminator("personality")` constant discrimin
https://github.com/kovdan01 closed
https://github.com/llvm/llvm-project/pull/102199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4207,16 +4214,31 @@ llvm::Constant *ItaniumRTTIBuilder::BuildTypeInfo(
break;
}
- llvm::Constant *Init = llvm::ConstantStruct::getAnon(Fields);
-
SmallString<256> Name;
llvm::raw_svector_ostream Out(Name);
CGM.getCXXABI().getMangleContext().mangleCXXRTTI(Ty
kovdan01 wrote:
@efriedma-quic I've switched to `replaceInitializer`, thanks for suggestion!
Now we construct `GV` with `nullptr` as initializer and
`llvm::ConstantStruct::getTypeForElements(Fields)` as type, and then replace
the initializer with `llvm::ConstantStruct::getAnon(Fields)`. See
5
https://github.com/kovdan01 updated
https://github.com/llvm/llvm-project/pull/102199
>From 0c20bcdf35f3c15024986da50cafb2a8c155e3cf Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Tue, 6 Aug 2024 20:48:02 +0300
Subject: [PATCH 1/3] [PAC] Fix address discrimination for type info vtable
poin
kovdan01 wrote:
> I think you should be able to avoid constructing the initializer twice if you
> restructure the code a bit to just construct the global before the call to
> BuildVTablePointer. I added GlobalVariable::replaceInitializer because I was
> looking at this review: it lets you cons
https://github.com/kovdan01 closed
https://github.com/llvm/llvm-project/pull/109247
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kovdan01 ready_for_review
https://github.com/llvm/llvm-project/pull/109247
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kovdan01 created
https://github.com/llvm/llvm-project/pull/109247
None
>From 26e9605ba09e0bc997a17804bae482d556501c0a Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Tue, 10 Sep 2024 10:02:07 +0300
Subject: [PATCH] [PAC][clang] Use cc1 instead of driver in init-fini code
@@ -3955,9 +3955,23 @@ void ItaniumRTTIBuilder::BuildVTablePointer(const Type
*Ty) {
VTable, Two);
}
- if (auto &Schema = CGM.getCodeGenOpts().PointerAuth.CXXTypeInfoVTablePointer)
-VTable = CGM.getConstantSigne
@@ -1056,12 +1056,18 @@ class ConstantPtrAuth final : public Constant {
return !getAddrDiscriminator()->isNullValue();
}
- /// A constant value for the address discriminator which has special
- /// significance to ctors/dtors lowering. Regular address discrimination
c
kovdan01 wrote:
@efriedma-quic @ahmedbougacha @ojhunt Would be glad to see your comments after
the latest commit 0c20bcdf35f3c15024986da50cafb2a8c155e3cf which introduces
using actual storage address instead of 'inttoptr 1' placeholder.
https://github.com/llvm/llvm-project/pull/102199
https://github.com/kovdan01 updated
https://github.com/llvm/llvm-project/pull/102199
>From 0c20bcdf35f3c15024986da50cafb2a8c155e3cf Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Tue, 6 Aug 2024 20:48:02 +0300
Subject: [PATCH 1/2] [PAC] Fix address discrimination for type info vtable
poin
https://github.com/kovdan01 commented:
LGTM in terms of addressing my previous comments, and I also do not have new
ones. But I'm not deeply into the context of the patch, so I'd prefer to wait
for other reviews on this.
https://github.com/llvm/llvm-project/pull/86212
_
https://github.com/kovdan01 closed
https://github.com/llvm/llvm-project/pull/102508
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kovdan01 ready_for_review
https://github.com/llvm/llvm-project/pull/102508
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kovdan01 created
https://github.com/llvm/llvm-project/pull/102508
For llvm_linux platform, define the following meaning for bits 9, 10, 11:
- bit 9: set if indirect gotos signing is enabled;
- bit 10: set if type info vtable pointer discrimination is enabled;
- bit 11: set if
@@ -1056,12 +1056,18 @@ class ConstantPtrAuth final : public Constant {
return !getAddrDiscriminator()->isNullValue();
}
- /// A constant value for the address discriminator which has special
- /// significance to ctors/dtors lowering. Regular address discrimination
c
https://github.com/kovdan01 ready_for_review
https://github.com/llvm/llvm-project/pull/102199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kovdan01 wrote:
Also tagging @ojhunt (GitHub still does not let to add as a reviewer)
https://github.com/llvm/llvm-project/pull/102199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kovdan01 created
https://github.com/llvm/llvm-project/pull/102199
In #99726, `-fptrauth-type-info-vtable-pointer-discrimination` was introduced,
which is intended to enable type and address discrimination for type_info
vtable pointers. However, some codegen logic for actuall
https://github.com/kovdan01 updated
https://github.com/llvm/llvm-project/pull/96160
>From 1ca6cf823585b03a6c580b23caafd1ff44d83aa7 Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Tue, 6 Aug 2024 20:02:07 +0300
Subject: [PATCH 1/2] [PAC][clang][Driver] Add signed GOT flag
Depends on #96159
https://github.com/kovdan01 updated
https://github.com/llvm/llvm-project/pull/96160
>From 1ca6cf823585b03a6c580b23caafd1ff44d83aa7 Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Tue, 6 Aug 2024 20:02:07 +0300
Subject: [PATCH] [PAC][clang][Driver] Add signed GOT flag
Depends on #96159
Add
https://github.com/kovdan01 closed
https://github.com/llvm/llvm-project/pull/96159
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 428 matches
Mail list logo
