[PATCH] D155955: [Clang] Improve the handling of large arrays evaluation.

danilaml added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:1026 + // APValue stores array extents as unsigned, + // so anything that is greater that unsigned would overflow when + // constructing the array, we catch this here. ==

[PATCH] D62574: Add support for target-configurable address spaces.

danilaml added a comment. So is missing an in-tree user (like AMDGPU) the only thing that prevents from merging this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62574/new/ https://reviews.llvm.org/D62574 ___

[PATCH] D89220: [clang-rename] Simplify the code of handling class paritial specializations, NFC.

danilaml added inline comments. Comment at: clang/lib/Tooling/Refactoring/Rename/USRFindingAction.cpp:119 +llvm::for_each(PartialSpecs, + [&](const auto *Spec) { addUSRsOfCtorDtors(Spec); }); addUSRsOfCtorDtors(TemplateDecl->getTemplatedDecl()); ---

[PATCH] D62574: Initial draft of target-configurable address spaces.

danilaml added a comment. In D62574#2135662 , @ebevhan wrote: > It's generally not safe to alter address spaces below the top level. C is > just very permissive about it. Isn't that also true for the top-level casts? Unless when it is. And the target s

[PATCH] D62574: Initial draft of target-configurable address spaces.

danilaml added a comment. What are the remaining roadblocks left before this patch can be merged? I'm interested in having a target-specific way to define the allowed explicit/implicit address space conversions. Also, it appears that currently whether implicit casts between pointers of differen

[PATCH] D52360: [clang-tidy] Fix for performance-unnecessary-value-param, performance-unnecessary-copy-initialization and performance-for-range-copy

danilaml added a comment. Would that also skip checks for something like `shared_ptr`? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

danilaml added inline comments. Comment at: lib/Format/FormatToken.h:323 + bool closesScopeAfterBlock() const { +if(BlockKind == BK_Block) + return true; Looks like all other `if`s in this file have space before `(`. Repository: rC Clang https://re