[clang] [IPSCCP] Variable not visible at Og. (PR #66745)

@@ -106,14 +107,71 @@ static void findReturnsToZap(Function &F, } } -static bool runIPSCCP( -Module &M, const DataLayout &DL, FunctionAnalysisManager *FAM, -std::function GetTLI, -std::function GetTTI, -std::function GetAC, -std::function GetDT, -std:

[clang-tools-extra] [IPSCCP] Variable not visible at Og. (PR #66745)

@@ -106,14 +107,71 @@ static void findReturnsToZap(Function &F, } } -static bool runIPSCCP( -Module &M, const DataLayout &DL, FunctionAnalysisManager *FAM, -std::function GetTLI, -std::function GetTTI, -std::function GetAC, -std::function GetDT, -std:

[clang-tools-extra] [IPSCCP] Variable not visible at Og. (PR #66745)

@@ -106,14 +107,71 @@ static void findReturnsToZap(Function &F, } } -static bool runIPSCCP( -Module &M, const DataLayout &DL, FunctionAnalysisManager *FAM, -std::function GetTLI, -std::function GetTTI, -std::function GetAC, -std::function GetDT, -std:

[clang] [IPSCCP] Variable not visible at Og. (PR #66745)

@@ -106,14 +107,71 @@ static void findReturnsToZap(Function &F, } } -static bool runIPSCCP( -Module &M, const DataLayout &DL, FunctionAnalysisManager *FAM, -std::function GetTLI, -std::function GetTTI, -std::function GetAC, -std::function GetDT, -std:

[clang] Introduce paged vector (PR #66430)

dwblaikie wrote: > This only affects builds with GCC. My understanding was that we basically only cared about performance of clang on clang - that we expect people who want an efficient clang to bootstrap? Could `always_inline` the function, but those sort of annotations would get out of date

[clang] [clang] Enable Wenum-constexpr-conversion also in system headers and … (PR #67528)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= Message-ID: In-Reply-To: dwblaikie wrote: > It seems checks are broken on trunk, I see commits merged with failing > pre-merge tests. They seem to be unrelated to this patch though. > > Is there anything else you'd like fixed before mergi

[clang] [clang][Modules] Make `Module::Requirement` a struct (PR #67900)

https://github.com/dwblaikie approved this pull request. Awesome - love a good readability improvement. Thanks! https://github.com/llvm/llvm-project/pull/67900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[clang] Introduce paged vector (PR #66430)

dwblaikie wrote: Oh, no worries at all. LLVM 's still figuring out this whole GitHub transition anyway. I mention it only for future reference and because it might help reviewers/you if comments are getting missplaced/there's trouble tracking unaddressed feedback, etc. Thanks for sticking wit

[clang] Introduce paged vector (PR #66430)

dwblaikie wrote: (aside: I was confused why there was only one commit in this PR, since there'd been so many updates to it - but I see they've been force pushed, which my vague understanding is that force pushing can complicate tracking previous comments and the LLVM convention is not to do so

[clang] [C++20] [Modules] Don't generate call to an imported module that dont init anything (PR #67638)

@@ -1245,6 +1245,27 @@ void Sema::ActOnEndOfTranslationUnit() { } } +// Now we can decide whether the modules we're building need an initializer. +if (Module *CurrentModule = getCurrentModule(); +CurrentModule && CurrentModule->isInterfaceOrPartition

[clang] [LLVM] Add new attribute `optdebug` to optimize for debugging (PR #66632)

@@ -2325,6 +2325,7 @@ void CodeGenModule::SetLLVMFunctionAttributesForDefinition(const Decl *D, B.addAttribute(llvm::Attribute::Naked); // OptimizeNone wins over OptimizeForSize and MinSize. +F->removeFnAttr(llvm::Attribute::OptimizeForDebugging); --

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -7944,9 +7944,13 @@ void ASTReader::PrintStats() { std::fprintf(stderr, "*** AST File Statistics:\n"); unsigned NumTypesLoaded = - TypesLoaded.size() - llvm::count(TypesLoaded, QualType()); + TypesLoaded.size() - std::count(TypesLoaded.materialisedBegin(), ---

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] 2993243 - Fix misdiagnosed writability for __attribute__((section()))

Author: David Blaikie Date: 2023-08-17T05:35:40Z New Revision: 2993243c45abdb4f2bc3979336d054be165b1134 URL: https://github.com/llvm/llvm-project/commit/2993243c45abdb4f2bc3979336d054be165b1134 DIFF: https://github.com/llvm/llvm-project/commit/2993243c45abdb4f2bc3979336d054be165b1134.diff LOG:

[clang] 19f2b68 - Make globals with mutable members non-constant, even in custom sections

Author: David Blaikie Date: 2023-08-14T22:25:42Z New Revision: 19f2b68095fe727e40079b7c6380b36b6462e691 URL: https://github.com/llvm/llvm-project/commit/19f2b68095fe727e40079b7c6380b36b6462e691 DIFF: https://github.com/llvm/llvm-project/commit/19f2b68095fe727e40079b7c6380b36b6462e691.diff LOG:

Re: [clang] 3b34d69 - Revert "For #64088: mark vtable as used if we might emit a reference to it."

Ping on this - please always include details on the reason for a revert. On Tue, Aug 1, 2023 at 10:09 AM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This revert reintroduces a wrong-code bug, can you explain what the > purpose of the revert is? > > On Fri, 28 Jul 2023 at

[clang] 3a100ea - Fix test to not write temporary files, use -fsyntax-only instead

Author: David Blaikie Date: 2023-07-31T19:01:44Z New Revision: 3a100ea901ed79d6a06a5f018be2b4d3bbca51e8 URL: https://github.com/llvm/llvm-project/commit/3a100ea901ed79d6a06a5f018be2b4d3bbca51e8 DIFF: https://github.com/llvm/llvm-project/commit/3a100ea901ed79d6a06a5f018be2b4d3bbca51e8.diff LOG:

[clang] b43df5b - PseudoObjectExpr: Prefer ArrayRef over iterator_range when iterating with pointers

Author: David Blaikie Date: 2023-07-18T23:43:41Z New Revision: b43df5bfe7e7ef358e135b515b0651ec51f635d8 URL: https://github.com/llvm/llvm-project/commit/b43df5bfe7e7ef358e135b515b0651ec51f635d8 DIFF: https://github.com/llvm/llvm-project/commit/b43df5bfe7e7ef358e135b515b0651ec51f635d8.diff LOG:

[clang] 793c5b1 - Fix for release notes (follow-up to D149182/a8b0c6fa)

Author: David Blaikie Date: 2023-05-09T00:40:11Z New Revision: 793c5b12b9a70e363be40c5da2e26d7151fbbf41 URL: https://github.com/llvm/llvm-project/commit/793c5b12b9a70e363be40c5da2e26d7151fbbf41 DIFF: https://github.com/llvm/llvm-project/commit/793c5b12b9a70e363be40c5da2e26d7151fbbf41.diff LOG:

[clang] a8b0c6f - Remove -Wpacked false positive for non-pod types where the layout isn't directly changed

Author: David Blaikie Date: 2023-05-09T00:13:45Z New Revision: a8b0c6fa28acced71db33e80bd0b51d00422035b URL: https://github.com/llvm/llvm-project/commit/a8b0c6fa28acced71db33e80bd0b51d00422035b DIFF: https://github.com/llvm/llvm-project/commit/a8b0c6fa28acced71db33e80bd0b51d00422035b.diff LOG:

[clang] e5144d9 - Fix a few clang-tidy warnings (container empty checks, function decl/def param naming)

Author: David Blaikie Date: 2023-04-05T01:06:41Z New Revision: e5144d9d2dd26a67f576d2f5772b3cf0486245f4 URL: https://github.com/llvm/llvm-project/commit/e5144d9d2dd26a67f576d2f5772b3cf0486245f4 DIFF: https://github.com/llvm/llvm-project/commit/e5144d9d2dd26a67f576d2f5772b3cf0486245f4.diff LOG:

[clang] e9c9db3 - PR58819: Correct linkage and mangling of lambdas in inline static member initializers

Author: David Blaikie Date: 2023-04-04T04:45:32Z New Revision: e9c9db34a9b04706937e9dd764d1d97ca84337b6 URL: https://github.com/llvm/llvm-project/commit/e9c9db34a9b04706937e9dd764d1d97ca84337b6 DIFF: https://github.com/llvm/llvm-project/commit/e9c9db34a9b04706937e9dd764d1d97ca84337b6.diff LOG:

[clang] 58ec6e0 - [NFC] [clang] Forward forwarding reference

Author: Chris Cotter Date: 2023-02-28T01:27:21Z New Revision: 58ec6e09abe8083709802833572bca931b2d15d9 URL: https://github.com/llvm/llvm-project/commit/58ec6e09abe8083709802833572bca931b2d15d9 DIFF: https://github.com/llvm/llvm-project/commit/58ec6e09abe8083709802833572bca931b2d15d9.diff LOG:

[clang] d8a1a55 - DebugInfo: Disable ctor homing for types with only deleted (non copy/move) ctors

Author: David Blaikie Date: 2023-02-28T01:25:22Z New Revision: d8a1a559f3009a31c517f864156db91d2ae3012c URL: https://github.com/llvm/llvm-project/commit/d8a1a559f3009a31c517f864156db91d2ae3012c DIFF: https://github.com/llvm/llvm-project/commit/d8a1a559f3009a31c517f864156db91d2ae3012c.diff LOG:

Re: [clang] 931d04b - [ADT] Make StringRef::compare like std::string_view::compare

Nice! On Sun, Jan 15, 2023 at 12:10 PM Benjamin Kramer via cfe-commits wrote: > > > Author: Benjamin Kramer > Date: 2023-01-15T20:59:21+01:00 > New Revision: 931d04be2fc8f3f0505b43e64297f75d526cb42a > > URL: > https://github.com/llvm/llvm-project/commit/931d04be2fc8f3f0505b43e64297f75d526cb42a >

[clang] 7a91e00 - Ensure clang test doesn't write out to the source directory

Author: David Blaikie Date: 2022-12-16T23:39:28Z New Revision: 7a91e00d915c638bfb4864826bc445211e0e41d7 URL: https://github.com/llvm/llvm-project/commit/7a91e00d915c638bfb4864826bc445211e0e41d7 DIFF: https://github.com/llvm/llvm-project/commit/7a91e00d915c638bfb4864826bc445211e0e41d7.diff LOG:

[clang] be931f8 - clang/test/CodeCompletion: Simplify/fix some `touch` commands

Author: David Blaikie Date: 2022-12-16T23:18:11Z New Revision: be931f89451b650e081daf875213c19f658caf25 URL: https://github.com/llvm/llvm-project/commit/be931f89451b650e081daf875213c19f658caf25 DIFF: https://github.com/llvm/llvm-project/commit/be931f89451b650e081daf875213c19f658caf25.diff LOG:

[clang] c73876d - Reapply "DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions""

Author: David Blaikie Date: 2022-12-12T22:36:23Z New Revision: c73876db4f2dfd2c38d5720f62509e57f23b2059 URL: https://github.com/llvm/llvm-project/commit/c73876db4f2dfd2c38d5720f62509e57f23b2059 DIFF: https://github.com/llvm/llvm-project/commit/c73876db4f2dfd2c38d5720f62509e57f23b2059.diff LOG:

[clang] 6ab6085 - Revert "DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions"

Author: David Blaikie Date: 2022-12-06T22:52:47Z New Revision: 6ab6085c77ef9bcdabf842342f63fba4291791a4 URL: https://github.com/llvm/llvm-project/commit/6ab6085c77ef9bcdabf842342f63fba4291791a4 DIFF: https://github.com/llvm/llvm-project/commit/6ab6085c77ef9bcdabf842342f63fba4291791a4.diff LOG:

[clang] 3c312e4 - DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

Author: David Blaikie Date: 2022-12-06T21:11:08Z New Revision: 3c312e48f325c1b1ee11404ee6cfa08ee00037b0 URL: https://github.com/llvm/llvm-project/commit/3c312e48f325c1b1ee11404ee6cfa08ee00037b0 DIFF: https://github.com/llvm/llvm-project/commit/3c312e48f325c1b1ee11404ee6cfa08ee00037b0.diff LOG:

Re: [clang] a446827 - [NFC][Clang][Driver][AMDGPU] Avoid temporary copies of std::string by using Twine and StringRef

On Mon, Dec 5, 2022 at 5:27 AM Juan Manuel MARTINEZ CAAMAÑO via cfe-commits wrote: > > > Author: Juan Manuel MARTINEZ CAAMAÑO > Date: 2022-12-05T07:27:10-06:00 > New Revision: a446827249bdeb2f27e55a9f4942bd7425ecb0ff > > URL: > https://github.com/llvm/llvm-project/commit/a446827249bdeb2f27e55a9f4

[clang] 2cea4c2 - Do not suggest taking the address of a const pointer to get void*

Author: Alexey Kreshchuk Date: 2022-11-23T18:43:06Z New Revision: 2cea4c239570c37f46ad0003b3d41d9473aca60f URL: https://github.com/llvm/llvm-project/commit/2cea4c239570c37f46ad0003b3d41d9473aca60f DIFF: https://github.com/llvm/llvm-project/commit/2cea4c239570c37f46ad0003b3d41d9473aca60f.diff L

[clang] 9df8ba6 - pr59000: Clarify packed-non-pod warning that it's pod-for-the-purposes-of-layout

Author: David Blaikie Date: 2022-11-22T00:02:09Z New Revision: 9df8ba631d4612eb8f930c9fe7c6cf39e5deb3af URL: https://github.com/llvm/llvm-project/commit/9df8ba631d4612eb8f930c9fe7c6cf39e5deb3af DIFF: https://github.com/llvm/llvm-project/commit/9df8ba631d4612eb8f930c9fe7c6cf39e5deb3af.diff LOG:

[clang] a72d8d7 - Update lambda mangling test to C++17

Author: David Blaikie Date: 2022-11-18T00:24:40Z New Revision: a72d8d704178118b254d9ff84a78afb18813b888 URL: https://github.com/llvm/llvm-project/commit/a72d8d704178118b254d9ff84a78afb18813b888 DIFF: https://github.com/llvm/llvm-project/commit/a72d8d704178118b254d9ff84a78afb18813b888.diff LOG:

Re: [clang] a88ebd4 - Revert "[clang] Instantiate NTTPs and template default arguments with sugar"

Please include some details about the reason for a revert in the revert commit message in addition to the precanned revision/subject quoting On Wed, Oct 26, 2022 at 1:16 AM Matheus Izvekov via cfe-commits wrote: > > > Author: Matheus Izvekov > Date: 2022-10-26T10:14:27+02:00 > New Revision: a88eb

[clang] 97c1b00 - Follow-up to Itanium ABI POD patchnotes

Author: David Blaikie Date: 2022-10-28T22:29:50Z New Revision: 97c1b0094ad6f628927223b53300c9296ae72f44 URL: https://github.com/llvm/llvm-project/commit/97c1b0094ad6f628927223b53300c9296ae72f44 DIFF: https://github.com/llvm/llvm-project/commit/97c1b0094ad6f628927223b53300c9296ae72f44.diff LOG:

Re: [Diffusion] rGe4ec6ce8a75c: Clang: Add release note for defaulted-special-members-POD GCC ABI fix

Posted, awaiting approval. On Fri, Oct 28, 2022 at 5:23 AM Aaron Ballman wrote: > > Also, please be sure to post something to > https://discourse.llvm.org/c/announce/46 with the potentially-breaking > tag applied to it. > > ~Aaron > > On Thu, Oct 27, 2022 at 8:19 PM Hubert Tong via Phabricator vi

[clang] e4ec6ce - Clang: Add release note for defaulted-special-members-POD GCC ABI fix

Author: David Blaikie Date: 2022-10-27T20:41:22Z New Revision: e4ec6ce8a75c208b49b163c81cda90dc7373c791 URL: https://github.com/llvm/llvm-project/commit/e4ec6ce8a75c208b49b163c81cda90dc7373c791 DIFF: https://github.com/llvm/llvm-project/commit/e4ec6ce8a75c208b49b163c81cda90dc7373c791.diff LOG:

[clang] ec273d3 - Add a warning for not packing non-POD members in packed structs

Author: David Blaikie Date: 2022-10-26T22:18:51Z New Revision: ec273d3e3a8c3bcb2cf98f893f28bee5bf9b30af URL: https://github.com/llvm/llvm-project/commit/ec273d3e3a8c3bcb2cf98f893f28bee5bf9b30af DIFF: https://github.com/llvm/llvm-project/commit/ec273d3e3a8c3bcb2cf98f893f28bee5bf9b30af.diff LOG:

[clang] 7846d59 - Extend the C++03 definition of POD to include defaulted functions

Author: David Blaikie Date: 2022-10-26T22:00:49Z New Revision: 7846d590033e8d661198f4c00f56f46a4993c526 URL: https://github.com/llvm/llvm-project/commit/7846d590033e8d661198f4c00f56f46a4993c526 DIFF: https://github.com/llvm/llvm-project/commit/7846d590033e8d661198f4c00f56f46a4993c526.diff LOG:

[clang] 5b773dc - Fix incorrect check for running out of source locations.

Author: Paul Pluzhnikov Date: 2022-10-18T20:48:00Z New Revision: 5b773dcd2de0c4844814266a90dac14c349b8f18 URL: https://github.com/llvm/llvm-project/commit/5b773dcd2de0c4844814266a90dac14c349b8f18 DIFF: https://github.com/llvm/llvm-project/commit/5b773dcd2de0c4844814266a90dac14c349b8f18.diff LO

Re: [clang] 0674f2e - [NFC] Fix warning on no return after switch.

On Mon, Oct 17, 2022 at 5:52 PM stan li wrote: > > Thanks for the suggestion. > > > > Updated llvm_unreachable. > > > > The static_cast not only check the switch cases all covered, also make sure 2 > enums not out of sync. Ah, OK - thanks for explaining! > > > > > > > > Sent from Mail for Win

Re: [clang] 0674f2e - [NFC] Fix warning on no return after switch.

Also the static_assert is probably not needed - Clang builds with -Wswitch-enum, which will warn if a switch over an enum doesn't cover all the enumerators. We have lots of other switches over enums that depend on this warning to detect code that needs to be updated when an enum is modified. On Mo

Re: [clang] 0674f2e - [NFC] Fix warning on no return after switch.

If the switch is exhaustive (covers all the enumerators in an enumeration), we usually use an llvm_unreachable at the end, rather than a return. Could you change this to an llvm_unreachable? On Mon, Oct 17, 2022 at 3:52 PM Xiang Li via cfe-commits wrote: > > > Author: Xiang Li > Date: 2022-10-17T

[clang] 037f856 - Itanium ABI: Pack non-pod members of packed types

Author: David Blaikie Date: 2022-10-14T19:32:57Z New Revision: 037f856681268c793c660389b4d6407367e68190 URL: https://github.com/llvm/llvm-project/commit/037f856681268c793c660389b4d6407367e68190 DIFF: https://github.com/llvm/llvm-project/commit/037f856681268c793c660389b4d6407367e68190.diff LOG:

[clang] 9363071 - Move GCC-compatible pod-packing change to v16/old behavior available at v15 and below

Author: David Blaikie Date: 2022-10-13T21:13:19Z New Revision: 9363071303ec59bc9e0d9b989f08390b37e3f5e4 URL: https://github.com/llvm/llvm-project/commit/9363071303ec59bc9e0d9b989f08390b37e3f5e4 DIFF: https://github.com/llvm/llvm-project/commit/9363071303ec59bc9e0d9b989f08390b37e3f5e4.diff LOG:

Re: [clang-tools-extra] 5d2d527 - [clangd] Avoid scanning up to end of file on each comment!

On Mon, Oct 10, 2022 at 11:13 AM Sam McCall wrote: > > On Mon, 10 Oct 2022, 19:57 David Blaikie, wrote: >> >> Could the underlying API be made more robust to handle StringRefs >> rather than null terminated char* in the first place? (like >> SourceManager::getCharacterData could return StringRef?

Re: [clang-tools-extra] 5d2d527 - [clangd] Avoid scanning up to end of file on each comment!

Could the underlying API be made more robust to handle StringRefs rather than null terminated char* in the first place? (like SourceManager::getCharacterData could return StringRef? Presumably at some layer it already knows how long the file is - the underlying MemoryBuffer, in this case) On Thu,

[clang] b61860e - Use inheriting ctors for OSTargetInfo

Author: David Blaikie Date: 2022-10-05T20:22:19Z New Revision: b61860e63e34d955a9841389583978af93c2b97a URL: https://github.com/llvm/llvm-project/commit/b61860e63e34d955a9841389583978af93c2b97a DIFF: https://github.com/llvm/llvm-project/commit/b61860e63e34d955a9841389583978af93c2b97a.diff LOG:

[clang] 4769976 - MSVC ABI: Looks like even non-aarch64 uses the MSVC/14 definition for pod/aggregate passing

Author: David Blaikie Date: 2022-10-04T20:19:17Z New Revision: 4769976c49be468d7629d513080e6959a25adcfe URL: https://github.com/llvm/llvm-project/commit/4769976c49be468d7629d513080e6959a25adcfe DIFF: https://github.com/llvm/llvm-project/commit/4769976c49be468d7629d513080e6959a25adcfe.diff LOG:

[clang] 2e1c1d6 - MSVC AArch64 ABI: Homogeneous aggregates

Author: David Blaikie Date: 2022-10-04T20:17:29Z New Revision: 2e1c1d6d72879cafc339ad035b1b5a6d1c8cc130 URL: https://github.com/llvm/llvm-project/commit/2e1c1d6d72879cafc339ad035b1b5a6d1c8cc130 DIFF: https://github.com/llvm/llvm-project/commit/2e1c1d6d72879cafc339ad035b1b5a6d1c8cc130.diff LOG:

[clang] 1651289 - [clang] fix generation of .debug_aranges with LTO

Author: Azat Khuzhin Date: 2022-10-04T20:03:36Z New Revision: 16512898956857b13e566165ba9a195be81d325f URL: https://github.com/llvm/llvm-project/commit/16512898956857b13e566165ba9a195be81d325f DIFF: https://github.com/llvm/llvm-project/commit/16512898956857b13e566165ba9a195be81d325f.diff LOG:

[clang] 4cd7529 - [clang][DebugInfo] Emit access specifiers for typedefs

Author: Jonathan Camilleri Date: 2022-09-22T17:08:41Z New Revision: 4cd7529e4caa00fa7ba27d9de18adea3c702ad8f URL: https://github.com/llvm/llvm-project/commit/4cd7529e4caa00fa7ba27d9de18adea3c702ad8f DIFF: https://github.com/llvm/llvm-project/commit/4cd7529e4caa00fa7ba27d9de18adea3c702ad8f.diff

[clang] 6bf6730 - [clang] fix generation of .debug_aranges with LTO

Author: Azat Khuzhin Date: 2022-09-13T22:33:56Z New Revision: 6bf6730ac55e064edf46915ebba02e9c716f48e8 URL: https://github.com/llvm/llvm-project/commit/6bf6730ac55e064edf46915ebba02e9c716f48e8 DIFF: https://github.com/llvm/llvm-project/commit/6bf6730ac55e064edf46915ebba02e9c716f48e8.diff LOG:

Re: [clang] b7a7aee - [clang] Qualify auto in range-based for loops (NFC)

On Sat, Sep 10, 2022 at 3:01 PM Kazu Hirata wrote: > > Thank you Aaron and David for your inputs. > > First and foremost, I apologize if I made your job harder by increasing the > number of commits you have to peel to get to the real author. > > I hear that we are moving toward github pull reques

Re: [clang] 0e5813b - [clang][NFC] silences warnings

On Fri, Aug 26, 2022 at 2:10 PM Christopher Di Bella via cfe-commits wrote: > > > Author: Abraham Corea Diaz > Date: 2022-08-26T21:09:39Z > New Revision: 0e5813b88e50576940070003e093d696390a6959 > > URL: > https://github.com/llvm/llvm-project/commit/0e5813b88e50576940070003e093d696390a6959 > DIFF

Re: [clang] b7a7aee - [clang] Qualify auto in range-based for loops (NFC)

Mixed feelings here - Kazu's made a lot of cleanup/stylistic changes across the LLVM project for a while now, most, at least I think, are quite welcome (things like switching to range-based-for, std algorithms over llvm ones, llvm algorithms over manually written loops, etc). But yeah, there's some

Re: [clang] acaf6b9 - [NFC] Add [[maybe_unused]] to avoid warning in gcc9

Thanks for the link - fair enough. We'll see how ubiquitous the constexpr-creating-sort-of-unused-variables situation is. If it comes up a lot we might want to disable the warning for GCC 9. On Mon, Aug 22, 2022 at 7:58 PM chuanqi.xcq wrote: > > Hi David, > > This is the reproduce link from god

Re: [clang] acaf6b9 - [NFC] Add [[maybe_unused]] to avoid warning in gcc9

Seems like a bug in the GCC9 warning - any chance we can disable it? (is it fixed in later versions of GCC?) I can't seem to reproduce this with godbolt at least with basic examples - it'd be good to know how bad the thing is we're working around so we know if we want to keep working around it, or

[clang] d4e0fe6 - Simplify RAV isSameMethod with constexpr if

Author: David Blaikie Date: 2022-08-19T04:00:21Z New Revision: d4e0fe62b1aa090527c0cc289cdf3eef0370f064 URL: https://github.com/llvm/llvm-project/commit/d4e0fe62b1aa090527c0cc289cdf3eef0370f064 DIFF: https://github.com/llvm/llvm-project/commit/d4e0fe62b1aa090527c0cc289cdf3eef0370f064.diff LOG:

[clang] 06c70e9 - DebugInfo: Remove auto return type representation support

Author: David Blaikie Date: 2022-08-17T00:35:05Z New Revision: 06c70e9b998ca289630ee1629ec09b6dd51b29b9 URL: https://github.com/llvm/llvm-project/commit/06c70e9b998ca289630ee1629ec09b6dd51b29b9 DIFF: https://github.com/llvm/llvm-project/commit/06c70e9b998ca289630ee1629ec09b6dd51b29b9.diff LOG:

[clang] 4bb192b - DebugInfo: Test vtable homing overriding ctor homing only on itanium since msvc ABI doesn't home vtables

Author: David Blaikie Date: 2022-07-28T00:45:00Z New Revision: 4bb192b846854ab1dc49a2e4b2a2717a4e3a9b1e URL: https://github.com/llvm/llvm-project/commit/4bb192b846854ab1dc49a2e4b2a2717a4e3a9b1e DIFF: https://github.com/llvm/llvm-project/commit/4bb192b846854ab1dc49a2e4b2a2717a4e3a9b1e.diff LOG:

Re: [clang] 4821508 - Revert "DebugInfo: Fully integrate ctor type homing into 'limited' debug info"

gt; From: cfe-commits On Behalf Of David > > Blaikie via cfe-commits > > Sent: Friday, June 24, 2022 1:08 PM > > To: cfe-commits@lists.llvm.org > > Subject: [clang] 4821508 - Revert "DebugInfo: Fully integrate ctor type > > homing into 'limited&#

[clang] 4e719e0 - DebugInfo: Prefer vtable homing over ctor homing.

Author: David Blaikie Date: 2022-07-28T00:07:35Z New Revision: 4e719e0f16933a8945a4e85db39fdad5afbede36 URL: https://github.com/llvm/llvm-project/commit/4e719e0f16933a8945a4e85db39fdad5afbede36 DIFF: https://github.com/llvm/llvm-project/commit/4e719e0f16933a8945a4e85db39fdad5afbede36.diff LOG:

[clang] 4821508 - Revert "DebugInfo: Fully integrate ctor type homing into 'limited' debug info"

Author: David Blaikie Date: 2022-06-24T17:07:47Z New Revision: 4821508d4db75a535d02b8938f81fac6de66cc26 URL: https://github.com/llvm/llvm-project/commit/4821508d4db75a535d02b8938f81fac6de66cc26 DIFF: https://github.com/llvm/llvm-project/commit/4821508d4db75a535d02b8938f81fac6de66cc26.diff LOG:

[clang] 517bbc6 - DebugInfo: Fully integrate ctor type homing into 'limited' debug info

Author: David Blaikie Date: 2022-06-23T20:15:00Z New Revision: 517bbc64dbe493644eff8d55fd9566435e930520 URL: https://github.com/llvm/llvm-project/commit/517bbc64dbe493644eff8d55fd9566435e930520 DIFF: https://github.com/llvm/llvm-project/commit/517bbc64dbe493644eff8d55fd9566435e930520.diff LOG:

Re: [clang] d4bcb45 - [MC][re-land] Omit DWARF unwind info if compact unwind is present where eligible

Please include details of what changed between one commit and a recommit of a patch - helpful for reviewers checking what's changed since the last commit, double-checking that the patch fully addresses the issues, etc. On Sun, Jun 12, 2022 at 2:24 PM Jez Ng via cfe-commits < cfe-commits@lists.llvm

Re: [clang] d941d59 - Revert "[MC] Omit DWARF unwind info if compact unwind is present where eligible"

Please include details about the reason for a revert in the revert commit message - helpful for folks following along/looking to see if a given revert addresses an issue they're seeing, etc. On Sun, Jun 12, 2022 at 7:47 AM Jez Ng via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Je

Re: [clang] f13019f - [clang] Use any_of and none_of (NFC)

On Sun, Jun 12, 2022 at 10:17 AM Kazu Hirata via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Kazu Hirata > Date: 2022-06-12T10:17:12-07:00 > New Revision: f13019f8367a417075e70effb13dcf58024090b2 > > URL: > https://github.com/llvm/llvm-project/commit/f13019f8367a417075e70effb13dcf

[clang] cb08f4a - Support warn_unused_result on typedefs

Author: David Blaikie Date: 2022-06-02T20:57:31Z New Revision: cb08f4aa4467cf562b62e542725f5351c5482495 URL: https://github.com/llvm/llvm-project/commit/cb08f4aa4467cf562b62e542725f5351c5482495 DIFF: https://github.com/llvm/llvm-project/commit/cb08f4aa4467cf562b62e542725f5351c5482495.diff LOG:

Re: Call for an assistance pushing patch review forward

Beyond that it may be useful to look at who's been contributing to the code you're trying to change and consider cc'ing them on the review. (if they can't help, maybe they can point you to someone who can) On Fri, May 27, 2022 at 2:23 PM stryku_t via cfe-commits wrote: > > Hi Paul, > > Thank you

[clang] e59f648 - Move GCC-compatible pod-packing change to v15/old behavior available at v14 and below

Author: David Blaikie Date: 2022-05-25T03:03:27Z New Revision: e59f648d698efe58b96e9b6224449b2b8cfa872a URL: https://github.com/llvm/llvm-project/commit/e59f648d698efe58b96e9b6224449b2b8cfa872a DIFF: https://github.com/llvm/llvm-project/commit/e59f648d698efe58b96e9b6224449b2b8cfa872a.diff LOG:

Re: [clang] 7aa1fa0 - Reland "[dwarf] Emit a DIGlobalVariable for constant strings."

(when recommitting a patch it can be helpful to mention the revisions of the previous commit/revert, the reason for the revert and what's different in this version of the patch that addresses that issue (or how was the issue otherwise addressed)) On Wed, May 18, 2022 at 1:59 PM Mitch Phillips via

[clang] 0b903ef - Re-add release notes for GCC ABI compatibility for non-POD in packed structs

Author: David Blaikie Date: 2022-05-22T01:15:34Z New Revision: 0b903ef6aa0976a60d3f448837f3c43adaf09cc1 URL: https://github.com/llvm/llvm-project/commit/0b903ef6aa0976a60d3f448837f3c43adaf09cc1 DIFF: https://github.com/llvm/llvm-project/commit/0b903ef6aa0976a60d3f448837f3c43adaf09cc1.diff LOG:

[clang] 1cee3d9 - DebugInfo: Consider the type of NTTP when simplifying template names

Author: David Blaikie Date: 2022-04-08T00:00:46Z New Revision: 1cee3d9db77b2c62a03efe1cce45f627dcbe6457 URL: https://github.com/llvm/llvm-project/commit/1cee3d9db77b2c62a03efe1cce45f627dcbe6457 DIFF: https://github.com/llvm/llvm-project/commit/1cee3d9db77b2c62a03efe1cce45f627dcbe6457.diff LOG:

[clang] 6b30623 - DebugInfo: Make the simplified template names prefix more unique

Author: David Blaikie Date: 2022-04-06T18:25:46Z New Revision: 6b306233f78876a1d197ed6e1f05785505de7c63 URL: https://github.com/llvm/llvm-project/commit/6b306233f78876a1d197ed6e1f05785505de7c63 DIFF: https://github.com/llvm/llvm-project/commit/6b306233f78876a1d197ed6e1f05785505de7c63.diff LOG:

[clang] bb3980a - DebugInfo: Don't use enumerators in template names for debug info as they are not canonical

Author: David Blaikie Date: 2022-04-05T17:16:42Z New Revision: bb3980ae9fa7e19540080285f2bf2d960ea802fc URL: https://github.com/llvm/llvm-project/commit/bb3980ae9fa7e19540080285f2bf2d960ea802fc DIFF: https://github.com/llvm/llvm-project/commit/bb3980ae9fa7e19540080285f2bf2d960ea802fc.diff LOG:

Re: [clang] abe997b - [CMake][Fuchsia] Switch to lld on Apple platforms

Neat! On Tue, Mar 22, 2022 at 1:07 AM Petr Hosek via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Petr Hosek > Date: 2022-03-22T01:06:30-07:00 > New Revision: abe997bb2dd61188784954ae866352740629985d > > URL: > https://github.com/llvm/llvm-project/commit/abe997bb2dd61188784954ae86

[clang] 34b9b1e - Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static"

Author: David Blaikie Date: 2022-03-25T23:53:19Z New Revision: 34b9b1ea4874b109b998d59a837f81f2f730001c URL: https://github.com/llvm/llvm-project/commit/34b9b1ea4874b109b998d59a837f81f2f730001c DIFF: https://github.com/llvm/llvm-project/commit/34b9b1ea4874b109b998d59a837f81f2f730001c.diff LOG:

[clang] 7b498be - DebugInfo: Classify noreturn function types as non-reconstructible

Author: David Blaikie Date: 2022-03-24T18:53:14Z New Revision: 7b498beef03ae07bb98796461a957af836074b92 URL: https://github.com/llvm/llvm-project/commit/7b498beef03ae07bb98796461a957af836074b92 DIFF: https://github.com/llvm/llvm-project/commit/7b498beef03ae07bb98796461a957af836074b92.diff LOG:

[clang] 85ee1d3 - Revert "Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static""

Author: David Blaikie Date: 2022-03-09T21:12:56Z New Revision: 85ee1d3ca1d06b6bd3477515b8d0c72c8df7c069 URL: https://github.com/llvm/llvm-project/commit/85ee1d3ca1d06b6bd3477515b8d0c72c8df7c069 DIFF: https://github.com/llvm/llvm-project/commit/85ee1d3ca1d06b6bd3477515b8d0c72c8df7c069.diff LOG:

[clang] c0a6433 - Simplify OpenMP Lambda use

Author: David Blaikie Date: 2022-03-07T18:23:20Z New Revision: c0a6433f2b5120d79f03431e9bf61b4da1184412 URL: https://github.com/llvm/llvm-project/commit/c0a6433f2b5120d79f03431e9bf61b4da1184412 DIFF: https://github.com/llvm/llvm-project/commit/c0a6433f2b5120d79f03431e9bf61b4da1184412.diff LOG:

Re: [clang] 1d1b089 - Fix more unused lambda capture warnings, NFC

On Mon, Feb 28, 2022 at 10:12 AM Reid Kleckner wrote: > I agree, but clearly this person chose a particular style, and I wasn't > trying to revise their code style, just to fix some the Bazel build, which > uses -Werror. > Oh, wow, yeah, this file/corner of the codebase is deep into lambdas, wow

Re: [clang] 1d1b089 - Fix more unused lambda capture warnings, NFC

FWIW, I think it's probably simpler/more maintainable to default capture by reference ("[&]") if a lambda doesn't escape its scope (if it's never type erased/put in a std::function or equivalent). Avoids assert/non-assert unused issues, having to maintain/update the list when the code changes and m

[clang] 1ea3266 - DebugInfo: Don't simplify template names using _BitInt(N)

Author: David Blaikie Date: 2022-02-15T11:58:40-08:00 New Revision: 1ea326634b582f5574e0b22b85e5b0c631b30dcf URL: https://github.com/llvm/llvm-project/commit/1ea326634b582f5574e0b22b85e5b0c631b30dcf DIFF: https://github.com/llvm/llvm-project/commit/1ea326634b582f5574e0b22b85e5b0c631b30dcf.diff

[clang] 26c5cf8 - Fix Windows build that fails if a class has a member with the same naem

Author: David Blaikie Date: 2022-02-10T15:27:31-08:00 New Revision: 26c5cf8fa031f5143fd180fdc8d9dbc26a88e89e URL: https://github.com/llvm/llvm-project/commit/26c5cf8fa031f5143fd180fdc8d9dbc26a88e89e DIFF: https://github.com/llvm/llvm-project/commit/26c5cf8fa031f5143fd180fdc8d9dbc26a88e89e.diff

[clang] 275c562 - Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static"

Author: David Blaikie Date: 2022-01-31T17:34:51-08:00 New Revision: 275c56226d7fbd6a4d554807374f78d323aa0c1c URL: https://github.com/llvm/llvm-project/commit/275c56226d7fbd6a4d554807374f78d323aa0c1c DIFF: https://github.com/llvm/llvm-project/commit/275c56226d7fbd6a4d554807374f78d323aa0c1c.diff

[clang] 2771233 - GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

Author: David Blaikie Date: 2022-01-28T11:04:20-08:00 New Revision: 277123376ce08c98b07c154bf83e4092a5d4d3c6 URL: https://github.com/llvm/llvm-project/commit/277123376ce08c98b07c154bf83e4092a5d4d3c6 DIFF: https://github.com/llvm/llvm-project/commit/277123376ce08c98b07c154bf83e4092a5d4d3c6.diff

[clang] 9c62728 - Default to DWARFv4 on Windows

Author: David Blaikie Date: 2022-01-26T18:01:07-08:00 New Revision: 9c6272861032f511a23784ce0c5cc8f6ac2f625b URL: https://github.com/llvm/llvm-project/commit/9c6272861032f511a23784ce0c5cc8f6ac2f625b DIFF: https://github.com/llvm/llvm-project/commit/9c6272861032f511a23784ce0c5cc8f6ac2f625b.diff

[clang] 87e68ca - Improve relnotes for the DWARFv5 default change

Author: David Blaikie Date: 2022-01-25T09:56:07-08:00 New Revision: 87e68cae50d7ca28975ca6fb456cf0ab2ac915a1 URL: https://github.com/llvm/llvm-project/commit/87e68cae50d7ca28975ca6fb456cf0ab2ac915a1 DIFF: https://github.com/llvm/llvm-project/commit/87e68cae50d7ca28975ca6fb456cf0ab2ac915a1.diff

Re: [clang] d3b26de - Clang: Change the default DWARF version to 5

. >> >> It also reproduces on Chromium's builders, e.g. >> >> https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8824141369391584977/+/u/package_clang/stdout >> >> Filed https://github.com/llvm/llvm-project/issues/53387 >> >> >> On M

Re: [clang] d3b26de - Clang: Change the default DWARF version to 5

I'm not > really sure which ones test this runtime. > > It also reproduces on Chromium's builders, e.g. > > https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8824141369391584977/+/u/package_clang/stdout > > Filed https://github.com/llvm/llvm-project

[clang] 90abe18 - Add missing function implementation from DWARF default change

Author: David Blaikie Date: 2022-01-23T21:10:16-08:00 New Revision: 90abe181da7c61d982e4873c97fd12bc06fefe09 URL: https://github.com/llvm/llvm-project/commit/90abe181da7c61d982e4873c97fd12bc06fefe09 DIFF: https://github.com/llvm/llvm-project/commit/90abe181da7c61d982e4873c97fd12bc06fefe09.diff

[clang] d3b26de - Clang: Change the default DWARF version to 5

Author: David Blaikie Date: 2022-01-23T20:49:57-08:00 New Revision: d3b26dea16108c427b19b5480c9edc76edf8f5b4 URL: https://github.com/llvm/llvm-project/commit/d3b26dea16108c427b19b5480c9edc76edf8f5b4 DIFF: https://github.com/llvm/llvm-project/commit/d3b26dea16108c427b19b5480c9edc76edf8f5b4.diff

[clang] baa9b7c - unique_ptrify the ModuleManager's VisitState linked list

Author: David Blaikie Date: 2022-01-19T09:57:46-08:00 New Revision: baa9b7c3c83ab6e4dfb15b8d7815a9958d5b5810 URL: https://github.com/llvm/llvm-project/commit/baa9b7c3c83ab6e4dfb15b8d7815a9958d5b5810 DIFF: https://github.com/llvm/llvm-project/commit/baa9b7c3c83ab6e4dfb15b8d7815a9958d5b5810.diff

[clang] e1e74f6 - -Wmissing-prototypes: Don't warn in named namespaces nested in anonymous namespaces

Author: David Blaikie Date: 2022-01-04T10:08:23-08:00 New Revision: e1e74f6cd6ce41ce8303a5a91f29736808fccc36 URL: https://github.com/llvm/llvm-project/commit/e1e74f6cd6ce41ce8303a5a91f29736808fccc36 DIFF: https://github.com/llvm/llvm-project/commit/e1e74f6cd6ce41ce8303a5a91f29736808fccc36.diff

<    1   2   3   4   5   6   7   8   9   10   >