[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

This revision was automatically updated to reflect the committed changes. Closed by commit rGae67984ca6d8: [clangd] ExtractVariable support for C and Objective-C (authored by dgoldman). Changed prior to commit: https://reviews.llvm.org/D124486?vs=425914=433089#toc Repository: rG LLVM Github

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:418 + if (const auto *ME = dyn_cast(E)) +if (const auto *TE = dyn_cast(ME->getBase())) + if (TE->isImplicit()) sammccall wrote: > dgoldman wrote: >

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:418 + if (const auto *ME = dyn_cast(E)) +if (const auto *TE = dyn_cast(ME->getBase())) + if (TE->isImplicit()) sammccall wrote: > dgoldman wrote: >

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:418 + if (const auto *ME = dyn_cast(E)) +if (const auto *TE = dyn_cast(ME->getBase())) + if (TE->isImplicit()) sammccall wrote: > oops, I forgot

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:170 + if (E->hasPlaceholderType(BuiltinType::PseudoObject)) { +if (const auto *PR = dyn_cast(E)) { + if (PR->isMessagingSetter()) { dgoldman wrote:

[PATCH] D124637: [clangd][ObjC] Filter ObjC method completions on the remaining selector

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG322e2a3b40fa: [clangd][ObjC] Filter ObjC method completions on the remaining selector (authored by dgoldman). Repository: rG LLVM Github Monorepo

[PATCH] D124637: [clangd][ObjC] Filter ObjC method completions on the remaining selector

dgoldman updated this revision to Diff 430974. dgoldman marked an inline comment as done. dgoldman added a comment. Go through chunks in getName and add missed FilterText place Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124637/new/

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman marked an inline comment as done. dgoldman added a comment. Friendly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124486/new/ https://reviews.llvm.org/D124486 ___ cfe-commits mailing list

[PATCH] D124637: [clangd][ObjC] Filter ObjC method completions on the remaining selector

dgoldman added a comment. Friendly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124637/new/ https://reviews.llvm.org/D124637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

dgoldman added a comment. In D124715#3490364 , @stefanhaller wrote: > In D124715#3488447 , @sammccall > wrote: > >> (How) does this interact with battery vs mains power on laptops? >> It seems like there's a

[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

dgoldman accepted this revision. dgoldman added a comment. This revision is now accepted and ready to land. In D124715#3484058 , @stefanhaller wrote: > Fix documentation of ThreadPriority::Low (was: Background), and move it up > from >

[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

dgoldman added inline comments. Comment at: llvm/include/llvm/Support/Threading.h:239 }; /// If priority is Background tries to lower current threads priority such /// that it does not affect foreground tasks significantly. Can be used for Should be

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:170 + if (E->hasPlaceholderType(BuiltinType::PseudoObject)) { +if (const auto *PR = dyn_cast(E)) { + if

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman updated this revision to Diff 425914. dgoldman marked 6 inline comments as done. dgoldman added a comment. - Extract var type handling to a function - Other fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124486/new/

[PATCH] D124637: [clangd][ObjC] Filter ObjC method completions on the remaining selector

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang,

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman updated this revision to Diff 425650. dgoldman added a comment. - Remove extraneous computeExprType declaration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124486/new/ https://reviews.llvm.org/D124486 Files:

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:170 + if (E->hasPlaceholderType(BuiltinType::PseudoObject)) { +if (const auto *PR = dyn_cast(E)) { + if (PR->isMessagingSetter()) { sammccall

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman updated this revision to Diff 425644. dgoldman marked 5 inline comments as done. dgoldman added a comment. - Don't use a method for computing the type - Compute the type using printType - Support MemberExprs and add a test for function pointers Repository: rG LLVM Github Monorepo

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman updated this revision to Diff 425354. dgoldman added a comment. Minor formatting fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124486/new/ https://reviews.llvm.org/D124486 Files:

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. - Use the expression's type

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9739f29cdd4: Serialize PragmaAssumeNonNullLoc to support preambles (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122179/new/

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

dgoldman updated this revision to Diff 418950. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122179/new/ https://reviews.llvm.org/D122179 Files: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

dgoldman updated this revision to Diff 418301. dgoldman added a comment. Revert comment change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122179/new/ https://reviews.llvm.org/D122179 Files:

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

dgoldman updated this revision to Diff 418030. dgoldman added a comment. Another formatting fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122179/new/ https://reviews.llvm.org/D122179 Files:

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

dgoldman updated this revision to Diff 418004. dgoldman added a comment. if/else formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122179/new/ https://reviews.llvm.org/D122179 Files:

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

dgoldman updated this revision to Diff 418001. dgoldman added a comment. Minor lint fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122179/new/ https://reviews.llvm.org/D122179 Files: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

dgoldman added inline comments. Comment at: clang/lib/Lex/PPLexerChange.cpp:436 + if (PragmaAssumeNonNullLoc.isValid() && !this->PPOpts->GeneratePreamble && + !(CurLexer && CurLexer->getFileID() == PredefinesFileID) && !isEndOfMacro && !(CurLexer &&

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

dgoldman updated this revision to Diff 417976. dgoldman marked an inline comment as done. dgoldman added a comment. Properly handle generation and restoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122179/new/ https://reviews.llvm.org/D122179

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

dgoldman added inline comments. Comment at: clang/lib/Lex/PPLexerChange.cpp:436 + if (PragmaAssumeNonNullLoc.isValid() && !this->PPOpts->GeneratePreamble && + !(CurLexer && CurLexer->getFileID() == PredefinesFileID) && !isEndOfMacro && !(CurLexer &&

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang/lib/Lex/PPLexerChange.cpp:436 + if (PragmaAssumeNonNullLoc.isValid() && !this->PPOpts->GeneratePreamble && + !(CurLexer && CurLexer->getFileID() == PredefinesFileID) &&

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

dgoldman updated this revision to Diff 417623. dgoldman marked 2 inline comments as done. dgoldman added a comment. Minor fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122179/new/ https://reviews.llvm.org/D122179 Files:

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:748 +TEST(DiagnosticsTest, PreambleWithPragmaAssumeNonnull) { + Annotations Header(R"cpp( sammccall wrote: > sammccall wrote: > > This test seems to have a lot

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

dgoldman updated this revision to Diff 417315. dgoldman marked 9 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122179/new/ https://reviews.llvm.org/D122179 Files:

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

dgoldman added a comment. LMK if there are other folks more suited to review this, I'm not sure... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122179/new/ https://reviews.llvm.org/D122179 ___

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

dgoldman created this revision. dgoldman added reviewers: sammccall, doug.gregor. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added projects: clang,

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1af5fbd5c605: [clangd] Code action for creating an ObjC initializer (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman updated this revision to Diff 416186. dgoldman marked 3 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/ https://reviews.llvm.org/D116385 Files:

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman added a comment. Herald added a project: All. friendly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/ https://reviews.llvm.org/D116385 ___ cfe-commits mailing list

[PATCH] D119366: [clangd] Use `ObjCProtocolLoc` for generalized ObjC protocol support

This revision was automatically updated to reflect the committed changes. Closed by commit rG54a962bbfee8: [clangd] Use `ObjCProtocolLoc` for generalized ObjC protocol support (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG805f7a4fa4ce: [clang] Add `ObjCProtocolLoc` to represent protocol references (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

dgoldman added a comment. In D119363#3324024 , @sammccall wrote: > In D119363#3323867 , @dgoldman > wrote: > >> In D119363#3323778 , @sammccall >> wrote: >> >>> I'm a

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

dgoldman updated this revision to Diff 409005. dgoldman marked 3 inline comments as done. dgoldman added a comment. Template fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119363/new/ https://reviews.llvm.org/D119363 Files:

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

dgoldman added a comment. In D119363#3323778 , @sammccall wrote: > I'm a bit concerned about the parent map vs ASTMatchFinder's view being out > of sync: we'll have a ProtocolLoc node that has a parent but the parent > doesn't have the child. > > I'm

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

dgoldman updated this revision to Diff 408970. dgoldman marked 4 inline comments as done. dgoldman added a comment. Template and variable casing fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119363/new/ https://reviews.llvm.org/D119363

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

dgoldman added a comment. PTAL, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119363/new/ https://reviews.llvm.org/D119363 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D119366: [clangd] Use `ObjCProtocolLoc` for generalized ObjC protocol support

dgoldman updated this revision to Diff 408937. dgoldman added a comment. Rebase on top of latest ProtocolLoc changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119366/new/ https://reviews.llvm.org/D119366 Files:

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

dgoldman added inline comments. Comment at: clang/include/clang/AST/TypeLoc.h:2621 + /// Evaluates true when this protocol loc is valid/non-empty. + explicit operator bool() const { return Protocol; } +}; sammccall wrote: > will we ever have invalid instances?

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

dgoldman updated this revision to Diff 408928. dgoldman marked an inline comment as done. dgoldman added a comment. Add tests and public accessors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119363/new/ https://reviews.llvm.org/D119363 Files:

[PATCH] D119366: [clangd] Use `ObjCProtocolLoc` for generalized ObjC protocol support

dgoldman updated this revision to Diff 407674. dgoldman added a comment. add hover test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119366/new/ https://reviews.llvm.org/D119366 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D119366: [clangd] Use `ObjCProtocolLoc` for generalized ObjC protocol support

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:948 Code = R"cpp( +void test(id p); sammccall wrote: > This new test case looks interesting, but can we keep the old one too? It now fails, I thought this

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

dgoldman updated this revision to Diff 407295. dgoldman added a comment. Minor lint fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119363/new/ https://reviews.llvm.org/D119363 Files: clang/include/clang/AST/ASTFwd.h

[PATCH] D119366: [clangd] Use `ObjCProtocolLoc` for generalized ObjC protocol support

dgoldman updated this revision to Diff 407287. dgoldman added a comment. Minor lint fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119366/new/ https://reviews.llvm.org/D119366 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D119366: [clangd] Use `ObjCProtocolLoc` for generalized ObjC protocol support

dgoldman created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This removes clangd's existing workaround in favor of

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

dgoldman created this revision. Herald added subscribers: usaxena95, kadircet. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. Add `ObjCProtocolLoc` which behaves like `TypeLoc` but for `ObjCProtocolDecl` references.

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

This revision was automatically updated to reflect the committed changes. Closed by commit rG4dfd11324eb0: [clangd] Properly compute framework-style include spelling (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman updated this revision to Diff 406081. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/ https://reviews.llvm.org/D117056 Files: clang-tools-extra/clangd/index/SymbolCollector.cpp

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

This revision was automatically updated to reflect the committed changes. dgoldman marked an inline comment as done. Closed by commit rG9385ece95a4a: [HeaderSearch] Track framework name in LookupFile (authored by dgoldman). Changed prior to commit:

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman updated this revision to Diff 405765. dgoldman added a comment. mergingEdit --> manual file checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/ https://reviews.llvm.org/D116385 Files:

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman updated this revision to Diff 403361. dgoldman marked an inline comment as done. dgoldman added a comment. Formatting fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/ https://reviews.llvm.org/D117056 Files:

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1043 // If this file is found in a header map and uses the framework style of // includes, then this header is part of a framework we're building.

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

dgoldman updated this revision to Diff 403340. dgoldman added a comment. Update comment + run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117830/new/ https://reviews.llvm.org/D117830 Files: clang/lib/Lex/HeaderSearch.cpp

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

dgoldman added a comment. In D117830#3267404 , @cishida wrote: > My understanding for the header map restriction is because headermaps are > generally emitted once for a framework build and only consumed to build such > framework and this struct

[PATCH] D118063: [DONOTSUBMIT] work on prototyping bracket fix its

dgoldman created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. dgoldman requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D118063

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

dgoldman added a comment. Cyndy and Jan, hopefully ya'll are the right reviewers here? We're using this Framework information to know to compute framework style includes in https://reviews.llvm.org/D117056 for clangd, please LMK if this is a bad idea and we should do something else.

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

dgoldman created this revision. dgoldman added a reviewer: sammccall. dgoldman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, the Framework name was only set if the file came from a header mapped framework; now we'll always

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman updated this revision to Diff 401746. dgoldman added a comment. Split up HeaderSearch change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/ https://reviews.llvm.org/D117056 Files:

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman added a comment. In D117056#3256538 , @sammccall wrote: > This looks good now, only blocker is dropping the change to LookupFile > somehow. > > Is it valuable to land this before the imminent 14 branch cut? I think it's > OK but as an indexing

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:326 +auto Path = FE->getName(); +auto It = CachePathToFrameworkSpelling.find(Path); +if (It != CachePathToFrameworkSpelling.end()) sammccall wrote: > any

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman updated this revision to Diff 401671. dgoldman marked 4 inline comments as done. dgoldman added a comment. Support private headers + private umbrellas Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman added a comment. PTAL, let me know what you think regarding the edits, had to make sure it works even if we generate multiple edits in the same file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1052 HFI.IndexHeaderMapHeader = 1; +} else if (CurDir->isFramework()) { + size_t SlashPos = Filename.find('/'); sammccall wrote: > This looks like a separate change, and

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:295 +if (!R.second && !R.first->second.empty()) { + // Framework has known umbrella spelling, cache it for this header as + // well. sammccall wrote: >

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman updated this revision to Diff 401422. dgoldman marked 18 inline comments as done. dgoldman added a comment. Changes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/ https://reviews.llvm.org/D117056 Files:

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman updated this revision to Diff 399336. dgoldman added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/ https://reviews.llvm.org/D117056 Files: clang-tools-extra/clangd/index/SymbolCollector.cpp

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. With this

[PATCH] D115183: [clang][HeaderSearch] Support framework includes in suggestPath...

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0cf7e61a42c7: [clang][HeaderSearch] Support framework includes in suggestPath... (authored by dgoldman). Changed prior to commit:

[PATCH] D115183: [clang][HeaderSearch] Support framework includes in suggestPath...

dgoldman updated this revision to Diff 398178. dgoldman added a comment. Don't suggest umbrella headers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115183/new/ https://reviews.llvm.org/D115183 Files: clang/include/clang/Lex/HeaderSearch.h

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman marked 3 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ObjCMemberwiseInitializer.cpp:265 + // Insert before the first non-init instance method. + std::vector Anchors = { + {[](const Decl *D) {

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman updated this revision to Diff 397956. dgoldman marked an inline comment as done. dgoldman added a comment. Support generating interface and impl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/ https://reviews.llvm.org/D116385

[PATCH] D115183: [clang][HeaderSearch] Support framework includes in suggestPath...

dgoldman updated this revision to Diff 397882. dgoldman added a comment. Improve double-quotes.m test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115183/new/ https://reviews.llvm.org/D115183 Files: clang/include/clang/Lex/HeaderSearch.h

[PATCH] D115183: [clang][HeaderSearch] Support framework includes in suggestPath...

dgoldman added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:782 if (IsIncludeeInFramework) { - NewInclude += ToFramework.str().drop_back(10); // drop .framework - NewInclude += "/"; + NewInclude += ToIncludeSpelling; + NewInclude += ">";

[PATCH] D115183: [clang][HeaderSearch] Support framework includes in suggestPath...

dgoldman updated this revision to Diff 397733. dgoldman marked 4 inline comments as done. dgoldman added a comment. Herald added a subscriber: ormris. Fixes for review - update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115183/new/

[PATCH] D116417: [clang][ObjC] Add fix it for missing methods in impl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. dgoldman marked an inline comment as done. Closed by commit rGdd72ae3dcc68: [clang][ObjC] Add fix it for missing methods in impl (authored by dgoldman). Repository:

[PATCH] D116417: [clang][ObjC] Add fix it for missing methods in impl

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang/lib/Sema/SemaDeclObjC.cpp:2241 +method->print(Out, Policy); +Str.append(" {\n\n}\n\n"); + sammccall wrote: > sammccall wrote: > > nit: mixing string & output

[PATCH] D116417: [clang][ObjC] Add fix it for missing methods in impl

dgoldman updated this revision to Diff 397336. dgoldman marked 4 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116417/new/ https://reviews.llvm.org/D116417 Files:

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ObjCMemberwiseInitializer.cpp:91 + +struct LocationWithPadding { + SourceLocation Loc; sammccall wrote: > We try not to spend

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman updated this revision to Diff 397329. dgoldman marked 3 inline comments as done. dgoldman added a comment. Rebase + use new helpers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/ https://reviews.llvm.org/D116385 Files:

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman marked 3 inline comments as not done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ObjCMemberwiseInitializer.cpp:113 +if (MD->getMethodFamily() == OMF_init) { + Loc = effectiveEndLoc(MD, SM).getLocWithOffset(1); +}

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman updated this revision to Diff 397321. dgoldman marked 11 inline comments as done. dgoldman added a comment. Some review fixes, still need to rebase for new changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman updated this revision to Diff 396706. dgoldman added a comment. Add another minor test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/ https://reviews.llvm.org/D116385 Files:

[PATCH] D116417: [clang][ObjC] Add fix it for missing methods in impl

dgoldman updated this revision to Diff 396690. dgoldman added a comment. Add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116417/new/ https://reviews.llvm.org/D116417 Files: clang/lib/Sema/SemaDeclObjC.cpp

[PATCH] D116417: [clang][ObjC] Add fix it for missing methods in impl

dgoldman created this revision. dgoldman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We suggest inserting the method with an empty body at the end of the implementation decl. Repository: rG LLVM Github Monorepo

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman updated this revision to Diff 396676. dgoldman added a comment. Minor change to how we get the loc of `@end` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/ https://reviews.llvm.org/D116385 Files:

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman updated this revision to Diff 396569. dgoldman added a comment. Remove debug log statement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/ https://reviews.llvm.org/D116385 Files:

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman created this revision. Herald added subscribers: usaxena95, kadircet, arphaman, mgorny. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. The code action creates an initializer for the

[PATCH] D115679: [clang] Add ability to suggest #import instead of #include.

dgoldman updated this revision to Diff 394065. dgoldman added a comment. Minor changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115679/new/ https://reviews.llvm.org/D115679 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D115679: [clang] Add ability to suggest #import instead of #include.

dgoldman created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added projects: clang, clang-tools-extra. This currently isn't used by anything, but will be used by

[PATCH] D115183: [clang][HeaderSearch] Support framework includes in suggestPath...

dgoldman updated this revision to Diff 392477. dgoldman added a comment. Add HeaderSearch tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115183/new/ https://reviews.llvm.org/D115183 Files: clang/include/clang/Lex/HeaderSearch.h

[PATCH] D115183: [clang][HeaderSearch] Support framework includes in suggestPath...

dgoldman updated this revision to Diff 392180. dgoldman added a comment. Use consistent IsSystem detection Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115183/new/ https://reviews.llvm.org/D115183 Files: clang/lib/Lex/HeaderSearch.cpp Index:

[PATCH] D115183: [clang][HeaderSearch] Support framework includes in suggestPath...

dgoldman updated this revision to Diff 392176. dgoldman added a comment. Fix IncludeSpelling issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115183/new/ https://reviews.llvm.org/D115183 Files: clang/lib/Lex/HeaderSearch.cpp Index:

<    1   2   3   4   5   6   >