[PATCH] D115183: [clang][HeaderSearch] Support framework includes in suggestPath...

dgoldman created this revision. dgoldman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang will now search through the framework includes to identify the framework include path to a file, and then suggest a framework style include spell

[PATCH] D110954: [clangd] Improve PopulateSwitch tweak

This revision was automatically updated to reflect the committed changes. Closed by commit rGa90d57b6cc5f: [clangd] Improve PopulateSwitch tweak (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110954/new/ https://reviews.llvm.o

[PATCH] D110954: [clangd] Improve PopulateSwitch tweak

dgoldman updated this revision to Diff 376635. dgoldman marked an inline comment as done. dgoldman added a comment. Minor fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110954/new/ https://reviews.llvm.org/D110954 Files: clang-to

[PATCH] D110954: [clangd] Improve PopulateSwitch tweak

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. - Support enums in C

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

This revision was automatically updated to reflect the committed changes. Closed by commit rGd75fb1ee794e: [clangd] Support `#pragma mark` in the outline (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://revie

[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

This revision was automatically updated to reflect the committed changes. Closed by commit rG8401713b3ef1: [clangd] Ignore ObjC `id` and `instancetype` in FindTarget (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108556/new/ h

[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

dgoldman marked an inline comment as done. dgoldman added a comment. Friendly ping, PTAL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108556/new/ https://reviews.llvm.org/D108556 ___ cfe-commits mailing

[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:188 if (const TypedefNameDecl *TND = dyn_cast(D)) { + if (shouldSkipTypedef(TND)) +return; kadircet wrote: > why do we

[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

dgoldman updated this revision to Diff 371103. dgoldman added a comment. Update comment + remove un-needed code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108556/new/ https://reviews.llvm.org/D108556 Files: clang-tools-extra/clangd/FindTarget

[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

dgoldman added a comment. In D108556#2981712 , @kadircet wrote: > Hmm, it sounds like you want them to be treated one way during semantic > highlighting and another during other features, which is fine but somewhat > confusing. (e.g. we want to surface

[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

dgoldman updated this revision to Diff 370609. dgoldman added a comment. Swap to ignore in FindTarget Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108556/new/ https://reviews.llvm.org/D108556 Files: clang-tools-extra/clangd/FindTarget.cpp cla

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2982bd9e9b58: [clangd] Use the active file's language for hover code blocks (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

dgoldman updated this revision to Diff 370590. dgoldman added a comment. Remove unnecessary build flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108584/new/ https://reviews.llvm.org/D108584 Files: clang-tools-extra/clangd/Hover.cpp clang-t

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

dgoldman added a comment. > I put a case for it in the declprinter so it is handled appropriately so it > would get the pointee type, whereas before this was neglected. > > Other than that, there should be no difference. It looks like DeclPrinter only uses that method here

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

dgoldman added a comment. Does this change the behavior of TypePrinter or DeclPrinter - not sure if there are existing tests for those with ObjC code? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 ___

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

dgoldman updated this revision to Diff 368395. dgoldman added a comment. Simplify setting the definition language Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108584/new/ https://reviews.llvm.org/D108584 Files: clang-tools-extra/clangd/Hover.cp

[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

dgoldman added a comment. In D108556#2962008 , @kadircet wrote: > thanks, it looks good as a contained fix. but it feels like we probably don't > want these to be treated as decls in other places too (e.g. can we really > provide any useful goto/hover o

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

dgoldman added a comment. In D108584#2962271 , @sammccall wrote: >> Likely will send a follow up diff to include more context in the Objective-C >> decl printing so they highlight properly. > > This might make sense if it provides useful context to human

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

dgoldman added a comment. LMK if you can think of a better approach to decide which language to use here. Likely will send a follow up diff to include more context in the Objective-C decl printing so they highlight properly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

dgoldman created this revision. dgoldman added reviewers: kadircet, sammccall. Herald added subscribers: usaxena95, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This helps improve the

[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Even though they're implemented

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGba06ac8b45ca: [clangd] Support `#pragma mark` in the outline (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 365279. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/clangd/CollectMacros.cpp clang-tools-extra/clan

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 365277. dgoldman added a comment. Remove more AllOfs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/clangd/CollectMacros.cpp clang-tool

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 365273. dgoldman marked 2 inline comments as done. dgoldman added a comment. Remove unnecessary AllOf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CollectMacros.cpp:42 +if (isInsideMainFile(Loc, SM)) { + Position Start = sourceLocToPosition(SM, Loc); + Position End = {Start.line + 1, 0}; kadircet wrote: > are we fine with the

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 365196. dgoldman marked 9 inline comments as done. dgoldman added a comment. Address nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman marked an inline comment as done. dgoldman added a comment. PTAL, also updated the test to no longer check the children's order Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 ___

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 364840. dgoldman marked an inline comment as done. dgoldman added a comment. Simplify children moving Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added a comment. Okay I think this is what you had in mind. LMK, if it's good I'll go ahead and delete the other ones Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 364263. dgoldman added a comment. the third time is the charm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/clangd/CollectMacros.cpp c

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:535 +/// by range. +std::vector mergePragmas(std::vector &Syms, + std::vector &Pragmas, dgoldm

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:664 + } + // NextPragma is after us but before the next symbol. Our reign is over. + break; kadircet wrote: > I suppose

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:535 +/// by range. +std::vector mergePragmas(std::vector &Syms, + std::vector &Pragmas, kadirc

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CollectMacros.cpp:13 +namespace { +class CollectPragmaMarks : public clang::PPCallbacks { kadircet wrote: > can you nest this inside `clang::clangd` and drop the qualifiers ? Done, had to keep

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 363562. dgoldman marked 4 inline comments as done. dgoldman added a comment. More fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-to

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:535 +/// by range. +std::vector mergePragmas(std::vector &Syms, + std::vector &Pragmas, kadircet wrote: > dgoldman wrote: > > kadircet wr

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/TextMarks.h:22 +/// Represents a programmer specified mark/note, typically used to easily locate +/// or differentiate code. e.g. a `pragma mark`, a `TODO`. +/// sammccall wrote: > dgoldman wro

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 361344. dgoldman added a comment. Test collectPragmaMarksCallback + preamble merging Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/clang

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 361247. dgoldman added a comment. minor comment fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/clangd/CollectMacros.cpp clang-tools

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:535 +/// by range. +std::vector mergePragmas(std::vector &Syms, + std::vector &Pragmas, dgoldman wrote: > sammccall wrote: > > FWIW the f

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 361246. dgoldman added a comment. Add in suggested algorithm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/clangd/CollectMacros.cpp cl

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CollectMacros.h:106 +struct PragmaMark { + SourceLocation Loc; + std::string Text; sammccall wrote: > Line number is enough, right? > Column is not interesting, and pragma marks expanded from

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 361208. dgoldman marked 3 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-ex

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added a comment. PTAL, now merge outside of DocumentOutline although the algorithm I've used is roughly the same Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 _

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 360980. dgoldman added a comment. Misc vector changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/clangd/CollectMacros.cpp clang-too

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 360972. dgoldman added a comment. Merge pragmas outside of the DocumentOutline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/clangd/Coll

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added a comment. Removed the TextMarks file, just need to swap over how the insertions are done Comment at: clang-tools-extra/clangd/TextMarks.h:45 + : SM(SM), Out(Out) {} + void PragmaMark(SourceLocation Loc, StringRef Trivia) override { +if (isInsideMainFil

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 360855. dgoldman marked 3 inline comments as done. dgoldman added a comment. Rebase and remove TextMark files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files:

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 359878. dgoldman added a comment. Fetch marks from preamble as well Move Range helper into SourceCode.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: cla

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindSymbolsTests.cpp:1122 + AllOf(WithName("someFunctionAbove")), + // FIXME: This should be nested under MYObject below. + Al

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added a comment. > Well it is not as strong as that. We'll mostly rely on the fact that symbols > are nested properly. Since we just need to figure out the mark container for > a symbol, we don't care about the ordering (or am I missing something here?). > OTOH, range of the parent bein

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/TextMarks.h:22 +/// Represents a programmer specified mark/note, typically used to easily locate +/// or differentiate code. e.g. a `pragma mark`, a `TODO`. +/// sammccall wrote: > dgoldman wro

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added a comment. In D105904#2879445 , @kadircet wrote: > In D105904#2877281 , @dgoldman > wrote: > >> Yep, I can you send you some searches internally with how prevalent they are. > > Thanks! > >> I don'

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 359001. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added a comment. In D105904#2877184 , @kadircet wrote: > So first of all, it is not clear to me if this is a useful enough improvement > to justify all the new code, but looking at your investment I'll assume this > is really common in ObjC lan

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 358606. dgoldman added a comment. Fix clang tidy warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/clangd/CMakeLists.txt clang-to

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 358307. dgoldman added a comment. Minor TODO change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-ex

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman created this revision. Herald added subscribers: usaxena95, kadircet, arphaman, kbarton, mgorny, nemanjai. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. Xcode uses `#pragma mark

[PATCH] D105533: [clang] Fix an infinite loop during typo-correction

dgoldman accepted this revision. dgoldman added a comment. Thanks! Just to confirm, the non-simplified example is also fixed, right? struct a { int xxx; }; int g_107; int g_108; int g_109; struct a g_999; void b() { (g_910.xxx = g_910.xxx1); } Repository: rG LLVM Gi

[PATCH] D105533: [clang] Fix an infinite loop during typo-correction

dgoldman added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8340 } + // Bail out if we didn't make any correction progress on the checking + // TypoExpr TE, otherwise we risk running the loop forever. dgoldman wrote: >

[PATCH] D105533: [clang] Fix an infinite loop during typo-correction

dgoldman added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8340 } + // Bail out if we didn't make any correction progress on the checking + // TypoExpr TE, otherwise we risk running the loop forever. sammccall wrote: >

[PATCH] D105368: Lex: add a callback for `#pragma mark`

dgoldman added inline comments. Comment at: clang/unittests/Lex/PPCallbacksTest.cpp:119 +SourceLocation Location; +StringRef Trivia; + }; should this be an std::string? not sure of the lifetime guarantees here Repository: rG LLVM Github Monorepo CHA

[PATCH] D104117: [clangd] Fix highlighting for implicit ObjC property refs

This revision was automatically updated to reflect the committed changes. Closed by commit rG570984204f24: [clangd] Fix highlighting for implicit ObjC property refs (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104117/new/ ht

[PATCH] D104117: [clangd] Fix highlighting for implicit ObjC property refs

dgoldman updated this revision to Diff 355035. dgoldman added a comment. Fix clang-tidy warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104117/new/ https://reviews.llvm.org/D104117 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp

[PATCH] D104117: [clangd] Fix highlighting for implicit ObjC property refs

dgoldman updated this revision to Diff 353987. dgoldman added a comment. Minor comment fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104117/new/ https://reviews.llvm.org/D104117 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp cl

[PATCH] D104117: [clangd] Fix highlighting for implicit ObjC property refs

dgoldman added a comment. In D104117#2835599 , @sammccall wrote: > Drive by from vacation, sorry - can this be tackled "upstream" in > findExplicitReferences rather than special cased in syntax highlighting? > > That would help with xrefs, rename etc. Fe

[PATCH] D104540: [clangd] Dont index ObjCCategoryDecls for completion

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1918 + // from the index, we reduce the noise in all the other completion scopes. + if (llvm::isa(&ND)) +return false; Seems like we should also ignore ObjCCategoryImplDec

[PATCH] D104117: [clangd] Fix highlighting for implicit ObjC property refs

dgoldman created this revision. dgoldman added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Objective-C lets you u

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. dgoldman marked an inline comment as done. Closed by commit rG2f951ca98b7a: [clangd] Add support for the `defaultLibrary` semantic token modifier (authored by dgoldman)

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:436 + if (HB.inDefaultLibrary(D->getLocation())) +return HighlightingModifier::DefaultLibrary; const DeclContext *DC = D->getDeclContex

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman updated this revision to Diff 349259. dgoldman marked an inline comment as done. dgoldman added a comment. Add `isDefaultLibrary(const Type *)` and support auto/decl types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101554/new/ https://r

[PATCH] D101645: [clang] RecursiveASTVisitor visits ObjCPropertyRefExpr's class receiver

This revision was automatically updated to reflect the committed changes. Closed by commit rG13a8aa3ee15a: [clang] RecursiveASTVisitor visits ObjCPropertyRefExpr's class receiver (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D100798: [clangd][ObjC] Fix issue completing a method decl by name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. dgoldman marked an inline comment as done. Closed by commit rG2a030e680e08: [clangd][ObjC] Fix issue completing a method decl by name (authored by dgoldman). Repositor

[PATCH] D100798: [clangd][ObjC] Fix issue completing a method decl by name

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:160 + // + // e.g. to complete `- (void)doSomething:(id)argument`: + // - Completion name: `doSomething:` -

[PATCH] D100798: [clangd][ObjC] Fix issue completing a method decl by name

dgoldman updated this revision to Diff 349014. dgoldman added a comment. Add another test for a simple method decl (no arg selector) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100798/new/ https://reviews.llvm.org/D100798 Files: clang-tools-ex

[PATCH] D101645: [clang] RecursiveASTVisitor visits ObjCPropertyRefExpr's class receiver

dgoldman added a comment. Friendly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101645/new/ https://reviews.llvm.org/D101645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D100798: [clangd][ObjC] Fix issue completing a method decl by name

dgoldman added a comment. Friendly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100798/new/ https://reviews.llvm.org/D100798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

This revision was automatically updated to reflect the committed changes. Closed by commit rG159dd447fe98: [clangd][ObjC] Highlight Objc Ivar refs (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101785/new/ https://reviews.llvm

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

dgoldman added a comment. In D101785#2741535 , @kadircet wrote: > Thanks! Can you also add a test to `FindExplicitReferencesTest.All` ? as > that's where the underlying change lies. > > To disambiguate properties and ivars, what if we used modifiers? I s

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

dgoldman updated this revision to Diff 343409. dgoldman added a comment. Add another test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101785/new/ https://reviews.llvm.org/D101785 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tool

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

dgoldman updated this revision to Diff 343087. dgoldman added a comment. Another attempt... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101785/new/ https://reviews.llvm.org/D101785 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-e

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

dgoldman updated this revision to Diff 342734. dgoldman added a comment. Fix test broken on non-macOS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101785/new/ https://reviews.llvm.org/D101785 Files: clang-tools-extra/clangd/FindTarget.cpp cla

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

dgoldman created this revision. dgoldman added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, jfb, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Treat them just l

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:470 + if (auto *OT = dyn_cast(T)) +return scopeModifier(OT->getInterface()); return llvm::None; kadircet wrote: > is t

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman updated this revision to Diff 342391. dgoldman added a comment. Remove unnecessary scope modifier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101554/new/ https://reviews.llvm.org/D101554 Files: clang-tools-extra/clangd/SemanticHighlig

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman updated this revision to Diff 341953. dgoldman marked 2 inline comments as done. dgoldman added a comment. Remove unnecessary null check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101554/new/ https://reviews.llvm.org/D101554 Files: c

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman marked 5 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:433 +scopeModifier(const NamedDecl *D, const HighlightingsBuilder &HB) { + if (!D) +return llvm::None; kadircet wrote: >

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman updated this revision to Diff 341947. dgoldman marked an inline comment as done. dgoldman added a comment. Split defaultLibrary check to separate function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101554/new/ https://reviews.llvm.org/D

[PATCH] D101645: [clang] RecursiveASTVisitor visits ObjCPropertyRefExpr's class receiver

dgoldman created this revision. dgoldman added reviewers: sammccall, benlangmuir. Herald added subscribers: usaxena95, kadircet, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added projects: clang, clang-tools-extra. We now make

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:413 + /// different heuristics may be used in the future (e.g. sysroot paths). + bool inDefaultLibrary(SourceLocation Loc) const { +if (!Loc.isValid()) kadircet wr

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman updated this revision to Diff 341683. dgoldman added a comment. Fix casing warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101554/new/ https://reviews.llvm.org/D101554 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp cl

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman created this revision. dgoldman added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, jfb, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This allows us to

[PATCH] D99975: [clangd][ObjC] Improve support for class properties

This revision was automatically updated to reflect the committed changes. dgoldman marked an inline comment as done. Closed by commit rG39866d249a21: [clangd][ObjC] Improve support for class properties (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D99975: [clangd][ObjC] Improve support for class properties

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:309-313 +// FIXME: visiting this here allows us to hover on UIColor in +// `UIColor.blackColor` but then `blackColor` no longer refers to

[PATCH] D99975: [clangd][ObjC] Improve support for class properties

dgoldman updated this revision to Diff 340885. dgoldman marked 2 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99975/new/ https://reviews.llvm.org/D99975 Files: clang-tools-extr

[PATCH] D99975: [clangd][ObjC] Improve support for class properties

dgoldman updated this revision to Diff 340840. dgoldman added a comment. Rebase on top of main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99975/new/ https://reviews.llvm.org/D99975 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-

[PATCH] D98984: [clangd] Improve handling of Objective-C protocols in types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc20e4fbfa6d1: [clangd] Improve handling of Objective-C protocols in types (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D98984: [clangd] Improve handling of Objective-C protocols in types

dgoldman updated this revision to Diff 340834. dgoldman added a comment. Rebase on top of formatting changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98984/new/ https://reviews.llvm.org/D98984 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D101328: [clangd] run clang-format on FindTargetTests.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG53e1cb88f280: [clangd] run clang-format on FindTargetTests.cpp's FindExplicitReferencesTest (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

<    1   2   3   4   5   6   >