[PATCH] D27597: [DebugInfo] Restore test case for long double constants.

2016-12-14 Thread David Gross via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL289686: [DebugInfo] Restore test case for long double constants. (authored by dgross). Changed prior to commit: https://reviews.llvm.org/D27597?vs=81321=81423#toc Repository: rL LLVM

[PATCH] D27597: [DebugInfo] Restore test case for long double constants.

2016-12-13 Thread David Gross via Phabricator via cfe-commits
dgross updated this revision to Diff 81321. dgross added a comment. Incorporate code review comments. - Use %clang_cc1 not %clang - Rather than trying to determine long double size for target, compile and check multiple times, and only check behavior of long double for known targets

[PATCH] D27597: [DebugInfo] Restore test case for long double constants.

2016-12-13 Thread David Gross via Phabricator via cfe-commits
dgross added a comment. In https://reviews.llvm.org/D27597#621596, @probinson wrote: > As dblaikie said in email, probably better to make this X86-specific; if > long-double varies by OS you can put in a specific triple. I think with this approach I'd want two test cases that are identical

[PATCH] D27597: [DebugInfo] Restore test case for long double constants.

2016-12-09 Thread David Gross via Phabricator via cfe-commits
dgross added a comment. I don't know exactly what the RUN syntax supported by lit is. What I've done here looks complex, but it does work for Linux. What about other platforms? Is there some better way of writing a test case where the checks to be done by FileCheck depend on some property of

[PATCH] D27597: [DebugInfo] Restore test case for long double constants.

2016-12-09 Thread David Gross via Phabricator via cfe-commits
dgross created this revision. dgross added reviewers: cfe-commits, probinson. https://reviews.llvm.org/D27549 (partial fix for PR26619) emits a constant value in the debug metadata for a floating-point static const that does not exceed 64 bits in size. Whether or not a long double exceeds 64

[PATCH] D27589: [DebugInfo] Relax test case for long double constants.

2016-12-08 Thread David Gross via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL289103: [DebugInfo] Relax test case for long double constants. (authored by dgross). Changed prior to commit: https://reviews.llvm.org/D27589?vs=80815=80817#toc Repository: rL LLVM

[PATCH] D27589: [DebugInfo] Relax test case for long double constants.

2016-12-08 Thread David Gross via Phabricator via cfe-commits
dgross created this revision. dgross added reviewers: cfe-commits, probinson. https://reviews.llvm.org/D27549 (partial fix for PR26619) emits a constant value in the debug metadata for a floating-point static const that does not exceed 64 bits in size. The regression test accompanying that fix

[PATCH] D27549: [DebugInfo] Add support for __fp16, float, and double constants.

2016-12-08 Thread David Gross via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL289094: [DebugInfo] Add support for __fp16, float, and double constants. (authored by dgross). Changed prior to commit: https://reviews.llvm.org/D27549?vs=80683=80806#toc Repository: rL LLVM

[PATCH] D27549: [DebugInfo] Add support for __fp16, float, and double constants.

2016-12-07 Thread David Gross via Phabricator via cfe-commits
dgross added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3765 +InitExpr = + DBuilder.createConstantValueExpression(Init.getFloat().bitcastToAPInt().getZExtValue()); GV.reset(DBuilder.createGlobalVariable( probinson wrote: > This line

[PATCH] D27549: [DebugInfo] Add support for __fp16, float, and double constants.

2016-12-07 Thread David Gross via Phabricator via cfe-commits
dgross updated this revision to Diff 80683. dgross added a comment. Incorporate code review feedback. - Reformat source. - Make test pattern more general. https://reviews.llvm.org/D27549 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGen/debug-info-static-const-fp.c Index: