herzka updated this revision to Diff 235188.
herzka added a comment.
rebase, restore changes to CC1Options.td that I left out of last revision
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71709/new/
https://reviews.llvm.org/D71709
Files:
clang/
herzka updated this revision to Diff 234966.
herzka added a comment.
Herald added a reviewer: jdoerfert.
change flags in tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71709/new/
https://reviews.llvm.org/D71709
Files:
clang/lib/Frontend/Com
herzka added a comment.
I worry that repeating all those names in those tests might be noisy. I think
I'll switch those to use the new name, but add another test that makes sure
both names still work.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D
herzka updated this revision to Diff 234746.
herzka added a comment.
Update argument parsing
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71709/new/
https://reviews.llvm.org/D71709
Files:
clang/include/clang/Driver/CC1Options.td
clang/lib/Fro
herzka added a comment.
@modocache, should I add a unit test for these aliases or would that be too
trivial? I don't see unit tests for all the existing flags.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71709/new/
https://reviews.llvm.org/D7170
herzka created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
herzka added a reviewer: modocache.
herzka added a comment.
@modocache, should I add a unit test for these aliases or would that be too
trivial? I don't see unit tests for all the existing flags.
herzka added a comment.
@compnerd, yes please. I don't have commit access. Thanks for the review!
https://reviews.llvm.org/D29967
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
herzka added a comment.
Currently, `A.customGetterProperty` would be turned into `[A
customGetterProperty]`, which would fail to compile because that selector isn't
declared anywhere. With my fix, it does compile because it (correctly) resolves
to `[A customGet]`, which does exist. Similarly, `
herzka updated this revision to Diff 88652.
herzka added a comment.
Rename selectors
https://reviews.llvm.org/D29967
Files:
lib/Sema/SemaExprObjC.cpp
test/SemaObjC/objc-class-property.m
Index: test/SemaObjC/objc-class-property.m
herzka updated this revision to Diff 88650.
herzka added a comment.
Added test, used auto
https://reviews.llvm.org/D29967
Files:
lib/Sema/SemaExprObjC.cpp
test/SemaObjC/objc-class-property.m
Index: test/SemaObjC/objc-class-property.m
===
herzka updated this revision to Diff 88519.
herzka edited the summary of this revision.
herzka added a comment.
Added full context. Sorry about that! This is my first contribution, and I
don't know how I completely missed that line while going through the steps.
https://reviews.llvm.org/D29967
herzka updated this revision to Diff 88448.
herzka retitled this revision from "Get class property setter selector from
property decl if exists" to "Get class property selectors from property decl if
it exists".
herzka edited the summary of this revision.
https://reviews.llvm.org/D29967
Files:
herzka planned changes to this revision.
herzka added a comment.
This issue applies to getters too. I'll make this fix broader.
I think the real fix for both is to construct the ObjCPropertyRefExpr using the
ObjCPropertyDecl so that it's considered an explicit property. Currently, it
still gets
herzka created this revision.
Before this fix, trying to set a class property using dot syntax would always
use the constructed name (setX:), which might not match the real selector if
the setter is specified via the `setter` property attribute. Now, the setter
selector in the declaration has p
14 matches
Mail list logo
